- 05 Sep, 2019 22 commits
-
-
Joshua Litt authored
Implements match indices for regexp, as specified by https://github.com/tc39/proposal-regexp-match-indices, a stage 3 TC39 proposal. This implementation is hidden behind the '--harmony-regexp-match-indices' flag. Regexp match indices extends the JSRegExpResult object with an array of indices of matches, as well as a dictionary of capture names to match indices. Bug: v8:9548 Change-Id: Ia9efcee00d997dda6158539b8d0f4c4e5965e5e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771379 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63581}
-
Santiago Aboy Solanes authored
Bug: v8:6949 Change-Id: I8f0de9e202f41c78e24c4d73c54b198a52122dac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784296 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63580}
-
Dan Elphick authored
Since const variables are immutable, ignore SetMaybeAssigned for them. Bug: chromium:999450, chromium:1000170, v8:8510 Change-Id: Idc1b71677b3d03bb63cc025017c119710b8f392d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782170 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#63579}
-
Santiago Aboy Solanes authored
TNodified: * Jump (both versions) * JumpBackward * JumpIfTaggedEqual * JumpIfTaggedNotEqual * JumpConditional * LoadOsrNestingLevel Removed slopiness from Advance's parameter. Renamed "delta" to jump_offset for JumpXXX arguments. They were called jump_offset in .h and delta in .cc. Bug: v8:6949 Change-Id: I6b34391dcb2ee881670d04edac9382258f6bcb51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782821 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
TNodified: * code-assembler * TailCallBytecodeDispatch * interpreter-assembler * GetContextAtDepth * ExportParametersAndRegisterFile * ImportRegisterFile * Dispatch * DispatchToBytecode * DispatchToBytecodeHandlerEntry * DispatchWide * return type of Jump (Jumps are coming in another CL) * LoadBytecode Removed DispatchToBytecodeHandler since it was unused. Removed target_bytecode parameter of DispatchToBytecodeHandlerEntry since it was unused. Bug: v8:6949 Change-Id: Icd3ded28cc1fd1dc528219dd83cf646e67c9b878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782838 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63577}
-
Santiago Aboy Solanes authored
TNodified from interpreter-generator: * SwitchOnSmiNoFeedback * CreateFunctionContext * CreateEvalContext * SwitchOnGeneratorState since they were using some of the interpreter-assembler now TNodified methods. Bug: v8:6949 Change-Id: I0055100428232e8bdc79cb4356954bac52f4a30d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781689 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Andreas Haas authored
There was no problem with the original CL. I just had a problem with my local git branches. Original message: The implementation on wasm-bigint has been done, as far as I can tell. There are no spec tests yet, only an out-dated copy of the original spec tests which don't pass anymore. Therefore I disabled all the tests for now and created a tracking bug at https://crbug.com/v8/9673. TBR=adamk@chromium.org Bug: v8:7741, v8:9673 Change-Id: Ida7ccda4547cf3fdcdff151d8b02946b7aa534ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787420Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63575}
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Change-Id: I2873acd03b9673dedf587d21e35101ad163fd580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787425 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#63574}
-
Santiago Aboy Solanes authored
TNodify related methods: * BytecodeArrayTaggedPointer * DispatchTablePointer (renamed from DispatchTableRawPointer) * GetAccumulatorUnchecked SloppyTNodify SetAccumulator's argument. Marking some tests as slow, due to TNodification. Bug: v8:6949 Change-Id: I3a56c47247828ec1313ce69ce76064efedf57776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782162Reviewed-by:
-
Clemens Hammacher authored
Node now requires gcc >=6.3, and we do not test on gcc <5.4 any more. Thus remove a special case for gcc <5. R=machenbach@chromium.org Bug: v8:9686 Change-Id: Ifffddec611c15b704aa292a65e87cd770d85ea7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786283Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63572}
-
Michael Achenbach authored
Bug: v8:9687 Change-Id: Ia9e82e1565d2dca595f5a231281d415f423b3421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787421Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63571}
-
Tobias Tebbi authored
This is a safe to merge hot-fix to tackle https://crbug.com/983764. To be reverted after merging to M77. Bug: chromium:983764 Change-Id: I3cd27481f224b352ef6bcf9dde21a8f77616acff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786285Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63570}
-
Clemens Hammacher authored
Node now requires gcc >=6.3, and we do not test on gcc <5.4 any more. Thus remove a hack for gcc <5. R=machenbach@chromium.org Bug: v8:9686 Change-Id: I503c6b76d40499bbe45fb83996e0dfebf86f3395 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786281Reviewed-by:
-
Michael Starzinger authored
This makes sure no underlying ArrayBuffer is reserved for modules that don't declare a module. For the case where a memory is declared but the initial size is 0, we still reserve a buffer in case of trap handlers. R=ahaas@chromium.org BUG=v8:9678 Change-Id: I837b8f257b63eb4111646806b899074babd7c9f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784290Reviewed-by:
-
Clemens Hammacher authored
This reduces the size per runtime stub slot by using the same sequence we plan to use for far jumps. Note that alignment is not an issue here, since runtime stub slots are never patched. R=mstarzinger@chromium.org CC=joey.gouly@arm.com Bug: v8:9477 Change-Id: Ib8f0f7b4930617b9c16dc54f6773572c70b681c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784292 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63567}
-
Ross McIlroy authored
The inferred name in the function literal might not be as accurate as the one already on the shared function info, so use the existing one instead. BUG=chromium:995813 Change-Id: Ie06eb964934fc039e56ebf9452f706e1192b7ab0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782169 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Mu Tao authored
On mips, NaN bit patterns is not same as WASM's definitions. Port e101dfb7 R=clemensh@chromium.org Change-Id: I134cd6289b7cf5d1a366345fe0a79cbecc9a6f73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782234 Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Clemens Hammacher authored
This reduces the size per runtime stub slot by using the same sequence we plan to use for far jumps. Note that alignment is not an issue here, since runtime stub slots are never patched. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ida73896bfc26d01f2a3fbccde785928d1ac92380 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784291 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 85e2dbb3 Change-Id: I59fbd2eb10469179def9bc6332543f5fc406d1c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784417 Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Refactor-only: This moves declaration of implementation details into the .cc file. No logic changes. Bug: v8:9574 Change-Id: I985ce17138e65f18dbb629b9f6660009e034fbf0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786279 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Async functions were not correctly fixed up for code coverage, which caused an additional uncovered range to be reported between a return statement and the closing bracket. This CL adds code that detects such ranges, and removes them, similarly to how the ranges are removed for normal functions. The removal process is different, because the parser rewrites async functions to contain a try-catch handling promise rejection. Change-Id: I73b08d64be74d26c32f2f9652d027430d4671251 Bug: chromium:981313, v8:8381 Change-Id: I82a7f0c54d3a48609ef5255a7659d9557e163566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782837Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/693faed..e030d8a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e7c719c..06605b0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f38bc17..624bf6e TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I19a17babd06d9cac9c9e8225ae322fba62f1b5c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786899Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63560}
-
- 04 Sep, 2019 18 commits
-
-
Tom Tan authored
Windows SDK defines `near` and `far` as macro in minwindef.h, so they cannot be used as variable name if Windows SDK header file is included for Windows build. Bug: chromium:893460 Change-Id: I5ed1076b965979b8e4e09958c1b6f0a698ec8d4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783839Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#63559}
-
Joey Gouly authored
Implement I64x2 multiply using 32-bit multiplies. This approach uses two fewer cycles (0.88x) on Cortex-A53 and three fewer cycles (0.86x) on Cortex-A72, compared to moving to general purpose registers and doing two 64-bit multiplies. Based on a patch by Zhi An Ng. Bug: v8:8460 Change-Id: I9c8d3bb77f0d751eec2d85823522558b7f173628 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781696 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63558}
-
Dominik Inführ authored
Reduce number of old-to-new invalidations. MigrateFastToFast, MigrateFastToSlow and DeleteObjectPropertyFast only need to invalidate objects in some cases but not in all. Bug: v8:9454 Change-Id: I901eecb9409c6dfa30cf6b4ee0bdd597862fc229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781042Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#63557}
-
Seth Brenith authored
I removed the padding field because I couldn't see a reason why we would want to pad to system pointer size. I'm guessing that the intent was to pad to tagged pointer size, which was once relevant but isn't anymore since one of the int32 fields got removed. Bug: v8:8952 Change-Id: Ic191d783efd8d686f6920e6e7ce2d3dacba883c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776847Reviewed-by:
-
Clemens Hammacher authored
R=mlippautz@chromium.org Bug: v8:9396 Change-Id: If197687b6208257be18f91b4b172ec41600c21b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784287Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63555}
-
Tobias Tebbi authored
This reverts commit 352a154e. Reason for revert: https://crbug.com/999972 Original change's description: > [compiler] improve inlining heuristics: call frequency per executed bytecodes > > TLDR: Inline less, but more where it matters. ~10% decrease in Turbofan > compile time including off-thread, while improving Octane scores by ~2%. > > How things used to work: > > There is a flag FLAG_min_inlining_frequency that limits inlining by > the callsite being sufficiently frequently executed. This call frequency > was measured relative to invocations of the parent (= the function we > originally optimize). At the same time, the limit was very low (0.15), > meaning we mostly relied on the total amount of inlined code > (FLAG_max_inlined_bytecode_size_cumulative) to limit inlining. > > How things work now: > > Instead of measuring call frequency relative to parent invocations, we > should have a measure that predicts how often the callsite in question > will be executed in the future. An obvious attempt at that would be to > measure how often the callsite was executed in absolute numbers in the > past. But depending on how fast feedback stabilizes, it can take more > or less time until we optimize a function. If we just take the absolute > call frequency up to the point in time when we optimize, we would > inline more for functions that stabilize slowly, which doesn't make > sense. So instead, we measure absolute call count per KB of executed > bytecodes of the parent function. > Since inlining big functions is more expensive, this threshold is > additionally scaled linearly with the bytecode-size of the inlinee. > The resulting formula is: > call_frequency > > FLAG_min_inlining_frequency * > (bytecode.length() - FLAG_max_inlined_bytecode_size_small) / > (FLAG_max_inlined_bytecode_size - FLAG_max_inlined_bytecode_size_small) > > The new threshold is chosen in a way that it effectively limits > inlining, which allows us to increase > FLAG_max_inlined_bytecode_size_cumulative without increasing inlining > in general. > > The reduction in compile time (x64 build) of ~10% was observed in Octane, > ARES-6, web-tooling-benchmark, and the standalone TypeScript benchmark. > The hope is that this will reduce CPU-time in real-world situations > too. > The Octane improvements come from inlining more in places where it > matters. > > Bug: v8:6682 > > Change-Id: I99baa17dec85b71616a3ab3414d7e055beca39a0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1768366 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63449} TBR=rmcilroy@chromium.org,neis@chromium.org,jgruber@chromium.org,tebbi@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6682 chromium:999972 Change-Id: Iffca63d4bef81afa0f66e34d35fb72f3b5baf517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784281Reviewed-by:
-
Joshua Litt authored
Bug: v8:9463 Change-Id: I4d9d35222597925a289a6c3055ef0ca0aaa43a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1775926 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Maya Lekova authored
Graph creation used to handle exception throwing gracefully, but this seems to never happen, so turned it into a CHECK instead. Change-Id: I90f8471fe77eb66402fd8abe0d5b15dcffee49bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784286 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63552}
-
Georg Neis authored
We already do this (if we can't migrate them) when processing the feedback but it could still happen that we find a deprecated map in the graph later on. Bug: chromium:996819, v8:7790 Change-Id: I3b9acc8bc21b5a9812235145b726ba3e53cc8957 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784284Reviewed-by:
-
Leszek Swirski authored
This reverts commit 981aafaf. Reason for revert: Still crashing on Canary. Original change's description: > Reland "[ic] In-place Double -> Tagged transitions" > > This is a reland of 0736599a. > This is a reland of 7e1fbe8f. > > Original change description: > > [ic] In-place Double -> Tagged transitions > > > > With no more MutableHeapNumber, we can make Double -> Tagged transitions > > in-place, at the cost of an extra map check when accessing double fields > > to make sure they are still doubles. > > > > Bug: v8:9606 > > Change-Id: I74ff39ed6fba62ee223cd37dfe761f7d73020e1c > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743973 > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#63374} > > TBR=verwaest@chromium.org, tebbi@chromium.org > > Bug: v8:9606 > Change-Id: I2d1b7416064d743582f4983fb868316b7e8a4cf2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1777661 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63499} TBR=leszeks@chromium.org, verwaest@chromium.org, tebbi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9606 Bug: chromium:997989 Change-Id: Ic95166e67df68e84a524dffd8155121c3ff6aa13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784283 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The "address" pointer we pass to {Allocate} and {AllocatePages} functions is actually just a hint. The actual address of the reservation is returned by the function. This CL renames the {address} argument of those functions to {hint} to make this semantic more clear. R=mlippautz@chromium.org Bug: v8:9396 Change-Id: I9ff3785ea4e6f9b7d77f26f224445f3f92e11f22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784280Reviewed-by: -
Patrick Thier authored
Instead of checking code flags to decide if the irregexp code object is an off-heap trampoline, we now directly load the builtin index offset and treat the code as on-heap if the offset is -1. In addition the regexp stack now has its own external reference for top of stack address. This prevents calculating the top of stack address using the base address and size at every invocation. Bug: chromium:999993 Change-Id: I23649e8b410a56276f26846b0b12ad29310c3db7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782565Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Andreas Haas authored
I don't know if there is another problem, but this change fixes all problems in the test case. The fuzzer will eventually tell us if there is another problem. R=clemensh@chromium.org Bug: chromium:1000503 Change-Id: I2f3ca9132e1b9e3f01e9b32604fb39b2272723f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784278 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
This reverts commit bf78435b. Reason for revert: This CL is not what I wanted to land. I mixed up my local branches. Original change's description: > [wasm] Stage wasm-bigint > > The implementation on wasm-bigint has been done, as far as I can tell. > There are no spec tests yet, only an out-dated copy of the original > spec tests which don't pass anymore. Therefore I disabled all the tests > for now and created a tracking bug at https://crbug.com/v8/9673. > > R=adamk@chromium.org > > Bug: v8:7741, v8:9673 > Change-Id: I015846cc6008ad266402b6835e634723a1a076da > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781050 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63541} TBR=adamk@chromium.org,ahaas@chromium.org Change-Id: I5e8a42ad01200c01446efe4ea50f8ae6fef2c174 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7741, v8:9673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784279Reviewed-by:
-
Georg Neis authored
This is a reland of ab089c78, after making a flaky test more robust. Original change's description: > [turbofan] Prepare for moving part of CreateGraph into the background > > - Pass Refs, not Handles, to graph builder, and drop bytecode array argument > (get it from SFI instead). > - Add some fields to FeedbackVectorRef that are needed to avoid heap access > in BytecodeGraphBuilderPhase. > - Rename FeedbackVectorRef's SerializeSlots to Serialize, since it's more > than just the feedback slots. > - Rearrange the last steps in PipelineCompilationJob::PrepareJobImpl such > that CreateGraph is last. > > Bug: v8:7790 > Change-Id: I4b17790d1d74da41ba63ee68e3a33968662fc398 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781682 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63515} Bug: v8:7790 Change-Id: Ia6f4c1ebd82dea93c14437514d0e25b730523f75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781694Reviewed-by:
-
Georg Neis authored
Change-Id: I29a4d20656727e6ec1e1fd052a840bd5aefe3cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781052 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
External string resources of length {0} have a {nullptr} data since https://crrev.com/c/1424861. This CL fixes allocation of an external one-byte string from such a resource. R=ishell@chromium.org Bug: chromium:995108 Change-Id: Ic8ef507d808583c1b529085d990d705058953f03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781051Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63543}
-
Dan Elphick authored
Use the position of commas in async arrow expressions to mark the initializer position of any parameters that might have been set in the preceding parameter. This extends https://chromium-review.googlesource.com/c/v8/v8/+/1710671 to async arrow heads. Bug: v8:8510, chromium:997320 Change-Id: I98e0ac817c7f53fbf1dced98fb6891a386ee7803 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781057Reviewed-by:
-
