- 21 Mar, 2018 36 commits
-
-
Jakob Gruber authored
This reverts commit f8184738. Reason for revert: arm is still unhappy https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20GC%20Stress/builds/6633 Original change's description: > Reland "[builtins] Load external references from the external-reference-table" > > This is a reland of 9afde91b > > Original change's description: > > [builtins] Load external references from the external-reference-table > > > > Off-heap code cannot embed external references. With this CL, we load > > from the external reference table (reached through the root pointer) > > instead. > > > > In a follow-up, the table could be stored within the isolate itself, > > removing one more level of indirection. > > > > Bug: v8:6666 > > Change-Id: I4c612ad3d4112ec03c3b389f5bfb9cdc3dc8a671 > > Reviewed-on: https://chromium-review.googlesource.com/970468 > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#52073} > > TBR=mstarzinger@chromium.org > > Bug: v8:6666, v8:7580 > Change-Id: I163cfc15605c1183b79ead77df0e37d71d60b6f7 > Reviewed-on: https://chromium-review.googlesource.com/972821 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52118} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I5bcd1a1c84c6e9a6a24364390c9359d43c77120d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666, v8:7580 Reviewed-on: https://chromium-review.googlesource.com/973782Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52121}
-
Sigurd Schneider authored
Bug: v8:7570, v8:7517 Change-Id: Ia62a9afeec0d0df1596198deec6165a3f02edeaa Reviewed-on: https://chromium-review.googlesource.com/973606Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52120}
-
Leszek Swirski authored
Fix up disassembly triggered by --print-*-code to print to the trace file specified by --redirect-code-traces-to rather than unconditionally to stdout. Change-Id: I80a8772361e8fb0550efcbbab6a7b7d822385303 Reviewed-on: https://chromium-review.googlesource.com/973167 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
jgruber authored
This is a reland of 9afde91b Original change's description: > [builtins] Load external references from the external-reference-table > > Off-heap code cannot embed external references. With this CL, we load > from the external reference table (reached through the root pointer) > instead. > > In a follow-up, the table could be stored within the isolate itself, > removing one more level of indirection. > > Bug: v8:6666 > Change-Id: I4c612ad3d4112ec03c3b389f5bfb9cdc3dc8a671 > Reviewed-on: https://chromium-review.googlesource.com/970468 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52073} TBR=mstarzinger@chromium.org Bug: v8:6666, v8:7580 Change-Id: I163cfc15605c1183b79ead77df0e37d71d60b6f7 Reviewed-on: https://chromium-review.googlesource.com/972821 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
Fixes ppc and s390: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20ppc%20-%20sim/builds/10144 https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20s390%20-%20sim/builds/10698 TBR=yangguo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Change-Id: I1134218d04f328980e97d1fe1f0d0e7d7d779a1d Reviewed-on: https://chromium-review.googlesource.com/973611Reviewed-by:
-
Clemens Hammacher authored
On ia32, the upper "half stack slot" must be located above the lower half stack slot (in absolute address), hence the index is "2 * index - 1" instead of "2 * index + 1". Note that the index describes the negative offset from the stack pointer. R=titzer@chromium.org Bug: v8:7579 Change-Id: If207af405b126ab30043432d7934273e6e2a5330 Reviewed-on: https://chromium-review.googlesource.com/973301 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52116}
-
Clemens Hammacher authored
This method always calls the FATAL macro, which is also marked [[noreturn]]. The documentation already mentioned this, but now it's actually enforced by the compiler. R=adamk@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2e331c9826fad6aad9c22929a0d5f890a508d0d9 Reviewed-on: https://chromium-review.googlesource.com/966561Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52115}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iee10287cdd157d5a62d75624d5099919d8e0a55d Reviewed-on: https://chromium-review.googlesource.com/973168Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52114}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ic374aaf222a20b5fffe95ffe22c14ff998fca7fd Reviewed-on: https://chromium-review.googlesource.com/973227 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This also introduces two new simplified operators, ObjectIsSafeInteger and NumberIsSafeInteger. Bug: v8:7340, v8:7250 Change-Id: I9a3028d844e6614ed248a03fe24b431fb54938f0 Reviewed-on: https://chromium-review.googlesource.com/973221Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52112}
-
Clemens Hammacher authored
This adds 5% testing of 'ignition' vs 'liftoff', which tests Turbofan vs Liftoff for wasm code, and tests Ignition vs Turbofan for javascript code. It also adds 3% testing of 'liftoff' (x64) vs 'liftoff' (ia32), which does standard x64 vs ia32 testing for javascript code. R=machenbach@chromium.org Bug: chromium:824098, v8:6600 Change-Id: I6a6afae0300efc33f3535541a11695a7bb32dcc5 Reviewed-on: https://chromium-review.googlesource.com/973161 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52111}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: I6fd915a66cd4993a8934e09575464cce2a17d404 Reviewed-on: https://chromium-review.googlesource.com/970475Reviewed-by:
-
Peter Marshall authored
This CL renames InterpreterPushArgsMode::kJSFunction to kArrayFunction because we only ever use it for the array function. We never use PushArgsThenCall with kArrayFunction mode, so remove the unused helpers that provide the plumbing there. This is in preparation for changes to PushArgsThenConstruct, where we will no longer pass the allocation site as undefined for modes other than kArrayFunction. Bug: v8:7503 Change-Id: I86e3333e2ebd912fc8f9b0e4248282330af4b9e2 Reviewed-on: https://chromium-review.googlesource.com/972047 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mythri Alle <mythria@google.com> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#52109}
-
jgruber authored
This is a reland of 25207bf8 Original change's description: > Remove isolate.h include from external-reference.h > > This triggers a bunch of other necessary include tweaks for files that > used to work until now because they indirectly included isolate.h > through external-reference.h. > > Bug: v8:6666 > Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 > Reviewed-on: https://chromium-review.googlesource.com/972042 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52103} TBR=petermarshall@chromium.org Bug: v8:6666 Change-Id: Ibbcf2c116dc3b202d325fd7644e8755ffe583ef1 Reviewed-on: https://chromium-review.googlesource.com/973062Reviewed-by:
-
sreten.kovacevic authored
Implement f32 and f64 abs, neg and sqrt unops. Bug: v8:6600 Change-Id: If2c9b0fa488c83ee53afe6debc990fffcd08894a Reviewed-on: https://chromium-review.googlesource.com/970826Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52107}
-
Yang Guo authored
R=jgruber@chromium.org Bug: v8:178 Change-Id: Ie2279c8a1bb50d01186dbd9dd29145bca9aeaf6f Reviewed-on: https://chromium-review.googlesource.com/972983 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
jgruber authored
Some debugging tests relied on the following anti-pattern: let exception = false; try { /* ... some code that may throw on test failure ... */ } catch (e) { exception = e; } assertFalse(exception); This may be problematic if a falseish value is thrown. Change-Id: I02eace4cc656fc9581928a90ac53cda4dc72b30c Reviewed-on: https://chromium-review.googlesource.com/972822Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52105}
-
Clemens Hammacher authored
This reverts commit 25207bf8. Reason for revert: Mips compile failure: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/16061 Original change's description: > Remove isolate.h include from external-reference.h > > This triggers a bunch of other necessary include tweaks for files that > used to work until now because they indirectly included isolate.h > through external-reference.h. > > Bug: v8:6666 > Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 > Reviewed-on: https://chromium-review.googlesource.com/972042 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52103} TBR=jgruber@chromium.org,petermarshall@chromium.org Change-Id: I2e867d3c82b020b4fd5201aaa5cf6ed65b081ca2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/973061Reviewed-by:
-
jgruber authored
This triggers a bunch of other necessary include tweaks for files that used to work until now because they indirectly included isolate.h through external-reference.h. Bug: v8:6666 Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 Reviewed-on: https://chromium-review.googlesource.com/972042 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52103}
-
Clemens Hammacher authored
Code is often being patched after creating, thus we don't need to flush the icache right away. This CL introduces a new enum to specify whether the icache should be flushed or not, and uses this in all methods which don't always need to flush. Drive-by: Fix a but where SKIP_ICACHE_FLUSH was interpreted as boolean value. R=mstarzinger@chromium.org Change-Id: I13ac71d2a7168a065b8a4a1086c590816de8ca28 Reviewed-on: https://chromium-review.googlesource.com/971881Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52102}
-
Hannes Payer authored
Change-Id: If8678bd244a0a4e21b1967c15da80e49643a33ea Reviewed-on: https://chromium-review.googlesource.com/973001Reviewed-by:
-
jgruber authored
ppc is still failing: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20ppc64%20-%20sim/builds/10180 TBR=yangguo@chromium.org No-Try: true No-Presubmit: true Bug: v8:6666, v8:7571 Change-Id: I99ddc97543b374014587970310ac5172ed514892 Reviewed-on: https://chromium-review.googlesource.com/973005 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
The multi-return tests and fuzzer used a custom call descriptor which was based on the default RegisterConfiguration. This meant that for the tests, all available registers could be used to pass parameters and to return values. This caused a problem, because in some cases we need a scratch register in the frame deconstruction. With this CL I change both the tests and the fuzzer to use the WebAssembly call descriptor. Thereby we only use 2 registers for returns, and one of the other registers can be used as scratch register. WebAssembly is the only use case at the moment which wants to return values not only through registers but also over the stack. Therefore I think it's acceptable to only test the WebAssembly usecase. R=mstarzinger@chromium.org Bug: chromium:813288 Change-Id: I31bed757af5f3e8589d2b3dfb6f0112ddecd1a20 Reviewed-on: https://chromium-review.googlesource.com/970656Reviewed-by:
-
Clemens Hammacher authored
Liftoff does not need to reference its own code object, so don't allocate a handle for that purpose. This also allows to create LiftoffAssembler instances in background tasks where no handle scope is available. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I2911aebd14aaa8450456cb8eea16cea547e0b671 Reviewed-on: https://chromium-review.googlesource.com/972081Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52098}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:810393 Change-Id: If783fc2d3edcfda6bf5d460de7216a974b28744d Reviewed-on: https://chromium-review.googlesource.com/968482 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52097}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ibbb224cc6be69f769158b3c1ea3411ceec8301a9 Reviewed-on: https://chromium-review.googlesource.com/968923Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52096}
-
Marja Hölttä authored
BUG=chromium:813630 Change-Id: I9eeaeb8830533c178c8073f48f036f9af8887a55 Reviewed-on: https://chromium-review.googlesource.com/972901Reviewed-by:
-
jgruber authored
Continuations are called directly from the deoptimizer, and thus cannot be lazy. This also changes the corresponding assertion to an unconditional CHECK in order to catch this type of mistake early. Drive-by: Sort Builtins::IsLazy. Bug: chromium:823292 Change-Id: I739429ef574e40d7b9ba40cd209175054eb73349 Reviewed-on: https://chromium-review.googlesource.com/972282Reviewed-by:
-
Marja Hölttä authored
Exposing it inside Internals was a hack. The downside of this CL is that heap object tagging is in two places now (v8.h and globals.h). BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic7115ab20d67109dd2b62c772d52eeb84fa7d9f7 Reviewed-on: https://chromium-review.googlesource.com/968423Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52093}
-
jgruber authored
Embedded builtins are now based off the v8_enable_embedded_builtins gn flag instead, which conditionally defines V8_EMBEDDED_BUILTINS. Bug: v8:6666 Change-Id: I44d40d30fce3a3ed9bbf973d46c4990ba3fade40 Reviewed-on: https://chromium-review.googlesource.com/964361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
On {mips,mips64,ppc,s390}, target addresses are specially coded into the instruction stream, i.e. split between a series of instructions. This adds support for that case, similar to what happens with runtime external references. Bug: v8:6666,v8:7571 Change-Id: Ie6f62bc0ca3183f005d8380f6f8b908fa12ea62b Reviewed-on: https://chromium-review.googlesource.com/970824 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Junliang Yan authored
Bug: v8:7571 Change-Id: Ifb59192ecefaa0f7968578a3b547b9e1fbe7c7d7 Reviewed-on: https://chromium-review.googlesource.com/971828 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Tom Anderson authored
Following CL [1], it is required to remove the thin_archive config everywhere complete_static_lib is set. [1] https://chromium-review.googlesource.com/c/chromium/src/+/954344 BUG=chromium:801925 R=machenbach Change-Id: Id75e06543545924771820500c53df3d5ee58774b Reviewed-on: https://chromium-review.googlesource.com/972550Reviewed-by:
-
jgruber authored
This is a reland of b105df6d Original change's description: > Fix kArchRootsPointer typo on s390 > > TBR=jarin@chromium.org > > Bug: v8:6666 > Change-Id: I9f4654955f297c54e67b98afb42125b659e35fd3 > Reviewed-on: https://chromium-review.googlesource.com/971042 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52074} TBR=jarin@chromium.org Bug: v8:6666 Change-Id: Iaae31c52f6099bf9007bd196ca9d4bcf8177aaca Reviewed-on: https://chromium-review.googlesource.com/972801Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a7e9a83..d7db4b1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4927c9c2c90853b8587ac1f5146bb91b4e745b7d Reviewed-on: https://chromium-review.googlesource.com/972640 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52087}
-
jing.bao authored
Change-Id: I53136c1c296b112e9521fa21e85e945267e51059 Reviewed-on: https://chromium-review.googlesource.com/963702Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#52086}
-
- 20 Mar, 2018 4 commits
-
-
Alexei Filippov authored
BUG=chromium:823874 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1df9347ead62dc84150f5549c29815600609c55b Reviewed-on: https://chromium-review.googlesource.com/972181 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52085}
-
Corentin Wallez authored
BUG=chromium:815092 Change-Id: Iec8207dddc56bbcc06ffe7755fc3dc7120bc4368 Reviewed-on: https://chromium-review.googlesource.com/971355Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9afde91b. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/6616 Original change's description: > [builtins] Load external references from the external-reference-table > > Off-heap code cannot embed external references. With this CL, we load > from the external reference table (reached through the root pointer) > instead. > > In a follow-up, the table could be stored within the isolate itself, > removing one more level of indirection. > > Bug: v8:6666 > Change-Id: I4c612ad3d4112ec03c3b389f5bfb9cdc3dc8a671 > Reviewed-on: https://chromium-review.googlesource.com/970468 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52073} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: Iecc2a68e54339e153f1d1e882d8972d5c9cff442 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/971902Reviewed-by:
-
Michael Achenbach authored
This reverts commit b105df6d. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/6616 Original change's description: > Fix kArchRootsPointer typo on s390 > > TBR=jarin@chromium.org > > Bug: v8:6666 > Change-Id: I9f4654955f297c54e67b98afb42125b659e35fd3 > Reviewed-on: https://chromium-review.googlesource.com/971042 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52074} TBR=jarin@chromium.org,jgruber@chromium.org Change-Id: Ibff56d207b12a0664e6ed66e5f6f4c725206e526 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/971901Reviewed-by:
-
