Commits · 87f77d6abaf8746719ae1f53b9eb61c1d1cf6a0b · Linshizhi / V8

23 Feb, 2015 17 commits

for-of should throw if result object is not an object · 87f77d6a

arv authored Feb 23, 2015

This is done using desugaring. Before this we had:

  result = iterator.next()

with this we instead do:

  !%_IsSpecObject(result = iterator.next()) &&
      %ThrowIteratorResultNotAnObject(result)

BUG=v8:3916
LOG=N

Review URL: https://codereview.chromium.org/929733003

Cr-Commit-Position: refs/heads/master@{#26805}

87f77d6a

Update GN build files with the cpu_arch -> current_cpu change. · f8abac93

dpranke authored Feb 23, 2015

R=machenbach@chromium.org, jochen@chromium.org
BUG=crbug.com/344767
LOG=Y

Review URL: https://codereview.chromium.org/946023002

Cr-Commit-Position: refs/heads/master@{#26804}

f8abac93

ES6 collections: Fix order of constructor logic · 36e72aed

arv authored Feb 23, 2015

The adder should be gotten before the iterator.

Motivation: Once this is done we should be able to use a for-of loop
instead which leads to cleaner code and correct behavior once the
for-of loop correctly supports abrupt completion.

BUG=None
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/949933002

Cr-Commit-Position: refs/heads/master@{#26803}

36e72aed

Prototype objects never share their map, and hence cannot be in deprecated state. · 74c0cdbf
verwaest authored Feb 23, 2015
```
Review URL: https://codereview.chromium.org/955433002

Cr-Commit-Position: refs/heads/master@{#26802}
```
74c0cdbf

Promise.all and race should work with iterables · 3a8e496f

arv authored Feb 23, 2015

BUG=v8:3705
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/948843004

Cr-Commit-Position: refs/heads/master@{#26801}

3a8e496f

Merge LookupResult into PropertyAccessInfo · ca623fae

verwaest authored Feb 23, 2015

BUG=

Review URL: https://codereview.chromium.org/939623004

Cr-Commit-Position: refs/heads/master@{#26800}

ca623fae

Revert "The expected key is a valid identifier, which is already free of \\, <0x20, "." · 460187b5

verwaest authored Feb 23, 2015

The optimization is invalid as indicated by the test.

BUG=
TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/950873003

Cr-Commit-Position: refs/heads/master@{#26799}

460187b5

Bump up version for 4.3 candidate. · 46c7d681

machenbach authored Feb 23, 2015

NOTRY=true
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/948003002

Cr-Commit-Position: refs/heads/master@{#26798}

46c7d681

MIPS: [turbofan] Fix several int vs size_t issues. · 585e50c3

balazs.kilvady authored Feb 23, 2015

Port 9c1407da

BUG=

Review URL: https://codereview.chromium.org/948843002

Cr-Commit-Position: refs/heads/master@{#26797}

585e50c3

emit premonomorphic ics for loads/stores in optimized code · 7361dce4

dcarney authored Feb 23, 2015

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/892383003

Cr-Commit-Position: refs/heads/master@{#26796}

7361dce4

More tests added to cctest/tests/test-migrations.cc. · 4349b186

ishell authored Feb 23, 2015

This also includes a regression test for crbug/459512.

BUG=chromium:459512
LOG=N

Review URL: https://codereview.chromium.org/947103002

Cr-Commit-Position: refs/heads/master@{#26795}

4349b186

disable some harmony scoping tests · 102ddf35

dcarney authored Feb 23, 2015

R=verwaest@chromium.org

BUG=v8:3914
LOG=N

Review URL: https://codereview.chromium.org/914333002

Cr-Commit-Position: refs/heads/master@{#26794}

102ddf35

MIPS64: Implement optimization utilizing signaling NaN for holes in double arrays. · c1f8f727
dusan.milosavljevic authored Feb 23, 2015
```
TEST=
BUG=

Review URL: https://codereview.chromium.org/945823002

Cr-Commit-Position: refs/heads/master@{#26793}
```
c1f8f727

Revert of Correctly propagate terminate exception in TryCall. (patchset #2... · 035b144b

machenbach authored Feb 23, 2015

Revert of Correctly propagate terminate exception in TryCall. (patchset #2 id:20001 of https://codereview.chromium.org/928193002/)

Reason for revert:
See crbug.com/460412 and crbug.com/460356. Reverting on master in order to roll from master again soon.

Original issue's description:
> Correctly propagate terminate exception in TryCall.
>
> BUG=v8:3892
> LOG=Y
>
> Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f
> Cr-Commit-Position: refs/heads/master@{#26685}

TBR=ishell@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3892

Review URL: https://codereview.chromium.org/946973004

Cr-Commit-Position: refs/heads/master@{#26792}

035b144b

Revert of [x64] Improve instruction selection for TruncateInt64ToInt32.... · 61ac4613

bmeurer authored Feb 23, 2015

Revert of [x64] Improve instruction selection for TruncateInt64ToInt32. (patchset #1 id:1 of https://codereview.chromium.org/936323004/)

Reason for revert:
Breaks SQLite

Original issue's description:
> [x64] Improve instruction selection for TruncateInt64ToInt32.
>
> R=svenpanne@chromium.org
>
> Committed: https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c
> Cr-Commit-Position: refs/heads/master@{#26739}

TBR=svenpanne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/928723003

Cr-Commit-Position: refs/heads/master@{#26791}

61ac4613

[linux] Use _GLIBCXX_DEBUG in Debug builds by default for better checking. · b9513848

bmeurer authored Feb 23, 2015

The _GLIBCXX_DEBUG macro is now set by default for Linux Debug builds
and can be disabled using the disable_glibcxx_debug=1 setting
(compatible with Chrome).  This will help us catch problems earlier.

BUG=v8:3638
LOG=n

Review URL: https://codereview.chromium.org/946283003

Cr-Commit-Position: refs/heads/master@{#26790}

b9513848

[turbofan] Fix several int vs size_t issues. · 9c1407da

bmeurer authored Feb 23, 2015

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/946553002

Cr-Commit-Position: refs/heads/master@{#26789}

9c1407da

20 Feb, 2015 23 commits

Replace is_reference_error bool argument with ParseErrorType enum · 82368b17

adamk authored Feb 20, 2015

This avoids accidental coercion-to-bool when calling ReportMessage()
in the parser (e.g., from pointer types), and as a bonus makes callsites
easier to read.

Review URL: https://codereview.chromium.org/939303002

Cr-Commit-Position: refs/heads/master@{#26788}

82368b17

Fix issue with -0 in Maps · 925364f5

arv authored Feb 20, 2015

Because we generated a different hash code for 0 and -0 we ended up
not even getting to the SameValueZero check.

BUG=v8:3906
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/947443005

Cr-Commit-Position: refs/heads/master@{#26787}

925364f5

ES6: Fix GetIterator · fa1523ea

arv authored Feb 20, 2015

After further spec reading it turns out that we should not do ToObject
on the iterable.

BUG=None
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/941313003

Cr-Commit-Position: refs/heads/master@{#26786}

fa1523ea

MIPS: Fix label position types in binding code. · 39f58c24

balazs.kilvady authored Feb 20, 2015

Also some target_at and target_at_put uniformed on mips and mips64.

BUG=

Review URL: https://codereview.chromium.org/942123002

Cr-Commit-Position: refs/heads/master@{#26785}

39f58c24

Change bit pattern of hole nan to reflect different sNan encoding on mips HW. · 4e946e3e
dusan.milosavljevic authored Feb 20, 2015
```
TEST=
BUG=

Review URL: https://codereview.chromium.org/945813002

Cr-Commit-Position: refs/heads/master@{#26784}
```
4e946e3e

Emit exception handler table in TurboFan. · 88c4f52c

mstarzinger authored Feb 20, 2015

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/943503003

Cr-Commit-Position: refs/heads/master@{#26783}

88c4f52c

Constant-fold strings in HGraphBuilder::BuildBinaryOperation. · 40ebcea1

yangguo authored Feb 20, 2015

R=vegorov@chromium.org
BUG=v8:3325
LOG=N

Review URL: https://codereview.chromium.org/935393002

Cr-Commit-Position: refs/heads/master@{#26782}

40ebcea1

Only normalize prototypes in OptimizeAsPrototype if it would benefit. · 6e346dfc
verwaest authored Feb 20, 2015
```
BUG=

Review URL: https://codereview.chromium.org/942833002

Cr-Commit-Position: refs/heads/master@{#26781}
```
6e346dfc

CpuProfiler: move StringsStorage class to separate source and header files. · 9b02dc5b

loislo authored Feb 20, 2015

Mechanical change.

This will break dependency between profiler-generator and heap-profiler-generator.
Later this will help us to reuse SourcePosition in cpu-profiler.

BUG=452067
LOG=n

Review URL: https://codereview.chromium.org/945873002

Cr-Commit-Position: refs/heads/master@{#26780}

9b02dc5b

Fix GC-unsafe use of BreakLocationIterator. · 0aa1d2af

yangguo authored Feb 20, 2015

R=svenpanne@chromium.org
BUG=v8:3776
LOG=N

Review URL: https://codereview.chromium.org/942003002

Cr-Commit-Position: refs/heads/master@{#26779}

0aa1d2af

Cleanup scheduler unit test a bit. · eb3bbd3d

mstarzinger authored Feb 20, 2015

R=bmeurer@chromium.org
TEST=unittests/SchedulerTest,unittests/SchedulerRPOTest

Review URL: https://codereview.chromium.org/927653004

Cr-Commit-Position: refs/heads/master@{#26778}

eb3bbd3d

Add missing test for CollectControlProjections on calls. · 7dba829b

mstarzinger authored Feb 20, 2015

R=bmeurer@chromium.org
TEST=unittests/NodePropertiesTest.CollectControlProjections_Call

Review URL: https://codereview.chromium.org/941993002

Cr-Commit-Position: refs/heads/master@{#26777}

7dba829b

Whitespace change to test new CQ config. · b039a75e

machenbach authored Feb 20, 2015

TBR=tandrii@chromium.org,

Review URL: https://codereview.chromium.org/938403002

Cr-Commit-Position: refs/heads/master@{#26776}

b039a75e

CpuProfiler: eliminate cpu-profiler dependency from heap-inl.h · 8ba89cce

loislo authored Feb 20, 2015

We accessed to cpu_profiler for tracking SharedFunctionInfo objects movements and used their addresses for generating function_id. Actually we could replace the manually generated shared_id by the pair script_id + position. In this case we can drop SharedFunctionInfo events support from cpu_profiler and remove the dependency.

BTW GetCallUid was used as an unique identifier of the function on the front-end side. Actually it is a hash which might not be unique. So I renamed GetCallUid with GetHash and implemented GetFunctionId method.

BUG=452067
LOG=n

Review URL: https://codereview.chromium.org/941973002

Cr-Commit-Position: refs/heads/master@{#26775}

8ba89cce

Fix CQ config. · 9d4c2020

Michael Achenbach authored Feb 20, 2015

R=tandrii@chromium.org
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/942823003

Cr-Commit-Position: refs/heads/master@{#26774}

9d4c2020

[turbofan] Don't compute unneeded gray set in AllNodes. · 6c701d15

bmeurer authored Feb 20, 2015

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/940403002

Cr-Commit-Position: refs/heads/master@{#26773}

6c701d15

Immediately "optimize as prototype" when setting as prototype of a function. · fade797d

verwaest authored Feb 20, 2015

This saves space since OptimizeAsPrototype detaches from the transition tree, reclaiming intermediate maps. On gmail this corresponds to roughly 20% of all maps.

BUG=

Review URL: https://codereview.chromium.org/941213005

Cr-Commit-Position: refs/heads/master@{#26772}

fade797d

Migrate CQ trybot config to v8 repo. · f4bd25da

machenbach authored Feb 20, 2015

TBR=tandrii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/940393002

Cr-Commit-Position: refs/heads/master@{#26771}

f4bd25da

There are no evacuation candidates and slot buffers when marking is started. · 916deea5
hpayer authored Feb 20, 2015
```
BUG=

Review URL: https://codereview.chromium.org/939163002

Cr-Commit-Position: refs/heads/master@{#26770}
```
916deea5

Disable failing debug tests in gc-stress. · c4d2234e

Yang Guo authored Feb 20, 2015

TBR=machenbach@chromium.org
BUG=v8:3776
LOG=N

Review URL: https://codereview.chromium.org/944833002

Cr-Commit-Position: refs/heads/master@{#26769}

c4d2234e

Simplify computation of environment stack delta. · 6fe12676

mstarzinger authored Feb 20, 2015

R=titzer@chromium.org
TEST=cctest/test-run-jsexceptions/CatchCall

Review URL: https://codereview.chromium.org/936343002

Cr-Commit-Position: refs/heads/master@{#26768}

6fe12676

[turbofan] Finally get rid of the generic algorithm. · 9e6181d5

Benedikt Meurer authored Feb 20, 2015

R=svenpanne@chromium.org

Committed: https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9
Cr-Commit-Position: refs/heads/master@{#26760}

Review URL: https://codereview.chromium.org/944803002

Cr-Commit-Position: refs/heads/master@{#26767}

9e6181d5

Model exceptional edges from call nodes in TurboFan. · 6881d760

mstarzinger authored Feb 20, 2015

R=titzer@chromium.org,bmeurer@chromium.org

Review URL: https://codereview.chromium.org/928213003

Cr-Commit-Position: refs/heads/master@{#26766}

6881d760