- 20 Nov, 2018 5 commits
-
-
Sigurd Schneider authored
This is pre-work to extend the typer phase until after load elinination. Load elimination uses maps from CheckMaps/MapGuard/CompareMaps/LoadField and this CL ensures they are brokerized. Bug: v8:7790 Change-Id: Ic04f9c374bc736f03abf2bc7d257deb268d723c8 Reviewed-on: https://chromium-review.googlesource.com/c/1341950Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57628}
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: Ib2eb33688517324884c4172560387242c71094fb Reviewed-on: https://chromium-review.googlesource.com/c/1342518Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57627}
-
Jaroslav Sevcik authored
Forgot to negate. Oops. Bug: chromium:906893 Change-Id: I6e7a5a87e8c513795cc598314c9f0a34e9389e69 Reviewed-on: https://chromium-review.googlesource.com/c/1342919Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2fb6537..1f137f3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b81a9c7..1e54003 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c6ffd7a..7da982a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1d879ce..aa6b9c8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7e874e531e589b194184067e0e5b7fd7230c371d Reviewed-on: https://chromium-review.googlesource.com/c/1342949 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57625}
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org,binji@chromium.org Change-Id: I2367e24888a268ce93b1730195cb4767896861cc Reviewed-on: https://chromium-review.googlesource.com/c/1341126Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57624}
-
- 19 Nov, 2018 33 commits
-
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org Change-Id: Ib7b18448d59e1f54f664e24908fbd3a8b4607a9f Reviewed-on: https://chromium-review.googlesource.com/c/1332153 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Ben Smith authored
These instructions aren't implemented yet in TF or in Liftoff, but they are properly decoded. The table instructions (i.e. `table.{init,drop,copy}`) are validated, since the table and element sections occur before the code section. The memory instructions (i.e. `memory.{init,drop,copy,fill}`) are not validated because the data section occurs after the code section, so it can't be verified in one pass (without throwing a validation error later). There is currently a discussion about whether to add a new section (similar to `func`) that predefines the number of expected data segments. If we add this, then we can validate in one pass. For now, we'll leave it unimplemented. Bug: v8:7747 Change-Id: I839edf51721105a47a1fa8dd5e5e1bd855e72447 Reviewed-on: https://chromium-review.googlesource.com/c/1339241 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57622}
-
Deepti Gandluri authored
Change-Id: I16cc93b44bddbd8356a4098f3857db4f9808e13c Reviewed-on: https://chromium-review.googlesource.com/c/1336777Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#57621}
-
Junliang Yan authored
Port 72823c8c Original Commit Message: {RegisterConfiguration} is not used inside assembler.h. Instead, include it where needed. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id79b6eda6f6ce9c105997ec65c9f72398af29954 Reviewed-on: https://chromium-review.googlesource.com/c/1342661Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57620}
-
Junliang Yan authored
Port 2cf36eb8 Original Commit Message: Instead, include macro-assembler.h (and others) where needed. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I94320322584a39802aaaefd279ce8819ad8686d8 Reviewed-on: https://chromium-review.googlesource.com/c/1342978Reviewed-by:
-
Junliang Yan authored
Port 1952f928 Original Commit Message: The platform specific macro assembler headers can not be included directly. They require symbols declared in macro-assembler.h. We also cannot include macro-assembler.h from the platform specific headers, because that would form a cycle, and the include in macro-assembler.h would be skipped, which then also fails. This CL documents and enforces this unfortunate situation. This helps with further iwyu cleanups. Note that current code which includes the platform specific headers only works because we transitively included macro-assembler.h already before. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iff6217ccb961d009a31f6adc50a7ef77ca1c8b70 Reviewed-on: https://chromium-review.googlesource.com/c/1342977Reviewed-by:
-
Junliang Yan authored
Port 6e5671e1 Original Commit Message: This marks the InterpreterEntryTrampoline as isolate-independent. With this change, all builtins are now embedded. Slight changes were needed to how we deopt into the trampoline. We now store the entry address within the Interpreter class instead of embedding the builtin code target. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I88aa263793c38cb60300fd795c0bd7011f337739 Reviewed-on: https://chromium-review.googlesource.com/c/1342738Reviewed-by:
-
Ulan Degenbaev authored
It removes special handling for Cells and PropertyCells. That handling was required before when new space objects were embedded in code objects via Cells. Since code objects support direct embedding now, the handling can be removed. The patch also makes sure to load the map of the object once using the synchronized accessor, which will be needed for concurrent visiting of code object. Bug: v8:8459 Change-Id: I83833e19ad1da4a92e1a9be60b7c1dcd05c2b2be Reviewed-on: https://chromium-review.googlesource.com/c/1337745Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57616}
-
Joyee Cheung authored
This patch implements the parsing of private methods in the stage 3 proposal https://tc39.github.io/proposal-private-methods - Adds a --harmony-private-methods flag - Parse the private methods/accessors The design doc is in https://docs.google.com/document/d/1T-Ql6HOIH2U_8YjWkwK2rTfywwb7b3Qe8d3jkz72KwA/edit?usp=sharing This patch only makes sure the syntax parses, doesn't implement the semantics. Bug: v8:8330 Change-Id: I9007b3b3dd6a0df35db7bb14f38f1a38d52bc663 Reviewed-on: https://chromium-review.googlesource.com/c/1329706 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57615}
-
Igor Sheludko authored
which will eventually replace kPointerSize[Log2] to make it explicit what kind of values is expected. With enabled pointer compression these sizes will not be equal anymore. This CL starts an incremental migration to proper constants. Bug: v8:8477, v8:8238 Change-Id: Ia134d5a1c0639d9f9103d7a88bf87211e353ad50 Reviewed-on: https://chromium-review.googlesource.com/c/1340298Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57614}
-
Peter Marshall authored
Do less work in MultipleProfilers. Reduces runtime from ~8 mins to ~40 seconds. Bug: v8:8474 Change-Id: I72b3266941ce40c8d064deaf00fb06f8d9fa8a70 Reviewed-on: https://chromium-review.googlesource.com/c/1341956Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57613}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I96fd746291aa2e1386ed40068d38f5140bb1e44f Reviewed-on: https://chromium-review.googlesource.com/c/1342031Reviewed-by:
-
Toon Verwaest authored
Change-Id: If5d5f45dbd7461db77d3da5ba050dbe67d87a442 Reviewed-on: https://chromium-review.googlesource.com/c/1342028 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57611}
-
Toon Verwaest authored
Change-Id: I06b36e97bfa81e0f044ed4a47dd15f4797608cad Reviewed-on: https://chromium-review.googlesource.com/c/1342030Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57610}
-
Jakob Gruber authored
Windows MASM becomes extremely slow when given very large data streams. Runtime behavior is super-linear, with compile times of 5s for 50 KLOC in embedded.S 15s for 100KLOC 40s for 150KLOC Compilation of the 320KLOC file produced for debug builds took more than 5 minutes. This CL reduces compile time by emitting QWORD directives instead, which reduces the emitted debug embedded.S to around 120KLOC and compile times to around 40s. Bug: v8:8475,v8:6666 Change-Id: I19903cdf7d1b70a65c00ca67f40129847b17f386 Reviewed-on: https://chromium-review.googlesource.com/c/1341951Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57609}
-
Clemens Hammacher authored
So far, we always finished the baseline units before finishing any tiering unit. This will be refactored to finish all units from the background threads, so the finishing can happen in any order. Thus refactor the counters to count both separately, and trigger the right events. R=ahaas@chromium.org Bug: v8:7921 Change-Id: Ia2d8ab3f70f9bc3406eff428da5d22580558887b Reviewed-on: https://chromium-review.googlesource.com/c/1333669 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I337749372ad5cb475f79ec4a365a13b26266b755 Reviewed-on: https://chromium-review.googlesource.com/c/1341949 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
That way we can also cache A-Z, 0-9, _, $ (and all others obviously). Change-Id: I394001646c80bbabf9b09f66eddc1bef82ae91b3 Reviewed-on: https://chromium-review.googlesource.com/c/1341948 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I4ce0008f56976102bad952ef2389f40845dcc15b Reviewed-on: https://chromium-review.googlesource.com/c/1340255Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57605}
-
Michael Lippautz authored
Bug: chromium:843903, chromium:903586 Change-Id: I0441ab2cc0fcc0b2cb411be0c92860c64d808324 Reviewed-on: https://chromium-review.googlesource.com/c/1340254Reviewed-by:
-
Andreas Haas authored
This reverts commit f09bec92. Reason for revert: This CL was reverted by accident. Original change's description: > Revert "[wasm] Open HandleScope in LogCode" > > This reverts commit 2035042e. > > Reason for revert: Blocks the roll, see https://chromium-swarm.appspot.com/task?id=41356e9eff2a5010&refresh=10&show_raw=1 for error message > > Original change's description: > > [wasm] Open HandleScope in LogCode > > > > In WasmCode::LogCode we allocate handles, but not all callers of LogCode > > open a HandleScope. Since the handles do not escape LogCode, we can just > > open a Handlescope in the function. > > > > R=herhut@chromium.org > > > > Bug: v8:8461 > > Change-Id: I2031b467f976a9af6f541b60af245573f33d9676 > > Reviewed-on: https://chromium-review.googlesource.com/c/1337736 > > Reviewed-by: Stephan Herhut <herhut@chromium.org> > > Commit-Queue: Andreas Haas <ahaas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#57550} > > TBR=ahaas@chromium.org,herhut@chromium.org > > NOTRY=true > > Bug: v8:8461 > Change-Id: I4c95c79c029f4eed2bbaf1fcf7ccb04203335659 > Reviewed-on: https://chromium-review.googlesource.com/c/1340287 > Commit-Queue: Michael Hablich <hablich@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57583} TBR=hablich@chromium.org,ahaas@chromium.org,herhut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8461 Change-Id: Ieaabde1c686505795e9059354573c38dd982c52a Reviewed-on: https://chromium-review.googlesource.com/c/1340251Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57603}
-
Georg Neis authored
This reverts commit 585b4eef. Reason for revert: Speculative, crbug 906567. Original change's description: > [turbofan] Improve NumberMultiply typing rule. > > The NumberMultiply typing rule gave up in the presence of NaN inputs, > but we can still infer useful ranges here and just union the result > of that with the NaN propagation (similar for MinusZero propagation). > This way we can still makes sense of these ranges at the uses. > > Bug: v8:8015 > Change-Id: Ic4c5e8edc6c68776ff3baca9628ad7de0f8e2a92 > Reviewed-on: https://chromium-review.googlesource.com/c/1261143 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56539} TBR=sigurds@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8015 Change-Id: I3c652bafbbc0e5d1ad4ff288264fd4f4cbf71330 Reviewed-on: https://chromium-review.googlesource.com/c/1340253Reviewed-by:
-
Clemens Hammacher authored
{RegisterConfiguration} is not used inside assembler.h. Instead, include it where needed. R=mstarzinger@chromium.org Bug: v8:8238, v8:7490 Change-Id: Ic1aca23e862c30f5b5c7d13b866a859f1a4d4803 Reviewed-on: https://chromium-review.googlesource.com/c/1340244 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Benedikt Meurer authored
Bug: chromium:906220 Change-Id: I72547d92ffad4039c22dd7ce2d1438fe85f9c190 Reviewed-on: https://chromium-review.googlesource.com/c/1340292Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57600}
-
Clemens Hammacher authored
Instead, include macro-assembler.h (and others) where needed. R=mstarzinger@chromium.org Bug: v8:8238, v8:7490 Change-Id: I6ba4420bafee3d937bc6b648ac907f30a1d6aa52 Reviewed-on: https://chromium-review.googlesource.com/c/1340280Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This is a reland of 3ca32e98 Original change's description: > [regexp] Introduce species constructor protector for regexps. > > Bug: v8:8445 > Change-Id: Iea69c65d0054b24b3f8c7234c4c556ebee2dd45f > Reviewed-on: https://chromium-review.googlesource.com/c/1335696 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57564} Bug: v8:8445 Change-Id: Ib79d716ff857eed95eed800b33ccb53f33d5167f Reviewed-on: https://chromium-review.googlesource.com/c/1340286Reviewed-by:
-
Jaroslav Sevcik authored
Fail IsInvalid check if the property cell has been invalidated. Bug: chromium:905555 Change-Id: Ia0712b97bd6ba628936b74b3893ddb1c229ee686 Reviewed-on: https://chromium-review.googlesource.com/c/1339863 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This updates the fast path check in RegExp.p.test reduction to trigger with constant field tracking. Bug: v8:8361 Change-Id: I05d2c44189d0cc647b898599d519c2af1d78487f Reviewed-on: https://chromium-review.googlesource.com/c/1340250Reviewed-by:
-
Leszek Swirski authored
Small readability increase for the keyword check magic, using memcmp instead of a chain of raw comparisons. Could allow better codegen for memcmp-aware compilers, though in practice seems to have little effect on generated code. Change-Id: I91020fe67cebc9270c61c4c678e15217e436afff Reviewed-on: https://chromium-review.googlesource.com/c/1340291Reviewed-by:
-
Jakob Gruber authored
In preparation for converting these stubs to builtins. This turns the compile-time IsJSArray parameter into a runtime check. Bug: v8:7777 Change-Id: Ief44e7cd77e772809e50618e55f51268e9ac8ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1339868 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57594}
-
Yang Guo authored
Bug: chromium:905940 Change-Id: Ifc5e04ea871539af3a690d75b4eddf54168836df Reviewed-on: https://chromium-review.googlesource.com/c/1340283Reviewed-by:
-
Jakob Gruber authored
KeyedLoadSloppyArguments -> KeyedLoadIC_SloppyArguments KeyedStoreSloppyArguments -> KeyedStoreIC_SloppyArguments LoadIndexedIntercepter -> LoadIndexedInterceptorIC StoreInArrayLiteralSlowStub -> StoreInArrayLiteralIC_Slow StoreInterceptor -> StoreInterceptorIC StoreSlowElementStub -> KeyedStoreIC_Slow A few Store stubs were parameterized for the sole purpose of determining the KeyedAccessStoreMode later on. These are now implemented as a dedicated builtin for each store mode. Bug: v8:7777 Change-Id: I743474b0e6c5d6ec2513bb9f8f3a93c5c0535927 Reviewed-on: https://chromium-review.googlesource.com/c/1339859Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1caa03d..2fb6537 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I68d342787770515ebbd38b81c341202026b24a25 Reviewed-on: https://chromium-review.googlesource.com/c/1341462Reviewed-by:
-
- 18 Nov, 2018 2 commits
-
-
Jungshik Shin authored
Both regress-8432 and regress-8413 pass with the latest ICU roll to 407b393. TBR=ftang@chromium.org,gsathya@chromium.org,machenbach@chromium.org Bug: v8:8432,v8:8414 Change-Id: I56f3d88c1f90021ad51062bc5f26a9e88877f954 Reviewed-on: https://chromium-review.googlesource.com/c/1341455 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57590}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/45f655f..407b393 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I66c8e7e5cb96dbaa4a2e80d0eaace3dfd1624c79 Reviewed-on: https://chromium-review.googlesource.com/c/1341454 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
