PPC/s390: [iwyu] Ensure that macro assembler includes happen correctly

Port 1952f928

Original Commit Message:

    The platform specific macro assembler headers can not be included
    directly. They require symbols declared in macro-assembler.h.
    We also cannot include macro-assembler.h from the platform specific
    headers, because that would form a cycle, and the include in
    macro-assembler.h would be skipped, which then also fails.

    This CL documents and enforces this unfortunate situation.
    This helps with further iwyu cleanups.

    Note that current code which includes the platform specific headers
    only works because we transitively included macro-assembler.h already
    before.

R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: Iff6217ccb961d009a31f6adc50a7ef77ca1c8b70
Reviewed-on: https://chromium-review.googlesource.com/c/1342977Reviewed-by: Muntasir Mallick <mmallick@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#57618}

src/compiler/backend/ppc/code-generator-ppc.cc

@@ -11,8 +11,8 @@
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/osr.h"
 #include "src/double.h"
+#include "src/macro-assembler.h"
 #include "src/optimized-compilation-info.h"
-#include "src/ppc/macro-assembler-ppc.h"
 #include "src/wasm/wasm-code-manager.h"
 #include "src/wasm/wasm-objects.h"
 

src/compiler/backend/s390/code-generator-s390.cc

@@ -6,12 +6,12 @@
 
 #include "src/assembler-inl.h"
 #include "src/callable.h"
-#include "src/compiler/backend/gap-resolver.h"
 #include "src/compiler/backend/code-generator-impl.h"
+#include "src/compiler/backend/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/osr.h"
+#include "src/macro-assembler.h"
 #include "src/optimized-compilation-info.h"
-#include "src/s390/macro-assembler-s390.h"
 #include "src/wasm/wasm-code-manager.h"
 #include "src/wasm/wasm-objects.h"
 

src/ppc/frame-constants-ppc.cc

@@ -4,14 +4,12 @@
 
 #if V8_TARGET_ARCH_PPC
 
-#include "src/assembler.h"
+#include "src/ppc/frame-constants-ppc.h"
+
+#include "src/assembler-inl.h"
 #include "src/frame-constants.h"
 #include "src/macro-assembler.h"
-#include "src/ppc/assembler-ppc-inl.h"
-#include "src/ppc/assembler-ppc.h"
-#include "src/ppc/macro-assembler-ppc.h"
 
-#include "src/ppc/frame-constants-ppc.h"
 
 namespace v8 {
 namespace internal {

src/s390/frame-constants-s390.cc

@@ -4,14 +4,12 @@
 
 #if V8_TARGET_ARCH_S390
 
-#include "src/assembler.h"
+#include "src/s390/frame-constants-s390.h"
+
+#include "src/assembler-inl.h"
 #include "src/frame-constants.h"
 #include "src/macro-assembler.h"
-#include "src/s390/assembler-s390-inl.h"
-#include "src/s390/assembler-s390.h"
-#include "src/s390/macro-assembler-s390.h"
 
-#include "src/s390/frame-constants-s390.h"
 
 namespace v8 {
 namespace internal {