- 26 Jul, 2022 1 commit
-
-
Matthias Liedtke authored
This extends the ExpectedOutProc runner to print a diff between the expected and actual output. The behavior of other runners is unchanged. Change-Id: If2b89d39cf98b8d257b1a209b5471a79ec3868ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771641Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81966}
-
- 18 Jul, 2022 1 commit
-
-
Liviu Rau authored
- Removed duplication and unnecessary indirection from all suites testcfgs. - Introduced a more comprehensive context to cover both command context and other platform specific concerns. - Propagated above context to TestLoader to allow for test counting command execution on all platforms. - Wrapped original pool with another class to give it a new interface and allow injecting different implementations in the future. - Consolidated progress indicators under a single processor in the pipeline. - Consolidated result retention requirements calculation outside of pipeline chain. - Refactored LoaderProc and got it under tests. - Added some more tests for the standard runner. - Extracted BuildConfig class. Bug: v8:12785 Change-Id: I87be040e91f792a983662bb5a10d55b36a14ea7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3701595Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81770}
-
- 14 Jun, 2022 1 commit
-
-
Liviu Rau authored
- removed some 'feature envy' instances: - created a AugmentedOptions class to take care of non trivial option look-ups - moved some calculation closer the the actual data - promoted parameter that was passed around a lot (options) to filed in the offending class - similar object creation looks a bit more similar - CommandContext provides a wrapper that ensures resource de-allocation - separate tests from standard and num_fuzz runners - added a couple of more tests to improve coverage This is still in flux. But further changes risk creating a disconnect between the original implementation and further refactorings. Bug: v8:12785 Change-Id: I0ec2e9c6a81604a5cd1d4a80982dd3329c1b48db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686411 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81148}
-
- 02 Jun, 2022 1 commit
-
-
Liviu Rau authored
- moved test data closer to tests - removed the coverage related code - refactored to remove boilerplate from test code Bug: v8:12785 Change-Id: I1013d29d8ff2c3ecb786c294ae3b3ab6decdca20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683610 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#80921}
-
- 01 Jun, 2022 1 commit
-
-
Liviu Rau authored
Bringing test closer together Bug: v8:12785 Change-Id: I2eed79fd3b1bda210b1f58b341422fc0c6435bfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678210Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#80887}
-
- 25 Mar, 2022 1 commit
-
-
Michael Achenbach authored
This is a reland of commit 1289704a Mac-arm64 problem fixed by: https://crrev.com/c/3550199 Original change's description: > [tools] Clean up py2 code > > Bug: chromium:1292013 > Change-Id: Ic2c3a197005a2136bb0eda4cbb36d8eb57f42a7c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523047 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79507} Bug: chromium:1292013 Change-Id: Iadf0ccf94c82012088b76a866296c8e008dff02f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550274Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79624}
-
- 17 Mar, 2022 2 commits
-
-
Michael Achenbach authored
This reverts commit 1289704a. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/8735/overview Original change's description: > [tools] Clean up py2 code > > Bug: chromium:1292013 > Change-Id: Ic2c3a197005a2136bb0eda4cbb36d8eb57f42a7c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523047 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79507} Bug: chromium:1292013 Change-Id: I48c38209220b775d0caa45f487ed163f78333e0c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532228 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79508}
-
Michael Achenbach authored
Bug: chromium:1292013 Change-Id: Ic2c3a197005a2136bb0eda4cbb36d8eb57f42a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3523047Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79507}
-
- 04 Feb, 2022 1 commit
-
-
Michael Achenbach authored
This fixes all Python3 problems in scripts and tests running via v8_presubmit.py. It includes: - Test runner - Release tools - Perf runner - Torque formatter - V8's main presubmit On bots, v8_presubmit is run with vpython, hence we also add the required dependencies. After the Python3 migration, most of the transitional code in this CL can be removed again. Bug: chromium:1293709,chromium:1292016 Change-Id: Ic25e5965948b212c047e9d5194d2a4b6db1fa91b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432213Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#78936}
-
- 27 Jan, 2022 1 commit
-
-
Shu-yu Guo authored
Drive-by fix to align what builds the test runner considers to be able to have shared memory features and what builds can create a shared Isolate. Bug: v8:12007 Change-Id: I151513ccbfbee31e5b35c5ce8e9192732eabfee2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3421507Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78824}
-
- 15 Dec, 2021 1 commit
-
-
Samuel Groß authored
This CL renames a number of things related to the V8 sandbox. Mainly, what used to be under V8_HEAP_SANDBOX is now under V8_SANDBOXED_EXTERNAL_POINTERS, while the previous V8 VirtualMemoryCage is now simply the V8 Sandbox: V8_VIRTUAL_MEMORY_CAGE => V8_SANDBOX V8_HEAP_SANDBOX => V8_SANDBOXED_EXTERNAL_POINTERS V8_CAGED_POINTERS => V8_SANDBOXED_POINTERS V8VirtualMemoryCage => Sandbox CagedPointer => SandboxedPointer fake cage => partially reserved sandbox src/security => src/sandbox This naming scheme should simplify things: the sandbox is now the large region of virtual address space inside which V8 mainly operates and which should be considered untrusted. Mechanisms like sandboxed pointers are then used to attempt to prevent escapes from the sandbox (i.e. corruption of memory outside of it). Furthermore, the new naming scheme avoids the confusion with the various other "cages" in V8, in particular, the VirtualMemoryCage class, by dropping that name entirely. Future sandbox features are developed under their own V8_SANDBOX_X flag, and will, once final, be merged into V8_SANDBOX. Current future features are sandboxed external pointers (using the external pointer table), and sandboxed pointers (pointers guaranteed to point into the sandbox, e.g. because they are encoded as offsets). This CL then also introduces a new build flag, v8_enable_sandbox_future, which enables all future features. Bug: v8:10391 Change-Id: I5174ea8f5ab40fb96a04af10853da735ad775c96 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3322981Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78384}
-
- 25 Aug, 2021 1 commit
-
-
Samuel Groß authored
In a follow-up CL, the backing stores will, when the sandbox is enabled, be referenced from V8 objects through offsets rather than raw pointers. For that to work, all backing stores must be located inside the virtual memory cage. This CL prepares for that. Bug: chromium:1218005 Change-Id: Ibb989626ed7094bd4f02ca15464539f4e2bda90f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114136 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76486}
-
- 27 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This reverts commit 67960ba1. Reason for revert: This has been properly fixed by https://crrev.com/c/3053740. Now dcheck_always_on already defaults to false for subprojects like V8 and no other switch is required. The switch didn't fully work anyways due to https://crbug.com/1231890. Original change's description: > Reland "[build] Add V8-specific dcheck_always_on" > > This is a reland of cecc666f > > Depends on: > https://crrev.com/c/3043611 > > Original change's description: > > [build] Add V8-specific dcheck_always_on > > > > This makes the V8 dcheck control independent of Chromium's and > > prepares switching Chromium's default behavior without affecting V8 > > developers or builders. > > > > Preparation for: https://crrev.com/c/2893204 > > > > Bug: chromium:1225701 > > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75827} > > Bug: chromium:1225701 > Change-Id: I56568b78592addba01793d2d14f768c9ee10103d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75839} Bug: chromium:1225701, chromium:1231890 Change-Id: I7e27f5774d8e162977f30f685da4b15dadcc1084 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055294Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75935}
-
- 21 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This is a reland of cecc666f Depends on: https://crrev.com/c/3043611 Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I56568b78592addba01793d2d14f768c9ee10103d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75839}
-
- 20 Jul, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit cecc666f. Reason for revert: Many crashes on clusterfuzz bots https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Win64%20ASAN%20-%20release%20builder/23404/overview Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I20329f77707caf8fba2405919aa13c67811a1469 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3042841 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75830}
-
Michael Achenbach authored
This makes the V8 dcheck control independent of Chromium's and prepares switching Chromium's default behavior without affecting V8 developers or builders. Preparation for: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75827}
-
- 26 May, 2021 1 commit
-
-
Michael Achenbach authored
The verbose output shown on bots didn't print the first failing result of a flaky test before. Now the result line shows all results and the details in the end show the output of the first failure. Previously it was confusing as it seemed that the json results and the test runner output differed. We now print PASS in all caps like the other statuses. A test for this case already existed and the output is now updated. Bug: v8:8434 Change-Id: I473ec392e0028bf64b3da53d4b37446ffcd17277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919670 Commit-Queue: Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74792}
-
- 21 May, 2021 1 commit
-
-
Michael Achenbach authored
This adds a new status file indicator "HEAVY" to mark tests with high resource demands. There will be other tests running in parallel, but only a limited number of other heavy tests. The limit is controlled with a new parameter --max-heavy-tests and defaults to 1. The change also marks a variety of tests as heavy that recently had flaky timeouts. Heavy also implies slow, hence heavy tests are executed at the beginning with a higher timeout like other slow tests. The implementation is encapsulated in the test-processor chain. A new processor buffers heavy tests in a queue and adds buffered tests only if other heavy tests have ended their computation. Bug: v8:5861 Change-Id: I89648ad0030271a3a5af588ecc9c43285b728d6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905767 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74712}
-
- 12 Apr, 2021 1 commit
-
-
Shu-yu Guo authored
The pointer compression cage is the virtual memory reservation that all compressed pointers fall within. This CL splits pointer compression into two modes: a per-Isolate cage and a shared cage among multiple Isolates. When multiple Isolates are sharing a cage, they can decompress each others' pointers and share the same virtual memory range. Bug: v8:11460 Change-Id: I7b89b7413b8e7ca6b8b6faafd083dc387542a8b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783674Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#73916}
-
- 22 Feb, 2021 1 commit
-
-
Clemens Backes authored
This CL introduces a test runner flag to detect if webassembly has been disabled. Since all tests that require wasm are alrady skipped in lite mode, we introduce a has_webassembly flag for the test runner which checks for v8_enable_webassembly=true and v8_enable_lite_mode=false. As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY preprocessor flag if lite mode is enabled. The status files are updated by splitting wasm tests from the "lite_mode" section and checking for "not has_webassembly" instead. Note that the v8_enable_webassembly=false configuration is not tested on any bot currently, but I will make sure that all tests keep passing on further changes in this configuration. R=machenbach@chromium.org Bug: v8:11238 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72898}
-
- 08 Oct, 2020 1 commit
-
-
Michael Achenbach authored
This flattens the json output to one result record as a dict. In the past several records with different arch/mode combinations could be run, but this is deprecated since several releases. We also drop storing the arch/mode information in the record as it isn't used on the infra side for anything. This was prepared on the infra side by: https://crrev.com/c/2453562 Bug: chromium:1132088 Change-Id: I944514dc00a671e7671bcdbcaa3a72407476d7ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456987Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70402}
-
- 07 Oct, 2020 1 commit
-
-
Michael Achenbach authored
This simplifies mode processing as follows: - Passing the --mode parameter is deprecated. - The build output is now only searched in the --outdir parameter that was passed (previously some combinations of mode and outdir were possible). - The mode is deduced from the build artifacts based on the gn arguments "is_debug" and "dcheck_always_on". - Timeouts and status file entries in release mode with dchecks are treated like in debug mode. This change was prepared on the infrastructure side by deprecating the --mode flag and passing --outdir=out/build: https://crrev.com/c/2426643 Bug: chromium:1132088, v8:10893 Change-Id: I0f34ebc003b220f07df4ecdbf69ea6c06ac1f66a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450016Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70363}
-
- 16 Sep, 2020 1 commit
-
-
Michael Achenbach authored
I/O is quite expensive on the bots. This cuts down a bit of it by printing slightly fewer characters per test in verbose mode. This leads to an overall speed improvement of ~20% for large test suites, e.g. Test262 output-collection time goes from ~2m30 to ~2m. The averages to a 5-10% overall speed improvement for slow tryjobs. Bug: v8:10916 Change-Id: I56dcb072af8eb32a1e09e17a05db5782c6d79315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414038 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69950}
-
- 05 May, 2020 1 commit
-
-
Liviu Rau authored
Slow tests are now collected in a heap with a fixed size. When the maximum size is reached we evict the fastest test after adding a new test to the heap. Bug: v8:10168 Change-Id: If3298df85d6e924451f55fe9350e293169cc849d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2106205 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#67572}
-
- 19 Feb, 2020 1 commit
-
-
Michael Achenbach authored
The extra checks done with --testing-d8-test-runner might not hold when using NumFuzz. This refactors the test runner and allows passing implementation specific flags. The --testing-d8-test-runner flag is now only passed in the standard-runner not in the numfuzz implementation. Bug: v8:10220 Change-Id: I83cac57a948c98c34f2d84f41d719e0434e25ee7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064217 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#66341}
-
- 22 Oct, 2019 2 commits
-
-
Simon Zünd authored
Embedded builtins are now unconditionally enabled, which removes the need to differentiate between enabled/disabled embedded builtins. This Cl removes the 'embedded_builtins' variant and related *.status entries. R=machenbach@chromium.org Bug: v8:8519 Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64464}
-
Simon Zünd authored
This CL removes the 'v8_enable_embedded_builtins' GN argument and sets the 'V8_EMBEDDED_BUILTIN' define unconditionally. Removing the now obsolete 'define' and corresponding C++ code will be done in a separate CL. R=machenbach@chromium.org Bug: v8:8519 Change-Id: Ibaa3e958121931c0ce14baf48ad401fab87c5337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864929 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64456}
-
- 16 Oct, 2019 1 commit
-
-
Simon Zünd authored
This is a reland of 1c56974f This is a plain reland of the original CL. The original CL was speculatively reverted, but ended up not being the cause for bot failures. Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Bug: v8:8531 Change-Id: Id75a802279238138f7aefec62e0b6425a5acc08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864649Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64305}
-
- 15 Oct, 2019 2 commits
-
-
Clemens Backes authored
This reverts commit 1c56974f. Reason for revert: Causes several bots to timeout, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/27945 Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: I4024d818877e534b9f7908a2d14f33dca35b5924 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862572Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64293}
-
Simon Zünd authored
This CL removes 'v8_use_snapshot' and the usages of the implied V8_USE_SNAPSHOT define. One test runner unittest was updated to use the "asan" variant instead of the now obsolete "no_snap" variant. Related chromium CL: https://crrev.com/c/1796325. Bug: v8:8531 Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64290}
-
- 03 Apr, 2019 1 commit
-
-
Clemens Hammacher authored
Reading --verify_predictable makes me sad, whereas --verify-predictable makes me happy. This CL introduces more happiness. R=machenbach@chromium.org Bug: v8:8834 Change-Id: Id51a75f32e6d5a2f87aed81e058a8b6dff189758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550399Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60599}
-
- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 12 Feb, 2019 3 commits
-
-
Tamer Tas authored
Using test generators meant that we had to remove the progress indicator since the total number of tests weren't known before-hand. This CL implements a progress indicator using test number estimations. cctest and unittests progress indicator is accurate, however estimating means the progress will terminate over 100% in big test suites and sometimes under 100%. R=machenbach@chromium.org CC=sergiyb@chromium.org,yangguo@chromium.org Bug: v8:8769 Change-Id: I40ca5b40f9b1223376d33707f0945900ea98cea3 Reviewed-on: https://chromium-review.googlesource.com/c/1460471 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59538}
-
Tamer Tas authored
Testrunner test-suite doesn't have automated tests for the Fuzzer. A significant change for the testrunner may break the fuzzers. We don't have a way to catch even the syntax errors for the fuzzer before landing CLs. This CL creates a rudimentary test-suite that runs the fuzzer without any tests to see if APIs still work as intended. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: v8:8763 Change-Id: Ib4519ca093de2af5279964edd164cee04aae77a8 Reviewed-on: https://chromium-review.googlesource.com/c/1466301Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59535}
-
Tamer Tas authored
Testrunner runs variants of a test sequentially without taking sharding into account. A slow test with slow variants slows down the whole test run no matter the sharding configuration. This CL implements a test hashing algorithm and variant sharding for test variants. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I15f8c547fa2f361fb6c53bf8d5df055d3df38d3e Reviewed-on: https://chromium-review.googlesource.com/c/1458016 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59530}
-
- 07 Feb, 2019 1 commit
-
-
Tamer Tas authored
The test name alone isn't informative alone. This CL prints the variant name during the progress reporting. tested by running test262 with all variants R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I3d7d1fc6eacef3712d87404c7276fd5523bb445a Reviewed-on: https://chromium-review.googlesource.com/c/1458156 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59437}
-
- 01 Feb, 2019 3 commits
-
-
Tamer Tas authored
This is a reland of 101fd4dd Original change's description: > [testrunner] catch unforeseen exceptions > > Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. > > Unforeseen exceptions should fail the CI step. > > This CL returns an error exit code for uncaught exceptions. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8731 > Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 > Reviewed-on: https://chromium-review.googlesource.com/c/1434034 > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59278} Bug: v8:8731 No-Try: true No-Tree-Checks: true Change-Id: Ic580b334697ecebec923e76ff4a3e09fdf24dc8c Reviewed-on: https://chromium-review.googlesource.com/c/1449632Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59283}
-
Tamer Tas authored
This reverts commit 101fd4dd. Reason for revert: Uncaught exception in the recipe API https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/29928 Original change's description: > [testrunner] catch unforeseen exceptions > > Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. > > Unforeseen exceptions should fail the CI step. > > This CL returns an error exit code for uncaught exceptions. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8731 > Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 > Reviewed-on: https://chromium-review.googlesource.com/c/1434034 > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59278} TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia2b661c1a71d1799693383bc942a9a1d47668b24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8731 Reviewed-on: https://chromium-review.googlesource.com/c/1449692Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59282}
-
Tamer Tas authored
Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. Unforeseen exceptions should fail the CI step. This CL returns an error exit code for uncaught exceptions. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8731 Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 Reviewed-on: https://chromium-review.googlesource.com/c/1434034 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59278}
-
- 21 Jan, 2019 1 commit
-
-
Tamer Tas authored
With and without infra_staging flag testrunner behaves the same for old features. This CL removes duplicate tests testing the same behavior. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: v8:8174 Change-Id: Icf7bea15b2343b90697016d050fa0d918a99997d Reviewed-on: https://chromium-review.googlesource.com/c/1424859Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#58951}
-