- 07 Jul, 2021 13 commits
-
-
Patrick Thier authored
This is a reland of 8b18c5e6 Original change's description: > Reland "Improve error messages for property access on null/undefined" > > This is a reland of 24c626c1 > > Original change's description: > > Improve error messages for property access on null/undefined > > > > Only print the property name when accessing null/undefined if we can > > convert it to a string without causing side effects. > > If we can't, omit the property name in the error message. > > This should avoid confusion when the key is an object with toString(). > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > Object]' anymore, which was misleading since the property accessed would > > be 'a', but we can't evaluate the key without side effects. > > > > Bug: v8:11365 > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75250} > > Bug: v8:11365 > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75571} Bug: v8:11365 Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219 Auto-Submit: Patrick Thier <pthier@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75604}
-
Junliang Yan authored
Change-Id: Iaab1eba1590a4489004880b039e2e8900aab94b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3011163Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75603}
-
Clemens Backes authored
We did not handle conflicts between regular register moves and the cached instance / cached memory start correctly. This could lead to us overwriting a regular register when restoring the cached instance, which results in either crashes or miscalculations afterwards. R=ahaas@chromium.org Bug: chromium:1217064 Change-Id: Icd4b08b97a47726108a50d51b3a7ba410d132f98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3003158Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75602}
-
Clemens Backes authored
The {TestingModuleBuilder} had separate logic to compute the bounds checking strategy. This can lead to compiled code that does not match the bounds checking strategy stored in the NativeModule. Hence, tests should use {NativeModule::bounds_checks_} for initializing their compilation environment. R=ahaas@chromium.org Change-Id: I366c2ea5d06062273fa21e388871fc1adab54fef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009222Reviewed-by: -
Camillo Bruni authored
Bug: chromium:1011762, chromium:1061857 Change-Id: I2b2661023215b7b2d05067e6f9fb894ad6274acd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2617084 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75600}
-
Dan Elphick authored
To avoid external-reference.cc having to depend on code-assembler.h, this moves ObjectType and CheckObjectType into a separate objects/object-type.h/.cc. Bug: v8:11879 Change-Id: Ia086b37f72c330eefef2ce4d35cdf31d2a0ebe62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009220 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75599}
-
Jakob Kummerow authored
A generalization of Karatsuba's idea for even larger inputs. Bug: v8:11515 Change-Id: I50eac2d313bf4217bf2f55ca2e64b5f120f40206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999870 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75598}
-
Manos Koukoutos authored
This should mitigate some of the regressions introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2972910. Changes: - Use a single Zone for all init. expressions in InstanceBuilder. - Specialize DecodeFunctionBody() for init. expressions. Bug: v8:11895, chromium:1226551 Change-Id: Ie39f981efeaa89e57f8ccb68903c6e7cc1cb7f09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009465 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75597}
-
Victor Gomes authored
These scripts are not used nor maintained anymore by V8. We use https://chromium.googlesource.com/v8/node-ci/. Node.js is now taking ownership of these scripts: https://github.com/nodejs/node/pull/39222 Change-Id: I5600f3725d1ff9f78733952e5905faef0195a188 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3000966 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jesper van den Ende authored
This allows for marking promises as silent. Setting this flag prevents the debugger from pausing when the promise rejects. Bug: chromium:1132506 Change-Id: I260e52faa45ebedd9e8d84e092bd0260e828a902 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001354Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75595}
-
Emanuel Ziegler authored
We only care about huge functions (>100kB) as they can cause extended compilation times and OOM situations. These are difficult to see in the existing histogram as they only account for a tiny fraction of functions. We therefore introduce a new counter that only covers those functions and remove the other histogram. Bug: chromium:1222273 Change-Id: I72fcec3fda5a358de6e29eb78d1fcf40059fb6c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008646Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ced9667..8969ad2 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/ae0481e..d87a06d Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/5f424e3..e7ac0f8 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/de5768d..096f6b4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/081034a..ccc7ba2 Rolling v8/tools/luci-go: git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b..git_revision:3501536c6f762461d322d6694711bb384ffce6f2 Rolling v8/tools/luci-go: git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b..git_revision:3501536c6f762461d322d6694711bb384ffce6f2 Rolling v8/tools/luci-go: git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b..git_revision:3501536c6f762461d322d6694711bb384ffce6f2 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Iac99d089064a592e9de2f3e6d21a4fb9a1be862f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009800Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75593}
-
Liu Yu authored
Bug: v8:11420 Change-Id: Ic2744f59b697d4b229ea5cd3055a396c616fc14b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3007181Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75592}
-
- 06 Jul, 2021 22 commits
-
-
Milad Fa authored
This adds a check similar to Word32ReverseBytes. Change-Id: I3a75f29ae1b9cb75dd0fda471d6d42ca21915bf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009795Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75591}
-
Z Nguyen-Huu authored
With this change, we use Float64Pow for both Smi and Float inputs, also introduce new speculative operator. For this PoC ========================================================== let result = [NaN]; // Avoid HeapNumber-boxing the results. function slow(){ for(let i = 0; i < 100000000; i++) { result[0] = i ** 2; } } start = Date.now(); slow(); console.log(Date.now() - start); ========================================================== Before: 1313 After: 112 Bug: v8:11731 Change-Id: I07a1bde068bef8184b9f556be9d1fe2d6a288705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960064 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ia3170ef243a988c05f5892893b80b5b0a4f43b0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008895 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75589}
-
Toon Verwaest authored
The preparser doesn't support extension parsing so always return false there, and move the field to the parser instead. Change-Id: Ie9ad0bd710858120467eb709ec92e59b38eaffba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009214Reviewed-by:
-
Mike Stanton authored
In GetOwnFastDataPropertyFromHeap, we read a property value then compare it with the expected representation. We already had code to bail out of that particular optimization if there was a mismatch, however it missed the case of expected representation being a HeapObject, and when a Smi value was found. The fix is to use the excellent pre-existing method Object::FitsRepresentation() to make this check. Thusly, all cases are handled. Bug: chromium:1225607, v8:7790 Change-Id: I7d9b1b7722d9691cf5427f8456a6deb466dda0d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008218 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75587}
-
Mike Stanton authored
TurboFan reads the value in HeapNumber, and TSAN detects a data race between this read and sets on the main thread elsewhere. We mark this as relaxed atomic (meaning, correct value of the read is not guaranteed). The compiler uses the dependency mechanism to re-read the value safely on the main thread later, and aborts compilation if a change is detected. Bug: chromium:1224277, v8:7790 Change-Id: I8931d8989812550c0c57b6bd27aa796f6f5e779d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996201Reviewed-by:
-
Santiago Aboy Solanes authored
In the schedule phase (and only in this phase!) the node 0 was not being selected due to `!0` being true. We meant to be checking against undefined rather than this. Bug: v8:7327 Notry: true Change-Id: Ie675979219868725b0e345065cec7a2a7091fda8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008215Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75585}
-
Junliang Yan authored
Change-Id: I1b1d8d0485f037ba5c105741039e62db87fd2b6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008642Reviewed-by:
-
Camillo Bruni authored
Add and use two new RCS scopes: - RuntimeCallCounterId::kDebugger - RuntimeCallCounterId::kDebuggerCallback Change-Id: Ifd326424248948d0d5c1e0e29cacaecc92046e88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006415Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This CL adds support for updating code objects. So far code objects were immutable. Sparkplug makes compilation a very frequent operation and thus wants to avoid copying the instruction stream from the AssemblerBuffer into the code object (with more overhead that entails). The idea is to allocate an "empty" Code object initially, which is likely large enough to hold the full instruction stream. Then Sparkplug will compile the given function and write the instruction stream directly into the code object. After compilation is done Sparkplug trims the Code to the right size and finishes its initialization. We use relocation_info to determine whether a Code object is fully initialized: undefined means that this object is filled by SparkPlug at the moment. If it's a proper ByteArray, this code object is assumed to be initialized. Turbofan still fully initializes the Code object immediately. Before changing the size of the code object, EnsureSweepingCompleted() makes sure that the code object's page is swept already. This prevents that the concurrent sweeper loads the new and smaller object size and stores that memory in the free list. NotifyCodeObjectChanged() signals the GC that the code object is now fully initialized and revisits that object (even if it is black already) to find and record outgoing references in the instruction stream. Design doc: https://docs.google.com/document/d/12LHGkRXY1H3IFMBrdxs2vhgtG9bfJTdquQUsX1oPoSE/edit?usp=sharing Bug: v8:11872 Change-Id: Ie1b95b27842eea5ec7e9d345052585a27d6ea7f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999087 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
There's only few testing code required for embedders. Add testing directly to the regular cppgc target to allow working around an ODR violation issue with //v8:v8 and //v8:v8_for_testing, see bug. This unblock Oilpan library builds in Chromium. Bug: v8:11952, chromium:1056170 Change-Id: I0f0448faa0904b9ece58bd5a24c79c86ee55e2bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008216 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75581}
-
Sigurd Schneider authored
Associating exception meta-data may throw an exception if the browser is under memory pressure. This CL adds a try-catch scope to prevent surfacing of said exceptions in Chrome. Bug: chromium:1226360 Change-Id: Ide969273b2ac6dc109370ba2adcb20586ef30bff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008214Reviewed-by:
-
Liu Yu authored
Port: 6f48b7b3 Bug: v8:11856 Change-Id: I1828e307caa55a31090e09b6e24b3d6317fdf6fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3007176 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0862c3..ced9667 Rolling v8/buildtools/linux64: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e1e56a5..081034a Rolling v8/tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b Rolling v8/tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b Rolling v8/tools/luci-go: git_revision:40f945205c8670537d14901c310374774f589254..git_revision:a5505c14c78e1a27562164fb55f7d2d8190a0a9b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I28f68680c554a54623bbeff106b3c6aafcde61f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008257Reviewed-by:
-
Leszek Swirski authored
This reverts commit 8b18c5e6. Reason for revert: Still failing: https://test-results.appspot.com/data/layout_results/V8_Blink_Linux/12469/blink_web_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html Original change's description: > Reland "Improve error messages for property access on null/undefined" > > This is a reland of 24c626c1 > > Original change's description: > > Improve error messages for property access on null/undefined > > > > Only print the property name when accessing null/undefined if we can > > convert it to a string without causing side effects. > > If we can't, omit the property name in the error message. > > This should avoid confusion when the key is an object with toString(). > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > Object]' anymore, which was misleading since the property accessed would > > be 'a', but we can't evaluate the key without side effects. > > > > Bug: v8:11365 > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75250} > > Bug: v8:11365 > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75571} Bug: v8:11365 Change-Id: Ic4137f0d70fa9b10ca70fa921b98ea7e1499f11b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008217 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75577}
-
Santiago Aboy Solanes authored
Now we can click any panel and connect to the others via highlight. Note that we do not have a bijection between panels and (e.g. one node can be several instructions in the generated code. Bug: v8:7327, v8:11192 Notry: true Change-Id: Idfabce98bfdfc1b6cd26d540e6f0bbac47754de1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001175 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#75576}
-
Santiago Aboy Solanes authored
Now, when we click an instruction in the register allocation phase we will have highlighted both the middle panel and right panel. Previously only the right panel was highlighted. Note that the reverse is not yet true (i.e. clickin the right panel does not highlight the middle panel). Bug: v8:7327 Notry: true Change-Id: Ia45d54a33587eac3706d5fbf56e01f19d6f94144 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001170 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
If you now click a line number on the source panel (left panel) you will get the nodes (middle panel) highlighted and the disassembly code (right panel). As a bonus, you can click on the middle or right panels and get the same result (i.e. you can click on a disassembly instruction and see the highlighted source text and nodes). Note that not all source text has a node or disassembly instruction associated with it. Bug: v8:7327, v8:11192 Notry: true Change-Id: Ia20aff02407e0d9d118c26a0b5895ee521288565 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3000965Reviewed-by:
-
Maya Lekova authored
This reverts commit d42ae802. Reason for revert: Broke Mac64 ASAN - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Mac64%20ASAN%20-%20release%20builder/23150/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0862c3..05e78ec > > Rolling v8/buildtools/linux64: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e1e56a5..081034a > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: Ic1191777085e8afc6f356fd2563fa27a13ec58a8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3007654 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#75570} Change-Id: I4e3435c5ec778bb7f61b6919dd13f09d0d767753 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006579 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75573}
-
Wenyu Zhao authored
This CL make TPH be able to access some heap private interfaces, by marking TPH classes as friend classes. Bug: v8:11641 Change-Id: I72aebf267c8f36593f50279bec5dccb44cda9528 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994220 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Cr-Commit-Position: refs/heads/master@{#75572}
-
Patrick Thier authored
This is a reland of 24c626c1 Original change's description: > Improve error messages for property access on null/undefined > > Only print the property name when accessing null/undefined if we can > convert it to a string without causing side effects. > If we can't, omit the property name in the error message. > This should avoid confusion when the key is an object with toString(). > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > Object]' anymore, which was misleading since the property accessed would > be 'a', but we can't evaluate the key without side effects. > > Bug: v8:11365 > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75250} Bug: v8:11365 Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0862c3..05e78ec Rolling v8/buildtools/linux64: git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943..git_revision:31f2bba8aafa8015ca5761100a21f17c2d741062 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e1e56a5..081034a TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic1191777085e8afc6f356fd2563fa27a13ec58a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3007654Reviewed-by:
-
- 05 Jul, 2021 5 commits
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: Ic8fa0100a1e276f6c8f7c70b325718d5bdf9123e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001349 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
We were already performing these accessors in an atomic relaxed way for concurrent marking. In no-cm builds I thought we could get away with performing it non-atomically but we are seeing TSAN warnings. Bug: v8:7790, v8:11945 Change-Id: I4f3b1be3e2ae726ac15777e6eb464979b3c0159c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001179 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Victor Gomes authored
No-Try: true Bug: v8:11234 Change-Id: Icb1f40c18334f22c5d3afbf028eac79ab22610a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006635 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75567}
-
Victor Gomes authored
We do not need to force the library to be linked statically. No-Try: true Change-Id: Ib2c639fa8c0f0857a902ccf80fff1ef0a17278c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006636 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3cf06a3..a0862c3 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5a9f0ed25ca228f0ce17cbdf03611d82bcde4b82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006535Reviewed-by:
-
