- 09 Oct, 2019 24 commits
-
-
Clemens Backes authored
The method allocates, so it should return the buffer in a {unique_ptr}. Also, the internals can be simplified by using {size_t} instead of {int} and removing a redundant special case. R=mlippautz@chromium.org Bug: v8:9810 Change-Id: I94ac5814c284bf6ab075841ddbfb768d31dfff4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849514 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64195}
-
Frank Tang authored
Move the "if (!((start >= 128) && (character < 128))) {" check outside while (start <= end) loop. Bug: v8:9731 Change-Id: I1f7e2fea189f0eba0b52100ac8d4063e7d79a306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832911Reviewed-by:Jakob Gruber <jgruber@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64194}
-
Joshua Litt authored
Trivial changes to the parser to allow parsing for-await. Unfortunately, these tests uncovered a stress bug related to using await in for loops(see v8:9825). Bug: v8:9817, v8:9825 Change-Id: Ie699c85389e94b834a22dc1fb2f9970fc37fcdd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1848434Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64193}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: If8605f4dc4ab50fb5a95b43994262c8f3edd92a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849524Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64192}
-
Michael Starzinger authored
This moves the weak list of instances from {WasmModuleObject} to the corresponding {Script} object. The list is used solely for breakpoints which are intended to affect all instances belonging to a given script, hence the new placement of the list is a preparation to fully support per-script breakpoints. R=clemensb@chromium.org BUG=v8:6847,chromium:893069 Change-Id: I52315e0ba1e5e5021f55bf05d8cb0f01bf9f0fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847359 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64191}
-
Leszek Swirski authored
Measure finalization time for streaming JS compilation (to measure impact of off-thread streaming finalization). Bug: chromium:865098 Bug: chromium:1011762 Change-Id: Idc89ea18e55fec87ac7e8cca28925820e0c56b84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844783 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64190}
-
Michael Achenbach authored
TBR=tmrts@chromium.org Bug: v8:9823 Change-Id: Ic22439a8a6536d65b736b73b48029f6dc208084c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849511Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64189}
-
Clemens Backes authored
The method was deprecated in https://crrev.com/c/1581640 (part of M-76). R=ulan@chromium.org Bug: v8:9810 Change-Id: I08db459356273239f1d340b8792e2b57857d1076 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849518Reviewed-by:
-
Georg Neis authored
Due to https://chromium-review.googlesource.com/c/v8/v8/+/1835541 it's now possible that we reach ProcessApiCall without any arguments hints. I don't know how to test this in d8. Bug: chromium:1011727, v8:7790 Change-Id: I556f562515548c6355ff2358e635a2e1fc3974a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847157Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64187}
-
Dan Elphick authored
Remove TaggedIsAsyncGenerator since all but one use is to generate asserts that are handled automatically by TNodes. The remaining use is then just inlined. Also removes unused IsFastJSIterResult function. Bug: v8:6949 Change-Id: Id5631586b7e4d4f43d352493a3e2638cf449665f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849516 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64186}
-
Santiago Aboy Solanes authored
The plan is to eliminate the DecompressionElimination reducer as well as the Compressed representation. We are adding a flag to easily swap between the old system and the new one. Bug: v8:7703, v8:9206 Change-Id: I083fc7a835962eddfd60e9c403131587489f4632 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815134 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
There is some code common to both wide and extra wide that we are able to hoist up since they do not affect the flags after testing to see which version to use. Port of https://chromium-review.googlesource.com/c/v8/v8/+/1826725 Bug: v8:9771 Change-Id: I2e40a16b784a9666df4cc5ac3ec7e8c8df5fd146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847358Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64184}
-
Santiago Aboy Solanes authored
If we do the check in InvokeFunctionCode instead of doing it in CheckDebugHook (now aptly named 'DebugHook'), we can defer the debug hook to the end of InvokeFunctionCode and is to make the common case stay in straight-line code. Bug: v8:9771 Change-Id: Icff84e8ced9d120ae2fe293a391aaadd53441644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829219 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Pierre Langlois authored
The `set disassembly-flavor` command is only available when debugging a x86 target. On other targets, sourcing `tools/gdbinit` fails as a result. Sadly, we have to resort to using python's exception to ignore errors and carry on. NOTRY=true Change-Id: If37450ee5bca43d5edb02fa9a5b218d7992f8885 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847353 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL changes the Tagged loads when pointer compression is enabled. It shouldn't affect anything for the time being since if we have pointer compression enabled, we are going to be storing Compressed values. Later, we will eliminate the Compressed representation and that it's where it will come into effect. Bug: v8:7703 Change-Id: I3dc774a0d6bada2955240e3fa318ff1f7ade6808 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822637 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Yang Guo authored
R=bmeurer@chromium.org Change-Id: I45d41d6074cdf117cdef6128f8544e1a882615c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849513Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64180}
-
Santiago Aboy Solanes authored
Port of https://chromium-review.googlesource.com/c/v8/v8/+/1825222 Bug: v8:9771 Change-Id: I5915cc3001350bde0ee5f4f935dbd849048803b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847357 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
CheckedInt32ToTaggedSigned -> ChangeTaggedSignedToCompressedSigned was being simplified to CheckedInt32ToCompressedSigned. However, sometimes the effect chain is not propagated correctly. Since we have plans to remove the Compressed MachineRepresentation, we can remove this optimization now. Bug: v8:7703, chromium:1011980 Change-Id: I9198c73666848f89db96928259af68400d442229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847363Reviewed-by:
-
Santiago Aboy Solanes authored
It was recently changed to Tagged in https://chromium-review.googlesource.com/c/v8/v8/+/1832174, but IntPtr is a better choice since we are doing an IntPtr equality check below. AnyTagged loads will decompress in the near future. Then, https://chromium-review.googlesource.com/c/v8/v8/+/1822637 needs this CL before submission since otherwise we will be decompressing a value that we don't need to decompress. Change-Id: Ifb44faaf84fd68e168c5f99b72c316aa1e5b9f13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847360 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Change-Id: I3efd292e61e65a1db200f473046b75ba81739e74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849515Reviewed-by:
-
Clemens Backes authored
The V8_HAS_DECLSPEC_NORETURN macro is unused since https://crrev.com/c/529072, where we switched to the standard [[noreturn]] attribute. R=ulan@chromium.org Bug: v8:9810 Change-Id: Ifd76c967df1da7bb71369e61cd0adc1807b62d44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847365Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Backes authored
Since C++14, there is a spec'ed attribute for deprecation of methods, functions, types, aliases or anything else. This CL switches from the GCC __attribute__ to this standard attribute. This allows to use the V8_DEPRECATED and V8_DEPRECATE_SOON macros on anything where the standard attribute can be used (including {using} statements that were not working before). It also avoids the need to nest the whole declaration in the macro, making the code more readable. R=adamk@chromium.org Bug: v8:9810 Change-Id: I7adab7694af75423fb31ade2fc982dbf9c9bc699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847361Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64174}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c36051..0cb6209 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cd2fb1e..c6dbc23 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e7ae514..be83c31 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iedda8eae838b26c606b0e9a64b9b602267073a17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1848512Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64173}
-
Deepti Gandluri authored
This CL implements i8x16.extract_lane_u, i16x8.extract_lane_u operations by changing the default narrow extract operations to be unsigned. The sign-extended extracts are implemented on top of the unsigned extracts with an additional extend compiler node. For IA32/X64, the codegen effectively remains the same - 0x389332bc32a3 63 660f3a14c900 pextrb rcx,xmm1,0 0x389332bc32a9 69 0fbec9 movsxbl rcx,rcx 0x389332bc32a3 63 660f3a14c900 pextrb rcx,xmm1,0 0x389332bc32a9 69 0fbec9 movsxbl rcx,rcx On ARM, this adds an additional sxt instruction for the signed extracts. Bug: v8:8460 Change-Id: I67f14b2b860ff8cc86ffbb2f65c7ef7de32da83f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846711Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64172}
-
- 08 Oct, 2019 16 commits
-
-
Santiago Aboy Solanes authored
PrepareFunctionForOptimize should read PrepareFunctionForOptimization Change-Id: Ia8402d10c28fb714cc0ab2705ae0f995e604825d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1848231 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Z Nguyen-Huu authored
Bug: v8:8976 Change-Id: I3f13980ce49e1ca0f5caf5712c5181908054d649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834882 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Matheus Marchini authored
R=yangguo@chromium.org Ref: https://github.com/nodejs/llnode/issues/255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311Reviewed-by:
-
Joshua Litt authored
Bug: v8:7834, v8:8179, v8:9282, v8:9816, v8:9817, v8:9818, v8:9819 Change-Id: Ic26eff96df9499cb6f935e446ef2519d64de2200 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1845656 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#64168}
-
Irina Yatsenko authored
Bug: chromium:1010312 Change-Id: I46ca9349f15f3dac896a4ab631be672c1979cc48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838927 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
-
Santiago Aboy Solanes authored
Port of https://chromium-review.googlesource.com/c/v8/v8/+/1817609. Since we were already loading the undefined value a few lines above, we could avoid loading it again. Bug: v8:9771 Change-Id: I3761faacd22dabd69623179c1dc39f39c47ccb6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847356Reviewed-by:
-
Jakob Kummerow authored
This is useful for the upcoming "huge TypedArrays" support, to be able to quickly decide in stubs/generated code whether a string used as the key for a property load/store can possibly be an exotic integer index. Bug: v8:4153 Change-Id: I50ce655d2f78fb36e5615fd580f22c9290216c84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1821460 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Tbr: clemensb@chromium.org No-Tree-Checks: true No-Try: true Change-Id: Id4ca5f618d035de13174e54ff4d617b03d839033 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847364Reviewed-by:
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set)Global' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set)Global\b/kExprGlobal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I064a6448cd95bc24d31a5931b5b4ef2464ea88b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847355 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64163}
-
Eric Leese authored
This is the first piece of the wasm debugging prototype. This change adds support for removing breakpoints in WasmModuleObject. This change does not introduce any ways of exposing this feature. Code mostly pulled from Paolo Severini's prototype. Bug: chromium:1010467 Change-Id: Ia2821c59e89aa7f234398bf41e145b907085b382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826902Reviewed-by:
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by:
-
Jakob Kummerow authored
The particular combination of (1) having callee-saved registers in the stub per the C++ calling convention, (2) passing arguments to the callee on the stack, and (3) that callee throwing an exception, caused the saved registers to be restored to bogus values. To fix this, the stack unwinder needs to compute the stub's frame size correctly (i.e. without stack parameters). Bug: chromium:1007608 Change-Id: Iadd99f10764f49f9e3c620c05723e09172c73cf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847352Reviewed-by:
-
Michael Starzinger authored
This removes the output parameter returning the number of stack slot for the frame from {LookupExceptionHandlerInTable}. This is a remnant from when V8 had dynamically sized frames (aka. full-codegen), which is no longer the case. The frame size can easily be computed independent of the exception handler found during the lookup. R=jkummerow@chromium.org BUG=v8:9810 Change-Id: I0c7e04c75d7e24f2731e22370833005c17d0297a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847155Reviewed-by: -
Mythri A authored
Empty slow element dictionary had the sticky bit set. This bit was used to indicate that the dictionary cannot go to the fast mode either because the dictionary had elements with attributed or elements at large indices. There is no reason for the empty dictionary to have this bit set. This causes bugs in some corner cases. Bug: chromium:1003732 Change-Id: Ib29e1cda784869b9deb9361d8e6b5539f7154a38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833686Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#64158}
-
Ingvar Stepanyan authored
Unfortunately, codebase contains lots of places that use one of the two formats as an internal representation for Wasm locations: 1) {line: 0, column: byte offset within entire module} 2) {line: function index, column: byte offset within function} These places choose these formats interchangeably and convert from one to another depending on the presence of source map URL in Wasm. This is not very convenient and makes it hard to add support for DWARF which should behave just like Wasm with source maps - that is, report a raw Wasm script instead of fake scripts per each disassembled function, and use representation (1) instead of (2) internally. I tried to refactor these locations and avoid checking for source map URLs in the previous CL - https://crrev.com/c/v8/v8/+/1833688. However, it quickly got out of hand, and updating code in one place just kept revealing yet another that gets broken by the changes, so I made a decision to abandon it and leave to someone who knows the codebase better. Instead, this CL is based on https://crrev.com/c/v8/v8/+/1809375, but, rather than trying to integrate DWARF separately and only for supported agents, it pretends that encountering DWARF section is the same as encountering a `sourceMappingURL` section with fake URL "wasm://dwarf". This ensures that Wasm with DWARF behaves exactly in the same way as Wasm with source maps, just like we want, with minimal changes to the codebase. The only downside is that frontends without DWARF support won't get even a disassembled version of Wasm that contains DWARF info. This is unfortunate, but, as per previous discussions, should be fine given current state of Wasm debugging. Change-Id: Ia7256075e4bfd2f407d001d02b96883d7267436e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834341 Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Reviewed-by: -
Santiago Aboy Solanes authored
This is a reland of 9b1e174f\ Reverted for a test failure that was unrelated to this CL. It was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/1845223. Original change's description: > [ptr-compr] Storing a Tagged value stores the lower 32 bits > > This CL changes the Tagged stores when pointer compression is enabled. > It shouldn't affect anything for the time being since if we have pointer > compression enabled, we are going to be storing Compressed values. Later, > we will eliminate the Compressed representation and that it's where it > will come into effect. > > The Arm64 side of the CL looks bigger since we eliminated the opcode in > https://chromium-review.googlesource.com/c/v8/v8/+/1803345. > > Bug: v8:7703 > Change-Id: Ic4afbff9646b5d058adb9619b20ccccb3f5aed45 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822044 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64133} Bug: v8:7703 Change-Id: I7775e90c36f180adb0484b22eaf3918d9c012b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1845219Reviewed-by:
-
