- 08 Jun, 2015 1 commit
-
-
conradw authored
Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1144183004 Cr-Commit-Position: refs/heads/master@{#28839}
-
- 04 Jun, 2015 1 commit
-
-
mbrandy authored
Embed constant pools within their corresponding Code objects. This removes support for out-of-line constant pools in favor of the new approach -- the main advantage being that it eliminates the need to allocate and manage separate constant pool array objects. Currently supported on PPC and ARM. Enabled by default on PPC only. This yields a 6% improvment in Octane on PPC64. R=bmeurer@chromium.org, rmcilroy@chromium.org, michael_dawson@ca.ibm.com BUG=chromium:478811 LOG=Y Review URL: https://codereview.chromium.org/1162993006 Cr-Commit-Position: refs/heads/master@{#28801}
-
- 03 Jun, 2015 1 commit
-
-
bmeurer authored
Revert of Embedded constant pools. (patchset #12 id:220001 of https://codereview.chromium.org/1131783003/) Reason for revert: Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP.. Original issue's description: > Add support for Embedded Constant Pools for PPC and Arm > > Embed constant pools within their corresponding Code > objects. > > This removes support for out-of-line constant pools in favor > of the new approach -- the main advantage being that it > eliminates the need to allocate and manage separate constant > pool array objects. > > Currently supported on PPC and ARM. Enabled by default on > PPC only. > > This yields a 6% improvment in Octane on PPC64. > > R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com > BUG=chromium:478811 > LOG=Y > > Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af > Cr-Commit-Position: refs/heads/master@{#28770} TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:478811 Review URL: https://codereview.chromium.org/1155703006 Cr-Commit-Position: refs/heads/master@{#28772}
-
- 02 Jun, 2015 2 commits
-
-
mbrandy authored
Embed constant pools within their corresponding Code objects. This removes support for out-of-line constant pools in favor of the new approach -- the main advantage being that it eliminates the need to allocate and manage separate constant pool array objects. Currently supported on PPC and ARM. Enabled by default on PPC only. This yields a 6% improvment in Octane on PPC64. R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:478811 LOG=Y Review URL: https://codereview.chromium.org/1131783003 Cr-Commit-Position: refs/heads/master@{#28770}
-
verwaest authored
This also fixes issues with - kMaxUint32 being a valid length but not index cornercases - exotic integer objects masking "exotic indexes" even though its in the prototype chain - concating of holey sloppy arguments BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1159433003 Cr-Commit-Position: refs/heads/master@{#28754}
-
- 01 Jun, 2015 2 commits
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
chunyang.dai authored
port 3a1d7335 (r28683) original commit message: This finishes up work begun by CL (https://codereview.chromium.org/546683003/) some months ago. BUG= Review URL: https://codereview.chromium.org/1163603003 Cr-Commit-Position: refs/heads/master@{#28720}
-
- 28 May, 2015 2 commits
-
-
mbrandy authored
Port 3a1d7335 Original commit message: This finishes up work begun by CL (https://codereview.chromium.org/546683003/) some months ago. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1160933003 Cr-Commit-Position: refs/heads/master@{#28686}
-
mvstanton authored
This finishes up work begun by CL (https://codereview.chromium.org/546683003/) some months ago. BUG= Review URL: https://codereview.chromium.org/1149053004 Cr-Commit-Position: refs/heads/master@{#28683}
-
- 26 May, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1152243002 Cr-Commit-Position: refs/heads/master@{#28607}
-
- 22 May, 2015 1 commit
-
-
mvstanton authored
This follows the logic of the load ics, in that the base extra ic state is better encapsulated. Introduce flag vector_stores to aid development of vector-based store ics. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1151253004 Cr-Commit-Position: refs/heads/master@{#28576}
-
- 21 May, 2015 2 commits
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1148583002 Cr-Commit-Position: refs/heads/master@{#28556}
-
chunyang.dai authored
port 09aaf003 (r28516). original commit message: Also removed ornamentation like "VectorRaw" from stub names. BUG= Review URL: https://codereview.chromium.org/1152473003 Cr-Commit-Position: refs/heads/master@{#28532}
-
- 20 May, 2015 3 commits
-
-
mbrandy authored
Port 09aaf003 R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1145223003 Cr-Commit-Position: refs/heads/master@{#28525}
-
ishell authored
BUG=chromium:489597 LOG=N Review URL: https://codereview.chromium.org/1123153005 Cr-Commit-Position: refs/heads/master@{#28518}
-
mvstanton authored
Also removed ornamentation like "VectorRaw" from stub names. BUG= Review URL: https://codereview.chromium.org/1144063002 Cr-Commit-Position: refs/heads/master@{#28516}
-
- 19 May, 2015 1 commit
-
-
chunyang.dai authored
X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. port 323ced9e (r28422). original commit message: BUG= Review URL: https://codereview.chromium.org/1142713007 Cr-Commit-Position: refs/heads/master@{#28467}
-
- 18 May, 2015 1 commit
-
-
verwaest authored
This reverts commit ac5336ba. BUG= Review URL: https://codereview.chromium.org/1138483005 Cr-Commit-Position: refs/heads/master@{#28442}
-
- 15 May, 2015 2 commits
-
-
mbrandy authored
PPC: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. Port 323ced9e R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1132513007 Cr-Commit-Position: refs/heads/master@{#28431}
-
mvstanton authored
Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. BUG= Review URL: https://codereview.chromium.org/1129853002 Cr-Commit-Position: refs/heads/master@{#28422}
-
- 12 May, 2015 4 commits
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for the binary >, >=, <, and <= operators. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1130283002 Cr-Commit-Position: refs/heads/master@{#28370}
-
yangguo authored
R=mvstanton@chromium.org Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f Cr-Commit-Position: refs/heads/master@{#28357} Review URL: https://codereview.chromium.org/1126043004 Cr-Commit-Position: refs/heads/master@{#28366}
-
yangguo authored
Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/) Reason for revert: patch didn't apply correctly. Original issue's description: > Migrate error messages, part 10. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f > Cr-Commit-Position: refs/heads/master@{#28357} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1130073005 Cr-Commit-Position: refs/heads/master@{#28358}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1126043004 Cr-Commit-Position: refs/heads/master@{#28357}
-
- 07 May, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1130783002 Cr-Commit-Position: refs/heads/master@{#28291}
-
- 05 May, 2015 2 commits
-
-
danno authored
Revert of Collect type feedback on result of Math.[round|ceil|floor] (patchset #13 id:230001 of https://codereview.chromium.org/1053143005/) Reason for revert: All sorts of performance regressions Original issue's description: > Collect type feedback on result of Math.[round|ceil|floor] > > By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. > > Committed: https://crrev.com/f36ecaf3a4d61568ca50a20718acce7dd5da9a5f > Cr-Commit-Position: refs/heads/master@{#28215} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1115973005 Cr-Commit-Position: refs/heads/master@{#28237}
-
danno authored
By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. Review URL: https://codereview.chromium.org/1053143005 Cr-Commit-Position: refs/heads/master@{#28215}
-
- 30 Apr, 2015 1 commit
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for the binary + operator. Test suite is also cleaned up/refactored to allow easier testing of the comparison operators in the future. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1109223004 Cr-Commit-Position: refs/heads/master@{#28159}
-
- 28 Apr, 2015 1 commit
-
-
conradw authored
See https://codereview.chromium.org/1092353002/ Due to parser rewrites, also implements restrictions for unary ~. Still to come, implementing restrictions for binary + and comparison. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1102923002 Cr-Commit-Position: refs/heads/master@{#28104}
-
- 27 Apr, 2015 3 commits
-
-
dcarney authored
R=verwaest@chromium.org BUG=468620 LOG=N Review URL: https://codereview.chromium.org/1102543002 Cr-Commit-Position: refs/heads/master@{#28081}
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1107843002 Cr-Commit-Position: refs/heads/master@{#28060}
-
mvstanton authored
If the array's map is the initial FastHoley array map, and the array prototype chain is undisturbed and empty of elements, then keyed loads can convert the load of a hole to undefined. BUG= Review URL: https://codereview.chromium.org/1100083002 Cr-Commit-Position: refs/heads/master@{#28056}
-
- 24 Apr, 2015 2 commits
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for binary arithmetic operations, not including the + special case. Adds some infrastructure for future implementation of the restrictions for other operators. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1092353002 Cr-Commit-Position: refs/heads/master@{#28045}
-
jochen authored
Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/) Reason for revert: still working on perf Original issue's description: > Reland "Remove the weak list of views from array buffers" > > Original description: > > Instead, views have to check their array buffer for whether > > it's neutered or not. > > > > BUG=v8:3996 > > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f > Cr-Commit-Position: refs/heads/master@{#28029} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1053203007 Cr-Commit-Position: refs/heads/master@{#28038}
-
- 23 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1093183004 Cr-Commit-Position: refs/heads/master@{#28029}
-
- 21 Apr, 2015 2 commits
-
-
machenbach authored
Revert of track global accesses to constant types (patchset #15 id:280001 of https://codereview.chromium.org/1062163005/) Reason for revert: [Sheriff] Speculative revert for maybe breaking layout tests, e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2589 Will reland if it doesn't help. Original issue's description: > track global accesses to constant types > > BUG= TBR=verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1094313003 Cr-Commit-Position: refs/heads/master@{#27982}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1062163005 Cr-Commit-Position: refs/heads/master@{#27966}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 16 Apr, 2015 1 commit
-
-
chunyang.dai authored
port 0179ec57 (r27846). original commit message: The cells are stored on prototypes (in their map's PrototypeInfo). When a prototype object changes its map, then both its own validity cell and those of all "downsstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. BUG= Review URL: https://codereview.chromium.org/1090803002 Cr-Commit-Position: refs/heads/master@{#27877}
-
- 15 Apr, 2015 1 commit
-
-
mbrandy authored
Port 0179ec57 Original commit message: The cells are stored on prototypes (in their map's PrototypeInfo). When a prototype object changes its map, then both its own validity cell and those of all "downstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. R=michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1091563002 Cr-Commit-Position: refs/heads/master@{#27849}
-