- 12 Mar, 2018 23 commits
-
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7549 Change-Id: I57d5065490703e0106a87bbb6855e750ee5ca34a Reviewed-on: https://chromium-review.googlesource.com/959002 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51887}
-
Andreas Haas authored
The lifetime of the collator is handled by the JavaScript heap. At the moment this is implemented with a weak GlobalHandle. With this CL I change the implementation to use a Managed object instead. In addition I did some code cleanup. The main reason for using a Managed is an lsan problem. The final GC in d8 is triggered before all pending WebAssembly compilations get canceled. Via the native context, WebAssembly compilation can keep the Collator wrapper alive, and therefore the collator is never deallocated. Managed, however, get processed at isolate teardown, independent of the reachability of the Managed. TEST=mjsunit/regress/regress-813440 Bug: chromium:813440 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie727eb1aff2144586eb36426cc44a32357c0f822 Reviewed-on: https://chromium-review.googlesource.com/956069 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#51886}
-
Andreas Haas authored
R=ulan@chromium.org Change-Id: Ib35e3556f11b1c7beb6aa908ac72d0a1bd9d8639 Reviewed-on: https://chromium-review.googlesource.com/958923Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51885}
-
Hannes Payer authored
Bug: chromium:774108 Change-Id: I04546edfbc20e92757bd6da0505868f357f8d40d Reviewed-on: https://chromium-review.googlesource.com/959005Reviewed-by:
-
Michael Starzinger authored
The feature in question has been enabled by default for a while and we no longer need to maintain a configuration without it enabled. Note that this change only removes the mechanical pieces. Further cleanup enabled by this will be done as follow-ups. R=clemensh@chromium.org BUG=v8:7549 Change-Id: I90e5bcddabe74a18a4d2a88132e8dc93317bcff4 Reviewed-on: https://chromium-review.googlesource.com/958424 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Andreas Haas authored
Bug: chromium:810739 Change-Id: I7658e01394b03ade1acedb37b1e56004dc7660fb Reviewed-on: https://chromium-review.googlesource.com/959004Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51882}
-
Camillo Bruni authored
Bug: v8:7066 Change-Id: I5aa7e976eee6b197586a656ee2e38b9d429ec07b Reviewed-on: https://chromium-review.googlesource.com/955587Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#51881}
-
Hannes Payer authored
Bug: chromium:774108 Change-Id: I640a4f0f17244ee77fa5480ec9faa773310b9caf Reviewed-on: https://chromium-review.googlesource.com/958907Reviewed-by:
-
Camillo Bruni authored
Change-Id: I5ee7de89a262fce7db25a970a3c56c25eb6f6803 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958924 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#51879}
-
Jaroslav Sevcik authored
This is to increase test coverage (ClusterFuzz and such). Bug: chromium:798964 Change-Id: I4923fb62b52b79636bfc24b76f9642135335c96c Reviewed-on: https://chromium-review.googlesource.com/958463Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#51878}
-
Sigurd Schneider authored
This CL now uses StringCharCodeAt + StringFromCharCode to replace StringCharAt. Optimizations are easier to implement if we have both operators; however, if this tanks performance a lot we have to revert. R=bmeurer@chromium.org Bug: v8:7531 Change-Id: I75590cc8b8db57715bc2de9f5b98d0878d62a394 Reviewed-on: https://chromium-review.googlesource.com/956134 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51877}
-
Marja Hölttä authored
Not used yet apart from tests. BUG=v8:7308 Change-Id: Ibbe12597007cba123236c9fab85c524df3d5dd4a Reviewed-on: https://chromium-review.googlesource.com/955427 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 73408095. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/21075 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/12955 Original change's description: > [heap] Turn on --write-protect-code-memory. > > Bug: chromium:774108 > Change-Id: I8001013d1ee75d0847fd6a804c9e37774d900992 > Reviewed-on: https://chromium-review.googlesource.com/957088 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51873} TBR=hpayer@chromium.org,ahaas@chromium.org Change-Id: I52bd5085b9778f85687925e8fcb9c2a4b9c5934c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:774108 Reviewed-on: https://chromium-review.googlesource.com/958862Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51875}
-
Jaroslav Sevcik authored
Bug: chromium:798964 Change-Id: Ia2f0ade9e69aeb4eb0497ff91abb7ffa1d02e03f Reviewed-on: https://chromium-review.googlesource.com/958515Reviewed-by:
-
Hannes Payer authored
Bug: chromium:774108 Change-Id: I8001013d1ee75d0847fd6a804c9e37774d900992 Reviewed-on: https://chromium-review.googlesource.com/957088 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51873}
-
Clemens Hammacher authored
Add support for f32.demote/f64 and f64.promote/f32. Both are straight forward to implement on ia32 and x64. R=titzer@chromium.org Bug: v8:6600 Change-Id: I75213ddf5f422d0aa1d5d9a3bbc90ac32f6950f5 Reviewed-on: https://chromium-review.googlesource.com/955849 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Use IteratorToList to implement CallWithSpread and ConstructWithSpread instead. Bug: v8:7310 Change-Id: Ic1c44cc97914fa4fb92da8c568ac66f3ae78e520 Reviewed-on: https://chromium-review.googlesource.com/956073Reviewed-by:
-
Sigurd Schneider authored
The single argument version of String.fromCharCode had an unneccessary runtime call in it; this CL removes it. Bug: v8:7531 Change-Id: Ieeb7d8aaffb0eabf814a52c51eaff50cb57d87c9 Reviewed-on: https://chromium-review.googlesource.com/955646 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I23be9d77e7216932bd81cc75e2d5872ce0248c3c Reviewed-on: https://chromium-review.googlesource.com/958514Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51869}
-
Yang Guo authored
TBR=machenbach@chromium.org NOTRY=true Bug: v8:178 Change-Id: Id13721946dc0dd2f4154dda516a79d5599b26c56 Reviewed-on: https://chromium-review.googlesource.com/958513Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51868}
-
Yang Guo authored
R=clemensh@chromium.org, jgruber@chromium.org Bug: v8:178 Change-Id: I6f180c5539935cd91cfbbb777d5900a55c681b1f Reviewed-on: https://chromium-review.googlesource.com/957094 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51867}
-
Yang Guo authored
This is a reland of ce8f5141 Original change's description: > Skip Execution::Call in CompileFunctionInContext. > > We execute the top-level function only to get to the wrapped function. > We could do the same by simply instantiating it. > > Other approaches would change the parser so that the top-level function > is the wrapped function. However, that change violates existing scoping > invariants and fixing it would add a lot more complexity to the parser. > > R=adamk@chromium.org, marja@chromium.org > > Bug: v8:7172 > Change-Id: I7272b8b58fc739d47a44da3a9d4a914af3e8cf3d > Reviewed-on: https://chromium-review.googlesource.com/836367 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50333} Bug: v8:7172 Change-Id: Ie0e4b3db46f84a30cff8613c89eb11534ce3c1ac Reviewed-on: https://chromium-review.googlesource.com/956146Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51866}
-
v8-autoroll authored
Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b6fe934..0a9737b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I85267bc7ecb1fc6cb53cfd761f414147b3d47d73 Reviewed-on: https://chromium-review.googlesource.com/958684Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51865}
-
- 11 Mar, 2018 1 commit
-
-
Clemens Hammacher authored
After the refactoring for supporting f32 conversions, adding f64 conversions is straight forward. R=titzer@chromium.org Bug: v8:6600 Change-Id: I8f76fbef3f1e67ecdb02dd1d103868f2d1d3226f Reviewed-on: https://chromium-review.googlesource.com/957026 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
- 10 Mar, 2018 7 commits
-
-
Tobias Tebbi authored
The analysis phase used to skip TypeGuard nodes, which are normally re-introduced by the reduction phase. However, phi nodes are created during the analysis phase already, and so it could happen that a phi input skips a TypeGuard. This CL solves the problem by not removing TypeGuard nodes in the first place, but only forwarding the VirtualObject. This is analogous to how we already treat FinishRegion nodes, which are similar in that they are a renaming too. Bug: chromium:741225 Change-Id: Icf8aa2d40a30d89788d875b37b9986111f9c966f Reviewed-on: https://chromium-review.googlesource.com/958442 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 8ae19e08. Reason for revert: Speculative revert for layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/22215 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original change's description: > [esnext] re-implement template strings > > - Add a new bytecode for the ToString operation, replacing the old > intrinsic call (currently does not collect type feedback). > - Add a new AST node to represent TemplateLiterals, and avoid > generating unnecessary ToString operations in some simple cases. > - Use a single feedback slot for each string addition, because the > type feedback should always be the same for each addition > > This seems to produce a very slight improvement on JSTests benchmarks > and bench-ruben.js from v8:7415, and it's possible that type feedback > for the ToString bytecode could provide more opportunities to eliminate > the runtime call in TurboFan. > > Doesn't touch tagged templates > > BUG=v8:7415 > R=rmcilroy@chromium.org, ishell@chromium.org, bmeurer@chromium.org > > Change-Id: If5a8c68558431f058db894d65776324abf54218e > Reviewed-on: https://chromium-review.googlesource.com/945408 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Cr-Commit-Position: refs/heads/master@{#51853} TBR=rmcilroy@chromium.org,caitp@igalia.com,ishell@chromium.org,bmeurer@chromium.org Change-Id: Id0529b065493ffc20c8f2b1abacc4c1484c3c046 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7415 Reviewed-on: https://chromium-review.googlesource.com/958163Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0802e2b2. Reason for revert: For reverting https://crrev.com/c/945408 Original change's description: > [esnext] fix OOB read in ASTPrinter::VisistTemplateLiteral > > Fixes an error where TemplateLiteral printing in --print-ast > would try to read an element beyond the length of a vector. > > BUG=v8:7415, chromium:820596 > R=adamk@chromium.org, gsathya@chromium.org > > Change-Id: Idf9e0da8c165ee62bc1a348a91c2ed5ed798404a > Reviewed-on: https://chromium-review.googlesource.com/957883 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Cr-Commit-Position: refs/heads/master@{#51857} TBR=adamk@chromium.org,gsathya@chromium.org,caitp@igalia.com Change-Id: I5fe950cd823ae350b5f6c09227a62aef9dc2a008 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7415, chromium:820596 Reviewed-on: https://chromium-review.googlesource.com/957724Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d8b353b..8e843a9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/df668c3..1537dce TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7f9c08d17ba2fb7b03547eb01a7a875194c2b94d Reviewed-on: https://chromium-review.googlesource.com/958202 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Add BigInt to the list of allowed result types. Bug: v8:6791, chromium:819871 Change-Id: Ib636859da07b38c462ce7017d720e5370ba618d6 Reviewed-on: https://chromium-review.googlesource.com/957422Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#51859}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:819555 Change-Id: I70e05a4b7fa917f3da22c9cf98ccd175f7b6a3ec Reviewed-on: https://chromium-review.googlesource.com/957723Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51858}
-
Caitlin Potter authored
Fixes an error where TemplateLiteral printing in --print-ast would try to read an element beyond the length of a vector. BUG=v8:7415, chromium:820596 R=adamk@chromium.org, gsathya@chromium.org Change-Id: Idf9e0da8c165ee62bc1a348a91c2ed5ed798404a Reviewed-on: https://chromium-review.googlesource.com/957883Reviewed-by:
-
- 09 Mar, 2018 9 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:793687 Change-Id: Iaa076a1dbbf2494e05763c71903ef569c76de519 Reviewed-on: https://chromium-review.googlesource.com/955858Reviewed-by:
-
Erik Luo authored
- Label as "bigint" in DevTools heap snapshot viewer - Treat as new primitive in injected-script-source - Show primitive value as property for BigIntObject - Adds the "n" suffix onto description, both with/without inspector being present Bug: v8:7486 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I47a02e32f9bdd9124a6c91056965574ecd443867 Reviewed-on: https://chromium-review.googlesource.com/940804 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51855}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:813065 Change-Id: Ic502079f66432aefe33a765d212389b4ab191c1d Reviewed-on: https://chromium-review.googlesource.com/955652 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Caitlin Potter authored
- Add a new bytecode for the ToString operation, replacing the old intrinsic call (currently does not collect type feedback). - Add a new AST node to represent TemplateLiterals, and avoid generating unnecessary ToString operations in some simple cases. - Use a single feedback slot for each string addition, because the type feedback should always be the same for each addition This seems to produce a very slight improvement on JSTests benchmarks and bench-ruben.js from v8:7415, and it's possible that type feedback for the ToString bytecode could provide more opportunities to eliminate the runtime call in TurboFan. Doesn't touch tagged templates BUG=v8:7415 R=rmcilroy@chromium.org, ishell@chromium.org, bmeurer@chromium.org Change-Id: If5a8c68558431f058db894d65776324abf54218e Reviewed-on: https://chromium-review.googlesource.com/945408Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#51853}
-
jgruber authored
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8.ports%2FV8_Linux_-_mipsel_-_sim%2F9763%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2FBreakPointJSBuiltin%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux64_-_debug_-_fyi%2F1461%2F%2B%2Frecipes%2Fsteps%2FCheck_-_stress_off_heap_code%2F0%2Flogs%2FBreakPointBuiltin%2F0 TBR=yangguo@chromium.org Bug: v8:7543 Change-Id: I137372b3330102fbd24f356d365206ce785eca83 Reviewed-on: https://chromium-review.googlesource.com/956048 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:820458 Change-Id: I962cdb57a89b1b852e92919812fcf67c7e38e3ed Reviewed-on: https://chromium-review.googlesource.com/955853 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
jgruber authored
The macro list avoids duplication in external-reference-table and will allow us to statically determine the size of the table in a follow-up. TBR=mlippautz@chromium.org Bug: v8:6666 Change-Id: I06bb2e8c25970b3c1047dafd6c63d7ca291fe37e Reviewed-on: https://chromium-review.googlesource.com/956187 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This was a shim for the non-I+TF codepath, which is now the only codepath (that still uses this tier-up mechanism anyway). There were a couple of places we were accidentally using it due to CompileLazy or deopts, so this also fixes those. Reland of https://chromium-review.googlesource.com/951490 Change-Id: I1101eeda7b16651610c6f120062771bdc3c8a49f Reviewed-on: https://chromium-review.googlesource.com/957032Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#51849}
-
jgruber authored
Mips big-endian builders don't like embedded builtins. Disable embedded builtins on mips for now and defer investigation for when there's time. Example failures: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20big%20endian%20-%20nosnap%20-%201/builds/6666 https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20big%20endian%20-%20nosnap%20-%202/builds/5188 Two issues: test failures due to big-endianness and mismatches in the isolate-independence list. TBR=yangguo@chromium.org Bug: v8:6666 Change-Id: I73750668c03c132a9bb4d4ae9ed2bafd6d91f816 Reviewed-on: https://chromium-review.googlesource.com/955699Reviewed-by:
-
