• Andreas Haas's avatar
    [intl] Store the collator as a Managed · 825d0175
    Andreas Haas authored
    The lifetime of the collator is handled by the JavaScript heap. At the
    moment this is implemented with a weak GlobalHandle. With this CL I
    change the implementation to use a Managed object instead. In addition I
    did some code cleanup.
    
    The main reason for using a Managed is an lsan problem. The final GC in
    d8 is triggered before all pending WebAssembly compilations get
    canceled. Via the native context, WebAssembly compilation can keep the
    Collator wrapper alive, and therefore the collator is never deallocated.
    Managed, however, get processed at isolate teardown, independent of the
    reachability of the Managed.
    
    TEST=mjsunit/regress/regress-813440
    
    Bug: chromium:813440
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: Ie727eb1aff2144586eb36426cc44a32357c0f822
    Reviewed-on: https://chromium-review.googlesource.com/956069
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51886}
    825d0175
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...