- 23 Apr, 2018 6 commits
-
-
Clemens Hammacher authored
This CL fixes the new {CodeReference} class to comply to the style guide. It makes it a proper class, renames private fields to end in an underscore and simplifies the union declaration. R=ahaas@chromium.org CC=herhut@chromium.org Bug: v8:7570 Change-Id: I329bbc6fca1ba3c0cb34fb4e1179eb4fa9044e76 Reviewed-on: https://chromium-review.googlesource.com/1023414Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52722}
-
Clemens Hammacher authored
For on-heap code, there is the nice feature of highlighting the current pc on the "jco" gdb macro (calling {Code->Print}, {Code->Disassemble} or {WasmCode::Disassemble}). For wasm code, this feature was missing so far. This CL adds it. R=ahaas@chromium.org Change-Id: I0ee86d3c5cf9f42581f03c2ba4ec16b4c992e016 Reviewed-on: https://chromium-review.googlesource.com/1021517Reviewed-by: -
Clemens Hammacher authored
For binary operations and unary operations, we were pinning too many registers, thereby disallowing to reuse a src register for the result. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Id4eea1e35d29c170e191249ef42d11ed1d284490 Reviewed-on: https://chromium-review.googlesource.com/1021818Reviewed-by:
-
Ivo Markovic authored
Change-Id: Ia32553de2b2365e7396392c8b6fbdba628d3f038 Reviewed-on: https://chromium-review.googlesource.com/1013929 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
Several functions on Array.prototype incorrectly threw a TypeError just because their receiver was sealed or frozen. Bug: v8:7677 Change-Id: I4ec38bfbf468f9bd676f1c0b341c8a50cf814f15 Reviewed-on: https://chromium-review.googlesource.com/1021870 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52718}
-
Sigurd Schneider authored
This CL applies the previously introduced stack abstraction for constructing output frames to interpreted frames. Bug: v8:7679 Change-Id: I8f62b40f76f3ea43145de37429c84fcaeb12a935 Reviewed-on: https://chromium-review.googlesource.com/1019146 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52717}
-
- 21 Apr, 2018 1 commit
-
-
Timothy Gu authored
With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: https://github.com/nodejs/node/issues/15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52716}
-
- 20 Apr, 2018 17 commits
-
-
Michael Achenbach authored
NOTRY=true TBR=ulan@chromium.org Bug: v8:7678 Change-Id: Id0b582539b0c9495ae7cd51a2324d096ade66821 Reviewed-on: https://chromium-review.googlesource.com/1021576 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52715}
-
Sigurd Schneider authored
This CL introduces an stack abstraction for writing frame descriptions. Previously, we managed the output offset by hand, which is verbose and error prone. This CL introduced FrameWriter, which offers a stack abstraction with push operations for constructing the output frame descriptions. The abstraction is only applied to DoComputeBuiltinContinuation; following CLs will apply it to the other DoCompute* functions. Bug: v8:7679 Change-Id: Ia6e34de1ed63ba9245e2a08945b1e0548562ed43 Reviewed-on: https://chromium-review.googlesource.com/1019143Reviewed-by:
-
Ulan Degenbaev authored
The function allocating objects in the test can be inlined in the middle of the run. All allocations after inlining are currently not accounted. This patch sums up allocations of the function and its outer function. The difference between counts is now about 4%-6% (down from 15%). Bug: chromium:834832 Change-Id: Iad071bd5bf53bb3527c9cb24d0a9ea38618c833c Reviewed-on: https://chromium-review.googlesource.com/1021734Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52713}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org, thakis@chromium.org Bug: v8:7658 Change-Id: Ib1ee0c2efb9eca9e3c9c5012ea69b5df4e831be9 Reviewed-on: https://chromium-review.googlesource.com/1021811 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds StoreFixedTypedArrayElementFromTagged to the CSA. This method takes an array element in the form of a Number/BigInt, and converts and stores it appropriately. For BigInts, an existing method was refactored slightly to allow its usage. The added method is used in the upcoming Torque implementation of TypedArray.p.sort. R=jgruber@chromium.org Bug: v8:7382 Change-Id: I5135de0eff96eb2048aaca73de327a027c1faef8 Reviewed-on: https://chromium-review.googlesource.com/1021083 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52711}
-
Simon Zünd authored
This CL adds a test for each typed element kind where the array to sort consists of some max/min/zero elements. When providing a custom compare function, the upcoming torque version of TypedArray.p.sort needs to convert array elements to Number/BigInt and back. The tests check the edge cases for that conversion. R=jgruber@chromium.org Bug: v8:7382 Change-Id: Ia85ca343f62ece208acdeb1595e94f17ce12b713 Reviewed-on: https://chromium-review.googlesource.com/1021080 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:7570, v8:6600 Change-Id: I2630a173756a7f2d7831b6d3f820fc4224c76f68 Reviewed-on: https://chromium-review.googlesource.com/1021731Reviewed-by:
-
jgruber authored
The existing signature is problematic for two reasons: 1. The void* -> V cast is invalid if sizeof(V) < sizeof(void*) 2. It's impossible to distinguish between a returned value of 0 and nullptr, designating failure. Bug: v8:6666 Change-Id: I71e8fc9119256c24a15b5bb73438f024f1af4f88 Reviewed-on: https://chromium-review.googlesource.com/1018466Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
jgruber authored
Embed a hash of the embedded blob at serialization-time, and verify it when loading the blob. Drive-by: Keep the size of the blob trimmed, and only page-align for dynamic page allocation and freeing during mksnapshot. Bug: v8:6666 Change-Id: I10b6064f4f2847d4cc400f6f1bd6961194985b8f Reviewed-on: https://chromium-review.googlesource.com/1019144 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
Bug: v8:7570 Change-Id: Ib3ff7e64390b1f159905a054e7f9e37bd3f8a19c Reviewed-on: https://chromium-review.googlesource.com/1021530 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This implement float to i64/u64 conversions on ia32 and x64. These conversions emit a C call on ia32, and are implemented using native instructions on x64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I5b97a74d336e196598b29d407a3d06405b74ee14 Reviewed-on: https://chromium-review.googlesource.com/1014114 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mike Stanton authored
To implement builtin continuations called from the deoptimizer, we need to better support writing builtins declared with javascript binding in Torque. This CL adds fixed number of argument support. So you can declare in Torque, something like: builtin javascript Foo(context: Context, receiver: Object, bar: Object): Object { ... } Formerly, this would give you an error because we only supported javascript bindings with a varargs array. Bug: v8:7672 Change-Id: I5b5b25bdbbd5e054049c39dd2f1a4c606472dcd5 Reviewed-on: https://chromium-review.googlesource.com/1018941 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#52704}
-
Clemens Hammacher authored
The convert operation only write an output value if the conversion succeeded. Thus, we always initialize the buffer before calling the conversion function. R=ahaas@chromium.org Change-Id: Ide230a1e608205f9067349db08adde6a90b31d6f Reviewed-on: https://chromium-review.googlesource.com/1021377 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Instead of passing multiple pointers to input and output, or to two input values, just pass one pointer which holds all inputs and where the output is written. This also reduces the size of generated Turbofan graphs, since only one stack slot is needed and less arguments are passed to the call. It also fixes undefined behaviour, since we were passing a pointer e.g. as {uint64_t*}, but accessed it using {ReadUnalignedValue}. Now we pass an Address, which does not have any alignment constraints. R=ahaas@chromium.org Bug: v8:3770, v8:6600 Change-Id: I54ef80b7e27f77587a9062560c0b3e01d6593e6d Reviewed-on: https://chromium-review.googlesource.com/1019147 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Achenbach authored
This makes testing with random gc stress use the status file entrees for gc fuzzing as well, since many test cases not suitable for one, are not suitable for the other. This also skips two more tests that rely on assert(Un)Optimized, which is unreliable with gc fuzzing. TBR=sigurds@chromium.org Change-Id: I33a617b251d5cf65cf6e486d07ec55cde050b8ab Reviewed-on: https://chromium-review.googlesource.com/1021082 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Mythri authored
Check for poisoned loads in unaligned loads in interpreter-assembler-unittest node matcher. Change-Id: I5007ed1767edb035181c66028dda064b7792267f Reviewed-on: https://chromium-review.googlesource.com/1018902Reviewed-by:
Miran Karić <miran.karic@mips.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#52700}
-
Alexey Kozyatinskiy authored
.. for side effect free debug evaluate. R=yangguo@chromium.org Bug: v8:7588 Change-Id: Iac4d782dbf996d9c11430fc681f38a648d89435b Reviewed-on: https://chromium-review.googlesource.com/1000527 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52699}
-
- 19 Apr, 2018 16 commits
-
-
Andrew Grieve authored
This is relevent for when the only "git" in your PATH is git.bat (from depot_tools). I'd guess this is pretty common for Googlers. Bug: v8:5960 Change-Id: I35bc49c6054afed20481ed408cfd02b7a4c346c8 Reviewed-on: https://chromium-review.googlesource.com/1019340 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This allows percent difference of up to 0.2 in SamplingHeapProfilerRateAgnosticEstimates. Bug: chromium:834832 Tbr: ofrobots@chromium.org No-Tree-Checks: true No-Try: true Change-Id: I2f38ac886700eed31840dc19d65103b84d155592 Reviewed-on: https://chromium-review.googlesource.com/1019781 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52697}
-
Ulan Degenbaev authored
The memory metric samples memory usage immediately after forcing GC via LowMemoryNotification. This makes the metric sensitive to the unmapper tasks timing. This patch forces eager unmapping in CollectAllAvailableGarbage. It also forces eager unmapping of non-regular chunks at the beginning of Mark-Compact to avoid accumulation of non-regular chunks. Bug: chromium:833291, chromium:826384 Change-Id: Iddf02cd4ab8613385d033899d29525fe6ee47fdd Reviewed-on: https://chromium-review.googlesource.com/1017102 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52696}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I5bc2faea374f116d3916b71465c34a84bd14f74f Reviewed-on: https://chromium-review.googlesource.com/1019501Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ib3926bfa22b8639d84374cf423d26d6362e3f46e Reviewed-on: https://chromium-review.googlesource.com/1019141 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The heuristic is no longer needed now that we have concurrent marking. Bug: chromium:834371 Change-Id: I8ca3eaacdab618f690d8007aff66713260ace19f Reviewed-on: https://chromium-review.googlesource.com/1017123Reviewed-by:
-
jgruber authored
These functions are now unused within V8, as we need tighter control in mksnapshot for creating embedded.cc. Embedders should switch to using SnapshotCreator directly. Bug: v8:6666 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id231b3d1fdf50e06c9278f13d095186364264b86 Reviewed-on: https://chromium-review.googlesource.com/1019442Reviewed-by:
-
Stephan Herhut authored
The handling of wasm breakpoints was prone to forget previously set breakpoints when inserting new ones. In particular, adding breakpoints in reverse order or adding more than 4 breakpoints would fail. Change-Id: I94f314e86bdf9b53a4170ce1b6b47339b7cb7848 Reviewed-on: https://chromium-review.googlesource.com/1019302Reviewed-by:
-
Ulan Degenbaev authored
ScavengeExternalString and ScavengeExternalOneByteString clear GC flags, which confuses concurrent sweeping that was started from another test. Tests that mutate flags should not be threaded. Bug: v8:7671 Change-Id: I08656d06fe85ff45baca685ebe5982528aad774c Reviewed-on: https://chromium-review.googlesource.com/1019102Reviewed-by:
-
Dan Elphick authored
This is a reland of 6c68efac Updated Heap::CommittedMemory and related functions to iterate over all spaces rather than including them manually which can lead to a space being overlooked. Also adds a test to ensure this the case. Original change's description: > Revert "Reland "[heap] Move initial objects into RO_SPACE"" > > This reverts commit 6c68efac. > > Reason for revert: https://bugs.chromium.org/p/v8/issues/detail?id=7668 > > Original change's description: > > Reland "[heap] Move initial objects into RO_SPACE" > > > > This is a reland of f8ae62fe > > > > Original change's description: > > > [heap] Move initial objects into RO_SPACE > > > > > > This moves: > > > * the main oddballs (null, undefined, hole, true, false) as well as > > > their supporting maps (also adds hole as an internalized string to make > > > this work). > > > * most of the internalized strings > > > * the struct maps > > > * empty array > > > * empty enum cache > > > * the contents of the initial string table > > > * the weak_cell_cache for any map in RO_SPACE (and eagerly creates the > > > value avoid writing to it during run-time) > > > > > > The StartupSerializer stats change as follows: > > > > > > RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE > > > old 0 0 270264 32608 12144 0 > > > new 21776 0 253168 32608 8184 0 > > > Overall memory usage has increased by 720 bytes due to the eager > > > initialization of the Map weak cell caches. > > > > > > Also extends --serialization-statistics to print out separate instance > > > type stats for objects in RO_SPACE as shown here: > > > > > > Read Only Instance types (count and bytes): > > > 404 16736 ONE_BYTE_INTERNALIZED_STRING_TYPE > > > 2 32 HEAP_NUMBER_TYPE > > > 5 240 ODDBALL_TYPE > > > 45 3960 MAP_TYPE > > > 1 16 BYTE_ARRAY_TYPE > > > 1 24 TUPLE2_TYPE > > > 1 16 FIXED_ARRAY_TYPE > > > 1 32 DESCRIPTOR_ARRAY_TYPE > > > 45 720 WEAK_CELL_TYPE > > > > > > Bug: v8:7464 > > > Change-Id: I12981c39c82a7057f68bbbe03f89fb57b0b4c6a6 > > > Reviewed-on: https://chromium-review.googlesource.com/973722 > > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#52435} > > > > Bug: v8:7464 > > Change-Id: I50427edfeb53ca80ec4cf46566368fb2213ccf7b > > Reviewed-on: https://chromium-review.googlesource.com/999654 > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#52638} > > TBR=rmcilroy@chromium.org,yangguo@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,delphick@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: v8:7464,v8:7668 > Change-Id: I10aa03623b51e997f95a3715ea9f0bf5d29d2cdb > Reviewed-on: https://chromium-review.googlesource.com/1016600 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52667} Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If4b7490c8c4d31612de8ec132de334955a319b11 Bug: v8:7464, v8:7668 Reviewed-on: https://chromium-review.googlesource.com/1019020Reviewed-by:
-
Daniel Clifford authored
This problem was discovered by mvstanton@'s forEach Torque patch. In the absense of test coverage for Torque, his patch will serve as the regression test case for this bug when it lands. Change-Id: Ic77446a8e46168928da221e6eb18753dd6478c87 Reviewed-on: https://chromium-review.googlesource.com/1018763Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#52688}
-
jing.bao authored
Complete ptest and add vptest Add Pcmpeqb, Pcmpeqw, Ptest macro Change-Id: I060aa5228d50f2dca7ed3e24324a08c04ec1a028 Reviewed-on: https://chromium-review.googlesource.com/1013236Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#52687}
-
Simon Zünd authored
Module names in torque are allowed to have underscores but not dashes. To stay consistent with C++ file naming conventions, the underscores in module names are replaced by dashes for file names. Example: module typed_array {} would now generate: builtins-typed-array-from-dsl-gen.(cc|h) instead of: builtins-typed_array-from-dsl-gen.(cc|h) R=danno@chromium.org Change-Id: Iff42d7b9b5f65c378ee30f9d884ab6a3a3cd42a7 Reviewed-on: https://chromium-review.googlesource.com/1016460Reviewed-by: -
Simon Zünd authored
'ref' builds might not yet have BigInt support. Instead of crashing when the benchmark file is loaded, the benchmark now fails during setup. R=jgruber@chromium.org Bug: chromium:834654 Change-Id: I2c03aeba4b6af947061504c369b5228d7b344307 Reviewed-on: https://chromium-review.googlesource.com/1019100 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
This refactoring is a big step towards separating Turbofan-related code from backend independent code. This will allow us to include way less headers from "src/compiler" at various places. The {WasmCompilationUnit} contained information for Turbofan compilation, and for Liftoff compilation. This CL tears this apart, such that {WasmCompilationUnit} holds backend-independent information, plus a pointer to either {LiftoffCompilationUnit} or {TurbofanWasmCompilationUnit}. These pointers are opaque, so that {function-compiler.h}, defining {WasmCompilationUnit}, does not need to include any Turbofan specific or Liftoff specific headers. R=ahaas@chromium.org, titzer@chromium.org, mstarzinger@chromium.org Bug: v8:7570, v8:6600 Change-Id: I024c9a23508ee1b4b3cbe1d068c8e785d732daca Reviewed-on: https://chromium-review.googlesource.com/1016640 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
sreten.kovacevic authored
Since movf and movt instructions were removed in r6, sel_s and sel_d instructions need to be used instead with some preparations. Change-Id: Ia6a2fda7d3d79ada1ae1ec4649793efd2466f79b Reviewed-on: https://chromium-review.googlesource.com/1016910Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52683}
-
