- 23 Jun, 2017 1 commit
-
-
Marja Hölttä authored
This removes the include from: assembler.h (moved Isolate::AddressId to globals.h / IsolateAddressId) counters.h (ditto) elements.h (trivial) keys.h (trivial + iwyu fixes) property.h (trivial) transitions.h (trivial) vm-state.h (trivial) heap/code-stats.h (trivial + drive-by iwyuing) BUG=v8:5294 Change-Id: I36b8c07d4edf4177f1a987a393569f5191167ed3 Reviewed-on: https://chromium-review.googlesource.com/532879Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#46176}
-
- 10 Feb, 2017 1 commit
-
-
ishell authored
This CL includes runtime and IC parts of the tracking. It is controlled by compile-time flag FLAG_constant_field_tracking and currently disabled. Transition from kConst to kMutable still involves map deprecation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2598543003 Cr-Commit-Position: refs/heads/master@{#43081}
-
- 19 Jan, 2017 1 commit
-
-
ishell authored
Currently PropertyConstness is still in sync with PropertyLocation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2591233002 Cr-Commit-Position: refs/heads/master@{#42497}
-
- 13 Jan, 2017 1 commit
-
-
ishell authored
BUG=v8:5495 Review-Url: https://codereview.chromium.org/2622413004 Cr-Commit-Position: refs/heads/master@{#42328}
-
- 12 Jan, 2017 2 commits
-
-
ishell authored
BUG= Review-Url: https://codereview.chromium.org/2627003005 Cr-Commit-Position: refs/heads/master@{#42291}
-
ishell authored
This is a necessary cleanup before introducing PropertyConstness bit. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2624903003 Cr-Commit-Position: refs/heads/master@{#42277}
-
- 10 Jan, 2017 1 commit
-
-
ishell authored
... including property reconfiguring, elements kind change and migration of a map to an up-to-date non-deprecated version. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2601643002 Cr-Commit-Position: refs/heads/master@{#42177}
-
- 21 Dec, 2016 1 commit
-
-
ishell authored
This is a preliminary step for constant tracking. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2595893002 Cr-Commit-Position: refs/heads/master@{#41899}
-
- 11 Nov, 2016 1 commit
-
-
verwaest authored
Methods in the runtime that enumerate over properties should never deal with private symbols. Most commonly such methods only loop over enumerable properties. This fix avoids accidentally handling private symbols in methods that only deal with enumerable properties. Methods that need to look at non-enumerable properties as well still have to manually filter private symbols (e.g., the KeyAccumulator). BUG=chromium:664411 Review-Url: https://codereview.chromium.org/2499593002 Cr-Commit-Position: refs/heads/master@{#40932}
-
- 07 Oct, 2016 3 commits
-
-
jgruber authored
BUG= Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020 Review-Url: https://codereview.chromium.org/2381843002 Cr-Original-Commit-Position: refs/heads/master@{#40080} Cr-Commit-Position: refs/heads/master@{#40087}
-
jgruber authored
This reverts commit 7db0ecde. Manual revert since automatic revert is too large for the web interface. BUG= TBR=bmeurer@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,ahaas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2396353002 Cr-Commit-Position: refs/heads/master@{#40082}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2381843002 Cr-Commit-Position: refs/heads/master@{#40080}
-
- 18 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1704353002 Cr-Commit-Position: refs/heads/master@{#34118}
-
- 16 Feb, 2016 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
jarin authored
Review URL: https://codereview.chromium.org/1700923002 Cr-Commit-Position: refs/heads/master@{#34026}
-
- 26 Jan, 2016 1 commit
-
-
jarin authored
This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map. The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1636013002 Cr-Commit-Position: refs/heads/master@{#33521}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 12 Aug, 2015 1 commit
-
-
mstarzinger authored
This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 7 violations of that rule in the code. However there now is the "tools/check-inline-includes.sh" tool detecting such violations. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1283033003 Cr-Commit-Position: refs/heads/master@{#30125}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 23 Mar, 2015 1 commit
-
-
ulan authored
BUG=v8:3877 LOG=NO Review URL: https://codereview.chromium.org/1018283002 Cr-Commit-Position: refs/heads/master@{#27362}
-
- 19 Mar, 2015 1 commit
-
-
yangguo authored
TBR=ulan@chromium.org BUG=v8:3969 LOG=N Review URL: https://codereview.chromium.org/1020843002 Cr-Commit-Position: refs/heads/master@{#27286}
-
- 26 Feb, 2015 3 commits
-
-
ulan authored
This reverts commit b57be748 and disables the test/mjsunit/debug-clearbreakpointgroup.js because BreakLocationIterator::ClearBreakPoint is already broken for unrelated reasons (see v8:3924). BUG=v8:3877 LOG=N TEST=cctest/test-heap/Regress3877 Review URL: https://codereview.chromium.org/957373002 Cr-Commit-Position: refs/heads/master@{#26893}
-
marja authored
Revert of Fix memory leak caused by field type in descriptor array. (patchset #3 id:40001 of https://codereview.chromium.org/955063002/) Reason for revert: Breaks test/mjsunit/debug-clearbreakpointgroup.js on arm64.debug. Original issue's description: > Fix memory leak caused by field type in descriptor array. > > When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. > > Map::GetFieldType(i) does the unwrapping. > > BUG=v8:3877 > LOG=N > TEST=cctest/test-heap/Regress3877 > > Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e > Cr-Commit-Position: refs/heads/master@{#26879} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3877 Review URL: https://codereview.chromium.org/960103003 Cr-Commit-Position: refs/heads/master@{#26883}
-
ulan authored
When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. Map::GetFieldType(i) does the unwrapping. BUG=v8:3877 LOG=N TEST=cctest/test-heap/Regress3877 Review URL: https://codereview.chromium.org/955063002 Cr-Commit-Position: refs/heads/master@{#26879}
-
- 18 Feb, 2015 2 commits
-
-
verwaest authored
Additionally handlify the "transition" field so that GC can stop caring about it. BUG= Review URL: https://codereview.chromium.org/935033003 Cr-Commit-Position: refs/heads/master@{#26718}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/932533003 Cr-Commit-Position: refs/heads/master@{#26717}
-
- 19 Jan, 2015 1 commit
-
-
ishell authored
PropertyKind: DATA -> kData ACCESSOR -> kAccessor PropertyType: FIELD -> DATA CONSTANT -> DATA_CONSTANT ACCESSOR_FIELD -> ACCESSOR CALLBACKS -> ACCESSOR_CONSTANT PropertyLocation: IN_OBJECT -> kField IN_DESCRIPTOR -> kDescriptor StoreMode: FORCE_IN_OBJECT -> FORCE_FIELD FieldDescriptor -> DataDescriptor ConstantDescriptor -> DataConstantDescriptor CallbacksDescriptor -> AccessorConstantDescriptor Review URL: https://codereview.chromium.org/856503002 Cr-Commit-Position: refs/heads/master@{#26146}
-
- 19 Nov, 2014 1 commit
-
-
ishell authored
First step towards replacing PropertyType with two enums: {DATA,ACCESSOR} x {CONST,WRITABLE}. Review URL: https://codereview.chromium.org/733253004 Cr-Commit-Position: refs/heads/master@{#25417}
-
- 30 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
Review URL: https://codereview.chromium.org/618643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
Less useless creativity is best creativity! R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/526223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/504183002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Aug, 2014 3 commits
-
-
verwaest@chromium.org authored
BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/494063002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/494663002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23261 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/492433005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23260 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
This breaks fetching name of the constructor property of "Object"-labeled values in the heap-snapshot-generator until that's handlified and can be moved over to the LookupIterator. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/480823004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23226 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2014 1 commit
-
-
danno@chromium.org authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/426233002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jul, 2014 1 commit
-
-
jkummerow@chromium.org authored
instead of on the receiver's map. Lazily overwrite cached handler if it is identical to the handler that just missed. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/400523007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2014 1 commit
-
-
svenpanne@chromium.org authored
This is a mostly mechanical CL (more than 90% Emacs macros and query-replace-regexp) moving FILE*/StringStream*-based APIs to OStream-based APIs. There are a few places where this had to stop, otherwise the CL would be even bigger, but this can easily and incrementally cleaned up later. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/363323003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/333013002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-