Commits · 7c085aa4d9a99a59c2ae4e6b7f3ad1e2d7457823 · Linshizhi / V8

04 Sep, 2014 15 commits

[turbofan] More const-correctness changes. · 7c085aa4

bmeurer@chromium.org authored Sep 04, 2014

Also get rid of the DeleteNode and ChangeOperator methods in Graph.

TEST=compiler-unittests,cctest,mjsunit
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/540863002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c085aa4

Move StructuredMachineAssembler into cctest suite. · 51894ec3

mstarzinger@chromium.org authored Sep 04, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/539903002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

51894ec3

Return 0 when roll scripts terminate gracefully. · 485168c8

machenbach@chromium.org authored Sep 04, 2014

BUG=408523
LOG=n
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/536403002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

485168c8

Skip test on windows debug. · 211e77cb

machenbach@chromium.org authored Sep 04, 2014

TBR=mstarzinger@chromium.org,bmeurer@chromium.org,jarin@chromium.org

Review URL: https://codereview.chromium.org/540823004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

211e77cb

Make lookup of last v8 roll work with pure git. · 55dc65f5

machenbach@chromium.org authored Sep 04, 2014

BUG=410721
LOG=n
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/540843002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55dc65f5

[turbofan] Make sure Operator is really immutable. · c8ffed88

bmeurer@chromium.org authored Sep 04, 2014

Make Operator const-correct in preparation for allocating sharing
Operators across different isolates (using LazyInstance).

TEST=cctest,compiler-unittests,mjsunit
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/539933002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8ffed88

Add missing -Wno-missing-field-initializer flag to standalone.gypi. · dd34bc2c

bmeurer@chromium.org authored Sep 04, 2014

Chrome uses -Wno-missing-field-initializers when building V8, so we
should better use that as well. It silences warnings generated for the
GTest port files.

BUG=v8:3518
LOG=n
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/535283006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd34bc2c

[turbofan] Properly delete nodes in the GraphReducer. · b1eca2ce

bmeurer@chromium.org authored Sep 04, 2014

This is required to enable a value numbering reducer, which needs to be
able to recognize "dead nodes".

TEST=compiler-unittests,cctest
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/541643002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b1eca2ce

MIPS: Clean up code stubs and ensure distinct major keys. · fdfe006e

akos.palfi@imgtec.com authored Sep 04, 2014

Port r23655 (6327324d)

BUG=
R=machenbach@chromium.org, paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/541513002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23674 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fdfe006e

Refactor common unit test code. · 31718c55

bmeurer@chromium.org authored Sep 04, 2014

TEST=compiler-unittests
BUG=v8:3489
LOG=n
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/540823002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31718c55

Make auto_roll run with a pure git checkout. · 33e56ef8

machenbach@chromium.org authored Sep 04, 2014

BUG=410721
LOG=n
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/540513002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23672 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

33e56ef8

Mark slow test as slow on windows. · 4f165b86

machenbach@chromium.org authored Sep 04, 2014

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/540813002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4f165b86

X87: Unify some PlatformCodeStubs · 65ef6c05

weiliang.lin@intel.com authored Sep 04, 2014

port r23631.

original commit message:

  Unify some PlatformCodeStubs

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/540763002

Patch from Jing Bao <jing.bao@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23670 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65ef6c05

MIPS: CallDescriptors::InitializeForIsolate() is no longer needed. · 7fd8a961

akos.palfi@imgtec.com authored Sep 04, 2014

Port r23652 (3bd900e4)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/537753002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23669 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7fd8a961

MIPS: Minor-key-ify remaining code stubs. · e5aaf742

akos.palfi@imgtec.com authored Sep 04, 2014

Port r23643 (0051736b)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/536193002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5aaf742

03 Sep, 2014 25 commits

MIPS: Make concrete classes for individual call descriptors. - external · c25ba578

akos.palfi@imgtec.com authored Sep 03, 2014

Port r23639 (e5a2758)

Original commit message:
The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information.

BUG=
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/535753003

Patch from Balazs Kilvady <balazs.kilvady@imgtec.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c25ba578

MIPS: Make concrete classes for individual call descriptors. - internal · fe0b82d1

balazs.kilvady@imgtec.com authored Sep 03, 2014

Port r23639 (e5a2758)

Original commit message:
The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information.

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/538573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe0b82d1

Fix r23638 "Convert Linkage to use MachineSignature." for crankshaft only architectures. · 2e6db865

balazs.kilvady@imgtec.com authored Sep 03, 2014

BUG=
R=paul.lind@imgtec.com, titzer@chromium.org

Review URL: https://codereview.chromium.org/538553002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e6db865

Add more output when roll scripts are retrying. · 63e33ba0

machenbach@chromium.org authored Sep 03, 2014

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/529343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23664 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

63e33ba0

Exclude LoadMutableDouble and FunctionBindArguments from fuzzing. · 7572e779

jarin@chromium.org authored Sep 03, 2014

BUG=409542,410262
LOG=N
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/535153002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23663 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7572e779

Reland "Make FrameStates recursive (to be used for inlining).". · f7d5558a

sigurds@chromium.org authored Sep 03, 2014

Reland fixes:
- Verifier is now aware of sentinel value for FrameState chains.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/534573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f7d5558a

Never skip access checks in the lookup iterator · 5941bb4e

verwaest@chromium.org authored Sep 03, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/536943002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5941bb4e

Fix Win64 compilation failure after r23657. · 96ae555e

mstarzinger@chromium.org authored Sep 03, 2014

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/536593003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

96ae555e

Whitespace change to test roll account. · 8a124e7b

v8-autoroll@chromium.org authored Sep 03, 2014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8a124e7b

Fix Clang compilation after r23657. · e92aeec9

mstarzinger@chromium.org authored Sep 03, 2014

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/534743004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23658 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e92aeec9

Remove usages of alloca() according to style guide. · 7a4d916e

mstarzinger@chromium.org authored Sep 03, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/535133002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23657 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7a4d916e

Remove incorrect FINAL attribute from MajorKey declarations. · 7540c6ce

yangguo@chromium.org authored Sep 03, 2014

TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/535113003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23656 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7540c6ce

Clean up code stubs and ensure distinct major keys. · 62ba2c8b

yangguo@chromium.org authored Sep 03, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/530343005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23655 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62ba2c8b

MIPS: Unify some PlatformCodeStubs. · 25efa1e8

balazs.kilvady@imgtec.com authored Sep 03, 2014

Port r23631 (87d82e2)

BUG=
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/529203003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25efa1e8

Lower simplified StringLessThan[OrEqual] to runtime call. · 01b9f4e2

mstarzinger@chromium.org authored Sep 03, 2014

R=titzer@chromium.org
TEST=cctest/test-simplified-lowering/LowerStringOps_to_call_and_compare

Review URL: https://codereview.chromium.org/531093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23653 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

01b9f4e2

CallDescriptors::InitializeForIsolate() is no longer needed. · dd6d2e07

mvstanton@chromium.org authored Sep 03, 2014

CallInterfaceDescriptors initialize themselves lazily. Soon we can also tear
down the CodeStubInterfaceDescriptor explicit initialization step.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/535103002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd6d2e07

Enable access checks when loading properties through the API · 3e032ad9

verwaest@chromium.org authored Sep 03, 2014

BUG=
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/532683002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3e032ad9

Fix loading non-configurable non-writable value from a constant with mismatching type feedback · 03b0237e

verwaest@chromium.org authored Sep 03, 2014

BUG=410209
LOG=n
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/534093003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03b0237e

Correctly overwrite author in chromium roll script. · 258ac97b

machenbach@chromium.org authored Sep 03, 2014

BUG=408523
LOG=n
R=jarin@chromium.org
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/535073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23647 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

258ac97b

Remove unnecessary member variables in RecordWrite on ARM64. · 8509ddc4

yangguo@chromium.org authored Sep 03, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/538493002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8509ddc4

Minor-key-ify remaining code stubs. · 3ef636f7

yangguo@chromium.org authored Sep 03, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/535733004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23643 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ef636f7

Fix typed lowering of JSToBoolean on number inputs. · 3071a64f

mstarzinger@chromium.org authored Sep 03, 2014

R=titzer@chromium.org
TEST=cctest/test-js-typed-lowering/JSToBoolean_replacement

Review URL: https://codereview.chromium.org/533103002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3071a64f

Fix missing visitation of effect inputs to loads and stores. · bd4b82ad

mstarzinger@chromium.org authored Sep 03, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/533773002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd4b82ad

ARM64: Use templates for simulated memory accesses. · 2174796b

Jacob.Bramley@arm.com authored Sep 03, 2014

This cleans up the memory interface somewhat, and also avoids a memcpy
call that the compiler can't optimise away.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/536923002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2174796b

Make concrete classes for individual call descriptors. The ic-convention... · c2fe5b2b

mvstanton@chromium.org authored Sep 03, 2014

Make concrete classes for individual call descriptors. The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/527093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c2fe5b2b