- 03 Aug, 2022 26 commits
-
-
Clemens Backes authored
If DefaultJobState::Join is called before any worker tasks were spawned (e.g. right after Platform::CreateJob), it should spawn the required number of worker tasks (mimicing what Platform::PostJob followed by Join would do, but with less context switches). This fixes regressions we got from switching from Platform::PostJob to Platform::CreateJob. R=mlippautz@chromium.org CC=etiennep@chromium.org Bug: chromium:1348512 Change-Id: Ic7984d12a28fc67f4b2f51ddc2ba5a406e43c127 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804600Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82178}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ifc1008dce56e8f7e628a0ee0012f13403c40170b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804668 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82177}
-
Michael Achenbach authored
This reverts commit 5592bad9. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/45109/overview Original change's description: > [d8] Dump stack trace on d8 tests timeouts on posix systems > > - Add a SIGTERM handler in d8 that dupms the stack trace > - Send SIGTERM before SIGKILL in the test runner > > Bug: v8:13115 > Change-Id: I75285f33caabab61ff6ae83c1fbc6faf45cf595a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791906 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82173} Bug: v8:13115 Change-Id: I29f72d67036f76f93043f06841e4236864623bbe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805885Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Owners-Override: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82176}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I4d74ca2d063869978226586c81fc45e0fd45dffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804665 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ifad20bcccea2b87cb2119dcbaa5f16bf2dba2f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804666Reviewed-by:
-
Camillo authored
- Add a SIGTERM handler in d8 that dupms the stack trace - Send SIGTERM before SIGKILL in the test runner Bug: v8:13115 Change-Id: I75285f33caabab61ff6ae83c1fbc6faf45cf595a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791906Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82173}
-
Andreas Haas authored
Async compilation with lazy compilation generated an error message that did not include the function name. With this CL the function name now gets included. R=clemensb@chromium.org Bug: v8:12852 Change-Id: Ia8aed83a2114a2c9da1367045404b20fa8554c8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804863 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82172}
-
Andreas Haas authored
The serialized module contains information for each function whether the serialized code for the function exists, and whether the function has been executed before serialization. The latter information is used to decide if the function should get compiled eagerly after deserialization (in case the function has been executed before serialization), or if the function should get compiled lazily because it will probably not be executed anytime soon. So far this code only worked for eager compilation. When lazy compilation was enabled, all functions would get compiled lazily after deserialization. With this CL the behavior described above is extended to lazy compilation. R=clemensb@chromium.org Bug: v8:12926 Change-Id: Ifd6f400396222105feffa472c2e8787e1358220e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807583Reviewed-by:
-
Michael Lippautz authored
Weak containers are re-traced during conservative stack scanning to strongify their contents. This runs in parallel with concurrent marking that could find new weak containers. The CL fixes two issues: - The concurrent marker could find a weak container and mark it but would only add it to the set of weak containers afterwards. We need to reverse this (using a lock) to make sure that the main thread sees the marked weak container. - The DCHECK for containment needs to be concurrency aware. Bug: chromium:1349298 Change-Id: I1ec31db62647f7f1c19e9cc60976e09946551333 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807593Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#82170}
-
Victor Gomes authored
... with inlined allocation. Bug: v8:7700 Change-Id: I523bc6ed843e87611f83ed39821c389c32ea787e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804663Reviewed-by:
-
Nico Hartmann authored
This reverts commit ccde4205. Reason for revert: Investigating performance regressions Original change's description: > [TurboFan] Support BigIntMultiply > > Bug: v8:9407 > Change-Id: Iab0a4ca8dd5d83444d1addd6043a5c8e3a8577a7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773773 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82140} Bug: v8:9407 Change-Id: I21de9fd43df2e043b4019d2bad560329ef0971b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807584 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82168}
-
Leszek Swirski authored
Use marking already made several assumptions about node numbering running just before it (in particular, that loop Phis can't be marked when visited, but only when the loop back edge is visited). This wasn't too bad initially, but now we have to bend over backwards to extract the node id at loop headers for lifetime extension. So, merge the numbering into the use marking. Bug: v8:7700 Change-Id: I2f2e8feec8d0e25e302e92988109d88621879cd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797830Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82167}
-
Leszek Swirski authored
The is_unmerged_loop predicate was using the "unmerged_loop_marker" predecessor sentinel value to decide whether the merge state is an unmerged loop header or not. However, the predecessor values were otherwise uninitialized. This means that with some amount of bad luck, you could get an uninitialized predecessor which happened to hold the unmerged loop marker (it's more likely than a 1 in 2^32 chance, because it could be left over from a previous compilation's zone). Since we anyway now store whether a merge state is a loop header for other reasons, we can replace the sentinel logic with predecessor count based logic for this predicate. Bug: v8:7700, v8:13109 Change-Id: Ibabe23feefc2bb909cf2480113300cb4757114d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807591 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Seth Brenith authored
This is a reland of commit a1392fa1 The original change was reverted due to v8:13135, which was fixed separately. Original change's description: > Enable background merging when --stress-background-compile > > This change adds new functions to BackgroundCompileTask which closely > match those in BackgroundDeserializeTask. These functions allow a caller > to manage background merging of newly compiled content into an existing > Script from the Isolate compilation cache. These functions are not yet > exposed via the API; instead, StressBackgroundCompileThread uses them to > increase test coverage of the merging logic. > > Bug: v8:12808 > Change-Id: I4d2f429164223785169fe447ce2bdd8beaee00d4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3793959 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82121} Bug: v8:12808 Change-Id: I530c6e87bbad11e178ef4abfdc25fa98530f0224 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3806590Reviewed-by:
-
ishell@chromium.org authored
... with addresses unexpected by V8. Bug: v8:12425 Change-Id: I602ea79e84242a4a163bdbd6b22fb16e76eda1a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807585Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82164}
-
Lu Yahan authored
This reverts commit 491de34b. Reason for revert: Lose co-authors information Original change's description: > [riscv32] Add RISCV32 backend > > This very large changeset adds support for RISCV32. > > Bug: v8:13025 > Change-Id: Ieacc857131e6620f0fcfd7daa88a0f8d77056aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736732 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> > Reviewed-by: ji qiu <qiuji@iscas.ac.cn> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82053} Bug: v8:13025 Change-Id: I6abea32c8ea43b080a938782dc643c97a123f1d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803994Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82163}
-
Andreas Haas authored
Some tests assume that liftoff code is available immediately after compilation. Add the `--no-wasm-lazy-compilation` flag to these tests so that they work even after shipping lazy compilation. R=clemensb@chromium.org Bug: v8:12926 Change-Id: I839610221390822b90b25e1bef3ae727fa33d1ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804862Reviewed-by:
-
Simon Zünd authored
R=bmeurer@chromium.org Fixed: chromium:1334585 Change-Id: Id79a60bac1731ea9c60654ff15c8e23f958c6e57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3799431Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#82161}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Id4294fdfad414b34606a1f15e97dbd5485b8e23a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804868 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
We create a constructor for CallBuiltin that accepts a feedback vector. It assumes that the builtin expects a slot and the vector respectively at the end. Bug: v8:7700 Change-Id: I20f9b4ff172dca7779abd31a042b3bdc734df350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804250 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Victor Gomes authored
These bytecodes simply call a builtin. Bug: v8:7700 Change-Id: I2616ea5571741a7f79b27bc6ddbd95cfb3254e97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805063 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
Except CopyDataPropertiesWithExcludedPropertiesOnStack. Bug: v8:7700 Change-Id: Ie7e070002071291da2d9279c601a78b22113fc9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804864Reviewed-by:
-
Hao Xu authored
Turbofan optimizes TruncateInt64ToInt32 by trying to merge it into its input. This can avoid generating a movl instruction. However, when the input is BitcastTaggedToWordForTagAndSmiBits, it fails to apply this optimization and this results in a redundant move: Turbofan IR: 149: Load[kRepTaggedSigned|kTypeInt32](...) 150: BitcastTaggedToWordForTagAndSmiBits(149) 151: TruncateInt64ToInt32(150) 152: Word32And(151, 558) Assembly: 103 movl r11,[r8+0x1f] 107 movl r11,r11 10a andl r11,0x4 This CL fixes this and avoids the redundant movl instruction. Change-Id: Id59d1ce1e3b139344f750e903726dd9f338cfdba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3787681Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#82156}
-
Seth Brenith authored
Currently, WebSnapshotDeserializer::CreateScopeInfo creates the ScopeInfo first, and then creates its local names hashtable if necessary. If GC occurs when creating the local names hashtable, the object verifier correctly complains that the ScopeInfo doesn't have all needed fields. The solution (consistent with ScopeInfo::Create) is to create the local names hashtable first. That way, no GC can happen in the interval after the ScopeInfo is allocated but before it has valid fields. Bug: v8:13135 Change-Id: Ifd6eb10e54a4151f7edb592bc19afa3263d41788 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803674Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#82155}
-
Andreas Haas authored
Follow-up to post-submit comments in https://chromium-review.googlesource.com/c/v8/v8/+/3782796 Bug: chromium:1346250, v8:12926 Change-Id: I09a8601c600b24fbc92489224ad69602e557bf7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784604 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Liu Yu authored
This is a reland of commit 7af609f9 Original change's description: > [loong64][mips64][wasm] WasmCompileLazyFrame scanning > > Port commit eb3fb6cb Change-Id: I9d48e02cf4d5710c6c36efb1c82c584755867b9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805838Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#82153}
-
- 02 Aug, 2022 14 commits
-
-
Anton Bikineev authored
On-heap objects may have TracedReferences, which are uncompressed pointers that still need to be conservatively scanned (another CL). Bug: chromium:1325007 Change-Id: If05add36191978486f315dc1ef142a7ed8d4a7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804808 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 4e329f8c Original Commit Message: The original CL did not handle the case where a GC gets triggered by the allocation of the error object when compilation fails. Orignal message: Feedback vector allocation can trigger a GC, and thereby make the WasmCompileLazyFrame visible for the GC. This CL add stack scanning for the WasmCompileLazyFrame. Design doc: http://doc/1peovM6N6C4nSEdC77l4uxU1L0njA0RTaOjy5F12r2CQ R=ahaas@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I3cdd5b0cd72463a6b492fcafcabcf65e1da55eea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804694Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82151}
-
Feng Yu authored
Bug: v8:12918 Change-Id: Id3419cf7cef833cc8e18948874c40e13a3f20675 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3798522 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Samuel Groß authored
Bug: v8:10391 Change-Id: I7f1b69b1fe41507e4eb72a35b4c143a970cc2f74 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788205 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I27db2c8d0cbbf4324d9f2b214b909326fc61968d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805065 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Omer Katz authored
Bug: v8:12612 Change-Id: Iaf967da524413b6701aa93fa471d79e2a82e43e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805064Reviewed-by:
-
Milad Fa authored
Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82146}
-
jameslahm authored
Bug: v8:7700 Change-Id: I36018a3323d778b8657087736e1bff70b0fdbf2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779920 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Milad Fa authored
Port 044a18ac Original Commit Message: The {LiftoffAssembler::Load} method already receives an {i64_offset} parameter which skips the UXTW (zero extension of 32-bit addresses) in the memory operand. The same needs to happen on stores. On 32-bit platforms, we cannot have addresses >=4GB anyway (they would be detected as OOB before reaching the point in question), so this is not a problem. On x64, all 32-bit registers are zero-extended already (which is debug-checked in the generated code), so this is also no problem (and we just ignore the additional parameter). R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic531618875bf3b6abcf3741bcbe153e603d9f250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794647Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:1348929 Change-Id: I14ce163dbebd7e83023286e210411e8a8208e238 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804603 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82143}
-
Liu Yu authored
Port commit ec6368bf Bug: v8:11325 Change-Id: I3805ec4886dc2cb109fa450c0141d5e3f0779292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803673Reviewed-by:
-
Victor Gomes authored
This also creates a generic CallBuiltin node. Bug: v8:7700 Change-Id: I7c7a4f8205fc6847372e880ad21658b825ab9bce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3798723 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Qifan Pan authored
Bug: v8:9407 Change-Id: Iab0a4ca8dd5d83444d1addd6043a5c8e3a8577a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773773Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
This reverts commit 6735d74a (relands cd617a58) and fixes the SIMD issue. Change-Id: I86894f2d4fbdb7ba85aae3730f90ab2b11c088bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3793709 Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
-
