• Hao Xu's avatar
    [turbofan][x64] Avoid TruncateInt64ToInt32 when possible · 59c55c1c
    Hao Xu authored
    Turbofan optimizes TruncateInt64ToInt32 by trying to merge it into
    its input. This can avoid generating a movl instruction. However, when
    the input is BitcastTaggedToWordForTagAndSmiBits, it fails to apply
    this optimization and this results in a redundant move:
    
      Turbofan IR:
      149: Load[kRepTaggedSigned|kTypeInt32](...)
      150: BitcastTaggedToWordForTagAndSmiBits(149)
      151: TruncateInt64ToInt32(150)
      152: Word32And(151, 558)
    
      Assembly:
      103  movl r11,[r8+0x1f]
      107  movl r11,r11
      10a  andl r11,0x4
    
    This CL fixes this and avoids the redundant movl instruction.
    
    Change-Id: Id59d1ce1e3b139344f750e903726dd9f338cfdba
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3787681Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Hao A Xu <hao.a.xu@intel.com>
    Cr-Commit-Position: refs/heads/main@{#82156}
    59c55c1c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...