- 20 Mar, 2018 11 commits
-
-
Clemens Hammacher authored
The MessageLoopBehavior might change over time: Sometimes we want to wait because wasm background compilation is going on, sometimes we don't. This makes the semaphore go out of sync with the task queue (we always notify it when a new task is scheduled, but we only sometimes wait on it). Using a condition variable instead of a semaphore avoids this problem. R=ahaas@chromium.org Change-Id: Ib9850efc634f5988d3f824895b6566bd76475985 Reviewed-on: https://chromium-review.googlesource.com/969122Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52057}
-
Daniel Clifford authored
In general, TurboFan doesn't encounter phi nodes with only a single data input in the backend. However, CSA-based builtins (especially auto-generated ones, e.g. from Torque), may contain single-input phi nodes, although outside the auto-generated case this doesn't happen much in practice. Single input phi nodes (i.e. phis in blocks with one predecessor) don't have any side effects and are essentially useless and harmless, but to avoid problems in the backend of TurboFan (whose SSA deconstruction disallows control flow splits that continue to blocks with phis), this CL tweaks the existing CSA-only control flow and graph sanitization in the CSA path to ensure no no-op phis. Change-Id: I109f4dc6cde5ad1794585a09609a230b1848e0d5 Reviewed-on: https://chromium-review.googlesource.com/963711Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#52056}
-
Michael Achenbach authored
This is a reland of 40d66d8b The fix disambiguates duplicate symbols in the generated embedded builtins file. Original change's description: > [build] Make separate snapshot for trusted variant > > This enables side-by-side snapshots with and without untrusted-code > mitigations. It'll be the default in all V8 stand-alone builds > with external startup data. Internal snapshots are not supported. > > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be > bundled with V8 on swarming and the correct file is loaded dependent > on the --untrusted-code-mitigations runtime flag. > > Likewise we embed two snapshots for builtins. > > Side-by-side snapshots won't be supported in Chromium. > > Bug: v8:7441 > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 > Reviewed-on: https://chromium-review.googlesource.com/960004 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52028} Bug: v8:7441 Change-Id: I626171d4e07389f0453b4d0a698e2772fd37e8c5 Reviewed-on: https://chromium-review.googlesource.com/968623 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52055}
-
Clemens Hammacher authored
This adds support to get or set globals of all the standard types (i32, i64, f32, f64). R=titzer@chromium.org Bug: v8:6600 Change-Id: Ie8d14d3d964e2abe3f19945a0e80b0e8462e9485 Reviewed-on: https://chromium-review.googlesource.com/969262 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52054}
-
Dan Elphick authored
Adds a new space RO_SPACE and modifies the serializer and other machinery to support it. Currently RO_SPACE has nothing in it, but will eventually contain all the immovable immutable objects, so the GC can ignore it. Bug: v8:7464 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib2ff474699196c138df8c24f7a2248471e30fbac Reviewed-on: https://chromium-review.googlesource.com/925703 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52053}
-
Clemens Hammacher authored
It was stored in a shared_ptr so far, which makes it more difficult to reason about life times. Since there is always exactly one owner of the AsyncCompileJob, a unique_ptr actually suffices. R=ahaas@chromium.org Change-Id: If94c9091889ad05325c559a97e9a9ffeee8d450c Reviewed-on: https://chromium-review.googlesource.com/968604Reviewed-by:
-
Clemens Hammacher authored
This adds support for the f32.abs and f64.abs opcodes. R=titzer@chromium.org Bug: v8:6600 Change-Id: I05a16bb4301d492ba8d22a6326c7b2ce0f9f2faa Reviewed-on: https://chromium-review.googlesource.com/968502Reviewed-by:
-
Yang Guo authored
Also unskip test that has already been fixed in f1b1ec70. R=jgruber@chromium.org Bug: v8:178 Change-Id: I9cd2156ef41146b0dd58a974088726f5cbda8058 Reviewed-on: https://chromium-review.googlesource.com/970243Reviewed-by:
-
Jaroslav Sevcik authored
This prevent forgotten field initializations. Bug: v8:5267 Change-Id: Iaef5f79af360e2400b29afe878f80870c8a64e71 Reviewed-on: https://chromium-review.googlesource.com/970241 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52049}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: chromium:822593 Change-Id: I86291a5039fc368c0fddea4d46e0d6c72c56a226 Reviewed-on: https://chromium-review.googlesource.com/968921 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52048}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/76da9f5..a7e9a83 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/2888931..3748a2a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6c4a8ca..734f737 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0a9737b..7d56ff9 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I60e4196d8ed8d39e88bbf3688569bbd0aadef919 Reviewed-on: https://chromium-review.googlesource.com/969956Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52047}
-
- 19 Mar, 2018 29 commits
-
-
Peter Marshall authored
In order to remove the construct_stub field of the SFI we need all construct stubs to be the same, and do any branching at runtime instead. For builtins we don't need to set the construct stub because the builtins construct stub will call into it for us. There should only be two builtins left without the builtins construct stub: Array and InternalArray, which are special cases that need to be dealt with in another CL. Bug: v8:7503 Change-Id: If0d419399a9ee22c09cf2a5a3d3dbea7a04dee77 Reviewed-on: https://chromium-review.googlesource.com/968862Reviewed-by:
-
Michael Stanton authored
This reverts commit 46a3c772. Reason for revert: This is actually not quite ready. What we need is a speculation free poisoning, and if we do another branch, then I think that won't happen. Original change's description: > [turbofan] Masking/poisoning in codegen (optimized code, mips & mips64) > > This introduces masking of loads with speculation bit during code generation. > At the moment, this is done only under the > --branch-load-poisoning flag, and this CL enlarges the set of supported > platforms from {x64, arm, arm64} to {x64, arm, arm64, mips, mips64}. > > Overview of changes: > - new register configuration configuration with one register reserved for > the speculation poison/mask (kSpeculationPoisonRegister). > - in codegen, we introduce an update to the poison register at the starts > of all successors of branches (and deopts) that are marked as safety > branches (deopts). > - in memory optimizer, we lower all field and element loads to PoisonedLoads. > - poisoned loads are then masked in codegen with the poison register. > * only integer loads are masked at the moment. > > Bug: chromium:798964 > Change-Id: I211395b8305ed0ad9288d6da48fa159fa970c827 > Reviewed-on: https://chromium-review.googlesource.com/951382 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> > Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> > Cr-Commit-Position: refs/heads/master@{#52042} TBR=mvstanton@chromium.org,mstarzinger@chromium.org,ivica.bogosavljevic@mips.com Change-Id: Ief4d9ef56d918172f0b545d321a64b1ab5b46915 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:798964 Reviewed-on: https://chromium-review.googlesource.com/969041Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#52045}
-
Kim-Anh Tran authored
Synchronous compilation currently continues creating new tasks even though compilation has already failed. This stops the creation of new background tasks and makes sure that the background task manager in the CompilationState is not canceled twice. Change-Id: Ic4c55275ff70e7eca901ad357253f81aa8e2e8e1 Reviewed-on: https://chromium-review.googlesource.com/968781 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52044}
-
Clemens Hammacher authored
EmitMonomorphicBinOp and EmitBinOpWithDifferentResultType were nearly identical, they just differ in one argument to GetUnusedRegister. This CL merges them. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ief75beb410c8ba248b43cd382693f25bd9153d74 Reviewed-on: https://chromium-review.googlesource.com/968501 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mike Stanton authored
This introduces masking of loads with speculation bit during code generation. At the moment, this is done only under the --branch-load-poisoning flag, and this CL enlarges the set of supported platforms from {x64, arm, arm64} to {x64, arm, arm64, mips, mips64}. Overview of changes: - new register configuration configuration with one register reserved for the speculation poison/mask (kSpeculationPoisonRegister). - in codegen, we introduce an update to the poison register at the starts of all successors of branches (and deopts) that are marked as safety branches (deopts). - in memory optimizer, we lower all field and element loads to PoisonedLoads. - poisoned loads are then masked in codegen with the poison register. * only integer loads are masked at the moment. Bug: chromium:798964 Change-Id: I211395b8305ed0ad9288d6da48fa159fa970c827 Reviewed-on: https://chromium-review.googlesource.com/951382Reviewed-by:Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52042}
-
Marja Hölttä authored
For problems with the current approach, see crbug.com/v8/7564. We can instead gather all weak references in code in VisitEmbeddedPointer. BUG=v8:7564, v8:7308 Change-Id: Ib369e7ab9efd62c90bdac69835318929c58217f2 Reviewed-on: https://chromium-review.googlesource.com/968250 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52041}
-
Georg Neis authored
This type is dangerous because it can become smaller over time (as strings get internalized). Bug: v8:6521 Change-Id: Iea650789ab52c13a0519f46999edc8a7959ccc71 Reviewed-on: https://chromium-review.googlesource.com/968525 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52040}
-
jgruber authored
This is another step towards efficient external reference access from off-heap builtins. Bug: v8:6666 Change-Id: I6f128a8a64724acaa092f28b1fceae01e3c05487 Reviewed-on: https://chromium-review.googlesource.com/968481Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52039}
-
Igor Sheludko authored
... and rename Runtime::kDeclareGlobalsForInterpreter -> Runtime::kDeclareGlobals. Bug: v8:7310 Change-Id: I58f9615b6948b66727f2de7e9ba1b0be4f87d9aa Reviewed-on: https://chromium-review.googlesource.com/966291 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52038}
-
Yang Guo authored
Bug: v8:7552 Change-Id: I6bee9de640bae67e005fc174ea53875d79afc1ba Reviewed-on: https://chromium-review.googlesource.com/964281 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52037}
-
Georg Neis authored
This avoids a deopt loop. Bug: v8:7254 Change-Id: I3a676186bc52fd47b03f03c26cb07d9257993693 Reviewed-on: https://chromium-review.googlesource.com/968503Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:6792,v8:7549 Change-Id: I1d153dcff729ed4c0863ae339ac7915efff3c33c Reviewed-on: https://chromium-review.googlesource.com/968484Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: chromium:822593 Change-Id: Iaa76cbcb95f2262d927a9a031b85cddeebdd2a87 Reviewed-on: https://chromium-review.googlesource.com/968490Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:822593 Change-Id: I0c16b879b8dbfc8fba061a2fd42ee339aa6a853e Reviewed-on: https://chromium-review.googlesource.com/968485Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/95a628b..76da9f5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7b53f08..6c4a8ca Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/d343832..45571de TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I576dc15bcc3c4c69572a0ff244d055e804e9e4d8 Reviewed-on: https://chromium-review.googlesource.com/963764Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: chromium:820416 Change-Id: If995357345c2916ed5a3c8d1ad94f783cf6d633a Reviewed-on: https://chromium-review.googlesource.com/968249Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:7317 Change-Id: I6c88de63c4bdb31f873c18c450d26f60659171f2 Reviewed-on: https://chromium-review.googlesource.com/968621 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#52030}
-
Michael Achenbach authored
This reverts commit 40d66d8b. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/20910 Original change's description: > [build] Make separate snapshot for trusted variant > > This enables side-by-side snapshots with and without untrusted-code > mitigations. It'll be the default in all V8 stand-alone builds > with external startup data. Internal snapshots are not supported. > > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be > bundled with V8 on swarming and the correct file is loaded dependent > on the --untrusted-code-mitigations runtime flag. > > Likewise we embed two snapshots for builtins. > > Side-by-side snapshots won't be supported in Chromium. > > Bug: v8:7441 > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 > Reviewed-on: https://chromium-review.googlesource.com/960004 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52028} TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I5b18f7aff7c05a17842fc68d785bb617eeca4a41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7441 Reviewed-on: https://chromium-review.googlesource.com/968622Reviewed-by:
-
Michael Achenbach authored
This enables side-by-side snapshots with and without untrusted-code mitigations. It'll be the default in all V8 stand-alone builds with external startup data. Internal snapshots are not supported. The files snapshot_blob.bin and snapshot_blob_trusted.bin will be bundled with V8 on swarming and the correct file is loaded dependent on the --untrusted-code-mitigations runtime flag. Likewise we embed two snapshots for builtins. Side-by-side snapshots won't be supported in Chromium. Bug: v8:7441 Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 Reviewed-on: https://chromium-review.googlesource.com/960004 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Marja Hölttä authored
For serializer changes, see goo.gl/Kh2eop Previous version: https://chromium-review.googlesource.com/955593 BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I14c92874d04545eb6d04590bedb21dc402326401 Reviewed-on: https://chromium-review.googlesource.com/968245Reviewed-by:
-
Kim-Anh Tran authored
This CL adds back a check that previously had an early exit within the compilation loop, when compilation failed. Change-Id: Ie511010af22029671c8eb71aa2189d6429081b14 Reviewed-on: https://chromium-review.googlesource.com/968504Reviewed-by:
-
Clemens Hammacher authored
Instead of returning nullptr, just always call FatalProcessOutOfMemory when we cannot allocate more memory. In a follow-up CL, this should be extended to first try to run a GC and see if this freed enough memory. This CL is intentionally minimal in order to make it backmergable. The unittest for WasmCodeManager needs to be refactored into a parameterized test, such that each individual (parameterized) test can die with OOM without affecting other tests. R=mstarzinger@chromium.org Bug: chromium:822266 Change-Id: I1336aa05ed50124b77ffaa4435ec9bed70e15c18 Reviewed-on: https://chromium-review.googlesource.com/966501Reviewed-by:
-
Benedikt Meurer authored
This extends the Promise#then protector to also guard the intrinsic %ObjectPrototype%, making it usable for fast-path logic in the AsyncGeneratorResolve operation, where we can skip the "then" lookup on the iteratorResult in that case. We also add a corresponding fast- path to the ResolvePromise builtin itself, which avoids the second "then" lookup on the async iterator side. This reduces execution time of the fibonacci-async-es2017-native test from 186.9ms to 171.2ms, which corresponds to an improvement of 8.4% in this case. Bug: v8:7253 Change-Id: Ia09effc81a016703780d5c308f541e3d797ccabe Reviewed-on: https://chromium-review.googlesource.com/967203Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52024}
-
Clemens Hammacher authored
This reverts commit ed2605f0. Reason for revert: Test flakes. Original change's description: > [d8][wasm] Test wasm compilation completion > > d8 was recently changed to keep running until wasm compilation has > completed. This adds a message test to test that. > > R=ahaas@chromium.org > > Change-Id: I73af53b6df4ee5f9a6afd26cf2d71a269140465f > Reviewed-on: https://chromium-review.googlesource.com/966184 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52008} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: If1e015bd346a71df1da8effe92882c37a00d1e62 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/968521Reviewed-by:
-
Clemens Hammacher authored
This adds support for i64.shl, i64.shr_s, and i64.shr_u. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ibc1982064ff3c9f3a494b5fa329841a0d3bc7bce Reviewed-on: https://chromium-review.googlesource.com/964844 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This adds variants of tests already in our test-suite that exercise inlining fast-paths of Number.{isFinite,isInteger}. Bug: chromium:823151, chromium:823100 Change-Id: Ibf1192b1325fb4f015acea94053fd51a7a7811a9 Reviewed-on: https://chromium-review.googlesource.com/968361Reviewed-by: -
Yang Guo authored
I suspect that this is a premature optimization that we don't actually need. R=leszeks@chromium.org BUG: v8:6780 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icdec54cb749897164f287f5a69c7f76a540b45c4 Reviewed-on: https://chromium-review.googlesource.com/968261 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52020}
-
Georgia Kouveli authored
Remove IsBlockTerminator and introduce InstructionScheduler::AddTerminator in order to handle block terminator instructions. Instead of the kBlockTerminator flags, we now rely on Instruction::IsTrap(), Instruction::IsDeoptimizeCall() and explicitly denoting block terminators when adding them with InstructionScheduler::AddTerminator(). IsBlockTerminator incorrectly included deopts when they were not at the end of a block, which meant that an instruction with side effects could have been reordered with respect to a deopt as the deopt was not identified correctly. Since the snapshot does not contain deopts, this is not causing any problems at the moment (the scheduler is only enabled on the snapshot). Change-Id: I1c2dad748a9398a3355630d9a542f4ac89afaa42 Reviewed-on: https://chromium-review.googlesource.com/960501Reviewed-by:
-
Igor Sheludko authored
... to MaybeHandle<Map> and add TransitionsAccessor::FindTransitionToDataProperty() which will be used in follow-up CLs. Bug: v8:7310 Change-Id: I98cc4fe16dc1ef335885101aa457f27c90ecf1a4 Reviewed-on: https://chromium-review.googlesource.com/968222Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52018}
-
