• Michael Stanton's avatar
    Revert "[turbofan] Masking/poisoning in codegen (optimized code, mips & mips64)" · 11831378
    Michael Stanton authored
    This reverts commit 46a3c772.
    
    Reason for revert: This is actually not quite ready. What we need is a speculation free poisoning, and if we do another branch, then I think that won't happen.
    
    Original change's description:
    > [turbofan] Masking/poisoning in codegen (optimized code, mips & mips64)
    > 
    > This introduces masking of loads with speculation bit during code generation.
    > At the moment, this is done only under the
    > --branch-load-poisoning flag, and this CL enlarges the set of supported
    > platforms from {x64, arm, arm64} to {x64, arm, arm64, mips, mips64}.
    > 
    > Overview of changes:
    > - new register configuration configuration with one register reserved for
    >   the speculation poison/mask (kSpeculationPoisonRegister).
    > - in codegen, we introduce an update to the poison register at the starts
    >   of all successors of branches (and deopts) that are marked as safety
    >   branches (deopts).
    > - in memory optimizer, we lower all field and element loads to PoisonedLoads.
    > - poisoned loads are then masked in codegen with the poison register.
    >   * only integer loads are masked at the moment.
    > 
    > Bug: chromium:798964
    > Change-Id: I211395b8305ed0ad9288d6da48fa159fa970c827
    > Reviewed-on: https://chromium-review.googlesource.com/951382
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com>
    > Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com>
    > Cr-Commit-Position: refs/heads/master@{#52042}
    
    TBR=mvstanton@chromium.org,mstarzinger@chromium.org,ivica.bogosavljevic@mips.com
    
    Change-Id: Ief4d9ef56d918172f0b545d321a64b1ab5b46915
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:798964
    Reviewed-on: https://chromium-review.googlesource.com/969041Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52045}
    11831378
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...