- 19 Mar, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 40d66d8b. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/20910 Original change's description: > [build] Make separate snapshot for trusted variant > > This enables side-by-side snapshots with and without untrusted-code > mitigations. It'll be the default in all V8 stand-alone builds > with external startup data. Internal snapshots are not supported. > > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be > bundled with V8 on swarming and the correct file is loaded dependent > on the --untrusted-code-mitigations runtime flag. > > Likewise we embed two snapshots for builtins. > > Side-by-side snapshots won't be supported in Chromium. > > Bug: v8:7441 > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 > Reviewed-on: https://chromium-review.googlesource.com/960004 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52028} TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I5b18f7aff7c05a17842fc68d785bb617eeca4a41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7441 Reviewed-on: https://chromium-review.googlesource.com/968622Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52029}
-
Michael Achenbach authored
This enables side-by-side snapshots with and without untrusted-code mitigations. It'll be the default in all V8 stand-alone builds with external startup data. Internal snapshots are not supported. The files snapshot_blob.bin and snapshot_blob_trusted.bin will be bundled with V8 on swarming and the correct file is loaded dependent on the --untrusted-code-mitigations runtime flag. Likewise we embed two snapshots for builtins. Side-by-side snapshots won't be supported in Chromium. Bug: v8:7441 Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 Reviewed-on: https://chromium-review.googlesource.com/960004 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52028}
-
- 26 Feb, 2018 1 commit
-
-
Nico Weber authored
Snapshots don't yet work in 64-bit win/cross builds, so disable them until they do. No behavior change in builds that aren't 64-bit win/cross builds. Bug: chromium:803591 Change-Id: I7a04c7e01a58a95a2bfb78c7d2593c7c5c5041cf Reviewed-on: https://chromium-review.googlesource.com/936668Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#51554}
-
- 30 Jan, 2018 2 commits
-
-
sreten.kovacevic authored
Use config with these options when target is MIPS Change-Id: Ia93504f90aa42daef37f1cf1025cef9e9a584034 Reviewed-on: https://chromium-review.googlesource.com/890741Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Miran Karić <miran.karic@mips.com> Cr-Commit-Position: refs/heads/master@{#50954}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: Ib80df7aa269a8e9de7ad739f29883f61f0f0882c Reviewed-on: https://chromium-review.googlesource.com/892978Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50948}
-
- 05 Jan, 2018 1 commit
-
-
Yang Guo authored
Otherwise dynamic linking with dlopen, as is the case with Node.js addons, would not work. R=fhinkel@chromium.org Bug: v8:6105 Change-Id: I5a884afc003fdfdb9de7e9b0c736f1894ba0019a Reviewed-on: https://chromium-review.googlesource.com/850112 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50384}
-
- 27 Nov, 2017 1 commit
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:6105 Change-Id: I51d7d38897d1b20469304345d11228a8f78d3489 Reviewed-on: https://chromium-review.googlesource.com/788376 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49627}
-
- 19 Oct, 2017 1 commit
-
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I96cedba176cd3c35ca39bb2d4604956cded114fc Reviewed-on: https://chromium-review.googlesource.com/728023Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48740}
-
- 17 Oct, 2017 1 commit
-
-
Michael Achenbach authored
Bug: chromium:726584 Change-Id: I1d413b5568e533e4f517c0687716689dd15da70d Reviewed-on: https://chromium-review.googlesource.com/723459 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48645}
-
- 29 Sep, 2017 1 commit
-
-
Michael Achenbach authored
This is a reland of a0d2ffb6 This also relands: https://chromium-review.googlesource.com/c/v8/v8/+/684215 Original change's description: > [build] Switch windows default compilation to MSVS 2017 > > Bug: v8:6857 > Change-Id: Icab007681753c6f8143147ea8b2c1b06bf325d92 > Reviewed-on: https://chromium-review.googlesource.com/686900 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48196} TBR=sergiyb@chromium.org Bug: v8:6857 Change-Id: I7e8f560dbb4fcf4f937f8494fb01c802201cf236 Reviewed-on: https://chromium-review.googlesource.com/691834Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48221}
-
- 28 Sep, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit a0d2ffb6. Reason for revert: Breaks CI Original change's description: > [build] Switch windows default compilation to MSVS 2017 > > Bug: v8:6857 > Change-Id: Icab007681753c6f8143147ea8b2c1b06bf325d92 > Reviewed-on: https://chromium-review.googlesource.com/686900 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48196} TBR=machenbach@chromium.org,brucedawson@chromium.org,sergiyb@chromium.org Change-Id: I5c961c8c28c6213014cf61ad342984193a18498e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6857 Reviewed-on: https://chromium-review.googlesource.com/690034Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48199}
-
Michael Achenbach authored
Bug: v8:6857 Change-Id: Icab007681753c6f8143147ea8b2c1b06bf325d92 Reviewed-on: https://chromium-review.googlesource.com/686900 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48196}
-
- 09 Aug, 2017 1 commit
-
-
Mostyn Bramley-Moore authored
To speed up compilation times, jumbo allows files to be compiled together. This is a well known method ("unity builds") to both compile faster and create a poor man's "full program optimization". We are only interested in compile times. Background: https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md Note that jumbo builds are not enabled by default. To try this out, add use_jumbo_build=true to your GN args. BUG=chromium:746958 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieb9fdccb6c135e9806dbed91c09a29aa8b8bee11 Reviewed-on: https://chromium-review.googlesource.com/579090 Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47239}
-
- 29 Jun, 2017 1 commit
-
-
Michael Achenbach authored
Before this CL, cctest with component build will depend on the static v8 snapshot target and omit to dump the build configuration. Now we simply write the configuration when building any v8 executable. In pure library builds, we don't need the configuration, as it's used by the test framework to auto-detect testing options. Bug: v8:5918 Change-Id: Ie85ba82a2803542f0a0c88d6044167138fdd7d4f Reviewed-on: https://chromium-review.googlesource.com/554690Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46305}
-
- 27 Jun, 2017 1 commit
-
-
Michael Achenbach authored
This adds GN configs for using sanitizer coverage and refactors gcov configs. Now, both coverage kinds are behind the same gn argument v8_code_coverage. This also switches the bot to GN. Bug: chromium:645890,v8:5502 Change-Id: I3af606e0cad109dd790a121d0d92e53cf4e38f9a Reviewed-on: https://chromium-review.googlesource.com/549360Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46254}
-
- 26 Jun, 2017 1 commit
-
-
Michael Achenbach authored
This prepares switching the gcov coverage bot to GN. We skip instrumenting test executables explicitly in gn configs. In gyp, we did the same through an extra compiler wrapper script. NOTRY=true Bug: chromium:645890 Change-Id: I663fb479347063ae9228598d356bb654ca2a496c Reviewed-on: https://chromium-review.googlesource.com/548275 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46217}
-
- 23 Jun, 2017 1 commit
-
-
Michael Achenbach authored
Bug: chromium:662388 Change-Id: Ia50889a6f4313270f1aadd19cc3f91eb25989c96 Reviewed-on: https://chromium-review.googlesource.com/544882 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46181}
-
- 13 Jun, 2017 1 commit
-
-
Michael Achenbach authored
Bug: v8:6461 Change-Id: Iafabf2d53aa6492b78a9e5ae683f010453bb195d Reviewed-on: https://chromium-review.googlesource.com/533014Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45922}
-
- 05 Apr, 2017 1 commit
-
-
Michael Achenbach authored
Bug: chromium:645890 Change-Id: I9856712ca8694b3447a611c3555c42145f449b11 Reviewed-on: https://chromium-review.googlesource.com/464726Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#44417}
-
- 17 Mar, 2017 1 commit
-
-
jgruber authored
Default to the chromium-internal build config (instead of the more permissive no_chromium_code config). BUG=v8:5878 Review-Url: https://codereview.chromium.org/2758563002 Cr-Commit-Position: refs/heads/master@{#43909}
-
- 13 Feb, 2017 1 commit
-
-
Jochen Eisinger authored
Windows won't create empty .lib files, and will subsequently fail to find the library other rules expect R=machenbach@chromium.org BUG= Change-Id: I8b848834a6957c2164f0eafc853587d39ccb6ca9 Reviewed-on: https://chromium-review.googlesource.com/440244Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43141}
-
- 02 Feb, 2017 1 commit
-
-
machenbach authored
This adds optional multi-architecture builds, allowing to compile x86 and x64 in one build. The correctness fuzzer can be configured to compare the two executables, e.g. to compare x86 to x64 run the launcher with: --second-d8=clang_x86/d8 in an x64 build. Configuring the executable's architecture is now simplified and inferred from the gn build configuration. Building for clusterfuzz has now a new canonical target that can be used by the infrastructure (defaults to d8). The clusterfuzz release builder is now defined to compile multi-arch builds, which will have an effect as soon as the infrastructure refers to the new clusterfuzz target. BUG=chromium:673246 NOTRY=true TBR=mstarzinger,jarin Review-Url: https://codereview.chromium.org/2649133010 Cr-Commit-Position: refs/heads/master@{#42884}
-
- 01 Feb, 2017 1 commit
-
-
Michael Achenbach authored
Reland of: https://codereview.chromium.org/2592663004/ BUG=chromium:656900 TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org Change-Id: I89b5c6b7a4214e25b4fea6d2ee33cd31b47320cc Reviewed-on: https://chromium-review.googlesource.com/435319Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#42846}
-
- 31 Jan, 2017 2 commits
-
-
machenbach authored
Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of https://codereview.chromium.org/2592663004/ ) Reason for revert: Breaks mac asan. Need to keep leak check off on mac. Original issue's description: > [test] Add back lsan leak detection > > BUG=chromium:662388 > TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org > > Review-Url: https://codereview.chromium.org/2592663004 > Cr-Commit-Position: refs/heads/master@{#42815} > Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f TBR=yangguo@chromium.org,glider@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2667993002 Cr-Commit-Position: refs/heads/master@{#42816}
-
machenbach authored
BUG=chromium:662388 TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2592663004 Cr-Commit-Position: refs/heads/master@{#42815}
-
- 26 Jan, 2017 1 commit
-
-
brettw authored
Chrome now uses the default_args system for specifying its own definitions of these variables so the separate file in build_overrides is no longer necessary. BUG=684096 Review-Url: https://codereview.chromium.org/2652263003 Cr-Commit-Position: refs/heads/master@{#42712}
-
- 25 Jan, 2017 1 commit
-
-
brettw authored
We're converting the build_overrides system to the new default_args list of overrides that can be listed in the toplevel .gn file. This will allow args to be set on a per-repo basis. This change conditionally adds the variables currently defined in build_overrides/v8.gni to build args. This allows V8's build to be used in both the new and old systems. Once all Chrome and pdfium have been updated, v8's build overrides and the conditional checks around the new args can be removed. BUG=684096 Review-Url: https://codereview.chromium.org/2654663003 Cr-Commit-Position: refs/heads/master@{#42639}
-
- 10 Jan, 2017 1 commit
-
-
machenbach authored
This adds the correctness fuzzer harness files to the output directory guarded by a gn arg. The switch will be turned on on the builder uploading builds to clusterfuzz. BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2623843002 Cr-Commit-Position: refs/heads/master@{#42166}
-
- 01 Dec, 2016 3 commits
-
-
machenbach authored
BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Review-Url: https://codereview.chromium.org/2533813002 Cr-Original-Commit-Position: refs/heads/master@{#41407} Cr-Commit-Position: refs/heads/master@{#41410}
-
machenbach authored
Revert of [build] Use MSVS 2015 by default. (patchset #5 id:80001 of https://codereview.chromium.org/2533813002/ ) Reason for revert: Breaks CI dbg builder: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/13817 Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac > Cr-Commit-Position: refs/heads/master@{#41407} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Review-Url: https://codereview.chromium.org/2538493007 Cr-Commit-Position: refs/heads/master@{#41409}
-
machenbach authored
BUG=chromium:603131 LOG=y Review-Url: https://codereview.chromium.org/2533813002 Cr-Commit-Position: refs/heads/master@{#41407}
-
- 28 Nov, 2016 1 commit
-
-
machenbach authored
BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2373783002 Cr-Commit-Position: refs/heads/master@{#41304}
-
- 21 Nov, 2016 1 commit
-
-
thestig authored
Instead of directly using v8_enable_inspector_override from build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector variable based on v8_enable_inspector_override and use that everywhere. This is the more common pattern seen in over projects, and reduces the need to include //build_overrides/v8.gni in many files. Review-Url: https://codereview.chromium.org/2520683002 Cr-Commit-Position: refs/heads/master@{#41156}
-
- 14 Nov, 2016 1 commit
-
-
Miran.Karic authored
In component build, unittests did not link with icu libraries, which caused errors. By adding icu libraries to dependencies unittests links correctly. BUG= TEST=unittests/* Review-Url: https://codereview.chromium.org/2479863002 Cr-Commit-Position: refs/heads/master@{#40955}
-
- 12 Oct, 2016 3 commits
-
-
kozyatinskiy authored
This location is used at least in Chromium. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2405303002 Cr-Commit-Position: refs/heads/master@{#40225}
-
machenbach authored
BUG=v8:5412 Review-Url: https://codereview.chromium.org/2409133002 Cr-Commit-Position: refs/heads/master@{#40208}
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2393863002 Cr-Commit-Position: refs/heads/master@{#40194}
-
- 28 Jul, 2016 1 commit
-
-
machenbach authored
The isolate_driver automatically adds referenced shared libraries. They don't need to be listed explicitly. The hard-coded location blocks the GN transition as the library location is different in GYP and GN. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2190543003 Cr-Commit-Position: refs/heads/master@{#38113}
-
- 27 Jul, 2016 2 commits
-
-
hablich authored
Revert of [gn] Don't use PIE for host executables (patchset #2 id:20001 of https://codereview.chromium.org/2179303003/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/2182043004/ Original issue's description: > [gn] Don't use PIE for host executables > > Using PIE switches on ASLR. With mksnapshot, this can lead > to non-deterministic snapshots. > > BUG=v8:5233 > > Committed: https://crrev.com/4ca39b53245619d94a80a93939613774e68e4649 > Cr-Commit-Position: refs/heads/master@{#38084} TBR=jochen@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5233 Review-Url: https://codereview.chromium.org/2187613003 Cr-Commit-Position: refs/heads/master@{#38092}
-
machenbach authored
Using PIE switches on ASLR. With mksnapshot, this can lead to non-deterministic snapshots. BUG=v8:5233 Review-Url: https://codereview.chromium.org/2179303003 Cr-Commit-Position: refs/heads/master@{#38084}
-