- 07 Feb, 2019 1 commit
-
-
Ulan Degenbaev authored
The new scheduling reduces the main thread marking performed in tasks and on allocation. It is based on two counters: - bytes_marked, - scheduled_bytes_to_mark. The bytes_marked accounts marking done both the main thread and the concurrent threads. The scheduled_bytes_to_mark increases based on allocated bytes and also based on time passed since the start of marking. The main thread steps are allowed to mark the minimal amount if bytes_marked is greater than scheduled_bytes_to_mark. This also changes tasks posted for marking. Before only normal tasks were posted. Now delayed tasks are posted if the marker is ahead of schedule. Bug: 926189 Change-Id: I5bc9c33a5ecfc9f8d09f78d08ae277d16a2779ca Reviewed-on: https://chromium-review.googlesource.com/c/1443056 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59433}
-
- 26 Nov, 2018 1 commit
-
-
Marja Hölttä authored
- Remove heap-inl.h includes from places where it looked unnecessary. (This is a non-scientific approach, because it's probably pulled in indirectly anyway.) - Annotate places which include heap-inl.h because they need heap/ internals. - ACCESSORS legitimately needs heap-inl.h because of Heap::FromWritableHeapObject. - Add includes to heap/heap-write-barrier(-inl).h - A bunch of IWYU fixes discovered when working on this CL (includes which were missing because heap-inl.h pulls them in indirectly). BUG=v8:7490,v8:8238,v8:8499 Change-Id: I00f9a74d430f13d7c080dca77a92b03bcca7ef96 Reviewed-on: https://chromium-review.googlesource.com/c/1349241Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57814}
-
- 29 May, 2018 1 commit
-
-
Andreas Haas authored
This CL switches to the new taskrunner API in the MemoryReducer. We want to remove the old API eventually so that there is only one API for task posting. R=ulan@chromium.org CC=gab@chromium.org Change-Id: I1dd16e42dc0fca013a97c76dfce9c6479b97521b Reviewed-on: https://chromium-review.googlesource.com/1061531Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53422}
-
- 08 May, 2018 1 commit
-
-
Dan Elphick authored
Removes lots of parameters that are never used (found using -Wunused-parameter). Also wires up the pretenure parameter for Factory::NewFrameArray so it's actually used. Change-Id: I486e22ac0683afb84bba6a286947674254f93832 Reviewed-on: https://chromium-review.googlesource.com/1041687Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53077}
-
- 15 Mar, 2018 1 commit
-
-
Hannes Payer authored
Change-Id: I57da95525e09820ed1a1697cc4eb1e39ecb7c7cc Reviewed-on: https://chromium-review.googlesource.com/964282Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51961}
-
- 12 Mar, 2018 1 commit
-
-
Andreas Haas authored
Bug: chromium:810739 Change-Id: I7658e01394b03ade1acedb37b1e56004dc7660fb Reviewed-on: https://chromium-review.googlesource.com/959004Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51882}
-
- 12 Oct, 2017 1 commit
-
-
Ulan Degenbaev authored
Bug: Change-Id: I9e4b2e1157f36dacb24f7a0d0c43d31c84de8488 Reviewed-on: https://chromium-review.googlesource.com/712397Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48484}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=ulan@chromium.org Bug: v8:6837 Change-Id: I8d900f3c703dea6ee3bcc225a1d2754e91666b9d Reviewed-on: https://chromium-review.googlesource.com/671047 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48136}
-
- 22 May, 2017 1 commit
-
-
Wiktor Garbacz authored
Change-Id: I20ed35a7fb5104a9cc66bb54fa8966589c43d7f9 Reviewed-on: https://chromium-review.googlesource.com/507287Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45458}
-
- 05 May, 2017 1 commit
-
-
hpayer authored
BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2863943002 Cr-Commit-Position: refs/heads/master@{#45128}
-
- 18 Nov, 2016 1 commit
-
-
ulan authored
This reverts commit 3c96c5e2. The CL was reverted to see its impact on UMA memory counters. There was no impact, so we can safely reland the CL. BUG= Review-Url: https://codereview.chromium.org/2507293004 Cr-Commit-Position: refs/heads/master@{#41109}
-
- 08 Nov, 2016 1 commit
-
-
ulan authored
This is an experiment to check whether the heuristics is still useful. BUG= Review-Url: https://codereview.chromium.org/2482163002 Cr-Commit-Position: refs/heads/master@{#40833}
-
- 04 Nov, 2016 1 commit
-
-
mlippautz authored
R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2473073002 Cr-Commit-Position: refs/heads/master@{#40756}
-
- 03 Nov, 2016 1 commit
-
-
ulan authored
Revert of [heap] Add a guard for restarting the memory reducer after mark-compact. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2433933005/ ) Reason for revert: Speculative revert to see impact on crbug.com/659531 Original issue's description: > [heap] Add a guard for restarting the memory reducer after mark-compact. > > Currently it is possible to get into a cycle of > mark-compact -> memory reducer -> mark-compact -> memory reducer ... > where the memory reducer does not free memory. > > This patch ensures that the memory reducer restarts only if the > committed memory increased by sufficient amount after the last run. > > BUG= TBR=hpayer@chromium.org,davidroutier17@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2472053003 Cr-Commit-Position: refs/heads/master@{#40737}
-
- 20 Oct, 2016 1 commit
-
-
ulan authored
Currently it is possible to get into a cycle of mark-compact -> memory reducer -> mark-compact -> memory reducer ... where the memory reducer does not free memory. This patch ensures that the memory reducer restarts only if the committed memory increased by sufficient amount after the last run. BUG= Review-Url: https://chromiumcodereview.appspot.com/2433933005 Cr-Commit-Position: refs/heads/master@{#40457}
-
- 12 Sep, 2016 1 commit
-
-
ulan authored
This patch changes incremental marking work scheduling from combination of idle/delayed tasks to ordinary short-running tasks and moves more marking work from V8.Execute to tasks by accounting how much bytes were marked in tasks. BUG=chromium:616434 LOG=NO Review-Url: https://codereview.chromium.org/2321553002 Cr-Commit-Position: refs/heads/master@{#39348}
-
- 07 Sep, 2016 1 commit
-
-
ulan authored
Now callers of Heap::CollectGarbage* functions need to specify the reason as an enum value instead of a string. Subsequent CL will add stats counter for GC reason. BUG= Review-Url: https://codereview.chromium.org/2310143002 Cr-Commit-Position: refs/heads/master@{#39239}
-
- 06 Sep, 2016 1 commit
-
-
ulan authored
This patch - extracts the logic of keeping track of allocated bytes from the actual incremental marking step. - replaces OldSpaceStep with a check for incremental marking start. - removes the force_marking parameter of AdvanceIncrementalMarking. BUG=chromium:616434 LOG=NO Review-Url: https://codereview.chromium.org/2304123003 Cr-Commit-Position: refs/heads/master@{#39213}
-
- 04 Apr, 2016 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1844293005 Cr-Commit-Position: refs/heads/master@{#35238}
-
- 22 Feb, 2016 1 commit
-
-
ulan authored
BUG=chromium:587574 LOG=NO Review URL: https://codereview.chromium.org/1705183003 Cr-Commit-Position: refs/heads/master@{#34188}
-
- 12 Feb, 2016 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1693813002 Cr-Commit-Position: refs/heads/master@{#33940}
-
- 25 Nov, 2015 1 commit
-
-
jochen authored
Moving Blink from hidden values to private symbols almost doubled the rate of API calls, as the private symbols API increases the call-depth scope while the hidden values one didn't. I manually checked that this fixes the regression on the long running gmail benchmark but doesn't add new memory reducer GCs on the infinite scrolling benchmark BUG=chromium:561325 R=ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/1472193003 Cr-Commit-Position: refs/heads/master@{#32279}
-
- 06 Nov, 2015 1 commit
-
-
ulan authored
if that is responsible for memory regression in UMA. Related CLs: crrev.com/1420363004, crrev.com/1423453003 TBR=hpayer@chromium.org BUG=chromium:552305 LOG=NO Review URL: https://codereview.chromium.org/1420283021 Cr-Commit-Position: refs/heads/master@{#31853}
-
- 29 Oct, 2015 1 commit
-
-
ulan authored
for starting major GC in the memory reducer. BUG= Review URL: https://codereview.chromium.org/1414483004 Cr-Commit-Position: refs/heads/master@{#31655}
-
- 27 Oct, 2015 1 commit
-
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1420363004 Cr-Commit-Position: refs/heads/master@{#31600}
-
- 22 Oct, 2015 1 commit
-
-
ulan authored
Incremental GC now finish quickly in background tabs too because they do not rely on idle notifications. BUG= Review URL: https://codereview.chromium.org/1423453003 Cr-Commit-Position: refs/heads/master@{#31461}
-
- 05 Oct, 2015 1 commit
-
-
ulan authored
when the application is not idle. BUG= Review URL: https://codereview.chromium.org/1369333005 Cr-Commit-Position: refs/heads/master@{#31100}
-
- 02 Oct, 2015 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1375853005 Cr-Commit-Position: refs/heads/master@{#31082}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 29 Sep, 2015 1 commit
-
-
mstarzinger authored
This prevents the internal incremental-marking.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1374203002 Cr-Commit-Position: refs/heads/master@{#31010}
-
- 03 Sep, 2015 1 commit
-
-
ulan authored
This reverts commit b06a6a89. BUG=chromium:519319,chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1311993003 Cr-Commit-Position: refs/heads/master@{#30569}
-
- 01 Sep, 2015 1 commit
-
-
mstarzinger authored
This CL us a pure refactoring that makes an empty compilation unit including just "isolate.h" or "contexts.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1322883002 Cr-Commit-Position: refs/heads/master@{#30500}
-
- 31 Aug, 2015 2 commits
-
-
hablich authored
Revert of [heap] More flag cleanup. (patchset #8 id:140001 of https://codereview.chromium.org/1314863003/ ) Reason for revert: Breaks http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20-%202/builds/2372 Original issue's description: > [heap] GC flag cleanup/restructuring. > > * GC's flags are now proper flags and not int. > * Callback flags are not threaded through but only set once like gc flags > * Callers of methods that trigger GCs need to pass a reason when not using > the default parameters. > > Furthermore, each GC invocation can be passed the GC and GCCallback flags. We > usually override the currently set flags upon finishing a GC cylce, but are able > to restore the previously set if desired. This is useful for explicitely > triggered scavenges or external requests that interrupt the current behaviour. > > BUG= > > Committed: https://crrev.com/f4f3b431b9ce0778d926acf03c0d36dae5c0cba4 > Cr-Commit-Position: refs/heads/master@{#30457} TBR=hpayer@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1303393004 Cr-Commit-Position: refs/heads/master@{#30463}
-
mlippautz authored
* GC's flags are now proper flags and not int. * Callback flags are not threaded through but only set once like gc flags * Callers of methods that trigger GCs need to pass a reason when not using the default parameters. Furthermore, each GC invocation can be passed the GC and GCCallback flags. We usually override the currently set flags upon finishing a GC cylce, but are able to restore the previously set if desired. This is useful for explicitely triggered scavenges or external requests that interrupt the current behaviour. BUG= Review URL: https://codereview.chromium.org/1314863003 Cr-Commit-Position: refs/heads/master@{#30457}
-
- 24 Aug, 2015 1 commit
-
-
mlippautz authored
This reverts commit 1345f811. BUG= Review URL: https://codereview.chromium.org/1303333005 Cr-Commit-Position: refs/heads/master@{#30329}
-
- 20 Aug, 2015 2 commits
-
-
mstarzinger authored
This prevents leakage of the gc-tracer.h declarations inside of the heap and prevents it from being exposed to the world. Protects private state from being inadvertently mocked with. R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1294763004 Cr-Commit-Position: refs/heads/master@{#30276}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 07 Aug, 2015 2 commits
-
-
ulan authored
even if there are no idle notifications. BUG=chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1274633003 Cr-Commit-Position: refs/heads/master@{#30062}
-
ulan authored
Otherwise, if there is no GC and no idle notification, memory reducer will use old allocation rate. BUG=chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1280623002 Cr-Commit-Position: refs/heads/master@{#30059}
-
- 04 Aug, 2015 1 commit
-
-
ulan authored
BUG=chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1263373002 Cr-Commit-Position: refs/heads/master@{#29996}
-