- 22 Feb, 2019 2 commits
-
-
Jon Kunkee authored
When Assembler::nop is in the header, it is considered an inline function. With GN arg is_component_build=true, the V8_EXPORT_PRIVATE mark on the class causes it to be exported every time the header is included. This, in turn, produces a reference to Register::XRegFromCode. Register::XRegFromCode is only ever defined as an inlined function, so that reference is never fulfilled. Clang can avoid this using the /Fc:dllexportInlines- flag to suppress the export of Assembler::nop and so avoid generating the reference to Register::XRegFromCode. MSVC does not support this flag, so this change suppresses the export by moving Assembler::nop's definition to the .cc file. This also allows it to use the inline definition of Register::XRegFromCode. Bug: v8:8870 Change-Id: I1cd33195677256c9dd06c7047fe84e1b912d3151 Reviewed-on: https://chromium-review.googlesource.com/c/1478216Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59785}
-
Erik Chen authored
Recent changes to luci/client-py contain functionality improvement/fixes to swarming.py. This is needed by v8 recipes to dispatch swarming tasks. Bug: chromium:934482 Change-Id: Icdbf213918f10d5bc67d6ce078179e95888281e5 Reviewed-on: https://chromium-review.googlesource.com/c/1480920Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#59784}
-
- 21 Feb, 2019 36 commits
-
-
Francis McCabe authored
Bug: v8:7431 Change-Id: I80ec116d21d67868747093887ca4660675dab8e4 Reviewed-on: https://chromium-review.googlesource.com/c/1473795Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#59783}
-
Sathya Gunasekaran authored
This reverts commit f1b21a10. Reason for revert: breaks https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24373 Original change's description: > [Intl] Ship Intl.Locale > > Bug: v8:7684 > Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a > Reviewed-on: https://chromium-review.googlesource.com/c/1478220 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59780} TBR=adamk@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: I7ae570d3cd0dd62f2b1a37c43b7f8b9ca51d7a5b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7684 Reviewed-on: https://chromium-review.googlesource.com/c/1481901Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59782}
-
Tobias Tebbi authored
This is a reland of c3148664 Original change's description: > [csa] disable selected bounds checks for remaining regressions > > Bug: chromium:932919 > TBR: jarin@chromium.org > Change-Id: Id1125dcd2978f790af4cf00125bcbb94741d0bf8 > Reviewed-on: https://chromium-review.googlesource.com/c/1480387 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59773} Bug: chromium:932919 Change-Id: Ifb115ded2ff272abae4fba557ef669eee8e3c687 TBR: tebbi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1481746Reviewed-by:
-
Frank Tang authored
Bug: v8:7684 Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a Reviewed-on: https://chromium-review.googlesource.com/c/1478220Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5368 Change-Id: I0d33076f8e9d31e07535b28f783e33cd24b946ad Reviewed-on: https://chromium-review.googlesource.com/c/1481024Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Tom Tan authored
Windows ARM64 does cross build for V8 and runs snapshot tool on build host under simulator. Simulator is built with LLP64 data model so 0xFFFFL is 32-bit long by default. It causes problem for the expression "0xFFFFL << shift" when shift is 32, which actually does nothing on x64 because 0xFFFFL is only 32-bit. The issue happens for instruction "movk rd, NUM lsl 32" which is simulated in Simulator::VisitMoveWideImmediate. "0xFFFL << shift" acts as mask to clear bits 32-47 of the orignal value in rd. Under LLP64, the mask happens unexpectedly to the lowest 16 bits of rd register and corrupts the result of rd. Specify 0xFFFFL as 64 bit as 0xFFFFLL fixes this problem. Bug: chromium:893460 Change-Id: Ibd911ce595e83637432a3e1f79a9bf28fcbe09f6 Reviewed-on: https://chromium-review.googlesource.com/c/1475330 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59778}
-
Sathya Gunasekaran authored
This reverts commit c3148664. Reason for revert: speculative revert for MSAN failure https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/25398 Original change's description: > [csa] disable selected bounds checks for remaining regressions > > Bug: chromium:932919 > TBR: jarin@chromium.org > Change-Id: Id1125dcd2978f790af4cf00125bcbb94741d0bf8 > Reviewed-on: https://chromium-review.googlesource.com/c/1480387 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59773} TBR=jarin@chromium.org,jgruber@chromium.org,leszeks@chromium.org,tebbi@chromium.org Change-Id: Ib6cb825375725773db73f40ad3b65e084645b568 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:932919 Reviewed-on: https://chromium-review.googlesource.com/c/1480914Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit 6f763280. Reason for revert: speculative revert for MSAN failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/25398 Original change's description: > [cleanup] Cleanup handling of padding field in Map > > Bug: v8:8834 > Change-Id: Iae9cbcccb8747298c5680ac1e865efebee85acec > Reviewed-on: https://chromium-review.googlesource.com/c/1480385 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59774} TBR=ulan@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: Icf42e4566382c8539c8d7fb709a91bf0c6353858 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/1481025Reviewed-by:
-
Jaroslav Sevcik authored
This should recover the regression from constant field tracking in Speedometer/angular. Bug: chromium:930680 Change-Id: I9ccbcbdaf11556596ed5df5c08829b7ae329cab7 Reviewed-on: https://chromium-review.googlesource.com/c/1480383Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59775}
-
Igor Sheludko authored
Bug: v8:8834 Change-Id: Iae9cbcccb8747298c5680ac1e865efebee85acec Reviewed-on: https://chromium-review.googlesource.com/c/1480385Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#59774}
-
Tobias Tebbi authored
Bug: chromium:932919 TBR: jarin@chromium.org Change-Id: Id1125dcd2978f790af4cf00125bcbb94741d0bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1480387 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59773}
-
Igor Sheludko authored
With 32-bit kTaggedSize string data address may not be kSystemPointerSize aligned. Bug: v8:7703 Change-Id: I243e6844bed62d96f8b07328fffe23e83512e8e5 Reviewed-on: https://chromium-review.googlesource.com/c/1481217Reviewed-by:
-
Stephan Herhut authored
This adds special prining for the different spill kinds. Change-Id: Ib03da8e46b98c62b83c686ee90ae24c9052ddb39 Reviewed-on: https://chromium-review.googlesource.com/c/1477743 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59771}
-
Igor Sheludko authored
With 32-bit kTaggedSize small strings may be not externalizable. Bug: v8:7703 Change-Id: I34002568214742dadb2358fca97dfb4b92a5342a Reviewed-on: https://chromium-review.googlesource.com/c/1480373Reviewed-by:
-
Nico Weber authored
It's only used in tests, and for some reason v8 refers to a macro defined in src.git, so I need to remove this in v8 first before I can remove it in Chromium. Bug: chromium:934255 Change-Id: I31ea32aa43cf7a5f518def7b91dce99dcb268709 Reviewed-on: https://chromium-review.googlesource.com/c/1480911Reviewed-by:
-
Leszek Swirski authored
This reverts commit 8a1e927f. Reason for revert: Seems to break chromium build (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20pointer%20compression/1987) Original change's description: > Update MicrotaskQueue ring buffer for pointer compression > > This updates MicrotaskQueue to use pointer-compression style object > reference. > > Bug: v8:8124 > Change-Id: I7bef92a8760609f3045d2025b145b9a0ec880424 > Reviewed-on: https://chromium-review.googlesource.com/c/1478320 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59762} TBR=bmeurer@chromium.org,tzik@chromium.org Change-Id: Id09e98271e3f301985a4312ecec27b2c292f9644 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8124 Reviewed-on: https://chromium-review.googlesource.com/c/1480381Reviewed-by:
-
Farazmand authored
Port adb7e37b Original Commit Message: In the Crankshaft days we (mis)used the Representation to also express the various internal representations that the compiler understands. But with TurboFan we now have proper MachineRepresentation and MachineType, which do that independently. So there's no need to have this in the Representation class anymore, and instead the Representation class only needs to deal with the field representations. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie3c8062786d5fd42872e22be01cea45d719ea0a4 Reviewed-on: https://chromium-review.googlesource.com/c/1479972Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#59767}
-
Michael Starzinger authored
This makes the asm.js validator reject source with trailing expressions after the module exporting return statement. Most of the time trailing statements would not affect semantics, since they are unreachable. In some cases we might hide an expected ReferenceError tough. R=leszeks@chromium.org TEST=mjsunit/regress/regress-crbug-934138 BUG=chromium:934138 Change-Id: I790366204f5e9c943715a065b5229f2442e2c86e Reviewed-on: https://chromium-review.googlesource.com/c/1481216 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7777 Change-Id: I781ac51ba740655c644e19388c6cadad7267b18c Reviewed-on: https://chromium-review.googlesource.com/c/1478209 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59765}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I06d4195597f0ac8ee771da49c9a402be48e91f15 Reviewed-on: https://chromium-review.googlesource.com/c/1480377Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8834 Change-Id: I5730e550f1b19e651d1fa7cb8b5694c9d839ff84 Reviewed-on: https://chromium-review.googlesource.com/c/1480374Reviewed-by:
-
tzik authored
This updates MicrotaskQueue to use pointer-compression style object reference. Bug: v8:8124 Change-Id: I7bef92a8760609f3045d2025b145b9a0ec880424 Reviewed-on: https://chromium-review.googlesource.com/c/1478320 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59762}
-
Jakob Gruber authored
Bug: v8:7777 Change-Id: I0227ee37018e718014b8a8fbdba93e82a2209ae0 Reviewed-on: https://chromium-review.googlesource.com/c/1480372Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59761}
-
Toon Verwaest authored
- Remove unused IsSpecialization - Simplify IsCompatibleForLoad Change-Id: I555adf9869322b600072c5006ff71f6b846d4241 Reviewed-on: https://chromium-review.googlesource.com/c/1479958Reviewed-by:
-
Stephan Herhut authored
This change adds two spilling modes: SpillAtDefinition and SpillDeferred. The former is the known spilling mode where we spill at definition. The latter spills only in deferred code regions. This is implemented based on control flow aware allocation and its invariants. The effect is mostly the same as splintering with the exception of forward looking allocation decisions still being impacted by register constraints in deferred code. Change-Id: Ia708e5765dd095196a8127deb2d8bec950d37e04 Reviewed-on: https://chromium-review.googlesource.com/c/1437118Reviewed-by:
-
Ulan Degenbaev authored
This merges the "do-nothing" case with the "done" case as the former is no longer useful. This also fixes a bug where the idle time handler would not make progress by always returning "do-nothing". Change-Id: Ibdd3189e4fd35acc5405aa82a13ea8ee2fd74cc6 Reviewed-on: https://chromium-review.googlesource.com/c/1478695 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59758}
-
Ulan Degenbaev authored
This is a reland of 49de5875 Original change's description: > [heap] Perform more embedder tracing in incremental marking step > > This should fix GC latency regressions introduced in 4c6598. > > Bug: chromium:926189, chromium:930844, chromium:930693,chromium:931629 > Change-Id: I81c91829badbeea82d6e44670d07794632869424 > Reviewed-on: https://chromium-review.googlesource.com/c/1477216 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59668} Bug: chromium:926189, chromium:930844, chromium:930693, chromium:931629 Change-Id: Ifa77647668bb052bb102b643182baf406cb9e059 Reviewed-on: https://chromium-review.googlesource.com/c/1477279Reviewed-by:
-
Sven Sauleau authored
Change-Id: Ib45690bb03b9c76502afed89a71e1dc9a545893b Reviewed-on: https://chromium-review.googlesource.com/c/1481213 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
Mythri authored
This cl moves the valid feeback vector checks to the builtins and uses fast paths runtime when possible even whithout a valid feedback vector. For LoadNamedProperty it calls LoadIC_Uninitialized which does not need any type feedback and for LoadKeyedProperty it follows the megamorphic path but doesnot use the stub cache. Bug: v8:8293 Change-Id: I6ef9653e3f43c15cb882cbf82c3c2f63fb705a81 Reviewed-on: https://chromium-review.googlesource.com/c/1475393Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=santa Change-Id: I0ff05d47526d7e648c026daecb63ad80b668d9d8 Reviewed-on: https://chromium-review.googlesource.com/c/1481215Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59754}
-
Jakob Gruber authored
The DCHECK verified capacity just before the call to EnsureCapacity() (which extends capacity if needed). This DCHECK can just be removed since FixedArray::set() already checks the given index is in-bounds. Drive-by: Remove similar duplicate DCHECKs in FixedArrayBuilder. Bug: chromium:933776 Change-Id: I9f058548063a170ea6dce112a3877792887efcca Reviewed-on: https://chromium-review.googlesource.com/c/1479955Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59753}
-
Peter Marshall authored
The default TracingController (used by d8 and Node) has some concurrency issues. The new test flushes these out, when a second thread logs trace events while the main thread calls StopTracing(). - Use an acquire load in UpdateCategoryGroupEnabledFlags() because this was racing with GetCategoryGroupEnabled() where a new category is added in the slow path. g_category_groups is append-only, but reads/writes to g_category_index need to be correctly ordered so that new categories are added and only then is the change to the index visible. The relaxed load ignored this and caused unsynchronized read/write. - Use a relaxed load in ~ScopedTracer() to access category_group_enabled as this previously used a non-atomic operation which caused a race with UpdateCategoryGroupEnabledFlag() which does a relaxed store. - Replace TracingController::mode_ with an atomic bool as read/writes to mode_ were not synchronized and caused TSAN errors. It only has two states and it doesn't seem like we will extend this so just convert it to bool. - Take the lock around calling trace_object->Initialize in AddTraceEvent(), and around trace_buffer_->Flush() in StopTracing(). These two raced previously as the underlying TraceBufferRingBuffer passes out pointers to TraceObjects in a synchronized way, but the caller (AddTraceEvent) then writes into the object without synchronization. This leads to races when Flush() is called, at which time TraceBufferRingBuffer assumes that all the pointers it handed out are to valid, initialized TraceObjects - which is not true because AddTraceEvent may still be calling Initialize on them. This could be the cause of issues in Node.js where the last line of tracing/logging sometimes gets cut off. This is kind of a band-aid solution - access to the TraceObjects handed out by the ring buffer really needs proper synchronization which at this point would require redesign. It's quite likely we will replace this with Perfetto in the near future so not much point investing in this code right now. - Enable TracingCpuProfiler test which was flaky due to these bugs. Bug: v8:8821 Change-Id: I141296800c6906ac0e7f3f21dd16d861b07dae62 Reviewed-on: https://chromium-review.googlesource.com/c/1477283 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#59752}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I92657d3aae6ba34b2aeeb6f000962707577811b6 Reviewed-on: https://chromium-review.googlesource.com/c/1478696Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59751}
-
Benedikt Meurer authored
In the Crankshaft days we (mis)used the Representation to also express the various internal representations that the compiler understands. But with TurboFan we now have proper MachineRepresentation and MachineType, which do that independently. So there's no need to have this in the Representation class anymore, and instead the Representation class only needs to deal with the field representations. Bug: v8:8749, v8:8834, v8:8865 Change-Id: I34ea9558b5fdf20d6c7939b52762eaffd4316b06 Reviewed-on: https://chromium-review.googlesource.com/c/1479954 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:933331 Change-Id: I598a32b1efe2d4b7e8278ddf84140c72f787afa8 Reviewed-on: https://chromium-review.googlesource.com/c/1475496Reviewed-by:
-
Z Duong Nguyen-Huu authored
This is a reland of 1fdf6405 Original change's description: > Make format torque tools work on win > > Reformatting Torque file is required to upload a CL > but it can only work on POSIX > > Change-Id: I51283e3f6b29abf492be7efb5b8f10454d09fb37 > Reviewed-on: https://chromium-review.googlesource.com/c/1475919 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59719} Change-Id: I09a19a9989091205eb413fd60b2e8bec289092fd Reviewed-on: https://chromium-review.googlesource.com/c/1479530 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
- 20 Feb, 2019 2 commits
-
-
Matt Gardner authored
Change-Id: I808ce4d0089accd3f6afaeab98bd6237e169f793 Reviewed-on: https://chromium-review.googlesource.com/c/1475915 Commit-Queue: Matt Gardner <magardn@microsoft.com> Reviewed-by:
-
Sathya Gunasekaran authored
Throw error when accessing private field on super. Bug: v8:8872 Change-Id: Iad383890fafbdccdd6b6b75a8f9eb32c9d6f5044 Reviewed-on: https://chromium-review.googlesource.com/c/1478219Reviewed-by:
-
