- 09 Feb, 2018 20 commits
-
-
Ivica Bogosavljevic authored
Fix 8238562b Requirement that the address is stored kJavaScriptCallCodeStartRegister caused failures on MIPSR6, because of R6 optimization which doesn't load the address in kJavaScriptCallCodeStartRegister. Change-Id: If05d8bfe8601288b10fc65cca77664fe9638bbe9 Reviewed-on: https://chromium-review.googlesource.com/910851Reviewed-by:
Miran Karić <miran.karic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#51212}
-
Andreas Haas authored
When streaming compilation for WebAssembly gets aborted, we reject the promise associated with the compilation. However, in some circumstances, e.g. when streaming comilation gets aborted because the browser tab gets refreshed, then we want to omit rejecting the promise. In an older CL (https://crrev.com/c/876103) we omit rejecting the promise when the exception value is null. With this CL the exception value is a MaybeLocal so that we document properly that the value can be null. In addition, I added documentation to say that in that case we do not reject the promise. R=adamk@chromium.org Bug: chromium:803838 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6a093e61c8ec63f7ae385a7f77ae6178e7b34a06 Reviewed-on: https://chromium-review.googlesource.com/897647Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51211}
-
Clemens Hammacher authored
This allows to emit the best opcode for the register move. The type is available at all call sites anyway. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I8516deff4d8a5480cea9df37cfc003fb9c668e8c Reviewed-on: https://chromium-review.googlesource.com/910910Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51210}
-
Michael Achenbach authored
The suppression flag must be set before loading the tests to have an effect. This got turned around in https://crrev.com/c/899366 and is fixed again by this CL. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: Ie58465288a0d6eec9a99a23d610710de9e1cdddd Reviewed-on: https://chromium-review.googlesource.com/911114Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51209}
-
Dan Elphick authored
This removes the Javascript version of Array.from in js/array.js and adds a CodeStubAssembler version in src/builtins/builtins-array-gen.cc. Also modify IteratorBuiltinsAssembler to allow querying the existence of the iterator method without calling it so we can fall back to the array-like behavior. BUG=v8:1956 Change-Id: Ibfb3cef002d72d70bd30b4de676fd22becde006c Reviewed-on: https://chromium-review.googlesource.com/887066Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#51208}
-
Clemens Hammacher authored
Add support for i64 loads and stores. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I494fb466f702c8b89b96f7ded6d1cf09ec6991fb Reviewed-on: https://chromium-review.googlesource.com/902046 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
jgruber authored
Since we naively build the JS source code through concatenation, we need to ensure the regexp literal does not end up being interpreted as a multiline comment: const re = /*/; Bug: v8:6741,chromium:808418 Change-Id: Id52fbd2d62c14fc634d05fa1b0192ab86cc9e4fc Reviewed-on: https://chromium-review.googlesource.com/905667Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51206}
-
Yang Guo authored
R=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Bug: chromium:807986 Change-Id: Iffcd9fb943c59e218e70c61491efcadce5a7497c Reviewed-on: https://chromium-review.googlesource.com/911049 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This new variant is executed on a small number of bots as part of the "extra" suite. It checks that the wasm-jit-to-native flag can still be disabled if unexpected failures pop up on a release branch. R=machenbach@chromium.org Bug: v8:7417 Change-Id: I1658cb2f04302fa80915b59bfedd85d980742db5 Reviewed-on: https://chromium-review.googlesource.com/909213Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
As part of https://chromium-review.googlesource.com/902283 I changed the JSCreateClosure lowering to respect the pretenure flag on the operator, but that tanks some benchmarks heavily, as the Parser marks closures like args[l] = function(...) { ... } for old-space allocation, which backfires for short-living closures. Bug: v8:7253, chromium:810132 Change-Id: I66f048553d9f2a70b2691537e726128f3fb01563 Reviewed-on: https://chromium-review.googlesource.com/910849Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51203}
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3ba6ca6..c1972dd Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/c9f9bbf..9a70d48 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b4a4bed..e653c4b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/357315f..7c6255f This also ports https://crrev.com/c/907673 for adjusting V8's DEPS file to the sysroot changes rolling in v8/build. TBR=yangguo@chromium.org Bug: chromium:807986 Change-Id: If55378330ae8797798abe1a98a858a0f57cf7fbe Reviewed-on: https://chromium-review.googlesource.com/910193Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51202}
-
Kim-Anh Tran authored
Added counter to correctly reflect the number of non-compiled functions. Added usages of variables used only for tracing or debug to avoid compiler warnings. R=clemensh@chromium.org Change-Id: I4c8d9c0f43bf23250b4702e43592cd64046d28c7 Reviewed-on: https://chromium-review.googlesource.com/907890 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51201}
-
Clemens Hammacher authored
This CL fixes several unrelated failures with --no-wasm-jit-to-native. A follow-up CL will then add a new test variant with that flag. R=ahaas@chromium.org Bug: v8:7417 Change-Id: I40a7be53a50d0efbbec8de49aceeb4a43a1f41de Reviewed-on: https://chromium-review.googlesource.com/909212Reviewed-by:
-
Yang Guo authored
R=franzih@chromium.org Bug: v8:7335 Change-Id: Icd4624b119f573640bd34b19db1f6c1b7e035f8d Reviewed-on: https://chromium-review.googlesource.com/910930Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51199}
-
Ivica Bogosavljevic authored
Fix 876f37c3 Wrong instruction use causes around 600 failures on MIPS64 bots Change-Id: I66bd9689c5e5b5e9bf40a0e7063dbbcfed04fcf7 Reviewed-on: https://chromium-review.googlesource.com/908465Reviewed-by:
-
Michael Achenbach authored
TBR=cbruni@chromium.org NOTRY=true Bug: v8:7429 Change-Id: Id30d462792f062e8c1b21f622b949e5b7aa52907 Reviewed-on: https://chromium-review.googlesource.com/910889Reviewed-by:
-
Clemens Hammacher authored
The return type of {CallFPImpl} differs between declaration and definition (int32_t vs intptr_t). Even though our bots seem to be fine with this, I got a compile error on mac. R=mstarzinger@chromium.org Change-Id: I4fb26cbe712c090d08dfcd2614a7af78de09e448 Reviewed-on: https://chromium-review.googlesource.com/909428Reviewed-by: -
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: Id733f67781acade86007cd65b20b7108857764b5 Reviewed-on: https://chromium-review.googlesource.com/910508 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51195}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: Ied48d94830b452a9bbde80858e7c130bfb671b01 Reviewed-on: https://chromium-review.googlesource.com/910368Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I5611f37c8c9d55a9b3ac316cf7d1ef8d4a1b2e2a Reviewed-on: https://chromium-review.googlesource.com/910288 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 08 Feb, 2018 20 commits
-
-
Adam Klein authored
Change-Id: I75111d30d9e31605fd78c55e3103af8834178cd7 Reviewed-on: https://chromium-review.googlesource.com/909963Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#51192}
-
Alexey Kozyatinskiy authored
We used to calculate hash in completely incorrect way. We use each forth character to calculate hash but we should use each one. R=dgozman@chromium.org Bug: v8:7426 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaaa317bbf3b3ef71632735dfd069db450283b6f4 Reviewed-on: https://chromium-review.googlesource.com/909586 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51191}
-
Wez authored
Bug: chromium:809201 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I060ae3a88c3a3731bfdbb9e6d5cdf8600ec8b832 Reviewed-on: https://chromium-review.googlesource.com/903421Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:616879 Change-Id: I686916ac031a32782a86ae74455d7f6f0d083377 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/910048Reviewed-by:
-
Michael Achenbach authored
Timeouts on num-fuzzer only lead to false positives, as tests might take unpredictably longer. This CL forgives timeouts through a global override mechanism of the expected outcomes. This allows to remove already existing scattered code that allowed timeouts in some test suites only. Bug: v8:6917 Change-Id: Ib131765d360e335789c1952bc6793ed051e016ea Reviewed-on: https://chromium-review.googlesource.com/908454 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:616879 Change-Id: I449b7e55bd2cf70f45e423ebc46982187c4f14dd No-Try: true Reviewed-on: https://chromium-review.googlesource.com/908455Reviewed-by:
-
Junliang Yan authored
Port 876f37c3 Original Commit Message: We reuse most of the infrastructure to set break points, with minor differences when we encounter functions where we can only break on entry: - PrepareFunctionForBreakPoints simply deopts all functions. - Break point objects have the canonical source position 0. - Break point is set/checked/cleared via bit on the DebugInfo. - Debug::Break do not continue stepping since stepping is implemented via regular break points and therefore do not interfere with break on entry. I promise to add more tests. R=yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I0595652adced533c1032a6c3fd64cddfd4e730da Reviewed-on: https://chromium-review.googlesource.com/909292 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#51186}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: Ied1101295fc9ee37fcc038b9aeb557229722df0b Reviewed-on: https://chromium-review.googlesource.com/897566 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7250 Change-Id: If4c9d0b32939a06993d3ffb39ac4b19edbad422f Reviewed-on: https://chromium-review.googlesource.com/906731Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51184}
-
Vasili Skurydzin authored
Change to v8/BUILD.gn regarding GN build of V8. Excluding platform-posix-time.h and platform-posix-time.cc from the sources list on AIX os. The changes affect AIX only. Bug: chromium:616029 Change-Id: I5e5d46aa4c62f70544ff593294e459c607a03c67 Reviewed-on: https://chromium-review.googlesource.com/897124 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
PromiseHooks can be called with a proxy which fails the cast and crashes. This patch changes the runtime functions to explicitly check for a JSPromise. This has the side effect of removing the existing broken support for catch prediction for non native promises. Bug: v8:7398, v8:7190 Change-Id: I66dbe5f9935943a91afb7ee14919bd9248f9f7e4 Reviewed-on: https://chromium-review.googlesource.com/907677Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Adam Klein authored
This reverts commit 14108f4c. Reason for revert: Not the culprit for Canary microtask crashes Original change's description: > [builtins] Mega-revert to address the Dev blocker in crbug.com/808911. > > - Revert "[builtins] Save one word in contexts for Promise.all." > This reverts commit 7632da06. > - Revert "[builtins] Also use the Promise#then protector for Promise#finally()." > This reverts commit d4f072ce. > - Revert "[builtins] Don't mess with entered context for MicrotaskCallbacks." > This reverts commit 6703dacd. > - Revert "[debugger] Properly deal with settled promises in catch prediction." > This reverts commit 40dd0658. > - Revert "[builtins] Widen the fast-path for Promise builtins." > This reverts commit db0556b7. > - Revert "[builtins] Unify PerformPromiseThen and optimize it with TurboFan." > This reverts commit a582199c. > - Revert "[builtins] Remove obsolete PromiseBuiltinsAssembler::AppendPromiseCallback." > This reverts commit 6bf88852. > - Revert "[builtins] Turn NewPromiseCapability into a proper builtin." > This reverts commit 313b490d. > - Revert "[builtins] Inline InternalPromiseThen into it's only caller" > This reverts commit f7bd6a2f. > - Revert "[builtins] Implement Promise#catch by really calling into Promise#then." > This reverts commit b23b098f. > - Revert "[promise] Remove incorrect fast path" > This reverts commit 0f6eafe8. > - Revert "[builtins] Squeeze JSPromise::result and JSPromise::reactions into a single field." > This reverts commit 8a677a28. > - Revert "[builtins] Refactor promises to reduce GC overhead." > This reverts commit 8e7737cb. > > Tbr: hpayer@chromium.org > Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 > Change-Id: I8c8ea5ed32ed62f6cd8b0d027a3707ddd891e5f1 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/906991 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51158} Change-Id: I09d958cbebd635a325809072a290f2f53df8c5d4 Tbr: adamk@chromium.org,yangguo@chromium.org,bmeurer@chromium.org Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/908988Reviewed-by:
-
Franziska Hinkelmann authored
Implement empty desctructor because of the forward declarations. Change-Id: I56af92d7ded44b6fcd3582d1e3a10e9bb5cb1296 Reviewed-on: https://chromium-review.googlesource.com/905671Reviewed-by:
-
Clemens Hammacher authored
For local variables of type i64 and also for i64 constants, it makes sense to store the constant value in the {VarState} instead of loading the value into a register immediately. This also helps with some instructions like i64 bitshifts, but also general patterns like incrementing an i64 local variable by a fixed number. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Ibed15228bbc53632dd3e60d7862ff2fbcb9832ca Reviewed-on: https://chromium-review.googlesource.com/904443 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Dan Elphick authored
The new macro takes a void(Label* ok, Label* not_ok), which should generate statements that branch to one of the labels. If the not_ok Label is reached, it will abort just like CSA_ASSERT. Also replaces an instance of #ifdef DEBUG ... #endif with this pattern in builtins-regexp-gen.cc Change-Id: Ie7ec87e041c040c03f9c528dccc8e709e50ed9b9 Reviewed-on: https://chromium-review.googlesource.com/906933Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: chromium:772804 Change-Id: I1f72b9710b25edf7d95fa5404bf22bd543fed66b Reviewed-on: https://chromium-review.googlesource.com/908459Reviewed-by:
-
sreten.kovacevic authored
Added registers and conditions for this architecture. Implemented some of the instructions, mainly for wasm context operations. Bug: v8:6600 Change-Id: I5f3e32eb4d284172b21434456395256872da3b46 Reviewed-on: https://chromium-review.googlesource.com/906609 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Because of missing parentheses, the computation of the "half index" was wrong, and always produced 0 or 1. Also, for non-pairs, we were still passing kHighWord for the RegPairHalf. R=ahaas@chromium.org Bug: v8:7422, v8:6600 Change-Id: If056aa8005d4b44e667b7d76b9be49ec0191d0eb Reviewed-on: https://chromium-review.googlesource.com/908554Reviewed-by:
-
Yang Guo authored
R=jarin@chromium.org Bug: v8:178 Change-Id: I4b77e96072d5b8b70df21477bba8cdbf573d184c Reviewed-on: https://chromium-review.googlesource.com/908289Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: chromium:772804 Change-Id: I738d67bd504180de70359f4aabec3ef8f54cee16 Reviewed-on: https://chromium-review.googlesource.com/907557 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
