Commits · 7005abf03b4f330cd217e425328f1cddd162bf44 · Linshizhi / V8

13 Jun, 2014 16 commits

Optimize Function.prototype.call · 7005abf0

verwaest@chromium.org authored Jun 13, 2014

- May inline the function, or call it directly, instead of going through call
- Supports arguments object escaping when it escapes to builtins (preparation for slice.call(arguments, ...) optimization)
- Both .call and .apply now support inlining when calling builtins indirectly

BUG=
R=verwaest@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/335683002

Patch from Petka Antonov <p.antonov@partner.samsung.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7005abf0

Have one, long-lived map for bound functions. · 6e29768e

jkummerow@chromium.org authored Jun 13, 2014

This avoids creating a new map for every bound function. Bonus: some cleanup in Runtime_FunctionBindArguments.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335653002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e29768e

Keep maps when resetting elements. · 9dd1f03c

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335553004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9dd1f03c

Reland "Rename kIs64BitArch with kRequiresCodeRange." · 510ea9e5

svenpanne@chromium.org authored Jun 13, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/331823002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21837 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

510ea9e5

Remove one more arch-specific target name. · 3b545740

jkummerow@chromium.org authored Jun 13, 2014

One more target had the architecture added to its name since r14209
originally landed and was missed when that change was reverted. Remove
the architecture from v8_libbase as well.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/334793004

Patch from Richard Coles <torne@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b545740

Emulate MLS on pre-ARMv6T2. Cleaned up thumbee vs. thumb2 confusion. · d82a6ada

svenpanne@chromium.org authored Jun 13, 2014

This should unbreak things on the Raspberry Pi.

LOG=y
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/331803003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21835 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d82a6ada

Allow all Names to be fast property names · 8334faa0

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/329393005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21834 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8334faa0

Use generic representation when normalizing boilerplate properties · a4d1e01b

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/323403008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21833 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a4d1e01b

Mark timed range in the profile plot. · 2e8a6f5e

yangguo@chromium.org authored Jun 13, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/333643006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e8a6f5e

Disable regress/regress-2653 until deopt_every_n_garbage_collections is fixed. · 0f69ed32

ulan@chromium.org authored Jun 13, 2014

BUG=3389
LOG=N
R=marja@chromium.org

Review URL: https://codereview.chromium.org/331823003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f69ed32

GVN fix, preventing loads hoisting above stores to the same field when... · 41e9d916

ishell@chromium.org authored Jun 13, 2014

GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representation is not the same.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/331493006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41e9d916

X87: Fixed flooring division by a power of 2, once again... · fd1ace4d

weiliang.lin@intel.com authored Jun 13, 2014

port r21769

original message:
    Avoid right shifts by zero bits: On ARM it actually means shifting by
    32 bits (correctness issue) and on other platforms they are useless
    (performance issue). This is fix for the fix in r20544.

    BUG=v8:3259
    LOG=y
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/330133004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21829 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd1ace4d

Fixed undefined behavior in RNG. · ac18d082

svenpanne@chromium.org authored Jun 13, 2014

We're basically trading undefined behavior for implementation defined
behavior, which should be OK for UBSan. :-) The generated code should
be identical, at least I checked that for GCC 4.6.3 on x64.

BUG=377790
LOG=y
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/332733002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21828 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac18d082

Update Lithium AddI, SubI, MulI, BitI, ShiftI, MathMinMax to support x32 port. · 817430f6

haitao.feng@intel.com authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/321373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21827 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

817430f6

Specially handle the key of the LoadKeyed and StoreKeyed instruction for x32 port. · 28e74e13

haitao.feng@intel.com authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/324913002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21826 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28e74e13

MIPS: Fix register usage after r21822. · 1eac6114

palfia@homejinni.com authored Jun 13, 2014

The at register is no longer in usage, so changed it to "scratch".

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/335753003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21825 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1eac6114

12 Jun, 2014 24 commits

MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...” · d773d05b

plind44@gmail.com authored Jun 12, 2014

Initialize scratch register for all possible code paths.

TEST=mjsunit/compiler/division-by-constant.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/333713002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21822 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d773d05b

Make timestamp of fuzz harness archives finer grained. · ed61b85c

mstarzinger@chromium.org authored Jun 12, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/329303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21821 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed61b85c

For-of calls [Symbol.iterator]() on RHS to get iterator · dfb1c7dc

wingo@igalia.com authored Jun 12, 2014

R=rossberg@chromium.org
BUG=http://code.google.com/p/v8/issues/detail?id=2735
LOG=N

Review URL: https://codereview.chromium.org/332663004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfb1c7dc

Drop dependency on Isolate* from platform.h · 52640018

jochen@chromium.org authored Jun 12, 2014

BUG=none
R=dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/328993003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21819 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52640018

Remove forced type changes when they can't deopt · 649057e0

m.m.capewell@googlemail.com authored Jun 12, 2014

Hydrogen attempts to force representation changes on certain operations in order
to deoptimise on the change rather than the operation. However, these forced
changes are often unnecessary on 64-bit platforms, and cause poor code
generation, so this patch makes some of them conditional on whether it's
possible for deoptimisation to occur in the change.

On ARM64, this prevents sequences like:
                  ;;; <@46,#89> smi-tag
0x7ff282c7f050   144  lsl x4, x4, #32
                  ;;; <@48,#90> smi-untag
0x7ff282c7f054   148  asr x5, x4, #32
                  ;;; <@50,#31> mul-const-i-s
0x7ff282c7f058   152  lsl w6, w5, #3

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/303263010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21818 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

649057e0

Optimize prototype chain when creating initial maps for functions used as constructors · 301ae7dd

jkummerow@chromium.org authored Jun 12, 2014

Review URL: https://codereview.chromium.org/332783002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

301ae7dd

Add non-miss slow path to LoadIC_Normal. · 918efd7e

jkummerow@chromium.org authored Jun 12, 2014

This avoids endless IC patching cycles between "normal" and "nonexistent" handlers when objects having and not having the property are seen alternatingly

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/328353002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

918efd7e

MIPS: Fix unsigned comparison. · 5c96e2cf

plind44@gmail.com authored Jun 12, 2014

TEST=mjsunit/regress/regress-3380
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/329223006

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c96e2cf

Rewrite GetPropertyAttribute to use the LookupIterator · fd80653a

verwaest@chromium.org authored Jun 12, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/321543004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21814 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd80653a

X87: Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 6a8d820f

weiliang.lin@intel.com authored Jun 12, 2014

Port r21781 (4869c528)

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/336543002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a8d820f

Revert "Active use of Hydrogen-generated generic KeyedLoad IC" · 7e67361e

danno@chromium.org authored Jun 12, 2014

Due to mirror-object test failure (although I'm pretty sure I was framed)

R=mstarzinger@chromium.org
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/328333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e67361e

Active use of Hydrogen-generated generic KeyedLoad IC · dc0236cf

danno@chromium.org authored Jun 12, 2014

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/330023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc0236cf

Don't use LOG() from platform. · 79a9eaf9

jochen@chromium.org authored Jun 12, 2014

All places that use OS::Allocate either CHECK() that the result is non-NULL,
or use a reasonable fallback if they can't mmap memory.

BUG=none
R=mstarzinger@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/326323002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

79a9eaf9

build fix after r21807 · 0ffe8b10

dcarney@chromium.org authored Jun 12, 2014

TBR=mstarzinger@chromium.org

BUG=

Review URL: https://codereview.chromium.org/333503005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0ffe8b10

Grow big old generation slower. · 9f80d076

hpayer@chromium.org authored Jun 12, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/324403008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21808 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f80d076

remove this == null · 99d9abaf

dcarney@chromium.org authored Jun 12, 2014

R=danno@chromium.org

BUG=chromium:381910

Review URL: https://codereview.chromium.org/336483002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99d9abaf

Sign extend the dehoisted key at the definition point for x64 port only; for... · 4d4485e4

haitao.feng@intel.com authored Jun 12, 2014

Sign extend the dehoisted key at the definition point for x64 port only; for x32 port, we need to sign extend the dehoisted key at the use points.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/328553005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d4485e4

Add v8::Promise::Then. · d757f378

rossberg@chromium.org authored Jun 12, 2014

Blink needs v8::Promise::Then to implement ScriptPromise::then.
Blink-side CL: https://codereview.chromium.org/316453002

BUG=371288
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/314553002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d757f378

Do away with variable length memcpy to Set/Get registers in simulator · 3419aefe

svenpanne@chromium.org authored Jun 12, 2014

About a 32% boost.

Before - 5:31

Richards: 84.5
DeltaBlue: 128
Crypto: 65.3
RayTrace: 203
EarleyBoyer: 149
RegExp: 23.4
Splay: 121
NavierStokes: 98.9
----
Score (version 7): 93.8

After - 4:10

Richards: 107
DeltaBlue: 175
Crypto: 93.9
RayTrace: 258
EarleyBoyer: 186
RegExp: 32.7
Splay: 165
NavierStokes: 124
----
Score (version 7): 124

R=jacob.bramley@arm.com, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21448

Review URL: https://codereview.chromium.org/213943002

Patch from Fritz Koenig <frkoenig@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3419aefe

Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" · 634cb5e8

danno@chromium.org authored Jun 12, 2014

This CL tickled an unrelated arm64 bug which was is fixed separately.

The MIPS port (originally landed 21784) is also included.

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/331633002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

634cb5e8

Remove duplicate code in SetPropertyPostInterceptor · 9fa48abd

verwaest@chromium.org authored Jun 12, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/314673002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fa48abd