Skip to content

V
V8
Switch branch/tag
  1. 11 Feb, 2016 1 commit
  3. 02 Feb, 2016 1 commit
    • jarin's avatar
      Remove the template magic from types.(h|cc), remove types-inl.h. · ef35f11c
      jarin authored 
      This CL removes the Config templatization from the types. It is not
necessary anymore, after the HeapTypes have been removed.

The CL also changes the type hierarchy - the specific type kinds are
not inner classes of the Type class and they do not inherit from Type.
This is partly because it seems impossible to make this work without
templates. Instead, a new TypeBase class is introduced and all the
structural (i.e., non-bitset) types inherit from it.

The bitset type still requires the bit-munging hack and some nasty
reinterpret-casts to pretend bitsets are of type Type*. Additionally,
there is now the same hack for TypeBase - all pointers to the sub-types
of TypeBase are reinterpret-casted to Type*. This is to keep the type
constructors in inline method definitions (although it is unclear how
much that actually buys us).

In future, we would like to move to a model where we encapsulate Type*
into a class (or possibly use Type where we used to use Type*). This
would loosen the coupling between bitset size and pointer size, and
eventually we would be able to have more bits.

TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1655833002

Cr-Commit-Position: refs/heads/master@{#33656}
      ef35f11c
  5. 09 Dec, 2015 1 commit
  7. 02 Dec, 2015 1 commit
  9. 12 Oct, 2015 1 commit
    • littledan's avatar
      Test for var declarations in eval which conflict with let · d515e513
      littledan authored 
      Previously, name conflicts between var and let declarations were only
made into exceptions if they were visible at parse-time. This patch adds
runtime checks so that sloppy-mode direct eval can't introduce conflicting
var declarations. The change is implemented by traversing the scope chain
when a direct eval introduces a var declaration to look for conflicting
let declarations, up to the function boundary.

BUG=v8:4454
R=adamk
LOG=Y

Review URL: https://codereview.chromium.org/1382513003

Cr-Commit-Position: refs/heads/master@{#31211}
      d515e513
  11. 30 Sep, 2015 1 commit
  13. 31 Jul, 2015 1 commit
  15. 27 Jul, 2015 1 commit
  17. 27 Apr, 2015 1 commit
  19. 21 Apr, 2015 3 commits
  21. 17 Mar, 2015 1 commit
  23. 12 Mar, 2015 1 commit
  25. 16 Feb, 2015 1 commit
    • ishell's avatar
      Property reconfiguring implemented. · 35841b50
      ishell authored 
      Previous approach for property reconfiguration was to create a free-floating map with generalized representations of all fields. This patch does it right.

When property is reconfigured either by changing its kind (kData <-> kAccessor) or its attributes it implies creation of a new branch in transition tree. If such a branch already existed before reconfiguration then it should be merged with the old (or source) branch of the transition tree. Merging procedure includes all the heavy machinery such as property location changes (kDescriptor -> kField), field representation/field type generalization, map deprecation, etc.

Review URL: https://codereview.chromium.org/888623002

Cr-Commit-Position: refs/heads/master@{#26667}
      35841b50
  27. 19 Jan, 2015 1 commit
    • ishell's avatar
      Massive renaming of PropertyType values and other implied stuff. · 33994b4a
      ishell authored 
      PropertyKind:
  DATA -> kData
  ACCESSOR -> kAccessor

PropertyType:
  FIELD -> DATA
  CONSTANT -> DATA_CONSTANT
  ACCESSOR_FIELD -> ACCESSOR
  CALLBACKS -> ACCESSOR_CONSTANT

PropertyLocation:
  IN_OBJECT -> kField
  IN_DESCRIPTOR -> kDescriptor

StoreMode:
  FORCE_IN_OBJECT -> FORCE_FIELD

FieldDescriptor -> DataDescriptor
ConstantDescriptor -> DataConstantDescriptor
CallbacksDescriptor -> AccessorConstantDescriptor

Review URL: https://codereview.chromium.org/856503002

Cr-Commit-Position: refs/heads/master@{#26146}
      33994b4a
  29. 16 Dec, 2014 1 commit
  31. 12 Dec, 2014 1 commit
  33. 19 Nov, 2014 1 commit
  35. 11 Nov, 2014 1 commit
  37. 10 Nov, 2014 2 commits
  39. 23 Oct, 2014 1 commit
  41. 26 Aug, 2014 2 commits
  43. 21 Aug, 2014 2 commits
  45. 04 Aug, 2014 1 commit
  47. 03 Jun, 2014 1 commit
  49. 29 Apr, 2014 1 commit
  51. 04 Apr, 2014 1 commit
  53. 12 Mar, 2014 1 commit
  55. 28 Feb, 2014 1 commit
  57. 18 Feb, 2014 1 commit
  59. 21 Jan, 2014 1 commit
  61. 10 Jan, 2014 1 commit
  63. 09 Jan, 2014 4 commits