- 05 Dec, 2016 12 commits
-
-
leszeks authored
Now that the BASE_EMBEDDED macro is gone, this should be safe. Originally removed in: https://codereview.chromium.org/2532103004/ Review-Url: https://codereview.chromium.org/2545723002 Cr-Commit-Position: refs/heads/master@{#41480}
-
ulan authored
This reverts commit aea4f1a7. Reason: performance regression on benchmarks (crbug.com/671118). BUG=chromium:671118,chromium:613518 TBR=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2549053002 Cr-Commit-Position: refs/heads/master@{#41479}
-
mstarzinger authored
This removes support for accessing super properties (load, store & call) from the {FullCodeGenerator}. Consequently optimized code containing such constructs must use the {BytecodeGraphBuilder} and can no longer use the {AstGraphBuilder} for graph building. R=bmeurer@chromium.org BUG=v8:5657 Review-Url: https://codereview.chromium.org/2544123004 Cr-Commit-Position: refs/heads/master@{#41478}
-
titzer authored
R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2551463002 Cr-Commit-Position: refs/heads/master@{#41477}
-
clemensh authored
This was somehow missing so far. With this CL, we can disassembly all functions on AngryBots. R=titzer@chromium.org, rossberg@chromium.org BUG=chromium:659715 Review-Url: https://codereview.chromium.org/2552643002 Cr-Commit-Position: refs/heads/master@{#41476}
-
machenbach authored
The bot will be renamed in a follow up, when the infra side is renamed. TBR=zhengxing.li@intel.com, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2549033002 Cr-Commit-Position: refs/heads/master@{#41475}
-
marija.antic authored
Port of d4f01b8a BUG= Review-Url: https://codereview.chromium.org/2550503003 Cr-Commit-Position: refs/heads/master@{#41474}
-
bmeurer authored
That ADD builtin is gone for a long time. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2547423002 Cr-Commit-Position: refs/heads/master@{#41473}
-
bmeurer authored
When enforcing Ignition+TurboFan for a function literal during AstNumbering, make sure to print the bailout reason with --trace-opt to make it easier to figure out what caused the bailout. BUG=chromium:670691 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2550093002 Cr-Commit-Position: refs/heads/master@{#41472}
-
bmeurer authored
The current Array.prototype.sort implementation is pretty sensitive to compiler changes, i.e. switching to I+TF completely, so refactor it a bit so that it can stay with FCG+CS for now. Middle-term the Array builtins need to be refactored to TurboFan builtins anyways. BUG=chromium:670691,v8:5666 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2553523002 Cr-Commit-Position: refs/heads/master@{#41471}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/83f770a..0676437 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d48a09f..7f925e3 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2551003002 Cr-Commit-Position: refs/heads/master@{#41470}
-
jarin authored
Review-Url: https://codereview.chromium.org/2546113002 Cr-Commit-Position: refs/heads/master@{#41469}
-
- 04 Dec, 2016 3 commits
-
-
bmeurer authored
Add support to lower the %_DebugIsActive intrinsic during JSIntrinsicLowering instead of always going to the runtime for this. This addresses part of the Bluebird regression caused by sending let and const to TurboFan and Ignition. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2550043002 Cr-Commit-Position: refs/heads/master@{#41468}
-
bmeurer authored
This should recover part of the Bluebird regression caused by sending let/const to TurboFan+Ignition. R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2552583002 Cr-Commit-Position: refs/heads/master@{#41467}
-
v8-autoroll authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/ca719be..627b0d9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2545293002 Cr-Commit-Position: refs/heads/master@{#41466}
-
- 03 Dec, 2016 3 commits
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a8dd8be..83f770a Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/36566dd..ca719be Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f4b896b..d48a09f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2550913002 Cr-Commit-Position: refs/heads/master@{#41465}
-
gdeepti authored
In the current implementation, WasmInstanceWrapper is allocated after the imports for the instance are processed, and before the InstanceFinalizer callback is associated with the instance. This raises the possibility of triggering a gc in the middle of the instantiate flow which is incorrect. BUG=5707 R=titzer@chromium.org, petermarshall@chromium.org Review-Url: https://codereview.chromium.org/2544273002 Cr-Commit-Position: refs/heads/master@{#41464}
-
adamk authored
Several cleanups to the output of the debug-only --print-scopes flag: - Function name variable only printed once - Only print headers for sections of variables that are non-empty - Assume Variables stored in Scope::variables_ are never null R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2544063004 Cr-Commit-Position: refs/heads/master@{#41463}
-
- 02 Dec, 2016 21 commits
-
-
alph authored
BUG=chromium:665398 Review-Url: https://codereview.chromium.org/2549653002 Cr-Commit-Position: refs/heads/master@{#41462}
-
enne authored
Revert of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2544503002/ ) Reason for revert: Speculative revert for causing timeouts on Win Debug gpu fyi bot Nothing else looks even remotely relevant in the list of changes. Will reland if this doesn't fix the issues. BUG=670396 Original issue's description: > [typedarrays] remove invalid optimization in NAMEConstructor() > > Before, we were treating objects with the builtin ArrayValues iterator > method as array-like, where the iterator would iterate through to the > full length of the object. > > This optimization was not sound, because it does not ensure that the > next method hasn't been modified. Even if it hasn't been modified, > it's entirely possible to be modified during iteration. Thus, this > optimization has been removed due to its observability. > > BUG=v8:5699 > R=littledan@chromium.org, cbruni@chromium.org > > Committed: https://crrev.com/77df8c67d9609ada3b7d79e8e6d33f198bbad5a1 > Cr-Commit-Position: refs/heads/master@{#41394} TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5699 Review-Url: https://codereview.chromium.org/2548583003 Cr-Commit-Position: refs/heads/master@{#41461}
-
thomasanderson authored
BUG=670470 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2544053002 Cr-Commit-Position: refs/heads/master@{#41460}
-
ulan authored
BUG=chromium:613518 Review-Url: https://codereview.chromium.org/2407153002 Cr-Commit-Position: refs/heads/master@{#41459}
-
ishell authored
... even when a receiver is not an object. BUG=v8:5697 Review-Url: https://codereview.chromium.org/2548753003 Cr-Commit-Position: refs/heads/master@{#41458}
-
bmeurer authored
TBR=machenbach@chromium.org BUG=v8:5666 Review-Url: https://codereview.chromium.org/2542843008 Cr-Commit-Position: refs/heads/master@{#41457}
-
rmcilroy authored
BUG=v8:5708 Review-Url: https://codereview.chromium.org/2548813002 Cr-Commit-Position: refs/heads/master@{#41456}
-
ivica.bogosavljevic authored
Turbofan uses 64-bit load followed by 32 bit arithmetic shift when loading higher 32 bits of 64-bit value. We simplify this by loading higher 32 bits directly. BUG= Review-Url: https://codereview.chromium.org/2532333003 Cr-Commit-Position: refs/heads/master@{#41455}
-
titzer authored
R=machenbach@chromium.org,jarin@chromium.org BUG=v8:5710 Review-Url: https://codereview.chromium.org/2551433002 Cr-Commit-Position: refs/heads/master@{#41454}
-
vogelheim authored
BUG=v8:4947 Review-Url: https://codereview.chromium.org/2547493002 Cr-Commit-Position: refs/heads/master@{#41453}
-
vogelheim authored
This apparently gradually fell out of use after the more general Token::IsIdentifer was introduced, and whoever left last forgot to turn out the lights. The only remaining use was in an assertion in DeclareLabel, but meanwhile DeclareLabel is only called if IsIdentifier. I added re-formulated assertions, just in case. R=verwaest@chromium.org BUG=v8:4947 Review-Url: https://codereview.chromium.org/2549493002 Cr-Commit-Position: refs/heads/master@{#41452}
-
mstarzinger authored
This enables {FLAG_debug_code} by default in debug builds. The advantage is that generated code contained within the snapshot will contain such debug code. Before we would only get coverage for these pieces with the no-snapshot builds, which have a meager coverage. One can still pass the inverse --no-debug-code flag to ensure generated code remains readable within debug builds as well. R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2528913002 Cr-Commit-Position: refs/heads/master@{#41451}
-
clemensh authored
Since we don't pass references to this constant to the DCHECKs any more (see http://crrev.com/2524093002), the constant can now be initialized in the header, reducing code size and increasing performance. Before the mentioned change in CHECK/DCHECK, this caused link errors. R=ishell@chromium.org CC=jgruber@chromium.org BUG=v8:5684 Review-Url: https://codereview.chromium.org/2541533002 Cr-Commit-Position: refs/heads/master@{#41450}
-
ishell authored
[ic] Use validity cells to protect keyed element stores against object's prototype chain modifications. ... instead of clearing of all the KeyedStoreICs which didn't always work. BUG=chromium:662907, chromium:669411, v8:5561 TBR=verwaest@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf Review-Url: https://codereview.chromium.org/2534613002 Cr-Original-Commit-Position: refs/heads/master@{#41332} Cr-Commit-Position: refs/heads/master@{#41449}
-
jochen authored
Revert of Introduce a separate FunctionLiteral ID for Eval (patchset #1 id:1 of https://codereview.chromium.org/2533303006/ ) Reason for revert: My assumption that eval and top-level code should be handled differently was wrong Original issue's description: > Introduce a separate FunctionLiteral ID for Eval > > Top level SharedFunctionInfos will end up in a scripts SFI list, but > eval'd SFIs shouldn't. Separate IDs will allow for adding a > corresponding DCHECK. > > BUG=v8:5589 > R=marja@chromium.org > > Committed: https://crrev.com/c6d421ff9aee7f3cab9e48faac88f6b08d2f1cf5 > Cr-Commit-Position: refs/heads/master@{#41421} TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5589 Review-Url: https://codereview.chromium.org/2544003003 Cr-Commit-Position: refs/heads/master@{#41448}
-
predrag.rudic authored
Tests were falling in qemu because of inexact computation in tests. After correcting tests, simulator also had to be fixed. Review-Url: https://codereview.chromium.org/2539133002 Cr-Commit-Position: refs/heads/master@{#41447}
-
jgruber authored
This relands API deprecation (without removing the implementation), removal of NewFunction and BeforeCompile events, and removal of DebugCommandProcessor tests. The remaining portion of the original CLs can be relanded after the 4.7 branch point. Original CLs: https://codereview.chromium.org/2524323002 https://codereview.chromium.org/2531543002 BUG=v8:5510 Review-Url: https://codereview.chromium.org/2546473008 Cr-Commit-Position: refs/heads/master@{#41446}
-
bmeurer authored
Crankshaft has this highly unpredictable performance cliff around the "Unsupported phi use of const or let variable", which is due to the fact that Crankshaft refuses to do hole checks (for a couple of reasons). So ideally we should not even try to send any lexically bound variables to fullcodegen+Crankshaft, but instead give them to Ignition and TurboFan. This CL only adds the appropriate check to the AstNumbering, but doesn't remove the functionality from fullcodegen/Crankshaft yet. This would be step two in case this CL sticks. If you see any major performance regressions with this CL in the range, just revert it and ping me. See Node.js issue https://github.com/nodejs/node/issues/9729 for additional information. BUG=v8:5666 R=hablich@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2525243002 Cr-Commit-Position: refs/heads/master@{#41445}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ac12d5e..a8dd8be Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/582ccd4..36566dd Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ccd4a12..f4b896b TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2543143002 Cr-Commit-Position: refs/heads/master@{#41444}
-
aseemgarg authored
BUG=v8:4124 TEST:test-run-wasm-simd-lowering R=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2498283002 Cr-Commit-Position: refs/heads/master@{#41443}
-
luoe authored
Descriptions for (typed)arrays will use parenthesis instead of square brackets "Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions of maps and sets. Related CL for DevTools: https://codereview.chromium.org/2524913002/ BUG=405845 Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d Review-Url: https://codereview.chromium.org/2521853003 Cr-Original-Commit-Position: refs/heads/master@{#41237} Cr-Commit-Position: refs/heads/master@{#41442}
-
- 01 Dec, 2016 1 commit
-
-
bjaideep authored
Port 2b991784 R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/2542313002 Cr-Commit-Position: refs/heads/master@{#41441}
-