• bmeurer's avatar
    [compiler] Consistently use Ignition+TurboFan for lexical variables. · 5529430d
    bmeurer authored
    Crankshaft has this highly unpredictable performance cliff around the
    "Unsupported phi use of const or let variable", which is due to the
    fact that Crankshaft refuses to do hole checks (for a couple of
    reasons). So ideally we should not even try to send any lexically bound
    variables to fullcodegen+Crankshaft, but instead give them to Ignition
    and TurboFan.
    
    This CL only adds the appropriate check to the AstNumbering, but doesn't
    remove the functionality from fullcodegen/Crankshaft yet. This would be
    step two in case this CL sticks. If you see any major performance
    regressions with this CL in the range, just revert it and ping me.
    
    See Node.js issue https://github.com/nodejs/node/issues/9729 for
    additional information.
    
    BUG=v8:5666
    R=hablich@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
    
    Review-Url: https://codereview.chromium.org/2525243002
    Cr-Commit-Position: refs/heads/master@{#41445}
    5529430d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...