- 12 Nov, 2018 15 commits
-
-
Sathya Gunasekaran authored
... to OrderedNameDict Bug: v8:6443, v8:7569 Change-Id: Ic952c88e3256935391707032320913069020b045 Reviewed-on: https://chromium-review.googlesource.com/c/1329682Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57432}
-
Sathya Gunasekaran authored
Specialize FindEntry for OrderedNameDictionary Bug: v8:6443, v8:7569 Change-Id: I776415fde6bc2ea292b645fbca6952c7bb09d89d Reviewed-on: https://chromium-review.googlesource.com/c/1329962Reviewed-by:
-
Sathya Gunasekaran authored
This is the larger dictionary specialized for Name. To be used as a property backing store. More methods and tests will be added in the future as it reaches parity with NameDictionary. Bug: v8:6443, v8:7569 Change-Id: I8f5d88b2f6f4e14d4851548566ffa9f59535358b Reviewed-on: https://chromium-review.googlesource.com/c/1329204Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57430}
-
Clemens Hammacher authored
I just ran into this when creating a test case. The huge spread caused a RangeError (stack overflow). It's not causing problems for the tests we currently have, but let's fix it anyway. R=ahaas@chromium.org Change-Id: Ib67f059f2981ccc6239ba4ae05611e20eb3aa191 Reviewed-on: https://chromium-review.googlesource.com/c/1329177 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57429}
-
Clemens Hammacher authored
Fixes building in MSVS with -std:c++17 Refs: https://en.cppreference.com/w/cpp/utility/functional/unary_function Change-Id: Ibb05b6810cae029aae33957f3eb52cc3a9e4863e Reviewed-on: https://chromium-review.googlesource.com/c/1227322 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57428}
-
Toon Verwaest authored
Now that identifiers in the preparser also carry their string, we can simply check that rather than relying on a weird "keyword". Dropping __proto__ as a keyword allows us to delist '_' as keyword character. Change-Id: I775df25f77a84de92a60790ca665f16d52abf4bf Reviewed-on: https://chromium-review.googlesource.com/c/1329692 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57427}
-
Clemens Hammacher authored
gcc 4.8 fails to compile an {std::atomic::compare_exchange_strong} with {memory_order_acq_rel} with this error: error: invalid failure memory model for ‘__atomic_compare_exchange’ This makes our gcov bot fail: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20gcov%20coverage/16053 According to the documentation, giving a single {memory_order_acq_rel} is equivalent to specifying {memory_order_acq_rel} as success memory order and {memory_order_acquire} for failure. This CL refactors the code to do this explicitly. R=ulan@chromium.org CC=machenbach@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Change-Id: Idcc69ee4b4ac53edc4fd1aa28eac7377f08044ce Reviewed-on: https://chromium-review.googlesource.com/c/1329693Reviewed-by: -
Daniel Clifford authored
Change-Id: Ie7f3cec3ae6541f46b3f43c83bd9d53de7614d20 Reviewed-on: https://chromium-review.googlesource.com/c/1329689 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57425}
-
Toon Verwaest authored
Now that we have no more do-expressions, we don't need to reparent variables and declarations anymore. However, it's still possible that temporaries were implicitly allocated. We still need to move those. Bug: chromium:904255 Change-Id: Ia8a90eb822b9db123ffb0bad58e4b720c1452d9f Reviewed-on: https://chromium-review.googlesource.com/c/1329685Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57424}
-
Toon Verwaest authored
Otherwise we may look into the invalid string literal later. Bug: chromium:903527 Change-Id: Ieeb3807bd05e532224e04a59878f5dac24e19579 Reviewed-on: https://chromium-review.googlesource.com/c/1329691 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Georg Neis authored
A missing negation (typo in previous refactoring) had effectively disabled this optimization. Bug: chromium:904104 Change-Id: I3f8d26c7594fcaa762e0a9c992b4cb0bf1bc53f6 Reviewed-on: https://chromium-review.googlesource.com/c/1329690Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:904275 Change-Id: I82712f70954246c16846f44bb9e8dc6e60e73d83 Reviewed-on: https://chromium-review.googlesource.com/c/1329686Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:903874 Change-Id: If9828ae206b9bc1407e7d3f217d5fb894a4fe747 Reviewed-on: https://chromium-review.googlesource.com/c/1329688Reviewed-by:
-
Georg Neis authored
Split the Install methods into PrepareInstall and Install, such that all heap mutations (besides the actual installation) are done in PrepareInstall and only the actual installation in Install. This ensures that the code object in question doesn't get deoptimized while we're still installing its dependencies. Bug: chromium:903697 Change-Id: I4da97d89d0707fa3c00c97c092af0d0faa7a4946 Reviewed-on: https://chromium-review.googlesource.com/c/1329162Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57419}
-
Jakob Kummerow authored
By matching ZoneHandleSet's internals to Handle's internals, we can avoid a few unnecessary casts, and get rid of a few more occurrences of Object**. Bug: v8:3770 Change-Id: I24d6bad3a4959d977abf1f6b8db9be50bb2bc6d8 Reviewed-on: https://chromium-review.googlesource.com/c/1330907 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57418}
-
- 11 Nov, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5d50916..f2c3502 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/af0ede1..ddbeac1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie5eb9348ac4bec24bdd4b7c42cc64199ef55b90d Reviewed-on: https://chromium-review.googlesource.com/c/1330919Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57417}
-
- 10 Nov, 2018 3 commits
-
-
Sergiy Byelozyorov authored
This is needed so that cctest is built for the Memory perf benchmark. Marking v8_achive as testonly is necessary to be able to depend on the cctest, which is testonly already. R=machenbach@chromium.org Bug: chromium:903562 Change-Id: If5baf3e75226282110999dfa2bd83d475b63258c Reviewed-on: https://chromium-review.googlesource.com/c/1330912Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57416}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3f61809..81ffd00 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/93cd73d..af0ede1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4d9b172f6657d33629a021475290869f743c5482 Reviewed-on: https://chromium-review.googlesource.com/c/1330911 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Jakob Kummerow authored
as part of the ongoing quest to get rid of Object**/Object* entirely. Bug: v8:3770 Change-Id: Ibe05801fad78b26ca27b044c8091a26ccab5469a Reviewed-on: https://chromium-review.googlesource.com/c/1330909Reviewed-by:
-
- 09 Nov, 2018 21 commits
-
-
chrome://tracingDeepti Gandluri authored
Currently, the tracing for background tasks is quite cryptic when looking at chrome://tracing. Most tasks that are posted appear as ThreadControllerImpl::RunTask, which when looking at other threads can be deduced as compile tasks. Improve instrumentation to be more indicative of the work being done. BUG:v8:8423 Change-Id: I9b5469154ff7163d743efb1df998ca1df08cd4ce Reviewed-on: https://chromium-review.googlesource.com/c/1330012 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
tzik authored
This CL moves RunSingleMicrotask with no logic change as a non-essential part of the following CL, in order to reduce the following CL size. Change-Id: I93e4aa860710c169c0474ee28ada083139d2b607 Reviewed-on: https://chromium-review.googlesource.com/c/1328552 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
tzik authored
This CL moves EnqueueMicrotask and RunMicrotasks builtins out of InternalBuiltinAssembler to a separate class with no logic change. This is a trivial part of the following "Implement Faster MicrotaskQueue Step 2" https://crrev.com/c/1290751 in order to clean up the diff for easier review, and also for unblocking other CLs. Change-Id: I34dda8e599ffbf4db4bae07d3fd8ea3d6fadeb6b Reviewed-on: https://chromium-review.googlesource.com/c/1328548Reviewed-by:
-
Frank Tang authored
All intl/regress-8413-* tests are super slow on native arm: So remove them now. NOTRY=true Bug: v8:8435 Change-Id: I2d07ce00332d8323777f0a1aed5235b6f9c7f123 Reviewed-on: https://chromium-review.googlesource.com/c/1328645Reviewed-by:
-
Adam Klein authored
Now that intl.js is gone, there's no particular reason to worry about Intl features accidentally using RegExp objects in a way that would be visible to author code. Bug: v8:5751 Change-Id: I7bb274ed124ac593ab5f4f6995941f11a0ded480 Reviewed-on: https://chromium-review.googlesource.com/c/1325030Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57409}
-
Adam Klein authored
This test was adapted from a repro, and thus it's rather complex. It takes over seven minutes to run on the arm64 sim debug bot, and nearly five minutes on arm. Given that it was originally accompanied by a very targeted fix in Crankshaft, it strikes me that this probably isn't worth our CPU time to continue running. Bug: v8:7783, chromium:85177 Change-Id: Ibe85cc254aa754365404b5fbbf80bcb1f5a09c68 Reviewed-on: https://chromium-review.googlesource.com/c/1327188Reviewed-by:
-
Toon Verwaest authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I287197c8603e9e550d7f4832c1f85009136f4bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1329961 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The flag is on by default, so we don't need to specify it. More importantly, the tests are expected to work for any value of that flag. So don't force the flag but use whatever the test variant chooses. Note that in streaming-compile.js, the flag was accidentally specified as '-async-compilation'. I also removed that one. R=ahaas@chromium.org Change-Id: Ifad31160d266dda38cdd9dd1d73dad69bd2c2f2c Reviewed-on: https://chromium-review.googlesource.com/c/1325961Reviewed-by:
-
George Wort authored
Bug: v8:6600 Change-Id: I9ca4c52cec6fe6d6a88483072084dbd5a174a603 Reviewed-on: https://chromium-review.googlesource.com/c/1309755 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57405}
-
Clemens Hammacher authored
AtomicValue is deprecated, so we can start removing things that are not in use any more. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I0a1445eccaf89f8869fd56e0fbece809bbcd6e5e Reviewed-on: https://chromium-review.googlesource.com/c/1326464 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57404}
-
Clemens Hammacher authored
Implement similar functionality in the unit test which used this field. One test gets slightly weaker by this. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I0b047ff54f08a4549a2f78af30e21296bb1ee63f Reviewed-on: https://chromium-review.googlesource.com/c/1327042 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
For small strings there's not much of a difference, but allows faster scanning over long strings. By directly accessing the underlying buffer and by typically only needing 2 branches per non-special character. Change-Id: I9c2c513177d9bf5e3f10c14a07bf6ecc2872b2f0 Reviewed-on: https://chromium-review.googlesource.com/c/1329206 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Daniel Clifford authored
It sould take an exception argument to ensure the proper re-throw semantics. Change-Id: I36caba1a80c0d3f59c18dce5a58a0c1f0100657d Reviewed-on: https://chromium-review.googlesource.com/c/1328803 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I6da7a3cbf681a5ae691fe0aee2e69536a84f0df0 Reviewed-on: https://chromium-review.googlesource.com/c/1329174 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57400}
-
Mythri authored
After adding an explicit API to create code caches the compile options related to producing code caches are no longer supported. Parser caches are also no longer supported. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6eb5d7cf6b03437834eb1a1d326374f09fbce5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1238493 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Mythri authored
Bug: chromium:896326 Change-Id: I9257573963f611711edbc48a46a3bacbe12a567d Reviewed-on: https://chromium-review.googlesource.com/c/1305934Reviewed-by:
-
Clemens Hammacher authored
This extracts the lambda tasks to an own compilation unit and header file. Additionally, it addresses the TODO to avoid templates and just store the function to execute in an std::function. Third, it provides the same functionality for pure (non-cancellable non-idle) tasks. Last, it removes the "Lambda" part from the methods, because we can actually instantiate it with anything that is invocable (function pointer, lambda, functor, ...). R=ahaas@chromium.org Bug: v8:8238 Change-Id: I2f613f5b15ee208f215bbf74bd6d1d41889fd637 Reviewed-on: https://chromium-review.googlesource.com/c/1328923 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Also add the ability to skip tests only when --optimize-for-size is passed. TBR=sergiyb@chromium.org Bug: v8:7819 Change-Id: I1dcc26ea8664d014b6c50f0d636c13bf21e26ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1328945Reviewed-by:
-
Georg Neis authored
Primary change is the removal of a CheckValue that is unnecessary because we only care about the map and there's already a CheckMaps. Secondary change is a minor refactoring for clarity. Change-Id: I96abd1bc2b38919fd08daa1c688298f8807a0fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1326026Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 61d42c94. Switched to acquire/release memory order. Original change's description: > Use std::atomic in Cancelable > > Avoid deprecated base::AtomicValue, use std::atomic instead. > Plus minor drive-by cleanups. > > R=mstarzinger@chromium.org > > Bug: v8:8238 > Change-Id: I47a1f00e26a843b60380c50399eedc49d859830a > Reviewed-on: https://chromium-review.googlesource.com/c/1326463 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57386} Bug: v8:8238 Change-Id: I992a49d29af68cfa45bfae1bfb8dba5b47f94b25 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1329164 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Peter Marshall authored
There is a better maintained script in node-code-utils which properly bumps the version numbers for each of the LTS branches, which is more useful. Node collaborators also use this script, so it will make backports more uniform. Change-Id: If5449b8a801c4bd14f39d59b7af52cc959989be7 Reviewed-on: https://chromium-review.googlesource.com/c/1328927Reviewed-by:
-
