- 25 Jun, 2020 24 commits
-
-
Ng Zhi An authored
Prototype f64x2.ceil on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintp, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintp, which is the same instruction used for Float64RoundUp (scalar), wasm-compiler reuses the Float64RoundUp check. Bug: v8:10553 Change-Id: I5841c6a06f260debe8ae90d331bdcc2a0fa3278c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2258813Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68553}
-
Andreas Haas authored
This is a reland of f7a1932e There was a wpt test in Chrome that expected the incorrect behavior. I disable the test in https://crrev.com/c/2264418 so that we can land the fix here. Original change's description: > [wasm] Re-exported globals preserve their identity > > V8 fails a recently added spec test that when an imported global get > re-exported, it should preserve its identity. This CL fixes the behavior > in V8. > > Drive-by change: fix the object printer of globals: a global which > stores a reference type only has a tagged buffer, a global which stores > a value type only has an untagged buffer. > > R=clemensb@chromium.org > > Bug: v8:10556 > Change-Id: I949d147fe4395610cfec6cf60082e1faecb23036 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235702 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68513} Bug: v8:10556 Change-Id: I8e1b08fc9f72dde166cba167e6e320e714796769 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264097Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68552}
-
Thibaud Michaud authored
The current code for AssignRegisterOnReload starts the search at the first interval instead of relying on the cached {current_interval_}, which seems to be a main cause for slow compile time in the linked issue's test case. Moreover, it does not take into account live range holes of the current range. This change uses FirstIntersection instead which already handles both issues. Since inactive ranges are sorted by their next start, we can also break early from the loop. R=sigurds@chromium.org Bug: v8:10533 Change-Id: I454df95376011462ce22e850a1c143d523b68538 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2263152 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68551}
-
Ng Zhi An authored
This implements I32x4DotI16x8S for arm. Bug: v8:10583 Change-Id: I4541f4f5bc7daba03c6ab2040589893c8ef571bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230787Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bitmask requires wasm_simd_post_mvp because it was merged into SIMD proposal after 84 cut, which Origin Trial starts. For now, bitmask is the only instruction that requires this flag to be set, and no other post mvp instructions are included in the fuzzer. We should revert this change (and also move bitmask out of the flag) after this OT is over. Bug: chromium:1098666 Change-Id: I7d45c805aaa18bfc1a5180e70b912d5f17d4a31d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264628Reviewed-by:
-
Clemens Backes authored
Similar tests are already skipped on tsan, using the same bug to also skip this test. Note that it's a slightly different test, but based on the same "worker-ping-test.js". TBR=ahaas@chromium.org Bug: v8:9506 Change-Id: Ie8d0aab5b1fd3ae6c77a65fa04ac4772b2836a1c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267301Reviewed-by:
-
Clemens Backes authored
Add an experimental flag to allow modules up to a size slightly below 2GB, to make sure that we don't run into integer overflows. Modules this large are not tested at all currently, hence the explicit "experimental" in the flag name. Drive-by: Fix one comparison to use ">" instead of ">=". R=ahaas@chromium.org CC=bmeurer@chromium.org Bug: v8:10642 Change-Id: I91cfc290c262b9b81750e3c8af5358c1cd2572b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2266535Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68547}
-
Milad Farazmand authored
Port 2332ebd8 Original Commit Message: - Add a separate function to load return slots, instead of encoding this in the offset, - Add fast path for single return. R=thibaudm@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia302772478b58fd25ee53a18e6ee03ac4b2ea9f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267477Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68546}
-
Ulan Degenbaev authored
It will be used in a Finch experiment to evaluate if icache flushing helps with crashes on certain CPUs. Bug: chromium:889460 Change-Id: I1218ce93db001833e29fdeca8fde3e863e26dfdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267297Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68545}
-
Clemens Backes authored
The immediate itself is just the index, and the local type can easily be looked up in every environment where the immediate is used. Hence remove that field. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: If3176fa4880a75bdc475ec61dea60e08001220f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2266532 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Alex Turner authored
This retrieves script name directly from StackFrameBase, bypassing building of StackFrameInfo if one hasn't already been initialized, thus avoiding computation of expensive properties that are not required. This matches current behavior of GetScriptNameOrSourceURL() and is a workaround until a dedicated API is available. Bug: chromium:1098530 Change-Id: I181dc7feeebaf2f45758bbd29be24ab036e44b19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2261736Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#68543}
-
Andreas Haas authored
The BigInt proposal got to stage 4 and integrated into the main spec. Therefore the proposal tests are unnecessary and will be outdated soon. R=thibaudm@chromium.org Change-Id: I149de015f098a89333dd907bf5a4d18a36086c2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264095Reviewed-by:
-
Clemens Backes authored
Local type information was stored in the {WasmFullDecoder}, and a pointer to that vector was handed to {WasmDecoder}. Since {WasmFullDecoder} inherits from {WasmDecoder}, we can just move the vector to the {WasmDecoder} class, and save an indirection and an unnecessary nullptr check. Drive-by: Rename {GetLocalType} to {local_type}, since it's a simple accessor. Drive-by 2: Move fields of {WasmDecoder} to the end of the class, as mandated in the style guide. Drive-by 3: Rename some locals in the 'let' decoding to make the meaning more clear. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I6ab9831f0c1955e47562e84c5fbf15807439b024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264360Reviewed-by: -
Marja Hölttä authored
Design doc: https://docs.google.com/document/d/1BU-Zyco8YPP2Ra0Y3eVZ_BllzpUkJaJhmVmmnGD44Yc/edit#heading=h.mmdxlkic7kqd Bug: v8:10239 Change-Id: Ie1b953c8242e32a0447440aaae7c2ed377c97511 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259933 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68540}
-
Lutz Vahl authored
Change-Id: Ic302912d11ada06a1ce13668df85b9e582e651d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2266737Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/master@{#68539}
-
Jakob Gruber authored
... and extend JS node wrapper functionality. Node wrappers now have accessors for value inputs and context/control/effect/frame-state inputs. Accessors are typed, although types aren't very meaningful so far (in current examples we only distinguish between Object/HeapObject). The following node kinds now take an additional feedback vector input, and use the new node wrapper functionality above: - CloneObject - CreateLiteralArray - CreateLiteralObject - CreateLiteralRegExp - GetIterator - GetTemplateObject - HasProperty - LoadProperty - StoreProperty Bug: v8:8888 Change-Id: I1eb33c078b11725a72ec983bbaa848b9a3c7b0d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259936 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68538}
-
Maya Lekova authored
This reverts commit 2b6b85ab. Reason for revert: Broken Android builder https://cr-buildbucket.appspot.com/build/8876523558361397488 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2dc7c7a..876a780 > > Rolling v8/third_party/aemu-linux-x64: UoYLOT0X6577j70eB9nPqYQs9Z3Nh5lA4I-pRtTchO0C..YFi4RbbToiNVSl0eKxjhhhAElSEXx2Y9i-5Q4eBGkUwC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/95c1f42..761dfad > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/35c6274..87c8b91 > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/02daed1..93be846 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/42b285f..62d4c43 > > TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ia948991c7735b13585cf12a7ccfb0e372ab86320 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2266393 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#68536} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieea4f4fca222c053014bea68c4020ee27fa4a0d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264104Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68537}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2dc7c7a..876a780 Rolling v8/third_party/aemu-linux-x64: UoYLOT0X6577j70eB9nPqYQs9Z3Nh5lA4I-pRtTchO0C..YFi4RbbToiNVSl0eKxjhhhAElSEXx2Y9i-5Q4eBGkUwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/95c1f42..761dfad Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/35c6274..87c8b91 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/02daed1..93be846 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/42b285f..62d4c43 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia948991c7735b13585cf12a7ccfb0e372ab86320 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2266393Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68536}
-
Thibaud Michaud authored
- Add a separate function to load return slots, instead of encoding this in the offset, - Add fast path for single return. Drive-by: Reuse helper function for stack slot loads on ia32 and x64. R=clemensb@chromium.org Bug: v8:10576 Change-Id: Iea5ad2f0982c443cf2297227e9a2367cbb14581f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264099Reviewed-by:
-
Clemens Backes authored
This method was there to turn a trap into an exception. It's not used any more, so can be removed. R=ahaas@chromium.org Bug: v8:10389 Change-Id: I39bb3141722ddf1e09271348016c1d6f6d72b928 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264103Reviewed-by:
-
Clemens Backes authored
This removes several dead functions from the wasm-module-runner.cc. R=ahaas@chromium.org Change-Id: I35efbc6960a28f41d14ca5d8e828c4e6f2953409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264100Reviewed-by:
-
Mike Stanton authored
Currently the FeedbackVector uses arrays in slots that are polymorphic, usually in a <map, handler> tuple pattern. Helper functions try to re-use an existing array if it's already in place. For Concurrent TurboFan, it would be far better if these FixedArrays were immutable. We could then count on semantic correctness when harvesting their information from a background thread without locking. Additionally, the arrays should always be initialized fully before being set in place. Bug: v8:7790 Change-Id: I81eae3bda48c2d0d8eea41d1bc9c62afb7e619d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264364Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68532}
-
Peter Ralbovsky authored
Change-Id: Ia303e0384aee4f6998599fc9f04104517c51aa66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249663 Commit-Queue: Peter Ralbovsky <ralbovsky@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68531}
-
Jakob Kummerow authored
We can walk linear prototype chains using iteration instead of recursion, reducing the likelihood (though not excluding the possibility) that large prototype-relation graphs will run into a stack overflow. This partial mitigation should be performance neutral. Bug: v8:10522 Change-Id: Ia266efe38a9cc52fe6ab2189066f45c4566f3596 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245591Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68530}
-
- 24 Jun, 2020 16 commits
-
-
Shu-yu Guo authored
This is a reland of f0c9e932 TBR=machenbach@chromium.org Original change's description: > [test] Add is_cfi variable for test status files > > Bug: v8:10640 > Change-Id: Ifa485c285f345ca1ffba949feb8fc70b160a018c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264627 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68523} Bug: v8:10640 Change-Id: Iabf005127eea412b991f3f59d9e786f3c1eb7891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2265240 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
This reverts commit f7a1932e. Reason for revert: Breaking wasm wpt tests: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/5408 Original change's description: > [wasm] Re-exported globals preserve their identity > > V8 fails a recently added spec test that when an imported global get > re-exported, it should preserve its identity. This CL fixes the behavior > in V8. > > Drive-by change: fix the object printer of globals: a global which > stores a reference type only has a tagged buffer, a global which stores > a value type only has an untagged buffer. > > R=clemensb@chromium.org > > Bug: v8:10556 > Change-Id: I949d147fe4395610cfec6cf60082e1faecb23036 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235702 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68513} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I06eb1996cafe7d4e93a7e59d21679fea239cf961 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10556 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264956Reviewed-by:
-
Shu-yu Guo authored
This reverts commit f0c9e932. Reason for revert: Suspicion of breaking infra somehow Original change's description: > [test] Add is_cfi variable for test status files > > Bug: v8:10640 > Change-Id: Ifa485c285f345ca1ffba949feb8fc70b160a018c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264627 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68523} TBR=machenbach@chromium.org,syg@chromium.org Change-Id: I9a71ac443d64d2e8121f6a7ea52af833bb8add36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264953Reviewed-by:
-
Ng Zhi An authored
Prototype f32x4.nearest on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintn, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintn, which is the same instruction used for F32RoundTiesEven (scalar), wasm-compiler reuses the Float32RoundTiesEven check. Bug: v8:10553 Change-Id: I066b8c5f10fd86294afe1c530c516493deeb7b53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2258037Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ic55c1aeb2bceb72dff1338c4d9cbde9aa799f25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2262914 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I45a8f1398554da8a9543c866b4125fd9711e230b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2263933 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:10640 Change-Id: Ifa485c285f345ca1ffba949feb8fc70b160a018c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264627Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68523}
-
Manos Koukoutos authored
Some operations require an immediate argument that represents a heap type. This CL introduces a class to represent it and uses it where appropriate. Also, the redundant TypeIndexImmediate is removed. Bug: v8:7748 Change-Id: Ib4b1d50764a79f5dd3240688f8165c39745eaad8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260874 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
All error handling should be marked V8_UNLIKELY, because this is never on the hot path. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8bc996e96a2e90f21ec065fbce4656d311097f74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2263153Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I50e94888340601febcede6be9899ca1ffaaed5a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264358 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I1c0275401671bb85d92afd2910618a0a345c26c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210233 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:10619 Change-Id: I9097e203404ca36301a08665a7383c9585301a67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264359 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I5050d58d9601214e88bb88b24502f288de0b7be8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264357Reviewed-by:
-
Dan Elphick authored
Fix returning from TryAllocateLinearlyAligned without updating the allocation stats if a preceding filler was required. Also makes AllocateRaw take an int instead of size_t in line with other Spaces. Bug: v8:8875, chromium:1097389 Change-Id: If0932caa94dce1cd45b41f44fa225a2007772ea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264354 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Backes authored
Move more logic into the {TraceLine} class. In release builds, this class will not do anything. Since there is no code after the switch in {DecodeOp} any more after this CL, we can apply tail-call optimization (via explicit returns in C++), which will save an additional call in some cases. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: Ie11ec550ab33d0c03a27375f34576e3a75dcf6ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254021Reviewed-by: -
Clemens Backes authored
Every condition which can only fail on invalid wire bytes should be wrapped in the VALIDATE macro. This way, it will automatically be skipped if {validate} is false, and we will automatically add V8_LIKELY annotations to the branches. Also, consistently use the style if (!VALIDATE(condition)) { ... handle error ... } ... continue ... Drive-by: Remove unnecessary OPCODE_ERROR macro. Drive-by 2: Replace unreachable code (after a switch) by UNREACHABLE. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I9b592bd4abde80d86e72c63739d77b4814dc96de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2262917Reviewed-by:
-
