• Clemens Backes's avatar
    [wasm] Use VALIDATE macro consistently · 5ce53d36
    Clemens Backes authored
    Every condition which can only fail on invalid wire bytes should be
    wrapped in the VALIDATE macro. This way, it will automatically be
    skipped if {validate} is false, and we will automatically add V8_LIKELY
    annotations to the branches.
    
    Also, consistently use the style
    if (!VALIDATE(condition)) {
      ... handle error ...
    }
    ... continue ...
    
    Drive-by: Remove unnecessary OPCODE_ERROR macro.
    Drive-by 2: Replace unreachable code (after a switch) by UNREACHABLE.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: I9b592bd4abde80d86e72c63739d77b4814dc96de
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2262917Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68514}
    5ce53d36
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...