- 16 Oct, 2017 40 commits
-
-
Jakob Kummerow authored
This supports {valueOf() { return BigInt(...) }} objects as operands in binary and unary operations. Bug: v8:6791 Change-Id: I30ec9983ff611477742f9ea0bc6d04972fe21d3c Reviewed-on: https://chromium-review.googlesource.com/716863 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#48612}
-
Adam Klein authored
We can use member initializers instead of the OTHER_CONSTANTS macro to handle the declaration of oddball AstValue members in AstValueFactory. Bug: v8:6921 Change-Id: I701e2fd36f854cfc0d835981d060622070b5bfba Reviewed-on: https://chromium-review.googlesource.com/719395Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48611}
-
Junliang Yan authored
This is a reland of af49af00 Original change's description: > PPC/s390: Fix arguement handling > > 1. in AssembleMove and AssembleSwap, we need to distinguish Double and Float > 2. in 32-bit mode, double needs to be counted as 2 slots in stack > > R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com, mmallick@ca.ibm.com > > Bug: > Change-Id: Iffe1844aa72e9d4c9492034c3df9a994e1304a27 > Reviewed-on: https://chromium-review.googlesource.com/720676 > Reviewed-by: Joran Siu <joransiu@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#48593} Change-Id: If91125e71b82c92f54f537345e4c213bd185e786 Reviewed-on: https://chromium-review.googlesource.com/721419Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#48610}
-
Ben Smith authored
This is only enabled when --experimental-wasm-threads is enabled. In addition, only shared WebAssembly.Memory may be sent, as specified here: https://github.com/WebAssembly/design/pull/1074/files#diff-8e85308ab5cc1e83e91ef59233648be2R227 Bug: v8:6895 Change-Id: Id009a7f890d15fa6c98e93f03806f7e7eff30c2a Reviewed-on: https://chromium-review.googlesource.com/719417 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#48609}
-
Benedikt Meurer authored
Port the baseline version of Reflect.has to the CodeStubAssembler and reuse the existing logic for HasProperty (i.e. the HasProperty builtin). Also inline the Reflect.has builtin into TurboFan, by adding a check on the target in front of a use of the JSHasProperty operator. Technically this additional check is not necessary, because the JSHasProperty operator already throws if the target is not a JSReceiver, but the exception message is confusing then. This improves the performance of the micro-benchmark from reflectHasPresent: 337 ms. reflectHasAbsent: 472 ms. to reflectHasPresent: 121 ms. reflectHasAbsent: 216 ms. which is a nice 2.8x improvement in the best case. It also improves the chai test on the web-tooling-benchmark by around 1-2%, which is roughly the expected win (since Reflect.has overall accounts for around 3-4%). Bug: v8:5996, v8:6936, v8:6937 Change-Id: I856183229677a71c19936f06f2a4fc7a794a9a4a Reviewed-on: https://chromium-review.googlesource.com/720959 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48608}
-
Andreas Haas authored
Calls like read_leb<int32_t, true, true, true>(...) can be hard to read and understand. This CL replaces the three boolean template parameters with enums so that the call is read_leb<int32_t, kChecked, kAdvancePC, kTrace>(...) now. R=clemensh@chromium.org Bug: v8:6921 Change-Id: Id876a727d5e17df721444e7e5a117ad5395071aa Reviewed-on: https://chromium-review.googlesource.com/718204 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48607}
-
Ali Ijaz Sheikh authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/715118. The UI doesn't allow me to reland this automatically due to merge conflicts so I ended up doing this manually. Change-Id: Ic013b61f459cb1e91e24203fb31ae7c14f3754f8 Reviewed-on: https://chromium-review.googlesource.com/720136Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#48606}
-
Jakob Gruber authored
This is a reland of 56da97bb Original change's description: > [snapshot] Ship lazy TFJ builtins > > Design doc: goo.gl/dxkYDZ > > Bug: v8:6624 > Change-Id: I8813f79e415843ffe8d33a605a2662dbfc0c9764 > Reviewed-on: https://chromium-review.googlesource.com/674883 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48590} TBR=yangguo@chromium.org,hablich@chromium.org Bug: v8:6624, v8:6942 Change-Id: I1af6b0982f7e129127f2714c27a74b7e39207065 Reviewed-on: https://chromium-review.googlesource.com/721179 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48605}
-
Andreas Haas authored
By using 64-bit comparison we make sure that there will be no out of memory accesses even if there are stale values in the high word of a register. R=titzer@chromium.org Change-Id: I2627b15e1598f35cc480d7028031e8de405164ea Reviewed-on: https://chromium-review.googlesource.com/721323Reviewed-by:
-
Michael Lippautz authored
Pause sweeper tasks when entering the Scavenger. In future CLs this enables removing the page lock for the Scavenger. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_tsan_rel;master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: v8:6923, chromium:774108 Change-Id: Idcb7e14b94704dead70c33a49e67047b88bb6c4c Reviewed-on: https://chromium-review.googlesource.com/718200 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48603}
-
Clemens Hammacher authored
Instead of modifying this flag in compiled wasm code, we can just change it in the caller / called code. This saves code space and compilation time and fixes the referenced bug. R=titzer@chromium.org, eholk@chromium.org Bug: chromium:773631, v8:5277 Change-Id: I095158ac01eecd21a92649a3990e8d7c593db912 Reviewed-on: https://chromium-review.googlesource.com/712597Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48602}
-
Junliang Yan authored
R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com Bug: Change-Id: I30c5bba9380d71d1ea2fc0391aa90adca9330eb2 Reviewed-on: https://chromium-review.googlesource.com/721339Reviewed-by:
-
Junliang Yan authored
This reverts commit af49af00. Reason for revert: <INSERT REASONING HERE> There is a mistake in codegen to cause error in snapshot. Original change's description: > PPC/s390: Fix arguement handling > > 1. in AssembleMove and AssembleSwap, we need to distinguish Double and Float > 2. in 32-bit mode, double needs to be counted as 2 slots in stack > > R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com, mmallick@ca.ibm.com > > Bug: > Change-Id: Iffe1844aa72e9d4c9492034c3df9a994e1304a27 > Reviewed-on: https://chromium-review.googlesource.com/720676 > Reviewed-by: Joran Siu <joransiu@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#48593} TBR=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,joransiu@ca.ibm.com,jbarboza@ca.ibm.com,mmallick@ca.ibm.com Change-Id: I76b7eb96e7bfc15e3d2b07474543e996b9ea5f86 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/721140Reviewed-by:
-
Georg Neis authored
R=bmeurer@chromium.org, jarin@chromium.org Bug: v8:6941 Change-Id: Ic1062e1c5f181ab5041fb7b7cb1487683a36c300 Reviewed-on: https://chromium-review.googlesource.com/721020 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ife79f1d3c60f591c00bb1ecd340a9f1b31b02039 Reviewed-on: https://chromium-review.googlesource.com/720808Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48598}
-
Michael Achenbach authored
NOTRY=true TBR=titzer@chromium.org Bug: chromium:775027 Change-Id: I0bd4a55e3530e1e2f26bbe416587f1421f6cdbae Reviewed-on: https://chromium-review.googlesource.com/721180Reviewed-by:
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=marja@chromium.org Bug: v8:6837, v8:6921 Change-Id: I17cf5cbbac3d2992c3b3588cc66e8564982453b6 Reviewed-on: https://chromium-review.googlesource.com/681355Reviewed-by: -
peterwmwong authored
- Extract core StringPrototypeRepeat code into a TFS builtin (StringRepeat) - Assumes arguments are a string and smi (no range checks) - Add StringPrototypePadStart and StringPrototypePadEnd TFJ builtins - Added StringPadAssembler to ensure common behavior - Removed functionality from string.js A quick benchmark shows significant performance gains for unoptimized code (2.1x to 2.46x) and optimized code (1.03x - 1.56x). https: //github.com/peterwmwong/v8-perf/blob/master/string-pad/README.md Bug: v8:5049 Change-Id: I6e4fe99fb62a3edb3d6906fd4f78b3576b5b0d13 Reviewed-on: https://chromium-review.googlesource.com/720067 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837, v8:6921 Change-Id: I0c2deaea3f2ff5b5b25ba658470850534f1900ac Reviewed-on: https://chromium-review.googlesource.com/681435 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48594}
-
Junliang Yan authored
1. in AssembleMove and AssembleSwap, we need to distinguish Double and Float 2. in 32-bit mode, double needs to be counted as 2 slots in stack R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com, mmallick@ca.ibm.com Bug: Change-Id: Iffe1844aa72e9d4c9492034c3df9a994e1304a27 Reviewed-on: https://chromium-review.googlesource.com/720676Reviewed-by:
-
Marja Hölttä authored
When skipping inner funcs is enabled, we also track variables for top level funcs. Thus, we also declared the function name for the function scope, even though it was the function scope for a function whose preparsing was aborted. This lead into declaring the function name twice. The fix is to declare the function name only in the success case. The code was "wrong" before too, but this was never a problem, since variable tracking and aborting preparsing were enabled for disjoint sets of functions (aborting preparsing only for top-level, and variable tracking for non-top-level). BUG=v8:5516,chromium:774475 Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09 Reviewed-on: https://chromium-review.googlesource.com/720920Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48592}
-
Michael Achenbach authored
This reverts commit 56da97bb. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/15579 Original change's description: > [snapshot] Ship lazy TFJ builtins > > Design doc: goo.gl/dxkYDZ > > Bug: v8:6624 > Change-Id: I8813f79e415843ffe8d33a605a2662dbfc0c9764 > Reviewed-on: https://chromium-review.googlesource.com/674883 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48590} TBR=yangguo@chromium.org,hablich@chromium.org,jgruber@chromium.org Change-Id: I5513d2d20444a95937465ab86df295b031849f99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6624 Reviewed-on: https://chromium-review.googlesource.com/721079Reviewed-by:
-
Jakob Gruber authored
Design doc: goo.gl/dxkYDZ Bug: v8:6624 Change-Id: I8813f79e415843ffe8d33a605a2662dbfc0c9764 Reviewed-on: https://chromium-review.googlesource.com/674883Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48590}
-
Ben L. Titzer authored
This is needed for proper deserialization of code and has the nice side effect of fixing the nasty race condition that led us to introducing a lock on the signature map. R=mtrofin@chromium.org CC=clemensh@chromium.org Bug: Change-Id: I6a018344ad8b58b088b20756d3b00ae08232bbb9 Reviewed-on: https://chromium-review.googlesource.com/718937 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48589}
-
Ivica Bogosavljevic authored
MachineOperatorBuilder was instantiated with default parameters and this caused unaligned memory access errors. Bug: Change-Id: Id95d074b2641ba4f002171b5c2990a520879f490 Reviewed-on: https://chromium-review.googlesource.com/720812Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#48588}
-
Leszek Swirski authored
Bug: v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3294568a550b829b0ec90147a4cdaefe169bb7cb Reviewed-on: https://chromium-review.googlesource.com/718206Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This comment was left over in https://codereview.chromium.org/2601043002. R=machenbach@chromium.org NOTRY=true Bug: v8:6921 Change-Id: I5182fc624129948172ce436dc9b04c6fcd299d18 Reviewed-on: https://chromium-review.googlesource.com/720924Reviewed-by:
-
Clemens Hammacher authored
The readability/streams category is gone since https://codereview.chromium.org/777533005. R=machenbach@chromium.org Bug: v8:6921 Change-Id: If0e0f978275ad20278ccedcdd607c31ae30d3133 Reviewed-on: https://chromium-review.googlesource.com/720925Reviewed-by:
-
Ben L. Titzer authored
With the introduction of the WasmContext, compiled code is no longer specialized to the memory start and size (or recently, globals_start). This CL uses the same WasmContext between the interpreter and compiled code, removing the need for UpdateMemory() and cached instance info. R=clemensh@chromium.org Bug: Change-Id: I0bd52352c9b6f3029246e94e239dc29f635e7920 Reviewed-on: https://chromium-review.googlesource.com/712734 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Also fix asan environment for testing on windows. TBR=sergiyb@chromium.org Bug: chromium:726584 Change-Id: Ic9e6afa714f4757ad1b0f2ebfa742e742e1c04b9 Reviewed-on: https://chromium-review.googlesource.com/720811 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Lippautz authored
With parallel marking enabled, both visitors have to be equal wrt. to actual visitation. The differences are captured by template parameters: - Retaining path tracing which we only do for full GCs. - Incremental marking of FixedArray. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_tsan_rel;master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:694255, chromium:750084 Change-Id: I177aeb0ee4f6a35e2f592ba257c9ddc14f88fd99 Reviewed-on: https://chromium-review.googlesource.com/704935 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This CL removes the code specialization for WASM functions that access globals. Previously, we were embedding the start address of the globals memory (globals_start) as a constant in the code, which required patching for every instance. We now put this base in to the WasmContext, which is available as a parameter to every WasmFunction. R=ahaas@chromium.org, CC=mtrofin@chromium.org Bug: Change-Id: I04bb739e898cc5a3b7dd081cc166483022d113fd Reviewed-on: https://chromium-review.googlesource.com/712595 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#48581}
-
Mike Stanton authored
They can be...eliminated. Bug: Change-Id: I234dddfb059fa15daf09c2095f1ea1813aa8428f Reviewed-on: https://chromium-review.googlesource.com/720802Reviewed-by:
-
Mike Stanton authored
In Array.prototype.map, we have to store the map result in an output array. If we know we are storing objects, or special objects like boolean, rather than a number, then we can reduce the amount of checks we have to do to transition the output array to the appropriate ElementsKind. Likewise, if we know we've got floating point values, we can specialize appropriately to a double array. Bug: v8:6896 Change-Id: I375daf604562b53638ea749945c1a4c907e33547 Reviewed-on: https://chromium-review.googlesource.com/711845 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Mathias Bynens authored
This patch introduces assertPromiseFulfills and assertPromiseFulfills as a replacement for assertPromiseResult because it’s more JavaScript-y. BUG=v8:6921 R=ahaas@chromium.org Also-By: ahaas@chromium.org Change-Id: I2f865dba3992ddf3b58987bf0b376d143edb5c31 Reviewed-on: https://chromium-review.googlesource.com/718746 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Achenbach authored
ASAN compilation expects a blacklist file. NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:726584 Change-Id: I1755dc20d3e91f9b15f15e0d34886a4fb03d97c1 Reviewed-on: https://chromium-review.googlesource.com/720804Reviewed-by:
-
Michael Achenbach authored
Win asan needs separate "clang" config as clang is not the default on windows. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:726584 Change-Id: Ic49eedf9a229eb3f81774c8d03c9d19ba1211c3d Reviewed-on: https://chromium-review.googlesource.com/720801Reviewed-by:
-
Michael Achenbach authored
V8 side for: https://chromium-review.googlesource.com/c/chromium/tools/build/+/720373 TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: chromium:726584 Change-Id: I240be307c1072a2fce354b4eda8a60e1c65b1607 Reviewed-on: https://chromium-review.googlesource.com/720796 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
When looking at /proc/self/maps, we need to take into account the offset in addition to the start and end addresses, otherwise --prof get's confused with binaries produced by lld. Change-Id: If6b484a8080a0393e91174c114dafe9a11964e8d Reviewed-on: https://chromium-review.googlesource.com/720371Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: v8:6918 Change-Id: I16d44acd8c5cf57d472e4e8ffebf08b3d316441c Reviewed-on: https://chromium-review.googlesource.com/720370Reviewed-by:
-
