• Marja Hölttä's avatar
    [parser] Skipping inner funcs: fix related to aborting preparsing. · d69159d5
    Marja Hölttä authored
    When skipping inner funcs is enabled, we also track variables for top level
    funcs. Thus, we also declared the function name for the function scope, even
    though it was the function scope for a function whose preparsing was
    aborted. This lead into declaring the function name twice.
    
    The fix is to declare the function name only in the success case.
    
    The code was "wrong" before too, but this was never a problem, since variable
    tracking and aborting preparsing were enabled for disjoint sets of
    functions (aborting preparsing only for top-level, and variable tracking for
    non-top-level).
    
    BUG=v8:5516,chromium:774475
    
    Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09
    Reviewed-on: https://chromium-review.googlesource.com/720920Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48592}
    d69159d5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...