1. 30 Jun, 2020 1 commit
  2. 05 Jun, 2020 1 commit
    • Yu Yin's avatar
      [mips] Correct function assembler::db/dd/dq · 5ecff4fe
      Yu Yin authored
      All these functions need to do is just write the value to the memory,
      but EmitHelper will do something more than this, EmitHelper will check
      if it need generate trampoline code while code generating and it will
      insert trampoline code at current pc offset, this means there maybe have
      trampoline code between two consecutive dd()'s target memory(pc), this
      is not we want.
      
      Change-Id: I5537f133be78aabdc4d53d4de07f388fa50f4a64
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224963
      Commit-Queue: Yu Yin <xwafish@gmail.com>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68188}
      5ecff4fe
  3. 16 Sep, 2019 1 commit
  4. 11 Sep, 2019 1 commit
  5. 10 Sep, 2019 1 commit
  6. 09 Sep, 2019 1 commit
  7. 12 Jul, 2019 1 commit
  8. 11 Jul, 2019 1 commit
  9. 28 May, 2019 1 commit
  10. 21 May, 2019 1 commit
  11. 20 May, 2019 3 commits
  12. 06 May, 2019 1 commit
  13. 30 Apr, 2019 1 commit
  14. 12 Mar, 2019 1 commit
  15. 04 Mar, 2019 1 commit
  16. 07 Feb, 2019 1 commit
  17. 30 Jan, 2019 1 commit
  18. 16 Jan, 2019 1 commit
    • Clemens Hammacher's avatar
      [assembler] Allow to pass custom buffer implementations · 1a3aab51
      Clemens Hammacher authored
      When generating an Assembler, you currently have two choices: Either
      let the Assembler allocate a growable internal buffer, which is owned
      by the Assembler. Or provide an externally allocated buffer, which
      cannot grow.
      This CL changes this interface to allow providing any implementation of
      a buffer. The provided buffer can be a view to an externally owned
      buffer, which still can grow.
      This will be used to split WebAssembly compilation and code submission.
      The buffer needs to be able to grow, but cannot be owned by the
      Assembler because it has to survive until the code is submitted.
      
      R=mstarzinger@chromium.org
      
      Bug: v8:8689
      Change-Id: Ib6c5ebffc8b71d0778944abac34f02c5cc7dbd79
      Reviewed-on: https://chromium-review.googlesource.com/c/1411347
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58848}
      1a3aab51
  19. 09 Jan, 2019 1 commit
    • Predrag Rudic's avatar
      MIPS[64]: Port '[Deopt] Remove jump table in prologue of deopt entries.' · b0dc60f6
      Predrag Rudic authored
      Port commit 4ab96a9a
      
      Original message:
      > Remove the use of a jump table in the prologue of the deopt entries
      > and instead pass the bailout id explicitly in a register when calling
      > the deopt entry routine from optimized code. This unifies the logic
      > with the way the Arm64 code works. It saves the following amount of
      > memory in code stubs:
      >
      >  - arm:  384KB
      >  - ia32: 480KB
      >  - x64:  240KB
      >
      > This could be offset by a slight increase in the size of optimized code
      > for loading the immediate, however this impact should be minimal and
      > will scale with the maximum number of bailout ids (e.g., the size of
      > code will increase by one instruction per bailout id on Arm, therefore
      > ~98,000 bailouts will be needed before the overhead is greater than
      > the current fixed table size).
      >
      > Change-Id: I838604b48fa04cbd45320c7b9dac0de08fd8eb25
      > Reviewed-on: https://chromium-review.googlesource.com/c/1398224
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58636}
      
      Change-Id: I4d070b90ebd4f9d4e82eaa74fe6d41c3a39d93e8
      Reviewed-on: https://chromium-review.googlesource.com/c/1400848Reviewed-by: 's avatarSreten Kovacevic <skovacevic@wavecomp.com>
      Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com>
      Cr-Commit-Position: refs/heads/master@{#58655}
      b0dc60f6
  20. 20 Dec, 2018 1 commit
  21. 17 Dec, 2018 1 commit
  22. 13 Dec, 2018 3 commits
    • Sigurd Schneider's avatar
      Reland "Reland "Reland "[code-comments] Put code comments into the code object""" · b55dd17f
      Sigurd Schneider authored
      This is a reland of 9c0a4858
      
      Original change's description:
      > Reland "Reland "[code-comments] Put code comments into the code object""
      >
      > This is a reland of ed3d6472
      >
      > This reland fixes that padding at the end of Wasm instruction streams
      > triggered asserts in the code printer.
      >
      > Original change's description:
      > > Reland "[code-comments] Put code comments into the code object"
      > >
      > > This is a reland of e774cffe
      > >
      > > This reland disables a test as v8:8548 is blocking it, which was
      > > broken by a recent CL. CQ did not catch this because the merge-base
      > > CQ used did not yet contain the CL that caused v8:8548.
      > >
      > > Original change's description:
      > > > [code-comments] Put code comments into the code object
      > > >
      > > > Code comments in the snapshot can now be enabled with gn
      > > > arg 'v8_enable_snapshot_code_comments'
      > > >
      > > > Bug: v8:7989
      > > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173
      > > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#58020}
      > >
      > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org
      > >
      > > Bug: v8:7989, v8:8548
      > > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1361166
      > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#58028}
      >
      > Bug: v8:7989, v8:8548
      > Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d
      > Reviewed-on: https://chromium-review.googlesource.com/c/1371784
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58221}
      
      TBR=jgruber@chromium.org,mstarzinger@chromium.org
      
      Bug: v8:7989, v8:8548, v8:8593
      Change-Id: I4f7ffc98e0281c7b744eb4a04ba0763896c7b59b
      Reviewed-on: https://chromium-review.googlesource.com/c/1375919Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58232}
      b55dd17f
    • Clemens Hammacher's avatar
      Revert "Reland "Reland "[code-comments] Put code comments into the code object""" · 8a5c0095
      Clemens Hammacher authored
      This reverts commit 9c0a4858.
      
      Reason for revert: Seems to break nosnap debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/22228
      
      Original change's description:
      > Reland "Reland "[code-comments] Put code comments into the code object""
      > 
      > This is a reland of ed3d6472
      > 
      > This reland fixes that padding at the end of Wasm instruction streams
      > triggered asserts in the code printer.
      > 
      > Original change's description:
      > > Reland "[code-comments] Put code comments into the code object"
      > >
      > > This is a reland of e774cffe
      > >
      > > This reland disables a test as v8:8548 is blocking it, which was
      > > broken by a recent CL. CQ did not catch this because the merge-base
      > > CQ used did not yet contain the CL that caused v8:8548.
      > >
      > > Original change's description:
      > > > [code-comments] Put code comments into the code object
      > > >
      > > > Code comments in the snapshot can now be enabled with gn
      > > > arg 'v8_enable_snapshot_code_comments'
      > > >
      > > > Bug: v8:7989
      > > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173
      > > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#58020}
      > >
      > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org
      > >
      > > Bug: v8:7989, v8:8548
      > > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1361166
      > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#58028}
      > 
      > Bug: v8:7989, v8:8548
      > Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d
      > Reviewed-on: https://chromium-review.googlesource.com/c/1371784
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58221}
      
      TBR=mvstanton@chromium.org,mstarzinger@chromium.org,sigurds@chromium.org,jgruber@chromium.org
      
      Change-Id: I681a3c63120c6ab953bfe9cd2b07bcf560ebfdee
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7989, v8:8548
      Reviewed-on: https://chromium-review.googlesource.com/c/1375916
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58228}
      8a5c0095
    • Sigurd Schneider's avatar
      Reland "Reland "[code-comments] Put code comments into the code object"" · 9c0a4858
      Sigurd Schneider authored
      This is a reland of ed3d6472
      
      This reland fixes that padding at the end of Wasm instruction streams
      triggered asserts in the code printer.
      
      Original change's description:
      > Reland "[code-comments] Put code comments into the code object"
      >
      > This is a reland of e774cffe
      >
      > This reland disables a test as v8:8548 is blocking it, which was
      > broken by a recent CL. CQ did not catch this because the merge-base
      > CQ used did not yet contain the CL that caused v8:8548.
      >
      > Original change's description:
      > > [code-comments] Put code comments into the code object
      > >
      > > Code comments in the snapshot can now be enabled with gn
      > > arg 'v8_enable_snapshot_code_comments'
      > >
      > > Bug: v8:7989
      > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173
      > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#58020}
      >
      > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org
      >
      > Bug: v8:7989, v8:8548
      > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9
      > Reviewed-on: https://chromium-review.googlesource.com/c/1361166
      > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58028}
      
      Bug: v8:7989, v8:8548
      Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d
      Reviewed-on: https://chromium-review.googlesource.com/c/1371784
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58221}
      9c0a4858
  23. 07 Dec, 2018 3 commits
  24. 04 Dec, 2018 4 commits
  25. 14 Nov, 2018 1 commit
  26. 12 Nov, 2018 1 commit
  27. 05 Nov, 2018 1 commit
  28. 02 Nov, 2018 1 commit
  29. 17 Oct, 2018 1 commit
  30. 15 Oct, 2018 1 commit
    • Predrag Rudic's avatar
      MIPS: Port [turbofan] Use relative calls/jumps on arm for builtins · a1974d49
      Predrag Rudic authored
      Port commit 23dbb81d.
      
      Original CL message:
      
      >This CL uses pc-relative jumps and calls (B/BL) for calls from embedded
      >builtins to embedded builtins. To make this work, the code range size is
      >limited to 32MB on arm during mksnapshot, which ensures that all builtin
      >to builtin offsets for jumps/calls fit into the B/BL immediate. At code
      >generation time, we put a placeholder into the instruction offset which
      >we resolve to the right code object when the code is copied to the heap.
      >We use a new relocation mode RELATIVE_CODE_TARGET for these relative jumps.
      >The relocation mode RELATIVE_CODE_TARGET should never appear after
      >generating the snapshot.
      >
      >We modify the target_address/set_target_address methods of RelocInfo
      >such that they return the absolute target addresses for pc-relative B/BL
      >instructions. This ensures that the GC can treat RELATIVE_CODE_TARGET in
      >the same way as code targets. This, however, only matters during
      >snapshot creation time, and production code never contains
      >RELATIVE_CODE_TARGET relocations.
      >
      >Bug: v8:6666
      >Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      >Change-Id: If7eab83ad588859ca87c654a5ddc3e37caea884c
      >Reviewed-on: https://chromium-review.googlesource.com/1117181
      >Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      >Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      >Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      >Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      >Cr-Commit-Position: refs/heads/master@{#54320}
      
      This CL is completed Miran's draft without MIPS64 port.
      (https://chromium-review.googlesource.com/c/v8/v8/+/1136640/3).
      
      Change-Id: I979378ac445548641755968d890f7f4a82dc7986
      Reviewed-on: https://chromium-review.googlesource.com/c/1221313
      Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarIvica Bogosavljevic <ibogosavljevic@wavecomp.com>
      Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56640}
      a1974d49
  31. 04 Oct, 2018 1 commit