- 03 Jun, 2020 1 commit
-
-
Frank Tang authored
The fix is in 630b884f84 not f2223961. This reverts commit 464ee4b7. Reason for revert: roll to 67.1 after the landing of the fix Original change's description: > Revert "Roll ICU from 65.1 to 67.1 (f2223961) & correct tests" > > This reverts commit e270b6d6. > > Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1 > > Original change's description: > > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests > > > > Rolling to chrome/src is in > > https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > > > Since auto rolling stop after 3/24/2020 and the rolling will cause > > change of test status, I get this cl ready (but not running trybot due > > to 1074260) and plan to hand roll after the submission of 2155530. > > > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486 > > Auto-Submit: Frank Tang <ftang@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67493} > > TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68051} TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,zhin@chromium.org,ftang@chromium.org,syg@chromium.org # Not skipping CQ checks because this is a reland. Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 Change-Id: I1de5eb36eff420482a12205682b153a2493d5249 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220781Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68160}
-
- 28 May, 2020 1 commit
-
-
Ng Zhi An authored
This reverts commit e270b6d6. Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1 Original change's description: > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests > > Rolling to chrome/src is in > https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > Since auto rolling stop after 3/24/2020 and the rolling will cause > change of test status, I get this cl ready (but not running trybot due > to 1074260) and plan to hand roll after the submission of 2155530. > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486 > Auto-Submit: Frank Tang <ftang@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67493} TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68051}
-
- 30 Apr, 2020 1 commit
-
-
Frank Tang authored
Rolling to chrome/src is in https://chromium-review.googlesource.com/c/chromium/src/+/2155530 Since auto rolling stop after 3/24/2020 and the rolling will cause change of test status, I get this cl ready (but not running trybot due to 1074260) and plan to hand roll after the submission of 2155530. Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486 Auto-Submit: Frank Tang <ftang@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67493}
-
- 11 May, 2019 1 commit
-
-
Frank Tang authored
harmony-locale is shipped in m74 and m74 is already out. Remove harmony-locale flag from the code. Bug: v8:8910 Change-Id: If9634b6767cfe449cfa03980bbad26ceb7408c79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592465 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61429}
-
- 03 Jan, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:7684 Change-Id: Ibe7db0ef1baacb33d07a45234e6bda4f69e95643 Reviewed-on: https://chromium-review.googlesource.com/c/1381732 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58511}
-
- 08 Aug, 2018 1 commit
-
-
Sathya Gunasekaran authored
Also, fix one spec violation that checked for Name, but should just check for Strings. Bug: v8:8032, v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib9ffa48b86b4da6e881eeec4eb24ec623345aae4 Reviewed-on: https://chromium-review.googlesource.com/1167042Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54987}
-
- 13 Jun, 2018 1 commit
-
-
Nebojsa Ciric authored
- Test that order of getter initialization doesn't change. - Test properties of each getter against the spec. Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I85d0d80947e55233f10f62f96fe33d4281db4315 Reviewed-on: https://chromium-review.googlesource.com/1083879 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53721}
-
- 01 Jun, 2018 1 commit
-
-
Nebojsa Ciric authored
Change code to propagate errors/exceptions to the top, and throw only once. Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9a2d15cc4931f5bf029d2a8d78ad86e61f8db452 Reviewed-on: https://chromium-review.googlesource.com/1066808 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53476}
-
- 15 May, 2018 1 commit
-
-
Nebojsa Ciric authored
https://github.com/tc39/proposal-intl-locale Rename locale property to baseName to better reflect the intented use case and the change in spec. TBR: bmeurer@chromium.org Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I91b630b49ce73abcebd6040ec968c91d75cff879 Reviewed-on: https://chromium-review.googlesource.com/1014411 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53193}
-