[Intl] Throw when language tag argument to Intl.Locale is empty

Also, fix one spec violation that checked for Name, but should just
check for Strings.

Bug: v8:8032, v8:7684
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Ib9ffa48b86b4da6e881eeec4eb24ec623345aae4
Reviewed-on: https://chromium-review.googlesource.com/1167042Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54987}

src/builtins/builtins-intl.cc

@@ -679,7 +679,7 @@ MaybeHandle<JSLocale> CreateLocale(Isolate* isolate,
                              JSObject::New(constructor, new_target), JSLocale);
 
   // First parameter is a locale, as a string/object. Can't be empty.
-  if (!tag->IsName() && !tag->IsJSReceiver()) {
+  if (!tag->IsString() && !tag->IsJSReceiver()) {
     THROW_NEW_ERROR(isolate, NewTypeError(MessageTemplate::kLocaleNotEmpty),
                     JSLocale);
   }

src/objects/js-locale.cc

@@ -175,8 +175,14 @@ MaybeHandle<JSLocale> JSLocale::InitializeLocale(Isolate* isolate,
   char icu_result[ULOC_FULLNAME_CAPACITY];
   char icu_canonical[ULOC_FULLNAME_CAPACITY];
 
+  if (locale->length() == 0) {
+    THROW_NEW_ERROR(isolate, NewRangeError(MessageTemplate::kLocaleNotEmpty),
+                    JSLocale);
+  }
+
   v8::String::Utf8Value bcp47_locale(v8_isolate, v8::Utils::ToLocal(locale));
-  if (bcp47_locale.length() == 0) return MaybeHandle<JSLocale>();
+  CHECK_LT(0, bcp47_locale.length());
+  CHECK_NOT_NULL(*bcp47_locale);
 
   int icu_length = uloc_forLanguageTag(
       *bcp47_locale, icu_result, ULOC_FULLNAME_CAPACITY, nullptr, &status);

test/intl/locale/locale-constructor.js

@@ -9,6 +9,11 @@ assertThrows(() => Intl.Locale('sr'), TypeError);
 
 // Non-string locale.
 assertThrows(() => new Intl.Locale(5), TypeError);
+assertThrows(() => new Intl.Locale(Symbol()), TypeError);
+assertThrows(() => new Intl.Locale(null), TypeError);
+assertThrows(() => new Intl.Locale(undefined), TypeError);
+assertThrows(() => new Intl.Locale(false), TypeError);
+assertThrows(() => new Intl.Locale(true), TypeError);
 
 // Invalid locale string.
 assertThrows(() => new Intl.Locale('abcdefghi'), RangeError);

test/intl/locale/regress-8032.js

+// Copyright 2018 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-locale
+
+assertThrows(() => new Intl.Locale(''), RangeError);