- 23 Jul, 2021 5 commits
-
-
Benedikt Meurer authored
This properly threads through the `executionContextId` to the request reported to the DevTools front-end, similarly to how we already report the `executionContextId` as part of `Runtime.bindingCalled`. Bug: chromium:1231521 Change-Id: I0a003041aedd8ec661d1b07cdddbcd1f2866a99f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3046187 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75875}
-
Danil Somsikov authored
devtools Bug: chromium:1213374 Change-Id: Ie064873e8a3998aad01120022e39e93dba0cb729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041424 Commit-Queue: Danil Somsikov <dsv@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#75874}
-
Dan Elphick authored
Replaces includes of v8.h with more fine-grained includes and moves the deoptimizer.h include to the places that actually need it. Bug: v8:11879 Change-Id: Ifc2e89caf455ddcf559fdb449d0fed7ad0d046d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045706Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75873}
-
legendecas authored
According to the spec https://tc39.github.io/proposal-error-cause, the property 'cause' should not present on Error.prototype. Bug: v8:12006 Change-Id: Ib1601769793b808c5f5a7065effcc77d1def4cbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3037911Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75872}
-
Al Muthanna Athamina authored
Bug: chromium:1231890 Change-Id: Iea8273dec335e0a9d264743751ac62e3869ec327 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045354 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75871}
-
- 22 Jul, 2021 23 commits
-
-
Dan Elphick authored
Removes unnecessary includes of v8.h from src/diagnostics/gdb-jit.h src/diagnostics/system-jit-win.h src/diagnostics/unwinder.h by predeclaring types or using more appropriate headers. Bug: v8:11879 Change-Id: I17f42acfef8e61133988453d67c3c0d473ff0337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045702 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75870}
-
Clemens Backes authored
This reverts commit 85e6c4b6. Reason for revert: All gc-stress bots are unhappy: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/34544/overview Original change's description: > [sparkplug] Enable sparkplug by default on desktop > > Bug: v8:11420 > Change-Id: I07ac7f30b5ffffe40170ac15d5df0d3bf8a53523 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041418 > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75868} Bug: v8:11420 Change-Id: I91fde3a35eece61e1dfa8b81f57fcda465ce5882 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3046178 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75869}
-
Leszek Swirski authored
Bug: v8:11420 Change-Id: I07ac7f30b5ffffe40170ac15d5df0d3bf8a53523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041418 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75868}
-
Andreas Haas authored
The test is flaky on that hardware but seems to work just fine on other arm hardware. R=machenbach@chromium.org Bug: v8:10948 Change-Id: Ic60cc23c1b4825623a91e3defcd21eada74554a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043954 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
legendecas authored
The intrinsic default proto was not installed on async function constructor, so the proto for those unable to get a proper receiver fallbacks to the realms' %Object.prototype%. Bug: v8:9818 Change-Id: I08b9459d60da72dc894b983973e0a36019be9141 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043691Reviewed-by:
-
Ross McIlroy authored
And use it to remove the set of TurboProp test skips. BUG=v8:9684,v8:12013 Change-Id: I878e2b9c595449c954735290959d3b38eead5a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043963 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75865}
-
Camillo Bruni authored
* Avoid accessing thread_local_top directly and use getters: - scheduled_exception - pending_exception - pending_message * Rename pending_message_obj to pending_message Bug: chromium:1014421 Change-Id: I080b7d5919e180a943776c79ee9321235d58d3c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3010278Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75864}
-
Jakob Kummerow authored
...while on-heap objects are referring to it. This is accomplished by storing a reference to its associated WasmInstanceObject on every WasmTypeInfo object. Details: https://bit.ly/2UxD4hW Fixed: v8:11953 Change-Id: Ifb6f976142356021393d41c50717d210d525d521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043959 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#75863}
-
legendecas authored
The original issue was resolved in https://github.com/tc39/test262/pull/2083 Change-Id: I5257982bc6d30a51c8fec4ecac31e54b5481a306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3040879Reviewed-by:
-
Jakob Gruber authored
These mutex guards may trigger GC on the slow paths; to detect misuse (creating these guards inside GC-disallowed scopes) more reliably, this CL adds DCHECK(AllowGarbageCollection::IsAllowed()) to the guard constructors. Bug: v8:12012 Change-Id: If59514c97ba6cc9bbca3b56559bf2496cafc78d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043952Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75861}
-
Clemens Backes authored
This is a follow-up to https://crrev.com/c/3015557. Even though we enabled trap handling and use it in wasm code, the embedder callback still refused to handle the signal. This CL removed an obsolete comment and simplifies the preprocessor condition to just check for the V8_TRAP_HANDLER_SUPPORTED variable instead of repeating the supported platforms. R=ahaas@chromium.org Bug: v8:11955, chromium:1231858 Change-Id: I417c790fdb755cba182578e7aa1ce4327f4c05ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045352Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75860}
-
Patrick Thier authored
- Add DropArguments() to x64 TurboAssembler to get rid of arguments on the stack while preserving the return address. - Add DropArgumentsAndPushNewReceiver() to x64 TurboAssembler to get rid of arguments on the stack and push a new receiver, while preserving the return address. Bug: v8:11112 Change-Id: I39ea012219ae3748a73933188eb860ce794de2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045349 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Jakob Gruber authored
A mix of readability refactors, additional DCHECKs, and addressed/updated TODOs. Bug: v8:7790 Change-Id: I87ff996abd40b0ed081586e2c0da1a4c0942fed4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041665 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75858}
-
Patrick Thier authored
Move some methods that don't access the isolate from x64 MacroAssembler to TurboAssembler. Drive-by: Add RootAsOperand to create an operand for root-relative constants. Bug: v8:11112 Change-Id: Ic0b62d96af004860e5a05539f94d0ac003b06fc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045348Reviewed-by:
-
Nico Hartmann authored
TBR=machenbach@chromium.org Bug: chromium:1231890 Change-Id: I60f0a21192f551e737d1b141a44601b9ad2b56fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045345Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#75856}
-
Jakob Kummerow authored
While pointer-compression still doesn't guarantee 8-byte alignment for objects, the WasmInstanceObject definition should be prepared for a future where that changes. No behavioral differences are expected from this, and likely no performance differences for now either. Change-Id: Iedd85f4361d45e1e3cf5d645496b9ad34acf533b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038527 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75855}
-
Ross McIlroy authored
Some skips are no longer required. BUG=v8:9684 Change-Id: I921f2032ea5c19429c735120ba80a09b8f1e352e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043961 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Adds incompatibility between future/turboprop variants and stress-concurrent-inlining due to incompatibility from both configs weakly setting --interrupt-budget. Also ensures we maintain this incompatibility if --future is passed as an extra flag as is done on some bots. BUG=v8:9684 Change-Id: I4855b92a64db00da15efc2384e241d4bf0c373c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041677 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Jakob Gruber authored
- Rename AssemblerOptions::enable_root_array_delta_access to enable_root_relative_access. - Remove the identical but duplicated PipelineData::roots_relative_addressing_enabled. Bug: v8:9594 Change-Id: I41c5ddc3c1ad9681dce8402640c50529f00141cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043956 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Fold the stack interrupt check to happen as part of the bytecode budget interrupt, so that we can skip the stack check on JumpLoop. This is a minor improvement for Ignition, but it's mainly for for Sparkplug code as it means we don't have to emit additional stack interrupt checks. TurboFan doesn't have budget interrupts, so it keeps the stack interrupt check. Bug: v8:11420 Change-Id: I055fe752946fda6a50ca2675fa3847999898a951 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041674 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The MapRef constructor contains a ParkedSharedMutexGuard which may trigger gc; and MapRefs may be created for any HeapObjectRef (or subclass) creation. Thus, calls to (Try)MakeRef must happen in contexts in which garbage collection is allowed. Bug: v8:7790,v8:12012 Change-Id: If0cb9e2dae7150b0aa5193a90ec3bc9cd9ac3b81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043951Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75850}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/d41864d..ad56859 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/51d7849..66e6c2e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6a2f664..9ac1fdf Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c81b8b9..131233f Rolling v8/tools/luci-go: git_revision:6387586e5b3279aebdf22bdab7ae619dbc156b66..git_revision:9ee8b1d719c0d3c268e0e19282351ca78024af2d Rolling v8/tools/luci-go: git_revision:6387586e5b3279aebdf22bdab7ae619dbc156b66..git_revision:9ee8b1d719c0d3c268e0e19282351ca78024af2d Rolling v8/tools/luci-go: git_revision:6387586e5b3279aebdf22bdab7ae619dbc156b66..git_revision:9ee8b1d719c0d3c268e0e19282351ca78024af2d TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1fb8aa68f5afba116d2f214f2128553a77e6ca7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045038Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75849}
-
Shu-yu Guo authored
RegExp match indices have shipped since M90 Bug: v8:9548 Change-Id: I8bf54ce1a50b5079aad71140f75c979a09aae5bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3042842 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
- 21 Jul, 2021 12 commits
-
-
Thibaud Michaud authored
This is a reland of 4cc547c7 Change: prevent a memcpy to nullptr by skipping the call to copy_out() when the length is zero. Original change's description: > [wasm][eh] Add WebAssembly.Tag.type > > R=ahaas@chromium.org > > Bug: v8:8091 > Change-Id: Id069ffbf76bf836b613287788b1b1fccbb577475 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3021173 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75815} Bug: v8:8091 Change-Id: I22f400b6e36d1322a4eabd20a68b4bdd70d61377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041436Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75847}
-
Michael Lippautz authored
Allow CrossThreadPersistent and its weak form to access ASAN poisoned memory from the GC entry points. In general, payloads of to-be-finalized objects are poisoned until the finalizer actually runs to avoid accidentally touching that payload. In the case of cross-thread handles, these may need to be cleared by a different thread before the finalizer actually runs. In order to clear those references, the slot needs to be unpoisoned. This is issue is ASAN-only and does not affect production or other debug builds. Bug: chromium:1230599, chromium:1056170 Change-Id: If4d0808953047319b02653821abbb5c638084dc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3040845 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#75846}
-
Michael Lippautz authored
Change-Id: I62b6ea126cd15c06fc48c8c7eae14b2b0c9b1dda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043962 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I1a9787514e105c70ab101aa035e6ee4ae2284ba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041434Reviewed-by:
-
Clemens Backes authored
This adds a little {Simulator::ProbeMemory} method that is used from several places in the arm64 simulator to test if a memory address can be accessed, and trigger a signal from a specific location such that the trap-handler can handle it. In case of a trap, the simulator is redirected to the landing pad and stops executing the memory instruction that triggered the trap. Standard memory accesses and SIMD memory loads and stores are instrumented to probe the memory. This passes all existing tests. In case this CL misses certain spots, we can still add them later. This will not be a security problem, since we do not use the simulator in production. R=ahaas@chromium.org CC=mseaborn@chromium.org, v8-arm-ports@googlegroups.com Bug: v8:11955 Change-Id: I52a81341e99fabc5fcf9e41ef4d8dd2226092803 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015557 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Michael Lippautz authored
The concurrent sweeper destroyed large pages directly in case no finalizer was needed during sweeping. This is unsafe as the logic of BasePage::Destroy is not concurrency safe. Bug: chromium:1056170, chromium:1231053 Change-Id: I8ae9b27b916f8c4aee0c239c7ac8f2ec61d92c56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041671 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Seth Brenith authored
Since most Torque-defined extern classes use @generateCppClass, it makes more sense to instead annotate the small number that don't. This is part of the cleanup work that Nico recommended in [1]. Classes that still have to opt out: - Those that can be converted by https://crrev.com/c/3015666 - HeapObject: sort of special since it's the root of the inheritance hierarchy. Generated code would include two declarations that don't compile until HeapObject is defined: bool IsHeapObject_NonInline(HeapObject o); explicit TorqueGeneratedHeapObject( Address ptr, HeapObject::AllowInlineSmiStorage allow_smi); - SmallOrdered*: these classes use templates on the C++ side, which is not currently representable in Torque. - SwissNameDictionary: according to a comment, the Torque generation for this class is incorrect. I haven't investigated further. Drive-by fix: make the Torque formatter keep LF on Windows rather than writing CRLF. [1] https://docs.google.com/document/d/1q_gZLnXd4bGnCx3IUfbln46K3bSs9UHBGasy9McQtHI/edit# Bug: v8:8952 Change-Id: I1fbb5290f0c645842b84c53816c09bb3398206a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3028721Reviewed-by:
-
Rakhim Khismet authored
We add additional num_types and liftoff parameters for GetValueType to be able to generate user-def reftypes. num_types is the number of types in the program and liftoff checks if we could add reftypes or not. The additional method (NumTypes) was added to WasmModuleBuilder and additional field (liftoff) to WasmGenerator constructor. Bug: v8:11954 Change-Id: I4904a41043264c65d5cba5b22129184d6a486bfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041426 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75840}
-
Michael Achenbach authored
This is a reland of cecc666f Depends on: https://crrev.com/c/3043611 Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I56568b78592addba01793d2d14f768c9ee10103d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75839}
-
Clemens Backes authored
This was triggered by the inspector fuzzer, which terminates execution after two seconds. This is done by triggering a termination exception via an interrupt. In this case, the runtime function should return immediately, and return the exception sentinel. This CL fixes the WasmDebugBreak runtime function to do that correctly. R=thibaudm@chromium.org Bug: chromium:1215711 Change-Id: Idf8e9769809f135b426e4d1a0ef82fae826050b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041423Reviewed-by:
-
Georg Neis authored
This reverts commit 0cd8a913. Reason for revert: There are reports of this check failing. It's still unclear why it's failing and what the implications of that are. The check had been disabled for many years so it seems safe to disable it again for now (it's in --debug-code anyways). Original change's description: > [ia32] Restore FP stack check in the deoptimizer > > This restores the check that was removed in > https://chromiumcodereview.appspot.com/12300020/ > > Bug: chromium:736643 > > Change-Id: I82e218b9f2572953a7f433d713dff0528574eea1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848469 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74168} Bug: chromium:1208057 Change-Id: I2f8ecfca3f4732583378a5d5b2a38ad636914e1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041673Reviewed-by:
-
Nico Hartmann authored
This reverts commit e24fa913. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/18917/overview Original change's description: > [offthread] Template deserializer on Isolate > > Make the deserializer class templated on Isolate/LocalIsolate. This > allows the ObjectSerializer to be split into a main-thread and offthread > variant, with the latter taking a LocalIsolate. > > Eventually, we probably want to anyway split off the code-cache de/serializer > to a separate implementation (for various reasons), and this the only one that > wants off-thread finalization, and at this point the deserializer can revert > back to being un-templated, used only for bootstrapping. However, this is the > simplest way, for now, to enable off-thread deserialization. > > Bug: chromium:1075999 > Change-Id: I49c0d2c5409f0aa58183673785296756c3714f22 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562254 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75834} Bug: chromium:1075999 Change-Id: Id699ebe0c17d3a61ec35b0f78417306175271647 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041675Reviewed-by:
-
