[Build] Reduce unnecessary includes of v8.h

Removes unnecessary includes of v8.h from
src/diagnostics/gdb-jit.h
src/diagnostics/system-jit-win.h
src/diagnostics/unwinder.h

by predeclaring types or using more appropriate headers.

Bug: v8:11879
Change-Id: I17f42acfef8e61133988453d67c3c0d473ff0337
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045702
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75870}

src/diagnostics/arm/unwinder-arm.cc

@@ -2,7 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <memory>
+
 #include "include/v8-unwinder-state.h"
+#include "include/v8.h"
 #include "src/diagnostics/unwinder.h"
 #include "src/execution/frame-constants.h"
 

src/diagnostics/arm64/unwinder-arm64.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 

src/diagnostics/gdb-jit.cc

@@ -8,6 +8,7 @@
 #include <memory>
 #include <vector>
 
+#include "include/v8.h"
 #include "src/api/api-inl.h"
 #include "src/base/bits.h"
 #include "src/base/hashmap.h"

src/diagnostics/gdb-jit.h

@@ -5,8 +5,6 @@
 #ifndef V8_DIAGNOSTICS_GDB_JIT_H_
 #define V8_DIAGNOSTICS_GDB_JIT_H_
 
-#include "include/v8.h"
-
 //
 // GDB has two ways of interacting with JIT code.  With the "JIT compilation
 // interface", V8 can tell GDB when it emits JIT code.  Unfortunately to do so,
@@ -25,6 +23,9 @@
 //
 
 namespace v8 {
+
+struct JitCodeEvent;
+
 namespace internal {
 namespace GDBJITInterface {
 #ifdef ENABLE_GDB_JIT_INTERFACE

src/diagnostics/ia32/unwinder-ia32.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 

src/diagnostics/mips/unwinder-mips.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 

src/diagnostics/mips64/unwinder-mips64.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 

src/diagnostics/ppc/unwinder-ppc.cc

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 #include "src/diagnostics/unwinder.h"
 namespace v8 {
+
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 }  // namespace v8

src/diagnostics/riscv64/unwinder-riscv64.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 

src/diagnostics/s390/unwinder-s390.cc

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 #include "src/diagnostics/unwinder.h"
 namespace v8 {
+
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}
 }  // namespace v8

src/diagnostics/system-jit-win.cc

@@ -4,6 +4,7 @@
 
 #include "src/diagnostics/system-jit-win.h"
 
+#include "include/v8.h"
 #include "src/api/api-inl.h"
 #include "src/base/lazy-instance.h"
 #include "src/base/logging.h"

src/diagnostics/system-jit-win.h

@@ -5,9 +5,10 @@
 #ifndef V8_DIAGNOSTICS_SYSTEM_JIT_WIN_H_
 #define V8_DIAGNOSTICS_SYSTEM_JIT_WIN_H_
 
-#include "include/v8.h"
-
 namespace v8 {
+
+struct JitCodeEvent;
+
 namespace internal {
 namespace ETWJITInterface {
 void Register();

src/diagnostics/unwinder.cc

@@ -6,6 +6,8 @@
 
 #include <algorithm>
 
+#include "include/v8.h"
+#include "src/execution/frame-constants.h"
 #include "src/execution/pointer-authentication.h"
 
 namespace v8 {

src/diagnostics/unwinder.h

@@ -5,12 +5,11 @@
 #ifndef V8_DIAGNOSTICS_UNWINDER_H_
 #define V8_DIAGNOSTICS_UNWINDER_H_
 
-#include "include/v8.h"
-#include "src/common/globals.h"
+#include "include/v8-internal.h"
 
 namespace v8 {
 
-i::Address Load(i::Address address);
+internal::Address Load(internal::Address address);
 
 }  // namespace v8
 

src/diagnostics/x64/unwinder-x64.cc

@@ -6,6 +6,8 @@
 
 namespace v8 {
 
+struct RegisterState;
+
 void GetCalleeSavedRegistersFromEntryFrame(void* fp,
                                            RegisterState* register_state) {}