- 28 Jun, 2018 24 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:857179 Change-Id: I6bbaa2601d62d303391d082a2ae1dff8d3c6e2b8 Reviewed-on: https://chromium-review.googlesource.com/1118562 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54095}
-
Clemens Hammacher authored
The flake is hopefully fixed with https://crrev.com/c/1118171. R=titzer@chromium.org Bug: v8:7879 Change-Id: I67ac9a447cbf8a99dfc612e84b3e381cc86fa643 Reviewed-on: https://chromium-review.googlesource.com/1118381Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54094}
-
Ben Smith authored
Supporting postMessage from WebAssembly.Module requires implementing some logic in the ValueSerializer and ValueDeserializer delegates. This change implements some simple logic for d8. This change also fixes a DCHECK that occurs when sending a shared WebAssembly.Memory object to two Workers. Bug: chromium:857049 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idddb23a48175c7175967af3fbc03d8572452a069 Reviewed-on: https://chromium-review.googlesource.com/1117871Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#54093}
-
Clemens Hammacher authored
We should only cancel asynchronous compilation jobs for the isolate which is being recycled. R=titzer@chromium.org Bug: chromium:854755 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I31d6c3ccb648f5465e52f4bc47c4261894458e60 Reviewed-on: https://chromium-review.googlesource.com/1118378Reviewed-by:
-
Clemens Hammacher authored
Another pair of {std::unique_ptr} and {size_t} that can be stored as one {OwnedVector}, which allows to pass it as one thing. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Ideac0dbd390ba8147b6620daa86f0d3da6c3b609 Reviewed-on: https://chromium-review.googlesource.com/1118236 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Instead of storing both the {NativeModule} and the {WasmModule} in a {Managed} object, just store the {WasmModule} in the {NativeModule} directly. This fixes crashes that happen if the {Managed<WasmModule>} dies before the {Managed<NativeModule>}. R=mstarzinger@chromium.org Bug: chromium:854794, v8:7879, v8:7889 Change-Id: I6b11729943fe7a03d225138782655ee5dafd26a6 Reviewed-on: https://chromium-review.googlesource.com/1118171 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Théotime Grohens authored
This CL adds the newline character as a valid character in Torque strings. You can now write Print('Hello, World!\n') in Torque and it works! Change-Id: I2a1f87cfef492fedd3d24086e226d3ebaf882115 Reviewed-on: https://chromium-review.googlesource.com/1118229Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54089}
-
Georg Neis authored
R=sigurds@chromium.org Bug: v8:7902 Change-Id: I0a126221ffded34cccc7db793e92d0ae22952bb4 Reviewed-on: https://chromium-review.googlesource.com/1118235Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54088}
-
Georg Neis authored
When run locally, one times out and the other runs out of stack space. R=sigurds@chromium.org Change-Id: I7cc1aa9bb0857f12ac46baf80de18a2c5175b8b9 Reviewed-on: https://chromium-review.googlesource.com/1118231Reviewed-by:
-
Clemens Hammacher authored
This reverts commit cd5d72fd. Reason for revert: breaks TSAN: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21284 Original change's description: > Reland "[heap] Clear from space after garbage collection. > > Bug: chromium:829771 > Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c > Reviewed-on: https://chromium-review.googlesource.com/1106657 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54082} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: I6b719266bd088f8835d2c769d471c8872256fb40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:829771 Reviewed-on: https://chromium-review.googlesource.com/1118298Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54086}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: chromium:856938 Change-Id: I57699de23b5c35a531c7601fd14a91f075abb0da Reviewed-on: https://chromium-review.googlesource.com/1117182 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL removes the friendship between {NativeModule} and {NativeModuleSerializer}/{NativeModuleDeserializer}. Instead, it adds a new public method ({AddDeserializedCode}) which is being called from the deserializer. Drive-by: Unify the argument order to {AddCode}, {AddOwnedCode} and {WasmCode}. R=mstarzinger@chromium.org Bug: chromium:856938 Change-Id: I88943c90c45650e21ae6bc17395a17f86319c046 Reviewed-on: https://chromium-review.googlesource.com/1117075Reviewed-by: -
Predrag Rudic authored
This CL complements commit f2695f73 for MIPS32. That commit addressed problem for MIPS64. Original message: >ArraySpliceTorque builtin triggers generation of MIPS specific >trampolines due to its large size, and this code is not PIC >and cannot be isolate independent. > >This CL is a workaround that marks ArraySpliceTorque as >isolate dependent on MIPS64. > >Bug: v8:7882 >Change-Id: I0b5764236268c2529e149b275dcf382dab709682 >Reviewed-on: https://chromium-review.googlesource.com/1111847 >Commit-Queue: Jakob Gruber <jgruber@chromium.org> >Reviewed-by: Michael Stanton <mvstanton@chromium.org> >Reviewed-by: Jakob Gruber <jgruber@chromium.org> >Cr-Commit-Position: refs/heads/master@{#53968} Bug: v8:7882 Change-Id: Iffdfab673781cca1eb14d11428ffcf7a01c21f27 Reviewed-on: https://chromium-review.googlesource.com/1117186 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#54083}
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c Reviewed-on: https://chromium-review.googlesource.com/1106657 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54082}
-
Ross McIlroy authored
Merges DebugInfo field into the function_identifier field, storing the function identifier in the DebugInfo. Also moves some debugging_hints bits to the SFI flags, and others to the DebugInfo. Finally, changes the logic to store debugger patched bytecode array on the SFI instead of the DebugInfo, simplifying the logic in the InterpreterEntryTrampoline. BUG=chromium:818642,chromium:783853 TBR=hpayer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If440080c0f08fac4fb96f5e18dcc0eb9b86d4821 Reviewed-on: https://chromium-review.googlesource.com/1115819 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54081}
-
jgruber authored
This is a reland of 7a0d6a50 Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org Bug: v8:7891, v8:6688 Change-Id: I3b1e80b3ca156b7d571ebc7f04e341f0ba716691 Reviewed-on: https://chromium-review.googlesource.com/1118139Reviewed-by:
-
jgruber authored
The multi-snapshot feature is only used on bots, where we need the ability to execute tests with/without mitigations controllable through a runtime flag. This disables the flag by default and only enables it on bot configs. Note: standard single-snapshot builds silently use the available snapshot regardless of the value of --untrusted-code-mitigations. Bug: v8:7891,v8:6688 Change-Id: I0d1a91e5c1c17b4d91b42d176b50ea44d2128d48 Reviewed-on: https://chromium-review.googlesource.com/1117687 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54079}
-
Clemens Hammacher authored
We pass the {WasmModule} by non-const pointer and by non-const reference a lot. This violates the style guide, and adds the risk of accidentally modifying it. This CL makes the {WasmModule} const during compilation and instantiation. R=mstarzinger@chromium.org Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie1878322828b63284b341d97da595e8e91dd4f51 Reviewed-on: https://chromium-review.googlesource.com/1117194Reviewed-by: -
Jakob Gruber authored
This reverts commit 7a0d6a50. Reason for revert: Breaks no-slow-assert builds. Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org,jgruber@chromium.org Change-Id: I6b048e819846c4bd9a064f82e2f3c7609369cd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7891, v8:6688 Reviewed-on: https://chromium-review.googlesource.com/1118138Reviewed-by:
-
Michael Starzinger authored
This loads the stack limit address from the instance object instead of embedding it into the instruction stream. It is another piece towards making the generated code independent of the Isolate. R=clemensh@chromium.org BUG=v8:7424 Change-Id: I9381956adf2d7c42f6626708229cfdd5c4ca114f Reviewed-on: https://chromium-review.googlesource.com/1117189 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9cd33e9e. Reason for revert: Didn't add value. Original change's description: > [build] Temporarily make ubsan bot use no snapshot > > Currently mksnapshot fails due to ubsan issues. With a nosnap build it > will be easier to track down failures initially as normal test > failures, since mksnapshot isn't called with the sanitizer > environment variables. > > NOTRY=true > TBR=jgruber@chromium.org > > Bug: v8:7860 > Change-Id: I897a8d307d90f545c80a90e1e1a2a632ffae1c3e > Reviewed-on: https://chromium-review.googlesource.com/1116783 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54051} TBR=machenbach@chromium.org,jgruber@chromium.org Change-Id: I31e06fafb845c07bbaeb7a104d130f923d3be062 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7860 Reviewed-on: https://chromium-review.googlesource.com/1118039Reviewed-by:
-
jgruber authored
Slow asserts double the time spent in mksnapshot. While we want them enabled on our bot builds, local builds should be fast and don't necessarily need them. This also adds v8_enable_fast_mksnapshot as default in gm.py. Bug: v8:7891,v8:6688 Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 Reviewed-on: https://chromium-review.googlesource.com/1116552Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54074}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fde5d81..5fc0186 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e82ab88..d96c633 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a991ac6..b3853af TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If6e75ab7bfac97aebaca75842a6d469a83277835 Reviewed-on: https://chromium-review.googlesource.com/1117923 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54073}
-
Michael Achenbach authored
This reverts commit fdf69d53. Reason for revert: Speculative revert for broken GPU bots: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20%28NVIDIA%29/1638 https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20%28Intel%29/1624 Original change's description: > [heap] Adds a young generation large object space > > This CL adds the young generation lage object spaces and a flag > --young-generation-large-objects that by default allocates all > large objects in this space. This is a preparation CL. The space > is not fully functional. > > Bug: chromium:852420 > Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac > Reviewed-on: https://chromium-review.googlesource.com/1099164 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54056} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org Change-Id: I175514f806a19c7837022795210625ca40e3c318 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1118038Reviewed-by:
-
- 27 Jun, 2018 16 commits
-
-
Sathya Gunasekaran authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/330733e..a6c1d05 TBR=adamk@chromium.org,gsathya@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia994bd405726120a369e841679ef6535ff6ae619 Reviewed-on: https://chromium-review.googlesource.com/1117100 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
This is required for jumbo builds to work before the stable jumbo chunk algorithm[*] can reland. [*] https://chromium-review.googlesource.com/c/chromium/src/+/1102218 Bug: chromium:856964, chromium:782863 Change-Id: Ibbe0994980eb554acd4e1557e733d07526a90608 Reviewed-on: https://chromium-review.googlesource.com/1117059Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12206d3..fde5d81 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f989b62..e82ab88 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c6e5ea2..de629a4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I32e0cb2be85c85276be7403ae8832e3b7b849bc7 Reviewed-on: https://chromium-review.googlesource.com/1117376Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:6443, v8:7569 Change-Id: Ia7e1ed9ab7e85ac366349688278ba59507d38b7e Reviewed-on: https://chromium-review.googlesource.com/1098474 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54068}
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/59ac9bd..12206d3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/5941c1b..9c9fd97 Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/3545ab5..130499e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2e625dc..f989b62 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d91a468..a991ac6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If880dd44606cbcbbf9e57ab46730ccfa844d5f84 Reviewed-on: https://chromium-review.googlesource.com/1116860Reviewed-by:
-
Rodrigo Bruno authored
This is a reland of d4792e8f Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} Bug: chromium:845409 Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 Reviewed-on: https://chromium-review.googlesource.com/1116638 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7754 Change-Id: Ic6157ab1219bcdbdb6ac751d05602ab411d58ce2 Reviewed-on: https://chromium-review.googlesource.com/1117072 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The name itself does not make sense any more since the {NativeModule} is shared across instances. It is also only used for debugging, so remove it, and replace it by the address of the {NativeModule} itself in debug output. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I02f9252981b776934811a904287be31c7076e90b Reviewed-on: https://chromium-review.googlesource.com/1114965 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Tobias Tebbi authored
The motivation for this CL were the expensive UnhandledIsSorted() checks, which increase mksnapshot time (v8:7895). In addition, it is a cleanup and removes a potential for quadratic performance. Change-Id: I33e734e4e20183768dbf8222adcbb3abc1f1a6bf Reviewed-on: https://chromium-review.googlesource.com/1116960 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#54063}
-
Vasili Skurydzin authored
Change-Id: Ib569f8587f18f91b89b4b8b824fa99cf1a5e6005 Reviewed-on: https://chromium-review.googlesource.com/1115359Reviewed-by:
-
Camillo Bruni authored
- Introduce ScriptEventType enum - Emit log event when deserializing scripts - Better handle deserialized and eval scripts when calculating the byte size Bug: chromium:757467, chromium:850038 Change-Id: I082161d8d1d4238a90d3607ca8b6b4e60f2f903e Reviewed-on: https://chromium-review.googlesource.com/1114845 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54061}
-
Michael Starzinger authored
This fixes include violations where normal "foo.h" headers included inline "bar-inl.h" headers. It also removes two (almost) dead methods. R=clemensh@chromium.org BUG=v8:7754 Change-Id: I11c6ce71650db22f3c1d7cf5ca50529c94b94839 Reviewed-on: https://chromium-review.googlesource.com/1117076 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since the Liftoff prologue is gone (https://crrev.com/c/1110222), this field is dead. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: I9d3e94a63087e7111939523c11fba4f009cecd54 Reviewed-on: https://chromium-review.googlesource.com/1116963Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I01b0b4948973ebbe0386ae8ae08e722ad16bcab8 Reviewed-on: https://chromium-review.googlesource.com/1114616Reviewed-by:
-
Clemens Hammacher authored
Replace two more pairs of {std::unique_ptr} and {size_t} by {OwnedVector}. R=mstarzinger@chromium.org Change-Id: Ifdf03abf9759fbbb4adde76a494073625723a03d Reviewed-on: https://chromium-review.googlesource.com/1116785 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Hannes Payer authored
This CL adds the young generation lage object spaces and a flag --young-generation-large-objects that by default allocates all large objects in this space. This is a preparation CL. The space is not fully functional. Bug: chromium:852420 Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac Reviewed-on: https://chromium-review.googlesource.com/1099164 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
