1. 21 Feb, 2019 1 commit
  2. 24 Sep, 2018 1 commit
    • Dan Elphick's avatar
      [deprecation] Deprecate ToBoolean(Local<Context>) · d235f550
      Dan Elphick authored
      ToBoolean and BooleanValue cannot throw exceptions so the Maybe versions
      of the functions don't make sense. As such this deprecates the Maybe
      versions and undeprecates ToBoolean(Isolate*). It also adds
      BooleanValue(Isolate*).
      
      Fix up all of the v8 code to not use the deprecated functions.
      
      Bug: v8:7279, v8:8015
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I50e7474d205c75baa153f0dea7f02dcf60232d1d
      Reviewed-on: https://chromium-review.googlesource.com/1238476
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56163}
      d235f550
  3. 17 Sep, 2018 1 commit
  4. 14 Sep, 2018 1 commit
  5. 19 Jul, 2018 1 commit
  6. 18 Jul, 2018 1 commit
    • Yang Guo's avatar
      Reland "[builtins] Add %IsTraceCategoryEnabled and %Trace builtins" · 0dd33901
      Yang Guo authored
      This is a reland of 8d4572a2
      
      Original change's description:
      > [builtins] Add %IsTraceCategoryEnabled and %Trace builtins
      >
      > Adds the builtin Trace and IsTraceCategoryEnabled functions
      > exposed via extra bindings. These are intended to use by
      > embedders to allow basic trace event support from JavaScript.
      >
      > ```js
      > isTraceCategoryEnabled('v8.some-category')
      >
      > trace('e'.charCodeAt(0), 'v8.some-category',
      >       'Foo', 0, { abc: 'xyz'})
      > ```
      >
      > Bug: v8:7851
      > Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250
      > Reviewed-on: https://chromium-review.googlesource.com/1103294
      > Commit-Queue: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54121}
      
      TBR=cbruni@chromium.org
      
      Bug: v8:7851
      Change-Id: Id063754b2834b3b6a2b2654e76e8637bcd6aa5f8
      Reviewed-on: https://chromium-review.googlesource.com/1137071
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54532}
      0dd33901
  7. 02 Jul, 2018 2 commits
  8. 02 May, 2018 1 commit
  9. 12 Jan, 2018 1 commit
  10. 29 Aug, 2017 1 commit
  11. 14 Aug, 2017 1 commit
  12. 01 Aug, 2017 1 commit
  13. 03 Jul, 2017 1 commit
    • Jochen Eisinger's avatar
      Reland "Switch tracing to use v8::TracingController" · cc59f8b1
      Jochen Eisinger authored
      Original change's description:
      > Switch tracing to use v8::TracingController
      >
      > BUG=v8:6511
      > R=fmeawad@chromium.org
      >
      > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      > Change-Id: I4961e4b61a9ddc98385ed97c3ffcbcaef2d9cba7
      > Reviewed-on: https://chromium-review.googlesource.com/543144
      > Commit-Queue: Jochen Eisinger <jochen@chromium.org>
      > Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46307}
      
      BUG=v8:6511
      TBR=fmeawad@chromium.org
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux64_tsan_rel
      Change-Id: Ide32b409248dfd466e7c0bae1d8ae61d6a955d98
      Reviewed-on: https://chromium-review.googlesource.com/558865
      Commit-Queue: Jochen Eisinger <jochen@chromium.org>
      Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46381}
      cc59f8b1
  14. 29 Jun, 2017 2 commits
  15. 28 Sep, 2016 1 commit
    • zhengxing.li's avatar
      [tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in... · 990a8e39
      zhengxing.li authored
      [tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Platform Class.
      
        The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc compilation fail for v8 debug mode.
        The error message was:
        In file included from .././include/libplatform/v8-tracing.h:13:0,
                         from .././src/libplatform/default-platform.h:14,
                         from ../src/libplatform/default-platform.cc:5:
        .././include/v8-platform.h:169:20: error: ‘virtual uint64_t v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, unsigned int)’ was hidden [-Werror=overloaded-virtual]
           virtual uint64_t AddTraceEvent(
                            ^
        In file included from ../src/libplatform/default-platform.cc:5:0:
        .././src/libplatform/default-platform.h:55:12: error:   by ‘virtual uint64_t v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’ [-Werror=overloaded-virtual]
           uint64_t AddTraceEvent(
                    ^
      
        This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all declarations of AddTraceEvent functions in Classes derived from Platform Class.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2380583002
      Cr-Commit-Position: refs/heads/master@{#39810}
      990a8e39
  16. 27 Sep, 2016 2 commits
  17. 26 Sep, 2016 1 commit
  18. 22 Sep, 2016 1 commit
  19. 19 Sep, 2016 1 commit
  20. 01 Mar, 2016 1 commit
  21. 26 Feb, 2016 1 commit
    • fmeawad's avatar
      Reland: Add Scoped Context Info (Isolate) to V8 Traces · 567e5839
      fmeawad authored
      This patch adds the newly added support for contexts in V8 Tracing, as well
      as use it to mark all the entry points for a V8 Isolate.
      
      Update for reland: The current tracing interface needs to be updated (AddTraceEvent),
      but the embedders need to migrate to the new version before removing the old version.
      (Reland of: https://codereview.chromium.org/1686233002)
      
      The revert happened because the 2 signatures of the old and new AddTraceEvent where different
      so it threw an overload-virtual error on cross arm debug. This issue is temporary, and to solve
      it, I added an implementation of the old and new everywhere until the embedder implements the new.
      
      BUG=v8:4565
      LOG=N
      
      R=jochen@chromium.org
      
      Review URL: https://codereview.chromium.org/1704253002
      
      Cr-Commit-Position: refs/heads/master@{#34332}
      567e5839
  22. 17 Feb, 2016 2 commits
  23. 17 Dec, 2015 1 commit