[cleanup] Refactor general tests to use default members.

Fixing clang-tidy warning.

Bug: v8:8015
Change-Id: I4236a2cf85a414f9d7d1fbdaaaaf1c72a84f02e3
Reviewed-on: https://chromium-review.googlesource.com/1224093Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Florian Sattler <sattlerf@google.com>
Cr-Commit-Position: refs/heads/master@{#55912}

test/cctest/cctest.cc

@@ -210,12 +210,12 @@ InitializedHandleScope::InitializedHandleScope()
       initialized_handle_scope_impl_(
           new InitializedHandleScopeImpl(main_isolate_)) {}
 
-InitializedHandleScope::~InitializedHandleScope() {}
+InitializedHandleScope::~InitializedHandleScope() = default;
 
 HandleAndZoneScope::HandleAndZoneScope()
     : main_zone_(new i::Zone(&allocator_, ZONE_NAME)) {}
 
-HandleAndZoneScope::~HandleAndZoneScope() {}
+HandleAndZoneScope::~HandleAndZoneScope() = default;
 
 static void PrintTestList(CcTest* current) {
   if (current == nullptr) return;

test/cctest/cctest.h

@@ -220,7 +220,7 @@ class ApiTestFuzzer: public v8::base::Thread {
         test_number_(num),
         gate_(0),
         active_(true) {}
-  ~ApiTestFuzzer() {}
+  ~ApiTestFuzzer() = default;
 
   static bool fuzzing_;
   static int tests_being_run_;
@@ -598,7 +598,7 @@ class StaticOneByteResource : public v8::String::ExternalOneByteStringResource {
  public:
   explicit StaticOneByteResource(const char* data) : data_(data) {}
 
-  ~StaticOneByteResource() {}
+  ~StaticOneByteResource() = default;
 
   const char* data() const { return data_; }
 

test/cctest/libsampler/test-sampler.cc

@@ -55,7 +55,7 @@ class TestSampler : public Sampler {
 
 class TestApiCallbacks {
  public:
-  TestApiCallbacks() {}
+  TestApiCallbacks() = default;
 
   static void Getter(v8::Local<v8::String> name,
                      const v8::PropertyCallbackInfo<v8::Value>& info) {

test/cctest/setup-isolate-for-tests.h

@@ -14,7 +14,7 @@ class SetupIsolateDelegateForTests : public SetupIsolateDelegate {
  public:
   explicit SetupIsolateDelegateForTests(bool create_heap_objects)
       : SetupIsolateDelegate(create_heap_objects) {}
-  virtual ~SetupIsolateDelegateForTests() {}
+  virtual ~SetupIsolateDelegateForTests() = default;
 
   void SetupBuiltins(Isolate* isolate) override;
 

test/cctest/test-api.cc

@@ -15834,7 +15834,7 @@ class OneByteVectorResource : public v8::String::ExternalOneByteStringResource {
  public:
   explicit OneByteVectorResource(i::Vector<const char> vector)
       : data_(vector) {}
-  virtual ~OneByteVectorResource() {}
+  virtual ~OneByteVectorResource() = default;
   virtual size_t length() const { return data_.length(); }
   virtual const char* data() const { return data_.start(); }
   virtual void Dispose() {}
@@ -15848,7 +15848,7 @@ class UC16VectorResource : public v8::String::ExternalStringResource {
  public:
   explicit UC16VectorResource(i::Vector<const i::uc16> vector)
       : data_(vector) {}
-  virtual ~UC16VectorResource() {}
+  virtual ~UC16VectorResource() = default;
   virtual size_t length() const { return data_.length(); }
   virtual const i::uc16* data() const { return data_.start(); }
   virtual void Dispose() {}
@@ -19365,7 +19365,7 @@ class VisitorImpl : public v8::ExternalResourceVisitor {
       found_resource_[i] = false;
     }
   }
-  virtual ~VisitorImpl() {}
+  virtual ~VisitorImpl() = default;
   virtual void VisitExternalString(v8::Local<v8::String> string) {
     if (!string->IsExternal()) {
       CHECK(string->IsExternalOneByte());
@@ -23707,7 +23707,7 @@ THREADED_TEST(JSONStringifyObjectWithGap) {
 class ThreadInterruptTest {
  public:
   ThreadInterruptTest() : sem_(0), sem_value_(0) { }
-  ~ThreadInterruptTest() {}
+  ~ThreadInterruptTest() = default;
 
   void RunTest() {
     InterruptThread i_thread(this);
@@ -24055,7 +24055,7 @@ class RequestInterruptTestBase {
         should_continue_(true) {
   }
 
-  virtual ~RequestInterruptTestBase() { }
+  virtual ~RequestInterruptTestBase() = default;
 
   virtual void StartInterruptThread() = 0;
 

test/cctest/test-heap-profiler.cc

@@ -1025,7 +1025,7 @@ class TestJSONStream : public v8::OutputStream {
   TestJSONStream() : eos_signaled_(0), abort_countdown_(-1) {}
   explicit TestJSONStream(int abort_countdown)
       : eos_signaled_(0), abort_countdown_(abort_countdown) {}
-  virtual ~TestJSONStream() {}
+  virtual ~TestJSONStream() = default;
   virtual void EndOfStream() { ++eos_signaled_; }
   virtual WriteResult WriteAsciiChunk(char* buffer, int chars_written) {
     if (abort_countdown_ > 0) --abort_countdown_;
@@ -1215,14 +1215,9 @@ class TestStatsStream : public v8::OutputStream {
       intervals_count_(0),
       first_interval_index_(-1) { }
   TestStatsStream(const TestStatsStream& stream)
-    : v8::OutputStream(stream),
-      eos_signaled_(stream.eos_signaled_),
-      updates_written_(stream.updates_written_),
-      entries_count_(stream.entries_count_),
-      entries_size_(stream.entries_size_),
-      intervals_count_(stream.intervals_count_),
-      first_interval_index_(stream.first_interval_index_) { }
-  virtual ~TestStatsStream() {}
+
+      = default;
+  virtual ~TestStatsStream() = default;
   virtual void EndOfStream() { ++eos_signaled_; }
   virtual WriteResult WriteAsciiChunk(char* buffer, int chars_written) {
     UNREACHABLE();

test/cctest/test-lockers.cc

@@ -362,7 +362,7 @@ class JoinableThread {
       thread_(this) {
   }
 
-  virtual ~JoinableThread() {}
+  virtual ~JoinableThread() = default;
 
   void Start() {
     thread_.Start();

test/cctest/test-log.cc

@@ -263,7 +263,7 @@ class SimpleExternalString : public v8::String::ExternalStringResource {
     for (int i = 0; i < utf_source_.length(); ++i)
       utf_source_[i] = source[i];
   }
-  virtual ~SimpleExternalString() {}
+  virtual ~SimpleExternalString() = default;
   virtual size_t length() const { return utf_source_.length(); }
   virtual const uint16_t* data() const { return utf_source_.start(); }
  private:

test/cctest/test-sampler-api.cc

@@ -17,7 +17,7 @@ class Sample {
  public:
   enum { kFramesLimit = 255 };
 
-  Sample() {}
+  Sample() = default;
 
   typedef const void* const* const_iterator;
   const_iterator begin() const { return data_.start(); }

test/cctest/test-strings.cc

@@ -1186,7 +1186,7 @@ class OneByteVectorResource : public v8::String::ExternalOneByteStringResource {
  public:
   explicit OneByteVectorResource(i::Vector<const char> vector)
       : data_(vector) {}
-  virtual ~OneByteVectorResource() {}
+  virtual ~OneByteVectorResource() = default;
   virtual size_t length() const { return data_.length(); }
   virtual const char* data() const { return data_.start(); }
  private:

test/cctest/test-trace-event.cc

@@ -98,7 +98,7 @@ class MockTracingPlatform : public TestPlatform {
     // Now that it's completely constructed, make this the current platform.
     i::V8::SetPlatformForTesting(this);
   }
-  virtual ~MockTracingPlatform() {}
+  virtual ~MockTracingPlatform() = default;
 
   v8::TracingController* GetTracingController() override {
     return &tracing_controller_;

test/fuzzer/wasm-fuzzer-common.h

@@ -31,7 +31,7 @@ void GenerateTestCase(Isolate* isolate, ModuleWireBytes wire_bytes,
 
 class WasmExecutionFuzzer {
  public:
-  virtual ~WasmExecutionFuzzer() {}
+  virtual ~WasmExecutionFuzzer() = default;
   int FuzzWasmModule(Vector<const uint8_t> data, bool require_valid = false);
 
  protected:

test/unittests/api/interceptor-unittest.cc

@@ -35,7 +35,7 @@ namespace {
 
 class InterceptorLoggingTest : public TestWithNativeContext {
  public:
-  InterceptorLoggingTest() {}
+  InterceptorLoggingTest() = default;
 
   static const int kTestIndex = 0;
 

test/unittests/code-stub-assembler-unittest.h

@@ -14,8 +14,8 @@ namespace internal {
 
 class CodeStubAssemblerTest : public TestWithIsolateAndZone {
  public:
-  CodeStubAssemblerTest() {}
-  ~CodeStubAssemblerTest() override {}
+  CodeStubAssemblerTest() = default;
+  ~CodeStubAssemblerTest() override = default;
 };
 
 class CodeStubAssemblerTestState : public compiler::CodeAssemblerState {

test/unittests/counters-unittest.cc

@@ -34,7 +34,7 @@ class MockHistogram : public Histogram {
 class AggregatedMemoryHistogramTest : public ::testing::Test {
  public:
   AggregatedMemoryHistogramTest() : aggregated_(&mock_) {}
-  virtual ~AggregatedMemoryHistogramTest() {}
+  virtual ~AggregatedMemoryHistogramTest() = default;
 
   void AddSample(double current_ms, double current_value) {
     aggregated_.AddSample(current_ms, current_value);

test/unittests/parser/preparser-unittest.cc

@@ -13,7 +13,7 @@ namespace internal {
 
 class PreParserTest : public TestWithNativeContext {
  public:
-  PreParserTest() {}
+  PreParserTest() = default;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PreParserTest);

test/unittests/register-configuration-unittest.cc

@@ -14,8 +14,8 @@ const MachineRepresentation kSimd128 = MachineRepresentation::kSimd128;
 
 class RegisterConfigurationUnitTest : public ::testing::Test {
  public:
-  RegisterConfigurationUnitTest() {}
-  virtual ~RegisterConfigurationUnitTest() {}
+  RegisterConfigurationUnitTest() = default;
+  virtual ~RegisterConfigurationUnitTest() = default;
 };
 
 TEST_F(RegisterConfigurationUnitTest, BasicProperties) {

test/unittests/run-all-unittests.cc

@@ -11,7 +11,7 @@ namespace {
 
 class DefaultPlatformEnvironment final : public ::testing::Environment {
  public:
-  DefaultPlatformEnvironment() {}
+  DefaultPlatformEnvironment() = default;
 
   void SetUp() override {
     platform_ = v8::platform::NewDefaultPlatform(

test/unittests/source-position-table-unittest.cc

@@ -14,8 +14,8 @@ namespace interpreter {
 
 class SourcePositionTableTest : public TestWithIsolate {
  public:
-  SourcePositionTableTest() {}
-  ~SourcePositionTableTest() override {}
+  SourcePositionTableTest() = default;
+  ~SourcePositionTableTest() override = default;
 
   SourcePosition toPos(int offset) {
     return SourcePosition(offset, offset % 10 - 1);

test/unittests/test-utils.cc

@@ -24,9 +24,7 @@ Isolate* TestWithIsolate::isolate_ = nullptr;
 TestWithIsolate::TestWithIsolate()
     : isolate_scope_(isolate()), handle_scope_(isolate()) {}
 
-
-TestWithIsolate::~TestWithIsolate() {}
-
+TestWithIsolate::~TestWithIsolate() = default;
 
 // static
 void TestWithIsolate::SetUpTestCase() {
@@ -67,7 +65,7 @@ Local<Value> TestWithIsolate::RunJS(const char* source) {
 TestWithContext::TestWithContext()
     : context_(Context::New(isolate())), context_scope_(context_) {}
 
-TestWithContext::~TestWithContext() {}
+TestWithContext::~TestWithContext() = default;
 
 v8::Local<v8::String> TestWithContext::NewString(const char* string) {
   return v8::String::NewFromUtf8(v8_isolate(), string,
@@ -85,9 +83,9 @@ void TestWithContext::SetGlobalProperty(const char* name,
 
 namespace internal {
 
-TestWithIsolate::~TestWithIsolate() {}
+TestWithIsolate::~TestWithIsolate() = default;
 
-TestWithIsolateAndZone::~TestWithIsolateAndZone() {}
+TestWithIsolateAndZone::~TestWithIsolateAndZone() = default;
 
 Factory* TestWithIsolate::factory() const { return isolate()->factory(); }
 
@@ -99,9 +97,9 @@ base::RandomNumberGenerator* TestWithIsolate::random_number_generator() const {
   return isolate()->random_number_generator();
 }
 
-TestWithZone::~TestWithZone() {}
+TestWithZone::~TestWithZone() = default;
 
-TestWithNativeContext::~TestWithNativeContext() {}
+TestWithNativeContext::~TestWithNativeContext() = default;
 
 Handle<Context> TestWithNativeContext::native_context() const {
   return isolate()->native_context();

test/unittests/test-utils.h

@@ -78,7 +78,7 @@ class Factory;
 
 class TestWithIsolate : public virtual ::v8::TestWithIsolate {
  public:
-  TestWithIsolate() {}
+  TestWithIsolate() = default;
   virtual ~TestWithIsolate();
 
   Factory* factory() const;
@@ -125,7 +125,7 @@ class TestWithIsolateAndZone : public virtual TestWithIsolate {
 class TestWithNativeContext : public virtual ::v8::TestWithContext,
                               public virtual TestWithIsolate {
  public:
-  TestWithNativeContext() {}
+  TestWithNativeContext() = default;
   virtual ~TestWithNativeContext();
 
   Handle<Context> native_context() const;