1. 21 May, 2019 1 commit
  2. 20 May, 2019 1 commit
  3. 17 May, 2019 2 commits
  4. 15 May, 2019 1 commit
  5. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  6. 04 Apr, 2019 1 commit
    • Deepti Gandluri's avatar
      [wasm] Move is_growable from JSArrayBuffer object to AllocationData · b0077b3b
      Deepti Gandluri authored
      Some state related to WasmMemories is cached on the JSArrayBuffer
      object (is_growable, is_wasm_memory). The problem with this is in
      some PostMessage flows, this information can get lost depending on
      how JSArrayBuffers are deserialized. In this particular case when
      the WasmMemory is postMessaged, it goes through the Blink
      DedicatedWorkerMessagingProxy::PostMessageToWorkerGlobalScope flow,
      which reconstructs the ArrayBuffer from the backing store, and size,
      and loses the is_growable flag, leading to a failure to grow memory.
      
      Moving the is_growable flag so that AllocationData can be the source
      of truth for all wasm memory state, and is consistently preserved
      across PostMessage.
      
      Change-Id: I775f66ddeff68b8cafc18b75ca5460dfb0343c8b
      Bug: v8:9065
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549789
      Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60641}
      b0077b3b
  7. 26 Feb, 2019 1 commit
  8. 16 Jan, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Clean up base::EnumSet · 4064757c
      Clemens Hammacher authored
      After moving to its own header, this CL cleans up some parts of the
      interface. It fixes names and const-declarations of simple accessors,
      and adds a named constructor to make it explicit that an EnumSet should
      be constructed from an integral value.
      Also refactor the use in cctest.h to have less statically declared
      constants. Instead, just create the set of extensions in the individual
      tests.
      
      R=titzer@chromium.org
      
      Bug: v8:8562
      Change-Id: I6178d1aba25afa1d7f54c29ccf81505c165e7cd3
      Reviewed-on: https://chromium-review.googlesource.com/c/1409366
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58862}
      4064757c
  9. 03 Jan, 2019 1 commit
  10. 17 Dec, 2018 1 commit
  11. 28 Nov, 2018 1 commit
  12. 21 Nov, 2018 1 commit
    • Ross McIlroy's avatar
      [AsmJs] Avoid allocation of WasmModuleObject until instantiation. · ccd8073c
      Ross McIlroy authored
      Moves allocation of the WasmModuleObject for asm.js code out of SyncCompileTranslatedAsmJS
      since that is called when we are compiling the native context independent SharedFunctionInfo
      and the WasmModuleObject requires a native context. Instead save the members required to
      create the object in the AsmWasmData and create it during module instantiation. Note:
      since the Wasm module is an implementation detail for asm_wasm code and isn't exposed,
      this doeesn't have semantic change for asm.js code.
      
      As part of this change, the AsmWasmData is changed from a FixedArray to a dedicated
      struct. Some logic is also moved from module-compiler to wasm-engine to make the
      seperation between Wasm SyncCompile and AsmJS SyncCompile more clear.
      
      BUG=chromium:900535,v8:8395
      
      Change-Id: Ia48469c095b0688f210aa86e7430c9ab4ea4b26b
      Reviewed-on: https://chromium-review.googlesource.com/c/1345509
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57704}
      ccd8073c
  13. 13 Nov, 2018 1 commit
  14. 30 Oct, 2018 1 commit
  15. 11 Oct, 2018 1 commit
  16. 13 Sep, 2018 1 commit
  17. 21 Aug, 2018 3 commits
    • Toon Verwaest's avatar
      [scanner] Go back to untemplatized scanning with buffering · fcfd995a
      Toon Verwaest authored
      This reverts the following 3 CLs:
      
      Revert "[scanner] Templatize scan functions by encoding"
      Revert "[asm] Remove invalid static cast of character stream"
      Revert "[scanner] Prepare CharacterStreams for specializing scanner and parser by character type"
      
      The original idea behind this work was to avoid copying, converting and
      buffering characters to be scanned by specializing the scanner functions. The
      additional benefit was for scanner functions to have a bigger window over the
      input. Even though we can get a pretty nice speedup from having a larger
      window, in practice this rarely helps. The cost is a larger binary.
      
      Since we can't eagerly convert utf8 to utf16 due to memory overhead, we'd also
      need to have a specialized version of the scanner just for utf8. That's pretty
      complex, and likely won't be better than simply bulk converting and buffering
      utf8 as utf16.
      
      Change-Id: Ic3564683932a0097e3f9f51cd88f62c6ac879dcb
      Reviewed-on: https://chromium-review.googlesource.com/1183190Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55258}
      fcfd995a
    • Ben L. Titzer's avatar
      Reland "[asmjs] Properly validate asm.js heap sizes" · 438e7ec6
      Ben L. Titzer authored
      This is a reland of 5c309271
      (the CL was reverted because of a Chromium test that is now fixed)
      
      Original change's description:
      > Reland "[asmjs] Properly validate asm.js heap sizes"
      >
      > This is a reland of 5d69010e
      >
      > Original change's description:
      > > [asmjs] Properly validate asm.js heap sizes
      > >
      > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/)
      > > limitations on the size of asm.js heaps.
      > >
      > > R=clemensh@chromium.org
      > > CC=​mstarzinger@chromium.org
      > >
      > > Bug: chromium:873600
      > > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd
      > > Reviewed-on: https://chromium-review.googlesource.com/1174411
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#55163}
      >
      > Bug: chromium:873600
      > Change-Id: Id24070bda3aafb9e1a32af0732a1b18f633ef932
      > Reviewed-on: https://chromium-review.googlesource.com/1179681
      > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55193}
      
      Bug: chromium:873600
      Change-Id: I6eca2a89589070837b109278f964fc8e9a0fd6f1
      Reviewed-on: https://chromium-review.googlesource.com/1183081Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55249}
      438e7ec6
    • Aseem Garg's avatar
      Revert "Reland "[asmjs] Properly validate asm.js heap sizes"" · dd65e4b8
      Aseem Garg authored
      This reverts commit 5c309271.
      
      Reason for revert: Broke fast/workers/worker-shared-asm-buffer.html
      
      Original change's description:
      > Reland "[asmjs] Properly validate asm.js heap sizes"
      >
      > This is a reland of 5d69010e
      >
      > Original change's description:
      > > [asmjs] Properly validate asm.js heap sizes
      > >
      > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/)
      > > limitations on the size of asm.js heaps.
      > >
      > > R=clemensh@chromium.org
      > > CC=​mstarzinger@chromium.org
      > >
      > > Bug: chromium:873600
      > > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd
      > > Reviewed-on: https://chromium-review.googlesource.com/1174411
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#55163}
      >
      > Bug: chromium:873600
      > Change-Id: Id24070bda3aafb9e1a32af0732a1b18f633ef932
      > Reviewed-on: https://chromium-review.googlesource.com/1179681
      > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55193}
      
      TBR=mstarzinger@chromium.org,titzer@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:873600
      Change-Id: I5845c584c7ac399b9b7939f5fd50c09b7b2cc3d2
      Reviewed-on: https://chromium-review.googlesource.com/1182616
      Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
      Reviewed-by: 's avatarAseem Garg <aseemgarg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55242}
      dd65e4b8
  18. 17 Aug, 2018 1 commit
  19. 16 Aug, 2018 2 commits
  20. 07 Aug, 2018 1 commit
  21. 01 Aug, 2018 1 commit
  22. 17 Jul, 2018 1 commit
  23. 23 Jun, 2018 1 commit
  24. 09 Apr, 2018 1 commit
  25. 06 Apr, 2018 2 commits
    • Michael Achenbach's avatar
      Revert "[cleanup] Refactor the Factory" · 503e07c3
      Michael Achenbach authored
      This reverts commit f9a2e24b.
      
      Reason for revert: gc stress failures not all fixed by follow up.
      
      Original change's description:
      > [cleanup] Refactor the Factory
      > 
      > There is no good reason to have the meat of most objects' initialization
      > logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
      > this CL changes the protocol between Heap and Factory to be AllocateRaw,
      > and all object initialization work after (possibly retried) successful
      > raw allocation happens in the Factory.
      > 
      > This saves about 20KB of binary size on x64.
      > 
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
      > Reviewed-on: https://chromium-review.googlesource.com/959533
      > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52416}
      
      TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org
      
      Change-Id: Idbbc53478742f3e9525eee83342afc6aedae122f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/999414Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52420}
      503e07c3
    • Jakob Kummerow's avatar
      [cleanup] Refactor the Factory · f9a2e24b
      Jakob Kummerow authored
      There is no good reason to have the meat of most objects' initialization
      logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
      this CL changes the protocol between Heap and Factory to be AllocateRaw,
      and all object initialization work after (possibly retried) successful
      raw allocation happens in the Factory.
      
      This saves about 20KB of binary size on x64.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
      Reviewed-on: https://chromium-review.googlesource.com/959533
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52416}
      f9a2e24b
  26. 04 Apr, 2018 1 commit
  27. 22 Mar, 2018 3 commits
  28. 20 Mar, 2018 2 commits
  29. 16 Mar, 2018 1 commit
  30. 01 Feb, 2018 1 commit
  31. 18 Jan, 2018 1 commit
  32. 15 Nov, 2017 1 commit