- 22 May, 2019 9 commits
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:9277 Change-Id: If385439e2bdd8146fe3ba5734920b2096b6c1789 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622853Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61724}
-
Simon Zünd authored
The HandleApiCall uses BUILTIN_EXIT frames now instead of EXIT frames, so API calls show up in stack traces. We no longer need API builtins and this CL removes them and the corresponding C++ macros. Bug: v8:9183 Change-Id: Ifa2e842123ef7e96b2ff296116f46d5d799a63ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617249 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61723}
-
Sigurd Schneider authored
This is mainly a torque change, but as a drive-by we get rid of kStartOfPointerFieldsOffset kEndOfTaggedFieldsOffset which often are used to enclose a section of pointers in an object. Bug: v8:7793 Change-Id: I52d83d09249a3cc6a99e7e7506e154ccfca53a12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615249 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61722}
-
Michael Achenbach authored
TBR=mythria@chromium.org NOTRY=true Bug: v8:9246 Change-Id: I18d6c22da5746d3af34c65ea22fd5ef80e4f13fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622850Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61721}
-
Andrey Lushnikov authored
New revision: fe0467fd105a9ea90fbb091dc2a7b4cdbf539803 Change-Id: I0c53935b719194f16ade131f703d656749ace3d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1623586Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#61720}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12e7bf6..0742a14 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5655d8f..535dc1d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5716400..c7e440c Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9d4cde4..f71fb4f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5b1310e..2db48c7 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Icfaca034cd7956805b8ba7815c97bc4ba219ca3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1623633Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61719}
-
Andreas Haas authored
At the moment the implementation of LoadElemSegmentImpl is not ready to support the loading of passive element segments into tables with index > 0. I added a check so that we notice when somebody starts to implement it. R=binji@chromium.org Bug: v8:9270 Change-Id: I118da434cc379bbdb7bcef4af847216f5124551f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622105Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61718}
-
Andrew Comminos authored
Now that we support a max_samples parameter, it isn't actually necessary to have a record_samples flag (as it can just be modeled by 0). Change-Id: I578ecc9f6ee73ecbe1f93d0d04ee8028a9a2716d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611015 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit dac86be2. Reason for revert: Still failing msan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26904 Original change's description: > Reland "[heap] Add global memory controller" > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > This reverts commit 5e043f27. > > Tbr: ulan@chromium.org > Bug: chromium:948807 > Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61715} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: If30649f158a08fd185f2771a13b8e09cf53fb667 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622849Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61716}
-
- 21 May, 2019 31 commits
-
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. This reverts commit 5e043f27. Tbr: ulan@chromium.org Bug: chromium:948807 Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61715}
-
Fabrice de Gans-Riberi authored
This is a reland of 748de1e5 Original change's description: > [fuchsia] Replace zx_clock_get() with zx_clock_get_new(). > > zx_clock_get() signature is being replaced to report errors. > As part of a soft transition, zx_clock_get_new() is introduced with > the final function signature. > > Bug: chromium:963956 > Change-Id: Ia6d0f4fc560bd9149683011099b064540b54edd6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1616545 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61591} Bug: chromium:963956 Change-Id: I555df23d448fa246e4edec36b349a3c0aaad66ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617805 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#61714}
-
Michael Lippautz authored
This reverts commit cfe281f3. Reason for revert: Fails on gcc bots Original change's description: > [heap] Add global memory controller > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > Bug: chromium:948807 > Change-Id: I3283a2c28e6ab889f8d2ad85c9b67b8f234b9900 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619762 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61712} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I503d5a1436eb9156556b5bca852d2b2f9da2446f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622967Reviewed-by:
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. Bug: chromium:948807 Change-Id: I3283a2c28e6ab889f8d2ad85c9b67b8f234b9900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619762 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Ben Smith authored
These instructions were renamed in the October 2, WebAssembly CG meeting. The issue describing the change is here: https://github.com/WebAssembly/spec/issues/884 Change-Id: Ia9e8733156b5ed5db7fc9ab1681c1a51b874dd71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1620681Reviewed-by:
-
Clemens Hammacher authored
This method is rarely used, and has several problems: 1) It CHECKs that the value is not undefined, then creates a {Handle<T>} which again DCHECKs that the value is of type {T}. 2) It is called on a raw {FixedArray} but returns a handle. 3) It is often used when no handle is actually needed, adding unnecessary overhead. 4) It adds complexity and hides actual checks and handlification. This CL removes that method, replacing some uses by explicit CHECKs (in tests) and relying on the DCHECKs in the casts otherwise. R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: I90ff59e8b78c909a9a207029d8cc9ab16c0c7b56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621939 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Frank Tang authored
Design Doc: https://goo.gl/ZAtL1f Bug: v8:8515 Change-Id: I543ab704fd3f8b41e396879ebbc581977ec0ff10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612325Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61709}
-
Maciej Goszczycki authored
HeapObjectIterator now has a DCHECK preventing iterating over read-only space. This removes DumpMaps and switches to ReadOnlyHeapIterator instead. Bug: v8:7464 Change-Id: Ifd186d0e26d94c315308aa3a6ecb9da02a270fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622120 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61708}
-
Sigurd Schneider authored
Bug: v8:9264 Change-Id: I936d203d38410a6aefff8a54acf49468abb20e39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621933 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
StringPrototypeCharAt, StringPrototypeCharCodeAt, StringPrototypeCodePointAt Bug: v8:8996 Change-Id: I7faaec880801cfe244654a257dc98f67d4bc39ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617807Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Maciej Goszczycki authored
This makes the API more consistent. Originally I planned to use this to template iterators inside mkgrokdump, but I decided against it. Bug: v8:9183 Change-Id: Iefa372370a7cc7c637dc86c0bfb837a91a2bc6e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622116Reviewed-by:
-
Georg Schmid authored
R=tebbi@chromium.org Change-Id: I3f34eeaf4ab9a198ffc68a8c974f0bf35a0582e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622117 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
-
Toon Verwaest authored
This was already unsupported by the map updated because the condition was manually checked before CanBeInPlaceChangedTo. Since the latter function missed the check, however, new code using the function (json parser) missed the relevant check. Simply move the condition to the function. Bug: chromium:964869 Change-Id: I9424a5706c5f6d637acbf532707da3f1e7d9b55e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622114 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=yangguo@chromium.org Change-Id: Ic688665dc137bb0a1c0875f76b1c2b6360a10e2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615243 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61702}
-
Clemens Hammacher authored
When tracing function compilations, do also trace the function index and the function body size. This information often helps investigating bottlenecks in compilation. R=ahaas@chromium.org Bug: v8:8916, chromium:950493 Change-Id: Ibabd1b59827b67ac9b0ef3a78f121ab8fb2c4e09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622111Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61701}
-
Toon Verwaest authored
Check uintptr_t sized blocks of UTF16 chars at a time similar to NonAsciiStart. Fix readds the length precheck so we won't read out of bounds while aligning the start. Change-Id: Iaea901945a2445ba5bf50c67a6211356697ed1fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622115 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ifd8734aa682e238de54284c74209d236c7ac824f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622110Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:9183 Change-Id: Ibdf4633a9a57d0a37e1e2ef8930471e6acbf7e13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621944Reviewed-by:
-
Maya Lekova authored
This reverts commit c2e4183a. Reason for revert: Uninitialized value on MSAN, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26888 Original change's description: > [runtime] Speed up String::IsOneByte > > Check uintptr_t sized blocks of UTF16 chars at a time similar to NonAsciiStart. > > Change-Id: Ib4c498cc064e6ac7b6f8cc87ab700eafc8132c39 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622107 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61693} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: I2e18c9476f0ed47e77da87d2308a3429ef4f515c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622112Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#61697}
-
Simon Zünd authored
This CL changes the existing TorqueError struct into a more general TorqueMessage by adding a "kind" enum. The contextual for lint errors is removed and replaced by a list of TorqueMessages. A MessageBuilder is introduced to help with the different combinations of present information and method of reporting. A lint error with custom SourcePosition can be reported like this: Lint("naming convention error").Position(<src_pos_var>); While a fatal error, with CurrentSourcePosition can be thrown like this: Error("something went horrible wrong").Throw(); This approach is both backwards compatible and should prove flexible enough to add more information to messages or add other message kinds. Bug: v8:7793 Change-Id: Ib04fa188e34b3e8e9a6526a086f80da8f690a6f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617245 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61696}
-
Sigurd Schneider authored
Change-Id: I377e96fca2dff89a986b43f092ef7684d164cd9d Bug: v8:9264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617679 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61695}
-
Michael Achenbach authored
NOTRY=true Change-Id: Ice2b86a5104e55f9c618791222a3bb91a21b655f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621940Reviewed-by:
-
Toon Verwaest authored
Check uintptr_t sized blocks of UTF16 chars at a time similar to NonAsciiStart. Change-Id: Ib4c498cc064e6ac7b6f8cc87ab700eafc8132c39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622107 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit 42fee61a. Reason for revert: it's not safe to access in-object fields that way. Will post more information in Gerrit. Original change's description: > Reland "[torque] Convert few class layout to torque." > > This is a reland of b9bfd006 > > Original change's description: > > [torque] Convert few class layout to torque and updated torque code formatter. > > > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > > TemplateList, > > JSStrictArgumentsObject to torque. > > 2. Updated torque code formatter to now handle multi-line > > declarations correctly. > > > > Bug: v8:8952 > > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988 > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#61624} > > Removed the Torque code Formatter update from this CL > > Bug: v8:8952 > Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146 > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61671} TBR=surshar@microsoft.com,szuend@chromium.org Change-Id: I6fd66ce67aeecf0128878924d5e5b6a71ad88e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622109Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61692}
-
Andreas Haas authored
This was supposed to be only a clean-up, but the original code even invalidated a test and thereby covered a test. I fixed the bug here as well. Without testing it I think this fixes https://crbug.com/964607. Bug: v8:9183 Change-Id: I076f40a2302bfd5b7cecd2ae35d4e05a465e054b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621935 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
There was a case missing when we have a compressed value that: * Can be compressed signed * We know can't be a smi * Has to be converted to tagged pointer The case from tagged to compressed was also missing. This was the proper way of fixing the chromium bug (963917), and it could fix more things since a conversion was missing. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: chromium:963917, v8:8977, v8:7703, v8:8982 Change-Id: Id1df8e81bc900fef9bed3539c0ace621810ab1da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621941Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61690}
-
Andreas Haas authored
This CL fixes an issue where V8 does not satisfy the WebAssembly spec of the anyref proposal. The table.fill instruction has 3 parameters, {start_index}, {length}, and {value}. V8 trapped with table-out-of-bounds when {start_index >= table_size}. However, the spec requires that {start_index == table_size} is valid when {length == 0}. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: I5f83a03fb8e349b48c887535f6f065492feb9ac2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609537 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Peter Marshall authored
This is not needed as this is already a method on all ArrayBufferViews and there is only one caller which actually uses the cast. Bug: v8:9183 Change-Id: Ic45b40bf433c870bc8cb0121c24755fd03ce405b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622106 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
In contrast to (private) class fields, struct fields are public and accessed directly, and do not end in an underscore. This CL fixes naming in struct fields in the recently introduces {CompilationUnitQueues} class. R=ahaas@chromium.org Bug: v8:9183 Change-Id: I87d80650dc4a1c58cf8067ebb4ecfadf929545ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621936Reviewed-by: -
Clemens Hammacher authored
The semantics of that method are not obvious (it returns an empty MaybeHandle if the element is undefined, otherwise it assumes it is of type T). Since there is only a single use of that method in the whole code base, just having that logic there explicitly is much simpler. Potential future uses of that method are probably also easier to understand if they just to the checks explicitly. Drive-by: Document semantics of {FixedArray::GetValueChecked}. Also for this method it's quesionable whether it is useful overall. Drive-by^2: Avoid else after return (see style guide). R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: I88dcb0f080d728bbe55932f17cf4d7eb25ab5928 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619761 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Yang Guo authored
TBR=hpayer@chromium.org NOPRESUBMIT=true Bug: v8:9247 Change-Id: I3d49c1c748fe5109523d4cd122ba925f20cfc60b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619755Reviewed-by:
-
