- 14 Jun, 2021 21 commits
-
-
Sathya Gunasekaran authored
Constructors define instance types for their instances while accessors define a range of permissable instance types for receiver checks.\ Bug: v8:11476 Change-Id: I48b5326ec0a4e847283c2fa5c8f1705302727453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821430Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#75131}
-
Camillo Bruni authored
improve logEntry hit testing performance fixing flame graph rendering adding some comments adding flamechart highlighting Bug: v8:10644, v8:11835 Change-Id: I2ab2f63b9e8339c6c25bb7023772fc97dfc56c2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959615 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75130}
-
Clemens Backes authored
Code protection scopes now work with shared code, hence the TODO can be removed. R=jkummerow@chromium.org Change-Id: I925732c653f652d4576f21e82c96c1477b11ec12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959612 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75129}
-
Clemens Backes authored
This configuration (PKU with fallback to mprotect) is already finched, and can hopefully be enabled by default soon. Hence stage it behind --future to get more test and fuzzer coverage. R=jkummerow@chromium.org CC=dlehmann@google.com Bug: v8:11714 Change-Id: I5c38c71582e79e3348e6296cbf175655d00a635c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959611Reviewed-by:
-
Camillo Bruni authored
- Convert Builtin to enum class - Change int-based builtin_index methods to use Builtin - Change Builtins::builtin to Builtins::code Change-Id: Id9e3bb83da97e8894ca7ca78e1e852da60675619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949104 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75127}
-
Thibaud Michaud authored
Now that try blocks don't need a catch handler, ensure that we still properly close the scope when we handle the "end" opcode. R=clemensb@chromium.org Change-Id: I012939d5b3ee9caee9275a2f0abd65e517593870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959623Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75126}
-
Leszek Swirski authored
Add a new LogEntry for sharedlib PCs Change-Id: I4f7fdca93a9905e41b73347df475dffcb84bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959620 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This is a reland of 4cd856ee This CL fixes the problem that local_isolate() returned nullptr on the main thread. Original change's description: > [heap] Introduce ParkedSharedMutexGuardIf and use it in compiler > > In some cases it could happen that the concurrent compiler tries to get > a shared lock on a mutex that is already exclusively held by the main > thread. The background thread will then block itself until the > main thread leaves the critical section. If the main thread then also > starts a GC while holding the lock, this will result in a deadlock. > > A GC can't start until the background thread reaches a safepoint and > the main thread can't leave the critical section before the GC ran. > > This CL introduces a new version of SharedMutexGuard named > RecursiveSharedMutexGuardIfNeeded. This class will park the thread > when blocking is needed and will unpark the thread again as soon as > the lock was acquired successfully. This resolves the deadlock on > safepointing. > > Turbofan can then simply use that class internally for > MapUpdaterGuardIfNeeded. > > Bug: v8:10315, chromium:1218318 > Change-Id: Ice04b222cc979e4905791118caede26e71fca6de > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953288 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75107} Bug: v8:10315 Bug: chromium:1218318 Change-Id: Ic56afb14a537e0cbf412311f11407c1f09278225 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2958408Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75124}
-
Clemens Backes authored
M1 hardware uses the CodeSpaceWriteScope (which uses MAP_JIT under the hood), hence all other memory protection mechanisms should be disabled there. Trying to protect code space allocated with MAP_JIT would fail otherwise, resulting in a CHECK failure. R=jkummerow@chromium.org CC=dlehmann@chromium.org Bug: chromium:1218782 Change-Id: I626990575c2180168c2e421a93b9f0b035382f03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959613 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Victor Gomes authored
This guard is deprecated. We actually have floating patches in g3 that removes these lines. Change-Id: I11168b3ca1f3985039cf31ddef70d5b292de85b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959619 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This is the last CL of the code generated stores. Bug: v8:7790, v8:11600 Change-Id: If8bbabb422027f938c7acc0bdc12a233dfed580e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2950760 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Dan Elphick authored
This moves all of the FunctionTemplateInfo code into templates.cc and removes the inline keyword from BreakAtEntry which is moved out of templates-inl.h. As a result templates-inl.h no longer depends on shared-function-info-inl.h. This in turn uncovered lots of other missing includes which are now in place. Change-Id: I9bc152d5e3db0e793db135a8cfcf97f6d8bcbb8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953295Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75120}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8870cb4..b59724c Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c793cca..be7dcbc Rolling v8/buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/7e3b768..e5f25a3 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/950faee..7e85c7a Rolling v8/third_party/aemu-linux-x64: Hf11zqHzrfja2miAIic8j5jVjfs3rcuSFj8vUK-AVYAC..KF0Sz0CG_sURJodN44_YMwy0VU9tagOFFB_3EDTux1kC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a8bae77..2f46970 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b508ecd..ef579a1 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/53495a2..e2239ee Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0c64e83..de043ec Rolling v8/tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 Rolling v8/tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 Rolling v8/tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Iec2c37e934759add7caeb0876b4a057d2f5c22c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960074Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75119}
-
Manos Koukoutos authored
Additionally, reduce the maximum times a loop can be unrolled to 5. Bug: v8:11298 Change-Id: Ia3cc5955c91e70abf388e08bdc37aba998b34b93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953297Reviewed-by:
-
Clemens Backes authored
If a module is not fully (baseline) compiled yet, we cannot reliably tier it down, because we might not have the wire bytes for all functions available (in streaming compilation). After baseline compilation finished, we already check if we need to tier down, and do it then. Hence we can just skip any tier-down of unfinished modules. We cannot easily test this in V8 stand-alone, as inspector-test can only execute one command at a time, so we cannot trigger asynchronous compilation and then enable the debugger while this is running. R=thibaudm@chromium.org Change-Id: I250162a8d3c20599cacebff2f4f540ff6f8b1946 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953298Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75117}
-
Clemens Backes authored
WireBytesStorage is the class used to access the wire bytes of a function for compilation. It is stored and passed in a shared_ptr, because it can be updated while compilation is running, and the compilation threads will keep the old reference alive until the last reference is dropped. This CL fixes a few issues where we unnecessarily passed a reference to the shared_ptr instead of just a raw pointer, and changes one copy-assign into a move-assign to avoid an unneeded reference increase and decrease. R=thibaudm@chromium.org Bug: v8:11879 Change-Id: I18b626a7b6cde09d5b29f091bd9f49d01d408206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953196Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I3fa510b4dc35d3f58532ecbbeecd79d2826ff667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951722 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: chromium:1217912 Change-Id: Ic34e56a223ce4068c4ce62e001dd22b49f153d67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959608 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75114}
-
Andreas Haas authored
WebAssembly functions often have subsequent memory accesses, and each of these memory accesses need the start address of the memory in a register. With this CL the register with the memory start address is cached, so only the first memory access has to load the memory start address into a register, subsequent memory accesses can just reuse the register. In first measurements with the epic benchmark this reduces the size of the generated Liftoff code by a bit more than 5%. R=clemensb@chromium.org Bug: v8:11862 Change-Id: Ic33e7e3c00a4209570821269c728187affbeadcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947403 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: chromium:1217912 Change-Id: I61f1dd82a5fdcae3d134d05c76c06ee47feffcca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953281Reviewed-by:
-
Georg Neis authored
This reverts commit 26f4585e. Reason for revert: Clusterfuzz issues Original change's description: > [turbofan] Turn on --turbo-optimize-apply by default > > Bug: v8:9974 > Change-Id: I5853177be27d0d31087e436f0311d5a077cc2124 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951723 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75098} Bug: v8:9974 Change-Id: I6ead63c2ae8ed2693805c337b68435b3de99d018 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960208 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75111}
-
- 12 Jun, 2021 1 commit
-
-
Marja Hölttä authored
Drive-by: Also add deferred function references. Bug: v8:11525 Change-Id: If546f2e6c5a991372f1b99dac149504941a24b3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951731 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
- 11 Jun, 2021 18 commits
-
-
Igor Sheludko authored
This CL adds WASM_ARRAY_ELEMENTS to distinguish WasmArray maps. Bug: v8:11804 Change-Id: I243ce24c2f2246efbc223af14361c28506e9a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922884 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Zhi An Ng authored
This reverts commit 4cd856ee. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/16843/overview Original change's description: > [heap] Introduce ParkedSharedMutexGuardIf and use it in compiler > > In some cases it could happen that the concurrent compiler tries to get > a shared lock on a mutex that is already exclusively held by the main > thread. The background thread will then block itself until the > main thread leaves the critical section. If the main thread then also > starts a GC while holding the lock, this will result in a deadlock. > > A GC can't start until the background thread reaches a safepoint and > the main thread can't leave the critical section before the GC ran. > > This CL introduces a new version of SharedMutexGuard named > RecursiveSharedMutexGuardIfNeeded. This class will park the thread > when blocking is needed and will unpark the thread again as soon as > the lock was acquired successfully. This resolves the deadlock on > safepointing. > > Turbofan can then simply use that class internally for > MapUpdaterGuardIfNeeded. > > Bug: v8:10315, chromium:1218318 > Change-Id: Ice04b222cc979e4905791118caede26e71fca6de > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953288 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75107} Bug: v8:10315 Bug: chromium:1218318 Change-Id: Ied5d8d8f3e4c7e036a5a42a25c43e8ca1ecc1218 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2956698 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75108}
-
Dominik Inführ authored
In some cases it could happen that the concurrent compiler tries to get a shared lock on a mutex that is already exclusively held by the main thread. The background thread will then block itself until the main thread leaves the critical section. If the main thread then also starts a GC while holding the lock, this will result in a deadlock. A GC can't start until the background thread reaches a safepoint and the main thread can't leave the critical section before the GC ran. This CL introduces a new version of SharedMutexGuard named RecursiveSharedMutexGuardIfNeeded. This class will park the thread when blocking is needed and will unpark the thread again as soon as the lock was acquired successfully. This resolves the deadlock on safepointing. Turbofan can then simply use that class internally for MapUpdaterGuardIfNeeded. Bug: v8:10315, chromium:1218318 Change-Id: Ice04b222cc979e4905791118caede26e71fca6de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953288 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 5d84b6cb. Reason for revert: Breaks mac-arm64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/4636 https://chromium-swarm.appspot.com/task?id=5414a227cc3d6b10 Original change's description: > [no-wasm] Exclude trap-handler implementation > > The trap handler is only needed for WebAssembly, hence it can be > excluded in no-wasm builds (v8_enable_webassembly = false). > This makes it easier to port WebAssembly to platforms that do not need > to support WebAssembly. > > R=ahaas@chromium.org, jkummerow@chromium.org > CC=johnx@google.com > > Bug: v8:11877 > Change-Id: I25c34c2c4f1122227047e13add532ee2b9f73d2f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953285 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75101} Bug: v8:11877 Change-Id: I7a98341f6c03667c6400dced2bc69746011dd3d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2956868 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75106}
-
Dominik Inführ authored
Two DCHECKS had to updated to allow for concurrent MAP_SPACE allocations. Bug: v8:11708 Change-Id: I8a059d2e5942f511802a95ec27cf566414dd740e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951724Reviewed-by:
-
Junliang Yan authored
Port c5d41ae6 Original Message: Migrate the remaining architectures to the new callee save RecordWrite approach. Bug: v8:11420 Change-Id: I20ddf47690203fe9a0cd76dea3a08658582faf9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953486 Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75104}
-
Dan Elphick authored
This removes/replaces header includes with the aim of shrinking the size of the inline header cycle. Specifically before this CL, there was a single Strongly-Connected Component comprising 60 header files from src/objects and src/heap. Now there are two 2 SCCs. The src/heap SCC has 6 files and depends on the src/objects SCC, which has 50 files. Additionally some previously implicit dependencies have been added. Dependencies calculated using: git grep "#include \"" *.h *.cc | sed 's/:#include "/ /;s/".*$//' | \ awk 'BEGIN {print "digraph deps {" } END {print "}"} {print "\""$1"\" -> \""$2"\""}' SCCs found using sccmap from graphviz. Also removes unused Cell::FromValueAddress method. Change-Id: Ib19d00ccd14e490ee64d57be4d99b1b3686ac32a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951734Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Daan de Graaf authored
The two instructions are fused into a single Uadalp instruction, improving performance of quantized neural network operator implementations such as XNNPACK. Bug: v8:11546 Change-Id: Ic11b35d1e7758ee0b4ccfe8f592edc1aa798f6f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939997Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Daan de Graaf <daagra@google.com> Cr-Commit-Position: refs/heads/master@{#75102}
-
Clemens Backes authored
The trap handler is only needed for WebAssembly, hence it can be excluded in no-wasm builds (v8_enable_webassembly = false). This makes it easier to port WebAssembly to platforms that do not need to support WebAssembly. R=ahaas@chromium.org, jkummerow@chromium.org CC=johnx@google.com Bug: v8:11877 Change-Id: I25c34c2c4f1122227047e13add532ee2b9f73d2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953285Reviewed-by:
-
Thibaud Michaud authored
A try block may have no handler. Relevant links: https://github.com/WebAssembly/exception-handling/issues/131 https://github.com/WebAssembly/exception-handling/pull/157 R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ia429762714dd87ed6b043f95c3496c65aaa8495f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949100 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Vicky Kontoura authored
This CL fixes WebSnapshotDeserializer::DeserializeContexts(), so that the new FunctionContext is allocated after the ScopeInfo is set up. Bug: v8:11525, v8:11706 Change-Id: Idb14c0fa5b5d51827e9f208f54c82a94535343a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953292 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75099}
-
Georg Neis authored
Bug: v8:9974 Change-Id: I5853177be27d0d31087e436f0311d5a077cc2124 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951723Reviewed-by:
-
Dominik Inführ authored
We do not need to park/unpark when we can acquire the lock without blocking. Bug: v8:10315, chromium:1218318 Change-Id: I7909936531ffe83087182d50e759113a9305fbcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953287 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Clemens Backes authored
Functions defined inside a class declarations are inline by default. Thus remove the 'inline' annotation from all such definitions. Drive-by: Move the 'inline' annotation of {WasmFunctionBuilder::signature} from the definition to the declaration. R=jkummerow@chromium.org Bug: v8:11384 Change-Id: I18be0b7d83c2414b3237e2f834e470c613143d7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953320Reviewed-by: -
Leszek Swirski authored
Use the Streams API for file Blobs, instead of FileReader, to allow large files to be loaded in chunks. Change-Id: I241e0daff3f9c3d491dde2f3e8e52ea2236f05be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953286 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
We previously enumberated properties and then restricted them to real named properties. This CL changes it to only enumerate own properties in the first place. Bug: chromium:1213393 Change-Id: I8665a19a9beccae3bef99106924b65fb219d48ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953284Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#75094}
-
Liu Yu authored
Bug: v8:11421 Change-Id: I1d3f8d3211d06d3e47ffd530715c1dbfbaf79fe8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2954905 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75093}
-
Georg Neis authored
The output was utterly confusing because block identities were printed in different ways: - "id:5" for a block with id 5 - "B5" for a block with rpo number 5 - also (!!!) "B5" for a block with id 5 With this CL, the last case above is eliminated such that there is no ambiguity. I originally wanted to unify the prefix syntax as well (e.g. "id:5" and "rpo:5"), but the prefixes are hard-coded in countless places including CodeGenerator, Turbolizer, and Verifier. Many of these are format strings that are painful to write more generically. Change-Id: I0eb70731c7b1ef9a9999e0bcb58b673288932e93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940890 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
