- 25 Jul, 2018 1 commit
-
-
Florian Sattler authored
Avoid copying the last character to a local variable, by checking the parsing state in a different order. BUG=v8:7926 Change-Id: Ifb722dd3864737dc66d8e0885adbeba1376a059e Reviewed-on: https://chromium-review.googlesource.com/1148569Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#54680}
-
- 24 Jul, 2018 2 commits
-
-
Clemens Hammacher authored
This reverts commit 9c4200b2. Reason for revert: breaks arm64 msan: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/22108 Original change's description: > [scanner] Faster SkipMultiLineComment by avoiding a copy. > > Avoid coping the last character to a local variable, by checking the parsing > state in a different order. > > BUG=v8:7926 > > Change-Id: I0b62f711674beac8c81a25dd566a5ed0d681948b > Reviewed-on: https://chromium-review.googlesource.com/1148456 > Commit-Queue: Florian Sattler <sattlerf@google.com> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54657} TBR=marja@chromium.org,sattlerf@google.com Change-Id: I665bce8214e6d0b8f8a619820ff13f37bc722332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7926 Reviewed-on: https://chromium-review.googlesource.com/1148620Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54658}
-
Florian Sattler authored
Avoid coping the last character to a local variable, by checking the parsing state in a different order. BUG=v8:7926 Change-Id: I0b62f711674beac8c81a25dd566a5ed0d681948b Reviewed-on: https://chromium-review.googlesource.com/1148456 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54657}
-
- 20 Jul, 2018 1 commit
-
-
Toon Verwaest authored
Bug: chromium:861953 Change-Id: Id3a57aca0b24c421ac959d69265c449eaa214c16 Reviewed-on: https://chromium-review.googlesource.com/1138083 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54573}
-
- 03 Jul, 2018 2 commits
-
-
Toon Verwaest authored
Change-Id: I21b0dfb572efab3257e25f2f3b81689c07f8f2d7 Reviewed-on: https://chromium-review.googlesource.com/1124562 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54177}
-
Toon Verwaest authored
Most scanner logic doesn't need to care about surrogate pairs, so we can just push it down to identifier scanning. This CL additionally drops some explicit kEndOfInput checks that are subsumed by predicates seemlessly returning false for kEndOfInput (-1). Change-Id: If031a9355ab5fbca0c3b647045e3034f42923979 Reviewed-on: https://chromium-review.googlesource.com/1124447Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#54172}
-
- 21 May, 2018 1 commit
-
-
Mathias Bynens authored
The ECMAScript ⊃ JSON proposal shipped in V8 v6.6 and Chrome 66. Bug: v8:7418 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id8979d0cec6d61ef4a7e9982142a3f3dcf7c326b Reviewed-on: https://chromium-review.googlesource.com/1067857Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53271}
-
- 02 May, 2018 1 commit
-
-
Leszek Swirski authored
This reverts commit 2df5e7a7. Reason for revert: Mystery crashes https://bugs.chromium.org/p/chromium/issues/detail?id=838805 Original change's description: > [parser] Slice the source string where possible > > When internalizing string literals (for quoted strings or property names), > try to create a sliced string of the source string rather than allocating > a copy of the bytes. > > This will not work for string literals that contain escapes (e.g. unicode > escapes), and currently does not support two-byte strings. > > Bug: chromium:818642 > Change-Id: I686e5ad36baecd1a84ce5e124118431249b6c980 > Reviewed-on: https://chromium-review.googlesource.com/1010282 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52898} TBR=marja@chromium.org,yangguo@chromium.org,jarin@chromium.org,mlippautz@chromium.org,leszeks@chromium.org,verwaest@chromium.org Change-Id: I598b6668c43a3e843e2dd8e60852b2b2f3461954 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1039885 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52919}
-
- 01 May, 2018 1 commit
-
-
Leszek Swirski authored
When internalizing string literals (for quoted strings or property names), try to create a sliced string of the source string rather than allocating a copy of the bytes. This will not work for string literals that contain escapes (e.g. unicode escapes), and currently does not support two-byte strings. Bug: chromium:818642 Change-Id: I686e5ad36baecd1a84ce5e124118431249b6c980 Reviewed-on: https://chromium-review.googlesource.com/1010282Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52898}
-
- 15 Mar, 2018 2 commits
-
-
Sathya Gunasekaran authored
Pointing to the exact spot of the incorrect numeric separator seems clearer both in terms of the error itself, and the resulting code in scanner because we don't have to keep track of the start position. Previously, the error was: ➜ ./out.gn/x64.release/d8 --harmony-numeric-separator -e '0x1__1' unnamed:1: SyntaxError: Only one underscore is allowed as numeric separator 0x1__1 ^^^^ SyntaxError: Only one underscore is allowed as numeric separator Now, the error is: ➜ ./out.gn/x64.release/d8 --harmony-numeric-separator -e '0x1__1' unnamed:1: SyntaxError: Only one underscore is allowed as numeric separator 0x1__1 ^ SyntaxError: Only one underscore is allowed as numeric separator Bug: v8:7317 Change-Id: I7df1b39816e51a97234da6ed0fca1bf8c0223c3e Reviewed-on: https://chromium-review.googlesource.com/962241 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#51950}
-
Sathya Gunasekaran authored
Bug: v8:7317 Change-Id: I20fb706c05852668a5a6ae8b69c150ae2e6b2f65 Reviewed-on: https://chromium-review.googlesource.com/960901Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51943}
-
- 08 Mar, 2018 1 commit
-
-
Teddy Katz authored
This updates the scanner to use the correct error message when it encounters an octal escape sequence in a template literal. Previously, the error message referred to strict mode, even when the template literal was not in strict mode code. Bug: v8:7502 Change-Id: I37bb1338cf796c471108bc10f35f824cdf3ce0b7 Reviewed-on: https://chromium-review.googlesource.com/945411Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#51823}
-
- 06 Mar, 2018 1 commit
-
-
Taketoshi Aono authored
Revert "Revert "[parser] Implements proposal-numeric-separator."" This reverts commit 782f6401. Original CL is https://chromium-review.googlesource.com/c/v8/v8/+/923441 Bug: v8:7317 Change-Id: I6f541c038bad0cff625094ba84aebe582bdeb12f Reviewed-on: https://chromium-review.googlesource.com/945034Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51749}
-
- 01 Mar, 2018 2 commits
-
-
Deepti Gandluri authored
This reverts commit 517df524. Reason for revert: Fails MSAN tests - https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/20030 Original change's description: > [parser] Implements proposal-numeric-separator. > > https://github.com/tc39/proposal-numeric-separator > > This proposal-numeric-separator extends NumericLiteral and > allows developers to insert underscore(_) inside numeric literal. > > Bug: v8:7317 > Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 > Reviewed-on: https://chromium-review.googlesource.com/923441 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51671} TBR=adamk@chromium.org,jkummerow@chromium.org,hablich@chromium.org,gsathya@chromium.org,mathias@chromium.org,goto@google.com,brn@b6n.ch Change-Id: I6dcf46820caf20f28fbc11d94a5e8ced3cbbc78d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7317 Reviewed-on: https://chromium-review.googlesource.com/944767Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51672}
-
Taketoshi Aono authored
https://github.com/tc39/proposal-numeric-separator This proposal-numeric-separator extends NumericLiteral and allows developers to insert underscore(_) inside numeric literal. Bug: v8:7317 Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 Reviewed-on: https://chromium-review.googlesource.com/923441 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51671}
-
- 26 Feb, 2018 1 commit
-
-
Adam Klein authored
This proposal has not moved beyoned stage 2 in two years, and has never moved past the HARMONY_INPROGRESS state in flag-definitions.h. It was originally added to aide in desugaring yield*, but is no longer used for that purpose. Bug: v8:4700, v8:7310 Change-Id: Ieca40d8e4bf565516bbe71e47b996daa70d2e835 Reviewed-on: https://chromium-review.googlesource.com/935297 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#51582}
-
- 21 Feb, 2018 1 commit
-
-
Sathya Gunasekaran authored
Change-Id: I5a706b015a36a7a176a03e740f3fc3c406e6a837 Reviewed-on: https://chromium-review.googlesource.com/927263 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#51411}
-
- 15 Feb, 2018 1 commit
-
-
Mathias Bynens authored
This patch makes ECMAScript a syntactic superset of JSON by allowing U+2028 and U+2029 in string literals. Proposal repo: https://github.com/tc39/proposal-json-superset Bug: v8:7418 Change-Id: I7ef4ae6d85854ebc44a66e0eaf789814576832b7 Reviewed-on: https://chromium-review.googlesource.com/921228Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#51313}
-
- 06 Feb, 2018 1 commit
-
-
Sathya Gunasekaran authored
Bug: v8:5368 Change-Id: Idcb13e039614167da8b5be879e5644dbcb9df271 Reviewed-on: https://chromium-review.googlesource.com/899881Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51128}
-
- 17 Jan, 2018 1 commit
-
-
Sathya Gunasekaran authored
This patch does not add any functionality, it just parses the private fields. Adds a new harmony flag as well. Bug: v8:5368 Change-Id: I71ce11868f458571eb57a4bc922223931ce5baa8 Reviewed-on: https://chromium-review.googlesource.com/862526Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50662}
-
- 11 Dec, 2017 1 commit
-
-
Mathias Bynens authored
The use counter was originally added in https://chromium.googlesource.com/v8/v8/+/d3c9812143f14fa616ebe2581f8b0a14f725d92e (https://chromium-review.googlesource.com/c/v8/v8/+/693155). The CL that removes the plumbing in Chromium is here: https://chromium-review.googlesource.com/c/chromium/src/+/819632 BUG=v8:6827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie5f861fe2a64454e682d8cd0618c948642a32886 Reviewed-on: https://chromium-review.googlesource.com/819553 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50009}
-
- 02 Dec, 2017 1 commit
-
-
Mathias Bynens authored
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
-
- 17 Nov, 2017 1 commit
-
-
Adam Klein authored
Both of these features were shipped in Chrome 62. Bug: v8:4545, v8:6172 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ie00dcbeded7517a15696d4a78fcfbbf162919923 Reviewed-on: https://chromium-review.googlesource.com/775601Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49453}
-
- 31 Oct, 2017 1 commit
-
-
Adam Klein authored
The parser now throws for literals that are too big for the runtime to support, thus avoiding CHECK-failures further down the line. Tbr: rmcilroy@chromium.org Bug: v8:6791 Change-Id: Ie45ddebb8aa9e7a30e8b6b74f99916b700e38e4a Reviewed-on: https://chromium-review.googlesource.com/747682 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49059}
-
- 16 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=marja@chromium.org Bug: v8:6837, v8:6921 Change-Id: I17cf5cbbac3d2992c3b3588cc66e8564982453b6 Reviewed-on: https://chromium-review.googlesource.com/681355Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48596}
-
- 13 Oct, 2017 2 commits
-
-
Adam Klein authored
Reuses the existing logic for BigInt.parseInt, adapted slightly to allow octal and binary radix prefixes (and to support parsing of a raw character buffer, rather than a v8::internal::String). Bug: v8:6791 Change-Id: I41904b2204721eac452e0765fa9ff0ab26ee343b Reviewed-on: https://chromium-review.googlesource.com/711334 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48560}
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 09 Oct, 2017 1 commit
-
-
Jan Krems authored
Rewrites import.meta expressions into null literals. Builds on top of- and requires dynamic import parsing to simplify the implementation. Adds a new --harmony-import-meta flag. BUG=v8:6693 Change-Id: Iadb7ddf6bad8986bf3ad641dbd3826fe730b5f44 Reviewed-on: https://chromium-review.googlesource.com/702678 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#48359}
-
- 02 Oct, 2017 1 commit
-
-
Mathias Bynens authored
The context is the following proposal to make JSON a subset of JavaScript: https://github.com/tc39/proposal-json-superset There’s interest in performing a side investigation to answer the question of what would happen if we stopped treating U+2028 and U+2029 as `LineTerminator`s *entirely*. (Note that this is separate from the proposal, which just changes how these characters are handled in ECMAScript strings.) This is technically a breaking change, and IMHO it would be wonderful if we could get away with it, but no one really has any data on whether or not we could. Adding this use counter lets us get that data. BUG=v8:6827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia22e8db1634df4d3f965bec8e1cfa11cc7b5e9aa Reviewed-on: https://chromium-review.googlesource.com/693155 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48260}
-
- 26 Sep, 2017 1 commit
-
-
Jakob Kummerow authored
- Move things to conversions.cc that don't need to be in headers - Turn InternalStringToInt into a subclassable helper class so we can re-use it for BigInt.parseInt - Bonus: play a round of IWYU with all the .cc files who thought that #including conversions-inl.h would give them nice Unicode things Bug: v8:6791 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I64022543a9b83002e2b78416c7e87b40a1a016e6 Reviewed-on: https://chromium-review.googlesource.com/673725 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48174}
-
- 05 Sep, 2017 1 commit
-
-
Marja Hölttä authored
For such a simple predicate, calling a(n inline) function that checks against the values is faster (*) than maintaining the cache. (*) When scanning a file that contains only comments, we're basically calling IsLineTerminator in a loop. Parsing such files is now 7-18% faster in local experiments. BUG=v8:6092 Change-Id: I6a8f2aba9669a76152292f4e6c7853638d15aae3 Reviewed-on: https://chromium-review.googlesource.com/645633 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47810}
-
- 30 Aug, 2017 1 commit
-
-
Peter Marshall authored
Bug: v8:6333 Change-Id: I53d321292b0a2c7b7f72ee90bd119484f163bdc1 Reviewed-on: https://chromium-review.googlesource.com/637913 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47701}
-
- 02 Aug, 2017 1 commit
-
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 26 Jun, 2017 1 commit
-
-
hans authored
This is towards closing the perf gap between the MSVC build (which uses link- time optimization) and Clang (where LTO isn't ready on Windows yet). We did a study (see bug) to see which non-inlined functions are hit a lot during render start-up, and which would be inlined during LTO. This should benefit performance in all builds which currently don't use LTO (Android, Linux, Mac) as well as the Win/Clang build. The binary size of chrome_child.dll increases by 2KB with this. BUG=chromium:728324 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng Review-Url: https://codereview.chromium.org/2950993002 Cr-Commit-Position: refs/heads/master@{#46229}
-
- 25 Jun, 2017 1 commit
-
-
machenbach authored
Revert of Make some functions that are hit during renderer startup available for inlining (patchset #3 id:40001 of https://codereview.chromium.org/2950993002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2954833002/ E.g.: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/449680 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/324953 Please include those chromium trybots on reland. Maybe missing symbol export? Original issue's description: > Make some functions that are hit during renderer startup available for inlining > > This is towards closing the perf gap between the MSVC build (which uses link- > time optimization) and Clang (where LTO isn't ready on Windows yet). We did > a study (see bug) to see which non-inlined functions are hit a lot during render > start-up, and which would be inlined during LTO. This should benefit performance > in all builds which currently don't use LTO (Android, Linux, Mac) as well as > the Win/Clang build. > > The binary size of chrome_child.dll increases by 2KB with this. > > BUG=chromium:728324 > > Review-Url: https://codereview.chromium.org/2950993002 > Cr-Commit-Position: refs/heads/master@{#46191} > Committed: https://chromium.googlesource.com/v8/v8/+/d00d52be1fce9c1bf5558c8b26bf984efd09e65b TBR=jochen@chromium.org,mstarzinger@chromium.org,rmcilroy@chromium.org,vogelheim@chromium.org,marja@chromium.org,mlippautz@chromium.org,thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:728324 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2955793002 Cr-Commit-Position: refs/heads/master@{#46195}
-
- 23 Jun, 2017 1 commit
-
-
hans authored
This is towards closing the perf gap between the MSVC build (which uses link- time optimization) and Clang (where LTO isn't ready on Windows yet). We did a study (see bug) to see which non-inlined functions are hit a lot during render start-up, and which would be inlined during LTO. This should benefit performance in all builds which currently don't use LTO (Android, Linux, Mac) as well as the Win/Clang build. The binary size of chrome_child.dll increases by 2KB with this. BUG=chromium:728324 Review-Url: https://codereview.chromium.org/2950993002 Cr-Commit-Position: refs/heads/master@{#46191}
-
- 21 Jun, 2017 1 commit
-
-
bakkot authored
(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.) This was never legal; the spec only allows '\0' in strict-mode strings or templates when not followed by a decimal digit. Previously we were only enforcing that it not be followed by an _octal_ digit. This was already fixed for numeric literals, but not for escape sequences in strings. BUG=v8:6504 Review-Url: https://codereview.chromium.org/2948903002 Cr-Commit-Position: refs/heads/master@{#46106}
-
- 20 Jun, 2017 3 commits
-
-
machenbach authored
Revert of [parser] Forbid \08 in strict strings (patchset #3 id:40001 of https://codereview.chromium.org/2950633002/ ) Reason for revert: Breaks layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16403 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [parser] Forbid \08 in strict strings and in untagged templates > > This was never legal; the spec only allows '\0' in strict-mode strings or templates > when not followed by a decimal digit. Previously we were only enforcing that it > not be followed by an _octal_ digit. > > This was already fixed for numeric literals, but not for escape sequences in strings. > > BUG=v8:6504 > > Review-Url: https://codereview.chromium.org/2950633002 > Cr-Commit-Position: refs/heads/master@{#46046} > Committed: https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461153d2 TBR=vogelheim@chromium.org,bakkot@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6504 Review-Url: https://codereview.chromium.org/2946953002 Cr-Commit-Position: refs/heads/master@{#46068}
-
Daniel Vogelheim authored
R=marja@chromium.org Bug: chromium:726625 Change-Id: I3f451a47b5a60a4c367d04a5466acd9e2f90df14 Reviewed-on: https://chromium-review.googlesource.com/530849Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#46063}
-
bakkot authored
This was never legal; the spec only allows '\0' in strict-mode strings or templates when not followed by a decimal digit. Previously we were only enforcing that it not be followed by an _octal_ digit. This was already fixed for numeric literals, but not for escape sequences in strings. BUG=v8:6504 Review-Url: https://codereview.chromium.org/2950633002 Cr-Commit-Position: refs/heads/master@{#46046}
-