- 14 Feb, 2019 9 commits
-
-
Mythri authored
The megamorphic case in the KeyedStoreIC doesn't use/update any feedback. We could use this path to fast path some of the keyed stores instead of misssing to the runtime when the feedback vector is not available. This cl, moves the check for feedback vector from the bytecode handler to the KeyedStoreIC and calls the KeyedStoreIC_Megamorphic builtin when there is no valid feedback vector. This will help improve the performance of no feedback/jitless case. Bug: v8:8293 Change-Id: I71c128b355d47ac20e50fc836f4bc2cf0aab1154 Reviewed-on: https://chromium-review.googlesource.com/c/1460946 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59590}
-
Mathias Bynens authored
It shipped in Chrome 70. Bug: v8:7807, v8:8562 Change-Id: I5c5a9fc23656018ee6e9115af7a0c779230e681b Reviewed-on: https://chromium-review.googlesource.com/c/1450787 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#59589}
-
Dan Elphick authored
Class member initializer functions do not support lazy compilation, so change FunctionLiteral::AllowsLazyCompilation to return false for them. Change-Id: I38434f3a7e8c88af3f407cf19308fc3862ec4403 Reviewed-on: https://chromium-review.googlesource.com/c/1470103Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: chromium:930304 Change-Id: I7793f83b3f3e9aeaa3ecf114c6064773257e90e8 Reviewed-on: https://chromium-review.googlesource.com/c/1461167Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59587}
-
Tobias Tebbi authored
This reverts commit cee2f772. Reason for revert: Breaks sanitizer builds: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4682 Original change's description: > [build] disable C++ optimization for mksnapshot code. > > By disabling C++ optimizations for code that's only run in mksnapshot, > that is, CSA and Torque-generated code, we can save compile time. > I observed up to 2x improvements of compile time for some files, > while the mksnapshot time did not increase significantly. > > Bug: v8:7629 > Change-Id: I96be2966611b2471b68023e0dd9e351d94f0013c > Reviewed-on: https://chromium-review.googlesource.com/c/1460941 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59585} TBR=yangguo@chromium.org,sigurds@chromium.org,tebbi@chromium.org Change-Id: I50da40da167f49a14e3a8994377c4f9dafdfe2ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7629 Reviewed-on: https://chromium-review.googlesource.com/c/1472630Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59586}
-
Tobias Tebbi authored
By disabling C++ optimizations for code that's only run in mksnapshot, that is, CSA and Torque-generated code, we can save compile time. I observed up to 2x improvements of compile time for some files, while the mksnapshot time did not increase significantly. Bug: v8:7629 Change-Id: I96be2966611b2471b68023e0dd9e351d94f0013c Reviewed-on: https://chromium-review.googlesource.com/c/1460941Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59585}
-
tzik authored
has_prototype_slot on Context::FunctionMapIndex() is unused in its implementation, and all callers passes just true. Whether the function has prototype or not is determined by FunctionKind instead. Change-Id: I598515b25267dd3470cccbf3236b5e64c6959d00 Reviewed-on: https://chromium-review.googlesource.com/c/1469542Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#59584}
-
Johannes Henkel authored
... to ec358ccfd63a2a657c147329c7793d217e278a58. This adds support for CBOR <-> Value. v8 changes: - Add StringUTF8Adapter (from Pavel's change) - Add Binary::fromSpan (needed for the cbor->BinaryValue conversion). Change-Id: I09746dc361df0b150b23697a20b287613558c003 Reviewed-on: https://chromium-review.googlesource.com/c/1470955 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59583}
-
Francis McCabe authored
Focuses on decoder implementation and unittests of decoding return call instructions Bug: v8:7431 Change-Id: Ib1351bb26f8bac0a766d633486492fcd8ead627b Reviewed-on: https://chromium-review.googlesource.com/c/1455476 Commit-Queue: Francis McCabe <fgm@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59582}
-
- 13 Feb, 2019 31 commits
-
-
Frank Tang authored
This is part 1 of 2 of clean up. C++ change in Part 2 next. Bug: v8:8705 Change-Id: Ibf4425c141391581b963f4775286b65b652452e2 Reviewed-on: https://chromium-review.googlesource.com/c/1461172Reviewed-by:
-
Mythri authored
The uninitialized case in the StoreIC doesn't use any feedback. We could use this path to fast path some of the named stores instead of missing to the runtime when the feedback vector is not available. Bug: v8:8293 Change-Id: Ib3c4f843b24a377708f8db18fae10983e5633484 Reviewed-on: https://chromium-review.googlesource.com/c/1463781 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Header generating action needs to be in public_deps if generated header is included from header file in the targets depending on the action target. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Bug: chromium:931596 Change-Id: I198d9e09b8585b213ec4b375f10aecc6268f3bdd Reviewed-on: https://chromium-review.googlesource.com/c/1469545Reviewed-by:
-
Georg Neis authored
I had forgotten to remove this in https://chromium-review.googlesource.com/c/v8/v8/+/1458243 Change-Id: Id0da5f87f782e854b204f400173aa2bbecb4c43c Reviewed-on: https://chromium-review.googlesource.com/c/1470133Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:8562 Change-Id: I7f65b4cd92bb08434afe3a18512223adaf47feec Reviewed-on: https://chromium-review.googlesource.com/c/1470112 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#59577}
-
Anna Henningsen authored
This API has existed for two and a half years now, with no API changes over the last year, and is widely used in production, code so it makes sense to consider it stable. Change-Id: I10e38c37fb8c13e22124ef0985f4b0bd8d4615fd Reviewed-on: https://chromium-review.googlesource.com/c/1461999Reviewed-by:
-
Michael Starzinger authored
This switches from copying entire runtime stubs into each module to only having small jump table slots in each module that act as a trampoline to the actual embedded builtin representing the runtime stub. This reduces the memory footprint of modules. R=clemensh@chromium.org Change-Id: I3de528f7ebcc104f114ec32914d2b86e810d10d6 Reviewed-on: https://chromium-review.googlesource.com/c/1460474 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Junliang Yan authored
Bug: chromium:926235 Change-Id: I7af37f574c03439da34afc86cc8e6f49c3781579 Reviewed-on: https://chromium-review.googlesource.com/c/1470810 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#59574}
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: Ic34b996460b9ad2124f4bdb18afdcc83f2453e6a Reviewed-on: https://chromium-review.googlesource.com/c/1470109Reviewed-by:
-
Yang Guo authored
TBR=sergiyb@chromium.org Bug: v8:8840 Change-Id: I04c2e6a1703764416cbb9987de262fe4d2b86b14 Reviewed-on: https://chromium-review.googlesource.com/c/1470105Reviewed-by:
-
Jakob Gruber authored
This is a reland of c79a63e6 Original change's description: > [nojit] Don't expose wasm in jitless mode > > Wasm currently still creates executable memory even in > interpreter-only mode, and is thus unsupported in jitless mode. This > hides wasm completely, which will help e.g. fuzzers that attempt to > run wasm code (and currently crash on the CHECK in AddOwnedCode). > > Bug: v8:7777,chromium:931068 > Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 > Reviewed-on: https://chromium-review.googlesource.com/c/1470124 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59561} Tbr: mstarzinger@chromium.org Bug: v8:7777, chromium:931068 Change-Id: I535c3f598c90cd5c4072a73544cc33c5bf5460c1 Reviewed-on: https://chromium-review.googlesource.com/c/1470132Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59571}
-
Jakob Gruber authored
This reverts commit c79a63e6. Reason for revert: Needs addtl test skips: https://chromium-review.googlesource.com/c/1470124 Original change's description: > [nojit] Don't expose wasm in jitless mode > > Wasm currently still creates executable memory even in > interpreter-only mode, and is thus unsupported in jitless mode. This > hides wasm completely, which will help e.g. fuzzers that attempt to > run wasm code (and currently crash on the CHECK in AddOwnedCode). > > Bug: v8:7777,chromium:931068 > Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 > Reviewed-on: https://chromium-review.googlesource.com/c/1470124 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59561} TBR=mstarzinger@chromium.org,jgruber@chromium.org Change-Id: Ic242db3efe73ef362e0f0c3efde90682db6de4a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777, chromium:931068 Reviewed-on: https://chromium-review.googlesource.com/c/1470131Reviewed-by:
-
Toon Verwaest authored
We'll let the bytecode compiler and optimizing compilers deal with dead code, rather than the ast visitors. The problem is that the visitors previously disagreed upon what was dead. That's bad if necessary visitors omit parts of the code that the bytecode generator will actually visit. I did consider removing the AST nodes immediately in the parser, but that adds overhead and actually broke code coverage. Since dead code shouldn't be shipped to the browser anyway (and we can still omit it later in the bytecode generator), I opted for keeping the nodes instead. Change-Id: Ib02fa9031b17556d2e1d46af6648356486f8433d Reviewed-on: https://chromium-review.googlesource.com/c/1470108 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59569}
-
Maya Lekova authored
This reverts commit 74951850. Reason for revert: Speculative revert, possibly causing an Arm failure - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/2399 Original change's description: > [wasm] Fix two jump table offset parameters. > > R=jgruber@chromium.org > > Change-Id: I5b40819b1a746f16b7b18aac1bba65d83a7e3483 > Reviewed-on: https://chromium-review.googlesource.com/c/1470127 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59560} TBR=mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I94735b93371289f1f7d9190160b21b2eabb88b14 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1470130Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#59568}
-
Clemens Hammacher authored
This cleans up a few things after https://crrev.com/c/1458956. R=titzer@chromium.org Bug: v8:8562 Change-Id: I7904c195ee385f0aa8815447f440d8119601af3e Reviewed-on: https://chromium-review.googlesource.com/c/1460467 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
They did the same thing. Change-Id: I6b63762352dae2dce58fb3a6182af52cd0aadef6 Reviewed-on: https://chromium-review.googlesource.com/c/1470126 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59566}
-
Sigurd Schneider authored
TBR=yangguo@chromium.org Change-Id: I28b549cc569e654482cc77f0de269eb33ea12569 Bug: v8:8788 Reviewed-on: https://chromium-review.googlesource.com/c/1463782 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59565}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I73393686c1529a470b4c10297e88626555b9253e Reviewed-on: https://chromium-review.googlesource.com/c/1470128Reviewed-by:
-
Mythri authored
When an error occurs when storing the properties we either need to throw or ignore the error depending on the language mode. We used to infer the language mode from the type feedback vector. This cl instead falls back to runtime to check and throw an error when needed. Bug: v8:8580 Change-Id: Iebeb3ca86d753157329dc1b5cfd1c07af2ff3dcd Reviewed-on: https://chromium-review.googlesource.com/c/1458220Reviewed-by:
-
Junliang Yan authored
Port c142e0a2 Original Commit Message: Refactor the CallApiCallback builtin to - pass the context as with other stubs, and - pass holder and call data in registers. This avoids having to place holder and call data onto the stack, and thus makes it possible to easily call the CallApiCallback builtin from other builtins while just forwarding the (stack) arguments. The idea is to use this in the future to optimize the general case of calling into any API method via a FunctionTemplateInfo and doing appropriate security and/or interface checks upfront as necessary (eventually making the HandleApiCall C++ builtin obsolete at some point). R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic6c246bb28a6affa6fe015c1207c773b375a2b30 Reviewed-on: https://chromium-review.googlesource.com/c/1470443Reviewed-by:
-
Jakob Gruber authored
Wasm currently still creates executable memory even in interpreter-only mode, and is thus unsupported in jitless mode. This hides wasm completely, which will help e.g. fuzzers that attempt to run wasm code (and currently crash on the CHECK in AddOwnedCode). Bug: v8:7777,chromium:931068 Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 Reviewed-on: https://chromium-review.googlesource.com/c/1470124Reviewed-by:
-
Michael Starzinger authored
R=jgruber@chromium.org Change-Id: I5b40819b1a746f16b7b18aac1bba65d83a7e3483 Reviewed-on: https://chromium-review.googlesource.com/c/1470127Reviewed-by:
-
Georg Neis authored
Since that condition doesn't depend on anything other than the SFI, the IsInlineable method is the right place for checking it. This also has the benefit that the condition will get checked earlier so that we might avoid unnecessary work. Bug: v8:7790 Change-Id: Ie92d4b72c6c524c5e8412701b88e88c9d73fa5bd Reviewed-on: https://chromium-review.googlesource.com/c/1470061 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Nico Weber authored
For macros expanding to function definitions, I removed the spurious ; after macro invocations. For macros expandign to function declarations, I made the ; required and consistently inserted it. No behavior change. Bug: chromium:926235 Change-Id: Ib8085d85d913d74307e3481f7fee4b7dc78c7549 Reviewed-on: https://chromium-review.googlesource.com/c/1467545Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This removes most macros from the function body decoder unittest. It makes the {Validate} method (and the new {ExpectValidates} and {ExpectFailure}) templates, to receive the code in different formats. Drive-by: Rename "verify" to "validate". R=titzer@chromium.org Bug: v8:8562 Change-Id: I89e6125b52cf40a9539317bf16189208cd0592ab Reviewed-on: https://chromium-review.googlesource.com/c/1458956Reviewed-by: -
Junliang Yan authored
bug: v8:8828 Change-Id: I271f8cd4282f52fbcc573f6ccbe67b1111f62c7f Reviewed-on: https://chromium-review.googlesource.com/c/1448711 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Georg Neis authored
...by moving a special case into a separate method. Change-Id: I880768ed6fbb7d29b94588435c9da65b01f07fde Reviewed-on: https://chromium-review.googlesource.com/c/1462960 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: I7716dab4d6d0ff582acdffb988a05429bccab2ad Reviewed-on: https://chromium-review.googlesource.com/c/1462006 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
We should just always get an Object in rather than both Object and Object* where the former is dealt with through operator->. Change-Id: I2d2542f37a357d4c410cc5f07c8e3563e66660b7 Reviewed-on: https://chromium-review.googlesource.com/c/1470104Reviewed-by:
-
Georg Neis authored
They didn't take the new premonomorphic state into account. My bad. Bug: chromium:931424 Change-Id: I74ad1f0f8ce0eb764d63c2a3527e597962baca6d Reviewed-on: https://chromium-review.googlesource.com/c/1470125Reviewed-by:
-
Benedikt Meurer authored
Refactor the CallApiCallback builtin to - pass the context as with other stubs, and - pass holder and call data in registers. This avoids having to place holder and call data onto the stack, and thus makes it possible to easily call the CallApiCallback builtin from other builtins while just forwarding the (stack) arguments. The idea is to use this in the future to optimize the general case of calling into any API method via a FunctionTemplateInfo and doing appropriate security and/or interface checks upfront as necessary (eventually making the HandleApiCall C++ builtin obsolete at some point). Bug: v8:8820, chromium:913553 Change-Id: I10c0065016df4d0c24bac3d46945ea597b65ed02 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/1469821 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
