1. 28 May, 2019 1 commit
  2. 24 May, 2019 1 commit
  3. 21 May, 2019 1 commit
  4. 29 Apr, 2019 1 commit
    • Joey Gouly's avatar
      Reland "[arm64] Cleanup TODO around handling of x18" · 4f65233f
      Joey Gouly authored
      This is a reland of 7a2651cb
      
      x18 is not allocatable nor callee-saved in v8, so stop comparing
      the before/after value in tests.
      
      Presumably the Nexus failure was due to printf on that platform
      clobbering x18.
      This can be reproduced locally by modifying `CorruptAllCallerSavedCPURegister`
      to also corrupt x18.
      
      CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_android_arm64_n5x_rel_ng
      
      Original change's description:
      > [arm64] Cleanup TODO around handling of x18
      >
      > Use `padreg` instead of x18 to maintain alignment in the CPURegList.
      >
      > Also clean up some comments and tidy up RequiredStackSizeForCallerSaved
      > and PushCallerSaved.
      >
      > Change-Id: I80a780e5649e69a1746c43f37c2d1d875120c7a0
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581609
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
      > Cr-Commit-Position: refs/heads/master@{#60987}
      
      Change-Id: I7c023a4706a98bcb9aa5acd37016a6d01e3979a6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583762Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
      Cr-Commit-Position: refs/heads/master@{#61078}
      4f65233f
  5. 16 Nov, 2018 1 commit
    • Clemens Hammacher's avatar
      [iwyu] Ensure that macro assembler includes happen correctly · 1952f928
      Clemens Hammacher authored
      The platform specific macro assembler headers can not be included
      directly. They require symbols declared in macro-assembler.h.
      We also cannot include macro-assembler.h from the platform specific
      headers, because that would form a cycle, and the include in
      macro-assembler.h would be skipped, which then also fails.
      
      This CL documents and enforces this unfortunate situation.
      This helps with further iwyu cleanups.
      
      Note that current code which includes the platform specific headers
      only works because we transitively included macro-assembler.h already
      before.
      
      R=mstarzinger@chromium.org
      
      Bug: v8:8238, v8:7490
      Change-Id: I2dc65ad950400941406e1f2f8969d0d15f524bf8
      Reviewed-on: https://chromium-review.googlesource.com/c/1340240
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57578}
      1952f928
  6. 18 Jan, 2018 1 commit
  7. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  8. 18 Oct, 2017 1 commit
  9. 13 Oct, 2017 1 commit
  10. 06 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [assembler] Make Register et al. real classes · 9e995e12
      Clemens Hammacher authored
      Up to now, each architecture defined all Register types as structs,
      with lots of redundancy. An often found comment noted that they cannot
      be classes due to initialization order problems. As these problems are
      gone with C++11 constexpr constants, I now tried making Registers
      classes again.
      All register types now inherit from RegisterBase, which provides a
      default set of methods and named constructors (like ::from_code,
      code(), bit(), is_valid(), ...).
      This design allows to guarantee an interesting property: Each register
      is either valid, or it's the no_reg register. There are no other
      invalid registers. This is guaranteed statically by the constexpr
      constructor, and dynamically by ::from_code.
      
      I decided to disallow the default constructor completely, so instead of
      "Register reg;" you now need "Register reg = no_reg;". This makes
      explicit how the Register is initialized.
      
      I did this change to the x64, ia32, arm, arm64, mips and mips64 ports.
      Overall, code got much more compact and more safe. In theory, it should
      also increase performance (since the is_valid() check is simpler), but
      this is probably not measurable.
      
      R=mstarzinger@chromium.org
      
      Change-Id: I5ccfa4050daf4e146a557970e9d37fd3d2788d4a
      Reviewed-on: https://chromium-review.googlesource.com/650927Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47847}
      9e995e12
  11. 31 May, 2017 1 commit
    • martyn.capewell's avatar
      Reland of Reland of "ARM64: Add NEON support" · fc3f29d3
      martyn.capewell authored
      This reverts commit c5aad5f2
      The CL was reverted due to missing Chromium dependencies.
      
      This commit removes the simulator trace-based tests, and the associated header file dependencies, previously pulled in by DEPS. The NEON support now has only hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added in a later patch.
      
      BUG=chromium:718439
      
      Original issue's description:
      > Reland "ARM64: Add NEON support"
      >
      > This reverts commit cc047635.
      > The CL was reverted due to a missing DEPS mirror.
      >
      > Original issue's description:
      > > ARM64: Add NEON support
      > >
      > > Add assembler, disassembler and simulator support for NEON in the ARM64 backend.
      > >
      > > BUG=
      > >
      > > Review-Url: https://codereview.chromium.org/2622643005
      > > Cr-Commit-Position: refs/heads/master@{#44306}
      >
      > BUG=
      >
      > Review-Url: https://codereview.chromium.org/2812573003
      > Cr-Commit-Position: refs/heads/master@{#44652}
      
      Review-Url: https://codereview.chromium.org/2896303003
      Cr-Commit-Position: refs/heads/master@{#45633}
      fc3f29d3
  12. 15 Apr, 2017 1 commit
  13. 13 Apr, 2017 1 commit
  14. 31 Mar, 2017 2 commits
  15. 25 Jul, 2016 1 commit
  16. 07 Dec, 2015 1 commit
  17. 15 May, 2015 1 commit
  18. 04 Aug, 2014 1 commit
  19. 20 Jun, 2014 1 commit
  20. 03 Jun, 2014 1 commit
  21. 21 Mar, 2014 1 commit
  22. 12 Mar, 2014 1 commit
  23. 17 Feb, 2014 1 commit
  24. 12 Feb, 2014 1 commit