- 13 Feb, 2012 1 commit
-
-
yangguo@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/9388003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10682 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2011 2 commits
-
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jul, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
The only usage of it was in logging tests, I've switched them for using a file. I've left out support for "--logfile=*" for now, as Chromium uses it. Will be removed after the next V8 roll. R=sgjesse@chromium.org BUG=859 TEST=mjsunit/log-* Review URL: http://codereview.chromium.org/7310025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8629 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2011 1 commit
-
-
lrn@chromium.org authored
Encapsulate the helper functions in mjsunit.js. Now only exposes the exception class and the assertXXX functions. Make assertEquals use === instead of ==. This prevents a lot of possiblefalse positives in tests, and avoids having to do assertTrue(expected === actual) when you need it. Fixed some tests that were either buggy or assuming == test. Review URL: http://codereview.chromium.org/6869007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Mar, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
This should fix test-profile-generator/RecordStackTraceAtStartProfiling flakinness. R=vitalyr@chromium.org BUG=1261 TEST=test-profile-generator/RecordStackTraceAtStartProfiling Review URL: http://codereview.chromium.org/6708056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7294 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Feb, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
The main issue was due to multiple recompilations of functions. Now code objects are grouped by function using SFI object address. JSFunction objects are no longer tracked, instead we track SFI object moves. To pick a correct code version, we now sample return addresses instead of JSFunction addresses. tools/{linux|mac|windows}-tickprocessor scripts differentiate between code optimization states for the same function (using * and ~ prefixes introduced earlier). DevTools CPU profiler treats all variants of function code as a single function. ll_prof treats each optimized variant as a separate entry, because it can disassemble each one of them. tickprocessor.py not updated -- it is deprecated and will be removed. BUG=v8/1087,b/3178160 TEST=all existing tests pass, including Chromium layout tests Review URL: http://codereview.chromium.org/6551011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Feb, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
As they are no more used in DevTools profiler, there is no need to prefix them with "devtools.profiler" namespace. Review URL: http://codereview.chromium.org/6456025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Dec, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
This is no longer used in Chromium, and only pollutes code. BUG=859 Review URL: http://codereview.chromium.org/5575006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Feb, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/574027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Jan, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/548198 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jan, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
The problem appeared due to a fact that stubs doesn't create a stack frame, reusing the stack frame of the caller function. When building stack traces, the current function is retrieved from PC, and its callees are retrieved by traversing the stack backwards. Thus, for stubs, the stub itself was discovered via PC, and then stub's caller's caller was retrieved from stack. To fix this problem, a pointer to JSFunction object is now captured from the topmost stack frame, and is saved into stack trace log record. Then a simple heuristics is applied whether a referred function should be added to decoded stack, or not, to avoid reporting the same function twice (from PC and from the pointer.) BUG=553 TEST=added to mjsunit/tools/tickprocessor Review URL: http://codereview.chromium.org/546089 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Aug, 2009 2 commits
-
-
mikhail.naganov@gmail.com authored
MSVS names '.map' file using only module's name, so both 'a.exe' and 'a.dll' will have 'a.map' file. To distinguish an originating module, we're now checking for image base which is always 00400000 for .exe files, and not 00400000 for .dlls. Verified that windows-tick-processor can now process logs from Chromium using .map file generated for 'chrome.dll', an that it still works for V8's 'shell.exe'. Review URL: http://codereview.chromium.org/172044 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
http://code.google.com/p/v8/issues/detail?id=420 Review URL: http://codereview.chromium.org/171038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
'nm' is now called with an option to report function code sizes. Static code entries are restricted to the sizes reported, and the remaining unnamed code is attributed to a library as a whole. This makes reports more accurate, as some functions are tiny, but has chunks of unnamed code behind them. This change doesn't affect reporting on Windows, as in .map files function code sizes aren't specified. Review URL: http://codereview.chromium.org/149513 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jul, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Now tests can be run from any directory. Location of test data is now determined using test file location provided by 'testcfg.py' script. Tested under Linux, Mac, and Windows. Review URL: http://codereview.chromium.org/155161 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2009 2 commits
-
-
kasperl@chromium.org authored
TBR=mikhail.naganov@gmail.com Review URL: http://codereview.chromium.org/155137 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
Added tests for cmdline args parsing, symbols processing, and the whole process. Tick Processor code was refactored to make it testable. Review URL: http://codereview.chromium.org/149195 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jun, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
- fixed address delta calculation; - code creations are also compressed to be in sync with other events; - factored out a base class from TickProcessor to reuse code in DevTools profiler. Review URL: http://codereview.chromium.org/125256 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This reduces memory usage of tickprocessor. Thanks to William Hesse for pointing out this issue. Also speed up static symbols loading. Review URL: http://codereview.chromium.org/113101 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Details: - added properties / functions in view objects needed for WebKit's ProfileView; - added ability to count profiles for specific functions. The tickprocessor functionality does not affected. Review URL: http://codereview.chromium.org/99181 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1823 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/100102 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This is an effort to reuse profiler data processing code both in TickProcessor and Dev Tools Profiler. The old Python implementation will be removed. The new TickProcessor works almost identical to the previous one. However, it has some differences: 1. Not very useful "Call profile" section is replaced with a new WebKit-like "Bottom up (heavy) profile" which shows the most expensive functions together with their callers. I used it personally in order to find and remove bottlenecks in the tickprocessor script itself, and found it quite helpful. 2. Code entries with duplicate names (they occur for RegExes, stubs and sometimes for anonymous Function objects) are now distinguished by adding an occurence number inside curly brackets. 3. (Address -> code entry) mapping is more precise in boundary cases. 4. Windows version no more requires specifying .map file location. 5. Works faster. Review URL: http://codereview.chromium.org/99054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
It will be used both in the new tickprocessor and Dev Tools profiler. Review URL: http://codereview.chromium.org/92120 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Apr, 2009 2 commits
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/67253 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/77014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Found a pair of bugs concerned with border cases in the original implementation. Review URL: http://codereview.chromium.org/67191 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This is the first step in reimplementing tick processing scripts in JavaScript. The goal is to have the same source both for Dev Tools and Golem, so Python implementation will be removed to avoid code duplication. The implementation follows the Dev Tools style: namespaces and JSDocs are used. Review URL: http://codereview.chromium.org/67151 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-