- 06 Mar, 2017 19 commits
-
-
kozyatinskiy authored
This CL provide type with each break location, type could be: call, return or debugger statement. BUG=chromium:432469 R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2728563002 Cr-Commit-Position: refs/heads/master@{#43619}
-
ulan authored
The concurrent marker uses ObjectVisitor to iterate pointers in objects and local marking bitmaps to keep track of visited objects. To keep it simple for now, I removed support for multiple tasks and canceling unfinished tasks. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2732053002 Cr-Commit-Position: refs/heads/master@{#43618}
-
tebbi authored
This extends https://codereview.chromium.org/2728983002 to all of Turbofan, for the same reasons: The machine reducer is unreliable in signalling changed nodes and value numbering is unpredictable if not always re-run on changed nodes. Putting value numbering last in all graph reducers patches this. BUG=v8:6036 R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2730753003 Cr-Commit-Position: refs/heads/master@{#43617}
-
kozyatinskiy authored
This method could be called on pause and will do stepInto next scheduled callback if any will happen until next break. First implementation support only callbacks chained by Promise.prototype.then. BUG=chromium:432469 R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2723273002 Cr-Commit-Position: refs/heads/master@{#43616}
-
ulan authored
This patch adds a trivial ConcurrentMarking class that can start background tasks. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728363002 Cr-Commit-Position: refs/heads/master@{#43615}
-
jarin authored
Review-Url: https://codereview.chromium.org/2736723003 Cr-Commit-Position: refs/heads/master@{#43614}
-
Clemens Hammacher authored
From asm.js code we might get an empty ArrayBuffer as heap memory. In this case, both the old memory start and the new memory start will be nullptr. The size however has to be patched from default_size to 0. This CL changes code specialization to be able to either patch memory references, or patch memory sizes or both. R=titzer@chromium.org, ahaas@chromium.org BUG=chromium:698587 Change-Id: I4d9d811d75cb83842f23df317e8e7fc02aeb5146 Reviewed-on: https://chromium-review.googlesource.com/450257 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#43613}
-
bmeurer authored
BUG=chromium:698607 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2735633003 Cr-Commit-Position: refs/heads/master@{#43612}
-
jarin authored
Drive by: remove two unused methods in optimized code visitor. Review-Url: https://codereview.chromium.org/2730323002 Cr-Commit-Position: refs/heads/master@{#43611}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2735713002 Cr-Commit-Position: refs/heads/master@{#43610}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2737483002 Cr-Commit-Position: refs/heads/master@{#43609}
-
Michael Starzinger authored
This makes the collection logic of {Projection} nodes (i.e. value projections for multi-value returning calls) more robust. The projection nodes by now have a control input, which in turn can make them appear more than once in the use list of a call. We should limit the use list inspection to value edges only. This is in preparation of eliding any redundant {IfSuccess} control node. R=jarin@chromium.org Change-Id: I9bb4cc0e2e877976be55a894af972aa83d07d7d7 Reviewed-on: https://chromium-review.googlesource.com/450244Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43608}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2734823003 Cr-Commit-Position: refs/heads/master@{#43607}
-
neis authored
Instead of creating a signed comparison with INT_MAX, create an unsigned comparison with 0. This saves a few bytes in the generated code. R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2715513007 Cr-Commit-Position: refs/heads/master@{#43606}
-
addaleax authored
It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539). This removes it assuming that leaving it in the header was an oversight. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2732803002 Cr-Commit-Position: refs/heads/master@{#43605}
-
franzih authored
DataPropertyParameters are not specific to StoreDataProperty. Rename it to FeedbackParameter, so it can be used for similar ICs, e.g., future CollectTypeProfile. Also, the parameter for spread calls contains just one parameter, remove the plural s. BUG= Review-Url: https://codereview.chromium.org/2725263003 Cr-Commit-Position: refs/heads/master@{#43604}
-
clemensh authored
The previous fix (http://crrev.com/2720813002) was problematic for functions containing i64 parameters or returns. Those would throw a TypeError when called via WASM_TO_JS and JS_TO_WASM. Instead, we now unwrap the WASM_INTERPRETER_ENTRY function and call it directly. This removes the option to later redirect back to the original wasm function, but this functionality is not needed currently. Plus drive-by fix to put functions in anonymous namespace in wasm-compiler.cc. R=ahaas@chromium.org, titzer@chromium.org BUG=v8:5971, v8:5822 Review-Url: https://codereview.chromium.org/2725333002 Cr-Commit-Position: refs/heads/master@{#43603}
-
jarin authored
The function list is now filtered by category by default, and sorting improved to break ties better. Since the butterfly trees get massive, I had to start expanding the call trees on demand. This is implemented by keeping track of all ticks that cross given tree node (+ position where they crosses it). This seems to work quite well - in subsequent CL, I am planning to flip the bottom-up and top-down trees to use this. Review-Url: https://codereview.chromium.org/2730293002 Cr-Commit-Position: refs/heads/master@{#43602}
-
Michael Achenbach authored
The previous method was too brittle as applying a variable number of arguments to Date can be manipulated in too many ways, e.g. concat and apply semantics. The new method shoud suffice for most cases. BUG=chromium:698305 NOTRY=true TBR=yangguo@chromium.org,mstarzinger@chromium.org Change-Id: If6baf6ca8f1534c41ab8c50a5c507df89fbf0d16 Reviewed-on: https://chromium-review.googlesource.com/449653Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43601}
-
- 04 Mar, 2017 4 commits
-
-
vabr authored
BUG=v8:6026 Review-Url: https://codereview.chromium.org/2728463006 Cr-Commit-Position: refs/heads/master@{#43600}
-
jarin authored
Improvements: - top-down call tree. - interactive restriction to time interval. Review-Url: https://codereview.chromium.org/2696903002 Cr-Commit-Position: refs/heads/master@{#43599}
-
Ross McIlroy authored
Adwords dominates the numbers and is flaky. Speedometer is measured elsewhere. Perf sheriffs: This will change the numbers on the RuntimeStats benchmarks. Change-Id: Id64863b41b95269987c95d48ce90f24cfa86b86d Reviewed-on: https://chromium-review.googlesource.com/449674Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43598}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ce7164..10e3929 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/7ef7617..9b85841 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Iabe50034cbccb6163ddd8699cf0498c601c18ec2 Reviewed-on: https://chromium-review.googlesource.com/449933Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43597}
-
- 03 Mar, 2017 17 commits
-
-
bakkot authored
A previous patch lifting the restriction on invalid escape sequences in tagged templates had a bug when two template tokens appeared immediately adject to each other. This moves invalid escape information from the tokenizer state proper into the TokenDesc, preventing the overwriting which caused this issue. Previous CL is at https://codereview.chromium.org/2665513002 BUG=v8:6029,v8:5546 Review-Url: https://codereview.chromium.org/2724003006 Cr-Commit-Position: refs/heads/master@{#43596}
-
luoe authored
BUG=chromium:686003 Review-Url: https://codereview.chromium.org/2705533002 Cr-Commit-Position: refs/heads/master@{#43595}
-
bmeurer authored
We don't need the JSStrictNotEqual operator in the compiler, because this is never generated by the BytecodeGraphBuilder, and the code in the AstGraphBuilder was dead code. Also remove the backing builtin StrictNotEqual. R=mstarzinger@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2727003006 Cr-Commit-Position: refs/heads/master@{#43594}
-
Ross McIlroy authored
Spinning up a new background task is expensive, and many times an existing task will finish it's work before a new task starts work on a job, so enable the existing tasks to do more than one background job. BUG=v8:5203 Change-Id: Ibbef317c8bb3921c36a096fed88d244716be9c42 Reviewed-on: https://chromium-review.googlesource.com/441706 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43593}
-
Michael Achenbach authored
BUG=chromium:673246 NOTRY=true TBR=marja@chromium.org Change-Id: I87faa32ae602a10b68a22fce46ee3bb39a7aa171 Reviewed-on: https://chromium-review.googlesource.com/449754Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43592}
-
Marja Hölttä authored
BUG=v8:5516 R=verwaest@chromium.org Change-Id: Ica04f74788a4812128bce1297aeee23f8c3bec3d Reviewed-on: https://chromium-review.googlesource.com/449675Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43591}
-
mvstanton authored
Also prevent division by zero. R=tebbi@chromium.org BUG= Review-Url: https://codereview.chromium.org/2731723002 Cr-Commit-Position: refs/heads/master@{#43590}
-
Peter Marshall authored
The callsite in ConstructByArrayBuffer could have a length that is above Smi range if the buffer had such a length. Check this before calling. Add a test too. BUG=v8:5977, chromium:698201 Change-Id: Ic22046a31607f1f85642c8caf7f5ed064edb3110 Reviewed-on: https://chromium-review.googlesource.com/449813 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43589}
-
littledan authored
This refactoring is preparatory work to enable ICU to be the backend for timezone information rather than system calls. In the process, a bit of code duplication that was inserted in the Solaris port patch is eliminated here among modern POSIX backends. One possible performance downside of this patch is that it introduces a virtual method call for operations which were previously not virtual methods. However, a couple factors mitigate this effect: - The DateCache minimizes the need for calls into the TimezoneCache - These calls were already not very high performance, as they included a system call which requires an RPC to get out of the sandbox, and they are surrounded by C++ builtins, which require a JS to C++ transition. - A future transition to ICU, enabled by this refactoring, may improve performance by eliminating the system call. BUG=v8:6031 Review-Url: https://codereview.chromium.org/2731463003 Cr-Commit-Position: refs/heads/master@{#43588}
-
tebbi authored
Following the design of https://codereview.chromium.org/2692753004, also compute the arguments length in the deoptimizer sucht that it does not have to be computed in optimized code. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2729163002 Cr-Commit-Position: refs/heads/master@{#43587}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728113002 Cr-Commit-Position: refs/heads/master@{#43586}
-
Michael Achenbach authored
BUG=v8:6030 NOTRY=true TBR=hablich@chromium.org Change-Id: I28815078e1f3d27411fa985df35ff70ac49dbcb4 Reviewed-on: https://chromium-review.googlesource.com/449833Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43585}
-
Toon Verwaest authored
BUG=v8:6039 Change-Id: I69bae9ed49d91b0bc67a8e66e469d57ea7799cca Reviewed-on: https://chromium-review.googlesource.com/449793Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43584}
-
clemensh authored
If the imported wasm function is being debugged (i.e. redirects to the interpreter), call it via the JS_TO_WASM stub, such that we can disable the breakpoint later by patching the exported function. This also contains a drive-by fix in wasm-translation.cc (for the case that all known positions are bigger than the requested one). R=titzer@chromium.org, kozyatinskiy@chromium.org BUG=v8:5971, v8:5822 Review-Url: https://codereview.chromium.org/2720813002 Cr-Commit-Position: refs/heads/master@{#43583}
-
Peter Marshall authored
We should throw a RangeError for offset % elementSize before length.toPrimitive is observable. Adds a test that checks this, too. BUG=v8:6037 Change-Id: Ie9f2551c8e8fb0018b508762ac93cdc470e15dde Reviewed-on: https://chromium-review.googlesource.com/449792Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#43582}
-
franzih authored
The parameters for ConstructWithSpread and CallWithSpread both contain the arity for JavaScript calls with a spread as the last parameter and have the same functionality. Simplify them as one parameter. BUG= Review-Url: https://codereview.chromium.org/2729143002 Cr-Commit-Position: refs/heads/master@{#43581}
-
Michael Lippautz authored
Second part of relanding d2c093bc. BUG=chromium:651354 Change-Id: I4d48e870ac3a630ee1c286a86e630b8cf52cadf9 Reviewed-on: https://chromium-review.googlesource.com/449712Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43580}
-