- 16 Jun, 2020 18 commits
-
-
Manos Koukoutos authored
This is in anticipation of more complex type names coming from the new proposals. Change-Id: I1e5b8bd8c5b3edb5b603d36f6c5e9a787ebad504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243215 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68370}
-
Santiago Aboy Solanes authored
As a drive-by, change an if(...) else UNREACHABLE into a CHECK(...). Change-Id: I6440191c690f36444faa89ac0f7f7dde51ebba3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237143Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68369}
-
Camillo Bruni authored
Bug: v8:10604 Change-Id: If66656017e53da34aa69bbe19d915df08cf6f332 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246564 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#68368}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I92b36c8ac3d31837729f2e1ce9f3c756a6270da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2248182 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68367}
-
Michael Lippautz authored
- Untangles MarkingVisitor from Marker. - Adds ConservativeTracingVisitor encapsulating conservative tracing. This enables the following architecture: - Marking visitors (unified + stand-alone) inherit from MarkingVisitor; - Markers (unified + stand-alone) inherit (or directly use) Marker Bug: chromium:1056170 Change-Id: I05304c231d2983dab5611d05cf4aa8bfa3ed5e20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245600Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Change-Id: I3d2da18477df775b6ecc8e358a02f4e838961831 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241522 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#68365}
-
Manos Koukoutos authored
Changes: - Simplify and generalize ToValueTypeString. - Fix some error messages in msjunit so that they reflect the underlying error better. - Change 'exn' -> 'exnref' to match exception-handling proposal. Bug: v8:7581 Change-Id: I264f6c9aa598a57f39d5a4d01399af64db83a2b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243214 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68364}
-
Manos Koukoutos authored
This is in anticipation of more reference types from various proposals being implemented. Change-Id: I740ceeb3b6d6fc484a61f9ebee2181dbd6694440 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243213Reviewed-by:
-
Clemens Backes authored
Avoid spawning low-priority tasks for tier-up, since low-priority tasks map to the BEST_EFFORT priority in chrome, which will severly delay execution of the tasks and not execute them even if background threads are idle (see linked bug). We should look into reverting this once the gin platform implementation (or task scheduling) is adjusted to execute low-priority background tasks more reliably. R=ahaas@chromium.org Bug: chromium:1094928 Change-Id: I9e84eeedc7b83bfd17edb1cd09a0084770b20eda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247645Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/908ea81..a980f85 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/574cbd5..3200e0f Rolling v8/buildtools/linux64: git_revision:9a0496a74efd13c1bb2abd866d8a227404615068..git_revision:fbe7aec770944d17c9f3006f6cbb5c19e8cd43ea Rolling v8/third_party/aemu-linux-x64: VTMne1aEixrBYfQxsfnRBgzudRPhjV-iUQeXgznyNqgC..T98d0T9VlsHV98PPahwzBa8kF94z5dghLKOTUDCTmwYC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b919b00..9253b25 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/03705f6..e364dd8 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/79a0420..0d67b22 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe96d7bb6c8b4b359698446a3087e4d9c1668704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68361}
-
Georgia Kouveli authored
The C++ code uses the A instruction key for return address signing, which is the default for Clang and GCC when the -mbranch-protection option is used (although this can be configured to use the B key). Using the B key for JS means that it's not possible to use an A key signing gadget to replace a return address signed with the B key and vice-versa. This should offer a degree of separation from the C++ side. Bug: v8:10026 Change-Id: Ia9dcc7ae7096c96b4a271efbe25fc02940f6fc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242953Reviewed-by:
-
Anton Bikineev authored
Bug: chromium:1029379 Change-Id: I9b030cd8d130793ba5b79303b71e3d60be981218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246567 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Anton Bikineev authored
This also introduces CagedHeapLocalData. Bug: chromium:1029379 Change-Id: Ice04fe5ad7daa02f17ad107e78e53bdd32479737 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246560Reviewed-by:
-
Marja Hölttä authored
The DCHECK is true in the current V8 / Chrome. However, an embedder can create a snapshot where the object in question has dictionary properties (by using the object as a prototype). When reading the snapshot, in the object already has dictionary properties, and adding a property to it won't change it. The erroneous DCHECK was used to assert that adding a property to an object won't turn it to dictionary mode. But now it's in the wrong place, since this part of the code is executed after reading the snapshot in. The corresponding DCHECKs which are executed when setting up the objects before snapshot creation are still valid. Fixing the behavior wrt whether the object should turn dictionary mode or whether it should turn back is beyond the scope of this CL. See https://github.com/nodejs/node-v8/issues/160 Bug: v8:10479 Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577Reviewed-by:
-
Kim-Anh Tran authored
Extract commonly used instantiate() and evalWithUrl() functions. Bug: chromium:1093165 Change-Id: I14f8b49d556bc70d2092a80b41c5bbf678efd1a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245599 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#68356}
-
Andreas Haas authored
Recently the test harness of the js-api spec tests got updated to the test harness of wpt. With this CL we import the wpt test harness into V8. Some adjustments to the test harness had to be made. These additions are in the new files report.js and testharness-additions.js Bug: v8:10556 Change-Id: Ia5f7dec3f40ba8fc639135fb2b2078b9220eccf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235116 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68355}
-
Frank Tang authored
Dep on https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2242106 Bug: v8:10443 Change-Id: I258d3452120004df627af8d1c5f2b249d4b334c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242260 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Ie7bf807a51b2dd822b956a92d0051bfabcaf81eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246528Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68353}
-
- 15 Jun, 2020 21 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I729761b27786d84b0a730e2e001574eb329b7ef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243759Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68352}
-
Milad Farazmand authored
Change-Id: I1b045c2c3e9b199d3f24b191639b5f8c28e8ac5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247038Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68351}
-
Milad Farazmand authored
Change-Id: I93cc2793ab12602d0bd7df223bd662b10294e450 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246853Reviewed-by:
-
Michael Lippautz authored
- Document internal namespace - Various trivial fixes Bug: chromium:1056170 Change-Id: If527d491a37d7ccd0aa4ff829ccc5dc06c02da38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246569 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10347 Change-Id: I58ca7604ffb17a0fbc2ecc2799fc6888c26a7853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237354 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Implements f32x4 and f64x2 ceil, floor, trunc, nearestint for ia32. Bug: v8:10553 Change-Id: I272c20441297b9aebd39bc7ff96870b40e8ac653 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227257 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d2f7d428..f89ea875 Bug: v8:7834, v8:10554, v8:6891, v8:10395, v8:10449, v8:10578 Change-Id: I7fb15d34a80c38ec2adbfc25da6426462f549906 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2244434Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68346}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: Ia5ac4216066dc591e0492a6c0c66305faa94aa81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233986Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68345}
-
Ng Zhi An authored
The intention is to print the address of Block, print it without any cast. See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: Id174083d0c51518a808459b1b4cd12d5aa9781ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240503Reviewed-by:
-
Ng Zhi An authored
This is a reland of 3692bef9 Integer overflow in the test code is fixed by using MulWithWraparound. Original change's description: > [wasm-simd][x64] Prototype i32x4.dot_i16x8_s > > This implements I32x4DotI16x8S for x64 and interpreter. > > Bug: v8:10583 > Change-Id: I404ac68c19c1686a93f29c3f4fc2d661c9558c67 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229056 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68244} Bug: v8:10583 Change-Id: Ie7d0032f5398b6f725c02b572764258adacc8578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2236962Reviewed-by:
-
Thibaud Michaud authored
When inserting the temporary cache key for synchronous compilation, use the NativeModule's owned wire bytes. When we eventually install the native module, key comparison can then take the fast path by checking base pointer equality instead comparing the full bytes. R=clemensb@chromium.org Bug: chromium:1035786, v8:10576 Change-Id: I4bfb948b4383d58dd11060a7d1d1e0495ddeed2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246559Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I1c6622bd476832852af64c299dcf952bc9e92fe5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245602Reviewed-by:
-
Arnaud Robin authored
The registers were not spilled correctly in liftoff when tracing function calls, which caused runtime errors. R=clemensb@chromium.org CC=thibaudm@chromium.org Bug: v8:10559 Change-Id: Ic0a9ae8a286bdee8f8440e006d0b47e52241ea5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245595Reviewed-by:
-
Jakob Gruber authored
... to OptimizedCompilationInfo, BytecodeGraphBuilder, and JSHeapBroker. Also add first uses of these flags in pipeline.cc by skipping certain phases when nci is enabled. With this change, tests in the NCI variant will start to fail since generic lowering is not fully implemented. These implementations will follow incrementally in the next days. Bug: v8:8888 Change-Id: I3f570fb92f09059d1f1f4015f88ffe80ccf746ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239572 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Introduce HeapBase as an internal base implementation for concrete heaps (unified, stand-alone). Change-Id: I0aa7185e23f83e01e4e2ca23d983b28e32bb610e Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238573 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Yang Guo authored
R=szuend@chromium.org Fixes: chromium:718827 Change-Id: I261ce2cf692b5bcf88f4f7f67249ec49c837de4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241521Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68337}
-
Emanuel Ziegler authored
This is a reland of change Idb1061cafcba7a2a654a207402dca520f79a3bbe. The access to wire_bytes has been protected by using atomic operations. Under some circumstances, Wasm is trying to log code for which the wire bytes are not fully loaded yet. This can happen during streaming compilation when a few functions are already fully compiled but the engine is still streaming the remaining functions. If the profiler now kicks in, it will attempt to log these freshly compiled functions. As these functions will not be executed before the module is fully compiled, we can simply defer the logging in this case. R=clemensb@chromium.org Bug: chromium:1085852 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: Iccb6607e8adb9fdaf6138d4ccd30de58d6a6cdff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230536 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
We currently hit a nullptr access when trying to update the detected feature set. Instead of adding a check for nullptr there (which would be unnecessary overhead in production code), we just pass a pointer when compiling for debugging. R=thibaudm@chromium.org Bug: chromium:1092408 Change-Id: I7804edc3f67237bbf28d0ed2f5c58339d3a0f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238080Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68335}
-
Andreas Haas authored
R=v8-arm-ports@googlegroups.com, clemensb@chromium.org Bug: v8:10108 Change-Id: I2026c50536a3053aa3bc7d412ed67ff13c5fa0e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231338 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Jakob Gruber authored
We recently changed uc32 to be an unsigned type, and with the invalid marker being static_cast<uc32>(-1) this DCHECK no longer holds. After this CL it expicitly checks for the invalid marker. Bug: v8:10568,chromium:1094226 Change-Id: Idd9efe055b38387e3e37b132cb786cca130767b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245592 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68333}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80a5599..908ea81 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa95742acd71c233dc06f7335e3f03fb64feb89e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245216Reviewed-by:
-
- 14 Jun, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6fbfa22..80a5599 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5e1d63a..79a0420 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia26223b35726dd00abede7ff99d804dd9f40dd38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245088Reviewed-by:
-
