- 28 Jun, 2019 12 commits
-
-
Maciej Goszczycki authored
This is a reland of 24ac9a9a Fixed an msvc warning. Original change's description: > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > Shared read-only heap is currently incompatible with pointer compression. > Enable sharing only if pointer compression is disabled. > > Bug: v8:7464 > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Cr-Commit-Position: refs/heads/master@{#61963} Bug: v8:7464 Change-Id: Ieb5fefe8be1f94e0ac8e769d73de21427559ccab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681128Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#62445}
-
Igor Sheludko authored
The latter is better because it takes field type into account when decompressing field value. Drive-by: use [DECL_]ACCESSOR macros for some fields. Bug: v8:9353 Change-Id: I3d7f07d11b1e379e3e6cf0310d836af6b48c1338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680539 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62444}
-
Darius Mercadier authored
To choose the evacuation candidates, all the pages were put in a vector, then sorted, and then only select if, among other thing, they had enough free bytes in them. It meant sorting a lot of pages that couldn't be selected. With this CL, only the pages with enough free bytes are put in the vector, which should (slightly) improve the time needing to select the evacuation candidates. Bug: v8:9329 Change-Id: I0261fe3554c0bf75136a84a35d5c6a231762afe8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680554Reviewed-by:
-
Johannes Henkel authored
New Revision: 8b7ea912e516a6daa61487c700687a9426e3a396 Update v8 files / build config accordingly. - There's now a new library in third_party/inspector_protocol, bindings/bindings.h, which is configured much like encoding/encoding.h. It doesn't have much stuff in it yet, but will soon get more code that would otherwise need to go into jinja templates. It also comes with a new test, only a smoke test thus far. Change-Id: I9c00a54a840c214b4bb744a3b272e5ce221954fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678273Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62442}
-
Yang Guo authored
TBR=jgruber@chromium.org Bug: v8:9247 Change-Id: I8024f701eae2a8b0d60fe859503089dd76b4d5bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681123Reviewed-by:
-
Ulan Degenbaev authored
The flag configures both the young and old generation limits. Bug: v8:9306 Change-Id: Ib94dcb6dc014864248a5926f585b54a83db28063 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679500Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62440}
-
Mathias Bynens authored
Instead of conditionally normalizing file paths, go back to using the basename in the dynamically-generated regular expression pattern. Bug: v8:7950, v8:9395, v8:9406 Change-Id: I57d2449a8229a67b038c7fcffe36218848d9a575 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681122Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#62439}
-
Yu Yin authored
port e304d80e https://crrev.com/c/1660618 Original Commit Message: powered by a new function Execution::CallWasm and a corresponding, Turbofan-generated CWasmEntry stub. This entirely sidesteps the traditional Execution::Invoke -> JSEntryStub path. Change-Id: I4d3a284779ecff27e39fffb658c608b16c43d828 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679962 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62438}
-
Yang Guo authored
TBR=luoe@chromium.org Bug: chromium:976713 Change-Id: Ib92c6054a017a94ad23721de240b8a20d87c9f85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680544Reviewed-by:
-
Sigurd Schneider authored
..until issue is resolved. TBR=jarin@chromium.org Change-Id: I304ab6bf2c4dcb28af022e07c7fc4719c5239d82 Bug: v8:9404 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681121 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/b568df7..024e273 [js-api] Remove incorrect note about object caching. (#1036) (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/024e273 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I167825682594ae758aa62098d18119cdbc4fee96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681320Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62435}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/deba8b5..f9c4d9d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d16c410..ac493ee TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ic3b556f79d3a7b9c5fe332ac418dc4fce0e995e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681319Reviewed-by:
-
- 27 Jun, 2019 28 commits
-
-
Daniel Clark authored
This change is a partial implementation of Synthetic Module Record as specified here: https://heycam.github.io/webidl/#synthetic-module-records This includes: - Introduce SyntheticModule class inheriting from Module. - Extend v8::Module interface in v8.h to include Synthetic Module APIs, with corresponding implementations in api.cc. - Provide SyntheticModule implementations of PrepareInstantiate, FinishInstantiate, and SetExport. - Provide cctest unit tests for the implementations in the preceding item. We will follow up with further submissions to implement the remaining members of SyntheticModule (ResolveExport and Evaluate). Bug: v8:9292 Change-Id: I25b1b695b5d1c3004677cd685f0dfd95283438fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1626829 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#62433}
-
Adam Klein authored
Add gdeepti and bbudge, remove aseemgarg. Change-Id: I87a9e0b36b1233aae5fb72d019e9b8b413d10f9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680799Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#62432}
-
Z Nguyen-Huu authored
GetPropertyWithReceiver is similar to GetProperty, except that additional receiver parameter is used in TryPrototypeChainLookup to support GetPropertyWithReceiver stub. We only use this stub in ProxyGetProperty builtin for now. Bug: v8:8958 Change-Id: Ied60e4f6ee6e09bca2f161048b481a0bf37a78a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1676879 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#62431}
-
Ng Zhi An authored
Bug: None Change-Id: Idc7857342e9249d66473ab4af1044e1cd2cab5a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680788Reviewed-by:
-
Milad Farazmand authored
Port e304d80e Original Commit Message: powered by a new function Execution::CallWasm and a corresponding, Turbofan-generated CWasmEntry stub. This entirely sidesteps the traditional Execution::Invoke -> JSEntryStub path. R=jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I87c85f3506c4e4dae12e462dd3c7790bc9ab25d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680798Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#62429}
-
Georg Neis authored
This reverts commit a05bcc3a. Reason for revert: Still issues with maybe_assigned, blocking roll. Original change's description: > Reland "Enable lazy source positions by default" > > Second attempt to reland 69fafb5f > now that the maybe_assigned bug is fixed. > > > Original change's description: > > Enable lazy source positions by default > > > > Also adds a compile time flag which allows the default to be configured > > so node can disable it since it hangs the node cpu profiler tests. > > > > Bug: v8:8510 > > Change-Id: Idf4785036dc6242769410091518a67ac9179b718 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491491 > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#62089} > > Bug: v8:8510 > Change-Id: Ia6d5d1d3a3c2b6a14c70ee67b02bec62a6a1a1d4 > Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg, v8_linux64_gc_stress_custom_snapshot_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679498 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62411} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: I52b2924e05ff87f6469be4723e5e13979d1aeffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8510 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg, v8_linux64_gc_stress_custom_snapshot_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680553Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: Ieab0007b477894fb8e4c662e584b54cb1e288041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680549 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62427}
-
Francis McCabe authored
This reverts commit 24ac9a9a. Reason for revert: compilation failures on windows. See https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20builder/29313 Original change's description: > Reland "[roheap] Enable shared ro-heap by default if ptr compression is disabled" > > This is a reland of fb4d5480 > > Few test-serialize tests were not clearing the shared heap before using a > new snapshot, breaking the noembed build. This is fixed now and a check > has been added > (https://chromium-review.googlesource.com/c/v8/v8/+/1667415) to make > sure it doesn't happen again. > > Original change's description: > > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > > > Shared read-only heap is currently incompatible with pointer compression. > > Enable sharing only if pointer compression is disabled. > > > > Bug: v8:7464 > > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > > Reviewed-by: Dan Elphick <delphick@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > > Cr-Commit-Position: refs/heads/master@{#61963} > > Bug: v8:7464 > Change-Id: Ie7d09cebf897a3f0e4a6c103ad0c132c4faf6c6e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667418 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Cr-Commit-Position: refs/heads/master@{#62425} TBR=delphick@chromium.org,goszczycki@google.com Change-Id: Ia96e2f13b502f96315ac2ed3447373c7b5774c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680659Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#62426}
-
Maciej Goszczycki authored
This is a reland of fb4d5480 Few test-serialize tests were not clearing the shared heap before using a new snapshot, breaking the noembed build. This is fixed now and a check has been added (https://chromium-review.googlesource.com/c/v8/v8/+/1667415) to make sure it doesn't happen again. Original change's description: > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > Shared read-only heap is currently incompatible with pointer compression. > Enable sharing only if pointer compression is disabled. > > Bug: v8:7464 > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Cr-Commit-Position: refs/heads/master@{#61963} Bug: v8:7464 Change-Id: Ie7d09cebf897a3f0e4a6c103ad0c132c4faf6c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667418Reviewed-by:
-
Jakob Kummerow authored
powered by a new function Execution::CallWasm and a corresponding, Turbofan-generated CWasmEntry stub. This entirely sidesteps the traditional Execution::Invoke -> JSEntryStub path. Change-Id: If2b97825cca4ce927eecbddc248c64782d903287 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660618 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62424}
-
Hannes Payer authored
Bug: v8:9093 Change-Id: I7c415fd0ea9e48f7ee189115f164825cb120695b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624213 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
The macro pn ensures that TurboFan nodes can be easily printed in gdb, even in release builds where Node::Print is sometimes not available (because all uses have been inlined). This CL also modifies the print function to deal gracefully with nullptr input nodes, which is helpful for debugging. Change-Id: Ib5f58aa13b719c8390826bc89dfe21cf58586de5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672941Reviewed-by:
-
Mathias Bynens authored
d8 treats files with the .mjs extension as modules instead of classic scripts. Thus, the `// MODULE` pragma and its corresponding logic in test runners can be removed in favor of explicitly adding the extension. Bug: v8:7950, v8:9395, v8:9406 Also-By: tmrts@chromium.org Change-Id: Ic74328dc5c5f176bb4bdf6d74bdd4d3966279ba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675958 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Previously, the early bailout for incremental marking only considered V8's memory which does not work when a big porition of memory is actually allocated globally. Bug: chromium:948807 Change-Id: Ie85c3c68f2b677ef87aba9e70ae74e65783a1fac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680542Reviewed-by:
-
Jakob Gruber authored
BoyerMoorePositionInfo is a simple wrapper around a bitset and an associated ContainedInLattice field. This CL refactors bitset-related operations that used to be implemented naively (e.g.: loop over all bits to find a single set bit, or to generate a union of two bitsets). Instead, use more suitable methods from base::bits and std::bitset. Drive-by: Remove dead class members. Drive-by: Zero the ByteArray with memset. Bug: v8:9359 Change-Id: I33923c7d216320f4e3d7e4a6df2967f4aa86ab05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667407 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62419}
-
Georg Neis authored
Such as making the Disallow* scope always the first thing in a function, and const-ifying a few members. Bug: v8:7790 Change-Id: I78e0701101ee63475bfa30230a2da54da730ba73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679508 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Currently, `intl/regress-7770` fails on environments with `LC_ALL` set, e.g. export LC_ALL=en_US.UTF-8 While engineers can manually work around it using `unset LC_ALL` before running the test suite, it would be more convenient if the test runner didn't rely on the absence of this environment variable in the first place. Bug: v8:8845 Change-Id: I8116e2fd369be1d561dfe465f2901d07d3f75510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680538 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: -
Igor Sheludko authored
... when querying internalized strings table and computing hash. Bug: chromium:974612 Change-Id: I59eed1477c8893cd0ff3eae593da092492668614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678418Reviewed-by:
-
Hannes Payer authored
Bug: chromium:966832 Change-Id: If705f3b3a58f1fa316499fb7f645751fd1e6f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679507 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Dan Elphick authored
If --stress-lazy-source-positions is enabled then always collect source positions after lazy compilation to try and flush out bytecode mismatch bugs. Bug: v8:8510 Change-Id: I895611c9fde2c4743d62951674277973def01d3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679502 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... and add getters with Isolate parameter. Bug: v8:9353, v8:9396 Change-Id: Iab1e4652859f0a8922af6243bac3caee0888df63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679503Reviewed-by:
-
Santiago Aboy Solanes authored
In https://chromium-review.googlesource.com/c/v8/v8/+/1621941 we added missing representation changes. By changing the return to an assignation, we forgot to include the (now needed) else. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: Ibc54a24ea4430fd43d70251ef1a44ef15c06aa46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678659Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62412}
-
Dan Elphick authored
Second attempt to reland 69fafb5f now that the maybe_assigned bug is fixed. > Original change's description: > Enable lazy source positions by default > > Also adds a compile time flag which allows the default to be configured > so node can disable it since it hangs the node cpu profiler tests. > > Bug: v8:8510 > Change-Id: Idf4785036dc6242769410091518a67ac9179b718 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491491 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62089} Bug: v8:8510 Change-Id: Ia6d5d1d3a3c2b6a14c70ee67b02bec62a6a1a1d4 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg, v8_linux64_gc_stress_custom_snapshot_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679498 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Additionally to the baseline compilation time, do also measure the time it takes to tier up to TurboFan. Since the {AsyncCompileJob} will be gone after baseline compilation, the timing has to be done via a separate callback, which will survive until after top-tier compilation. R=ahaas@chromium.org CC=jwd@chromium.org Bug: chromium:978425 Change-Id: I7914173191c8a7a2aeb47343973d4034010047a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678362 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62410}
-
Andreas Haas authored
With recent spec changes (I think in the bulk memory proposal), WebAssembly instances exist and can be used even when instantiation itself fails. Therefore the order of checks and assignents during instantiation may matter. That's why I move the table import after the checks of the import in this CL. Note that I'm not aware that this is a problem yet. I think in the worst case this CL has no effect. In the best case it helps. R=clemensh@chromium.org Bug: v8:9396 Change-Id: I83998ff98bded443b3f015cee778fa29a3374534 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678656Reviewed-by:
-
Zhang, Shiyu authored
The localeCompare for ASCII chars needs to expand the string contents from one-byte representation into two-byte representation, which requires memory copy. This CL skips the representation conversion by using compareUTF8. It can improve the JetStream2 cdjs case by 21% on my machine. Change-Id: I3841dc700e36744aadd9a1ff9fa7d93c84dc04fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624705 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Leszek Swirski authored
If there was an assignment to a maybe-shadowing dynamic variable, then the shadowing variable would be marked maybe_assigned, but the maybe-shadowed variable would stay unchanged. This meant that in non-shadowing cases, the not-actually-shadowed variable would have the wrong maybe_assigned state, and e.g. would break context specialization. This patch pessimistically unconditionally sets maybe_assigned on variables shadowed by a dynamic variable in a `with` scope. This marking can cause false positives and sub-optimal optimization for some functions with 'with' blocks, but it's also the simplest fix for this issue which doesn't affect performance in the common case of no 'with' blocks. Bug: v8:9394 Change-Id: I6924bd7d48dda61232aa9d72c39df1c76c665c67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678365 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=tmrts@chromium.org Bug: chromium:978771 Change-Id: I997d212344af2e3940d5220349485685ba04040c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678360Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62406}
-
