• Leszek Swirski's avatar
    [parser] Always mark shadowed vars maybe_assigned · e79751b3
    Leszek Swirski authored
    If there was an assignment to a maybe-shadowing dynamic variable,
    then the shadowing variable would be marked maybe_assigned, but the
    maybe-shadowed variable would stay unchanged. This meant that in
    non-shadowing cases, the not-actually-shadowed variable would have
    the wrong maybe_assigned state, and e.g. would break context
    specialization.
    
    This patch pessimistically unconditionally sets maybe_assigned on
    variables shadowed by a dynamic variable in a `with` scope. This
    marking can cause false positives and sub-optimal optimization for
    some functions with 'with' blocks, but it's also the simplest fix
    for this issue which doesn't affect performance in the common case
    of no 'with' blocks.
    
    Bug: v8:9394
    Change-Id: I6924bd7d48dda61232aa9d72c39df1c76c665c67
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678365
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62407}
    e79751b3
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...